question about approach to take

There is a JIRA live for the network resilience feature that I mentioned previously. The design document (also copied into the JIRA) has essentially converged except for two points. These include:

[jira] [Commented] (ZOOKEEPER-3189) Support new configuration syntax for resilient network feature

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684812#comment-16684812 ] Ted Dunning commented on ZOOKEEPER-3189: Supporting any syntax requires having the semantics

[jira] [Created] (ZOOKEEPER-3189) Support new configuration syntax for resilient network feature

Ted Dunning created ZOOKEEPER-3189: -- Summary: Support new configuration syntax for resilient network feature Key: ZOOKEEPER-3189 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3189 Project:

[jira] [Updated] (ZOOKEEPER-3167) add an API to get total count of recursive sub nodes of one node

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3167: -- Labels: patch pull-request-available (was: patch) > add an API to get total count

[GitHub] zookeeper issue #686: Zookeeper 3167

Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/686 @TyqITstudent quick comment: - you can follow an example of `GetChildren2Test`,create an UT:e.g `GetAllChildrenNumberTest`，create some zk-nodes,then do some asserts of the number of the

***UNCHECKED*** [jira] [Commented] (ZOOKEEPER-3018) Ephemeral node not deleted after session is gone

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684784#comment-16684784 ] clouds xu commented on ZOOKEEPER-3018: -- May be i found the reason.   {panel:title=grep

[GitHub] zookeeper issue #690: ZOOKEEPER-3179: Add snapshot compression to reduce the...

Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/690 @yisong-yue Global state can still be maintained in a static field of a concrete class, it shouldn't be a problem. Though, you're probably right about `SnapStream` cannot maintain a

[jira] [Commented] (ZOOKEEPER-3071) Add a config parameter to control transaction log size

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684589#comment-16684589 ] Hudson commented on ZOOKEEPER-3071: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #266 (See

[GitHub] zookeeper pull request #690: ZOOKEEPER-3179: Add snapshot compression to red...

Github user yisong-yue commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/690#discussion_r232864632 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/SnapStream.java --- @@ -0,0 +1,336 @@ +/** + * Licensed to

[jira] [Commented] (ZOOKEEPER-3071) Add a config parameter to control transaction log size

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684544#comment-16684544 ] Hudson commented on ZOOKEEPER-3071: --- SUCCESS: Integrated in Jenkins build

[GitHub] zookeeper issue #690: ZOOKEEPER-3179: Add snapshot compression to reduce the...

Github user yisong-yue commented on the issue: https://github.com/apache/zookeeper/pull/690 @anmolnar I agree that concrete classes are a lot easier to test. Though in this case, I think it's more appropriate for SnapStream to be a utility class that does not hold any state. (It

[GitHub] zookeeper pull request #700: ZOOKEEPER-1441 - JAVA 11 - Some test cases are ...

Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/700#discussion_r232840801 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxnFactory.java --- @@ -181,7 +181,7 @@ protected void

[GitHub] zookeeper pull request #700: ZOOKEEPER-1441 - JAVA 11 - Some test cases are ...

Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/700#discussion_r232840623 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxnFactory.java --- @@ -209,6 +209,8 @@ public void run() {

[GitHub] zookeeper pull request #700: ZOOKEEPER-1441 - JAVA 11 - Some test cases are ...

Github user eolivelli commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/700#discussion_r232832500 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxnFactory.java --- @@ -181,7 +181,7 @@ protected void

[GitHub] zookeeper pull request #700: ZOOKEEPER-1441 - JAVA 11 - Some test cases are ...

Github user eolivelli commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/700#discussion_r232832059 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxnFactory.java --- @@ -209,6 +209,8 @@ public void run() {

[GitHub] zookeeper issue #699: ZOOKEEPER-3162 (branch3.4). Broken lock semantics in C...

Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/699 Committed. Thanks @andreareale ! Please assign the jira to yourself and close this PR. ---

[jira] [Resolved] (ZOOKEEPER-3162) Broken lock semantics in C client lock-recipe

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-3162. - Resolution: Fixed Fix Version/s: 3.5.5 3.4.14

[GitHub] zookeeper pull request #567: ZOOKEEPER-3071: Add a config parameter to contr...

Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/567 ---

[GitHub] zookeeper issue #567: ZOOKEEPER-3071: Add a config parameter to control tran...

Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/567 Committed to master branch. Thanks @suyogmapara ! ---

[jira] [Resolved] (ZOOKEEPER-3071) Add a config parameter to control transaction log size

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-3071. - Resolution: Fixed Issue resolved by pull request 567

[jira] [Updated] (ZOOKEEPER-1441) Some test cases are failing because Port bind issue.

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-1441: -- Labels: flaky flaky-test pull-request-available (was: flaky flaky-test) > Some

[GitHub] zookeeper pull request #700: ZOOKEEPER-1441 Some test cases are failing beca...

GitHub user anmolnar opened a pull request: https://github.com/apache/zookeeper/pull/700 ZOOKEEPER-1441 Some test cases are failing because Port bind issue. Fixes the Java 11 build issue. Details are in Jira. You can merge this pull request into a Git repository by running: $

[jira] [Commented] (ZOOKEEPER-1441) Some test cases are failing because Port bind issue.

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684312#comment-16684312 ] Andor Molnar commented on ZOOKEEPER-1441: - I might have found the issue: QuorumUtil creates

[GitHub] zookeeper issue #567: ZOOKEEPER-3071: Add a config parameter to control tran...

Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/567 @suyogmapara Let's try to get a green build. ---

[GitHub] zookeeper issue #567: ZOOKEEPER-3071: Add a config parameter to control tran...

Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/567 retest this please ---

[jira] [Assigned] (ZOOKEEPER-1441) Some test cases are failing because Port bind issue.

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar reassigned ZOOKEEPER-1441: --- Assignee: Andor Molnar (was: Michael Han) > Some test cases are failing

[GitHub] zookeeper issue #699: ZOOKEEPER-3162 (branch3.4). Broken lock semantics in C...

Github user andreareale commented on the issue: https://github.com/apache/zookeeper/pull/699 @anmolnar , as requested this is a duplicate of PR #662 ported onto branch-3.4. It applied cleanly except for the calls to the logging macros, which in 3.5 support logging by callback as

[GitHub] zookeeper issue #567: ZOOKEEPER-3071: Add a config parameter to control tran...

Github user suyogmapara commented on the issue: https://github.com/apache/zookeeper/pull/567 Hi @anmolnar, do I need to do anything before this can be merged? ---

[GitHub] zookeeper pull request #699: ZOOKEEPER-3162 (branch3.4). Broken lock semanti...

GitHub user andreareale opened a pull request: https://github.com/apache/zookeeper/pull/699 ZOOKEEPER-3162 (branch3.4). Broken lock semantics in C client lock-recipe. This is a new pull request that, as requested, ports PR #662 to branch-3.4 This PR fixes a few issues with

[jira] [Comment Edited] (ZOOKEEPER-3187) Apache zookeeper 3.5.3-beta security vulnerabilities CVE-2018-8012

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684103#comment-16684103 ] Andor Molnar edited comment on ZOOKEEPER-3187 at 11/12/18 5:11 PM: ---

[jira] [Commented] (ZOOKEEPER-3187) Apache zookeeper 3.5.3-beta security vulnerabilities CVE-2018-8012

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684103#comment-16684103 ] Andor Molnar commented on ZOOKEEPER-3187: - Please upgrade to 3.5.4-beta:

[jira] [Created] (ZOOKEEPER-3188) Improve resilience to network

Ted Dunning created ZOOKEEPER-3188: -- Summary: Improve resilience to network Key: ZOOKEEPER-3188 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3188 Project: ZooKeeper Issue Type: Bug

[jira] [Updated] (ZOOKEEPER-3187) Apache zookeeper 3.5.3-beta security vulnerabilities CVE-2018-8012

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mujassim Sheikh updated ZOOKEEPER-3187: --- Description: Apache zookeeper 3.5.3-beta  has security vulnerabilities

[jira] [Updated] (ZOOKEEPER-3187) Apache zookeeper 3.5.3-beta security vulnerabilities CVE-2018-8012

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mujassim Sheikh updated ZOOKEEPER-3187: --- Summary: Apache zookeeper 3.5.3-beta security vulnerabilities CVE-2018-8012

[jira] [Created] (ZOOKEEPER-3187) Apache zookeeper 3.5.3-beta CVE-2018-8012

Mujassim Sheikh created ZOOKEEPER-3187: -- Summary: Apache zookeeper 3.5.3-beta CVE-2018-8012 Key: ZOOKEEPER-3187 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3187 Project: ZooKeeper

ZooKeeper_branch35_jdk8 - Build # 1193 - Still Failing

See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1193/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 65.82 KB...] [junit] Tests run: 1, Failures: