[GitHub] [zookeeper] enixon commented on issue #958: ZOOKEEPER-1523: Better logging during instance loading/syncing

2019-05-23 Thread GitBox
enixon commented on issue #958: ZOOKEEPER-1523: Better logging during instance loading/syncing URL: https://github.com/apache/zookeeper/pull/958#issuecomment-495423430 This adds a new admin command that will show the syncing state of a peer. The ticket also requests better logging - I'm

[GitHub] [zookeeper] enixon opened a new pull request #958: ZOOKEEPER-1523: Better logging during instance loading/syncing

2019-05-23 Thread GitBox
enixon opened a new pull request #958: ZOOKEEPER-1523: Better logging during instance loading/syncing URL: https://github.com/apache/zookeeper/pull/958 This is an automated message from the Apache Git Service. To respond to

[jira] [Updated] (ZOOKEEPER-1523) Better logging during instance loading/syncing

2019-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-1523: -- Labels: pull-request-available (was: ) > Better logging during instance

[jira] [Commented] (ZOOKEEPER-1523) Better logging during instance loading/syncing

2019-05-23 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847110#comment-16847110 ] Brian Nixon commented on ZOOKEEPER-1523: [~Yohan123] , I have some code stashed by the side

[GitHub] [zookeeper] enixon commented on issue #939: ZOOKEEPER-3385: Add admin command to display leader

2019-05-23 Thread GitBox
enixon commented on issue #939: ZOOKEEPER-3385: Add admin command to display leader URL: https://github.com/apache/zookeeper/pull/939#issuecomment-495401373 retest ant build This is an automated message from the Apache Git

[jira] [Commented] (ZOOKEEPER-2694) sync CLI command does not wait for result from server

2019-05-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847063#comment-16847063 ] Hudson commented on ZOOKEEPER-2694: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #535 (See

[GitHub] [zookeeper] enixon commented on issue #118: ZOOKEEPER-1634: hardening security by teaching server to enforce client authentication.

2019-05-23 Thread GitBox
enixon commented on issue #118: ZOOKEEPER-1634: hardening security by teaching server to enforce client authentication. URL: https://github.com/apache/zookeeper/pull/118#issuecomment-495386499 @hanm - we're interested in this feature though not for sasl. If you think that this can be

[GitHub] [zookeeper] eolivelli commented on issue #957: ZOOKEEPER-3401: Fix metric PROPOSAL_ACK_CREATION_LATENCY

2019-05-23 Thread GitBox
eolivelli commented on issue #957: ZOOKEEPER-3401: Fix metric PROPOSAL_ACK_CREATION_LATENCY URL: https://github.com/apache/zookeeper/pull/957#issuecomment-495385500 retest ant build This is an automated message from the

[GitHub] [zookeeper] eolivelli commented on issue #957: ZOOKEEPER-3401: Fix metric PROPOSAL_ACK_CREATION_LATENCY

2019-05-23 Thread GitBox
eolivelli commented on issue #957: ZOOKEEPER-3401: Fix metric PROPOSAL_ACK_CREATION_LATENCY URL: https://github.com/apache/zookeeper/pull/957#issuecomment-495385554 retest maven build This is an automated message from the

[GitHub] [zookeeper] eolivelli edited a comment on issue #957: ZOOKEEPER-3401: Fix metric PROPOSAL_ACK_CREATION_LATENCY

2019-05-23 Thread GitBox
eolivelli edited a comment on issue #957: ZOOKEEPER-3401: Fix metric PROPOSAL_ACK_CREATION_LATENCY URL: https://github.com/apache/zookeeper/pull/957#issuecomment-495385173 rerun ant build rerun maven build This is an

[GitHub] [zookeeper] eolivelli removed a comment on issue #957: ZOOKEEPER-3401: Fix metric PROPOSAL_ACK_CREATION_LATENCY

2019-05-23 Thread GitBox
eolivelli removed a comment on issue #957: ZOOKEEPER-3401: Fix metric PROPOSAL_ACK_CREATION_LATENCY URL: https://github.com/apache/zookeeper/pull/957#issuecomment-495385173 rerun ant build rerun maven build This is an

[GitHub] [zookeeper] eolivelli commented on issue #957: ZOOKEEPER-3401: Fix metric PROPOSAL_ACK_CREATION_LATENCY

2019-05-23 Thread GitBox
eolivelli commented on issue #957: ZOOKEEPER-3401: Fix metric PROPOSAL_ACK_CREATION_LATENCY URL: https://github.com/apache/zookeeper/pull/957#issuecomment-495385173 retest ant build retest maven build This is an automated

[GitHub] [zookeeper] eolivelli commented on issue #858: ZOOKEEPER-3321: Add metrics for Leader

2019-05-23 Thread GitBox
eolivelli commented on issue #858: ZOOKEEPER-3321: Add metrics for Leader URL: https://github.com/apache/zookeeper/pull/858#issuecomment-495383955 retest ant build This is an automated message from the Apache Git Service. To

[GitHub] [zookeeper] eolivelli commented on issue #956: ZOOKEEPER-3399: Remove logging in getGlobalOutstandingLimit for optimal performance.

2019-05-23 Thread GitBox
eolivelli commented on issue #956: ZOOKEEPER-3399: Remove logging in getGlobalOutstandingLimit for optimal performance. URL: https://github.com/apache/zookeeper/pull/956#issuecomment-495380507 retest ant build This is an

[jira] [Commented] (ZOOKEEPER-2694) sync CLI command does not wait for result from server

2019-05-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847025#comment-16847025 ] Hudson commented on ZOOKEEPER-2694: --- SUCCESS: Integrated in Jenkins build

[GitHub] [zookeeper] jhuan31 opened a new pull request #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics

2019-05-23 Thread GitBox
jhuan31 opened a new pull request #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933 To address a potential flaky test in PR #849 (LearnerHandlerMetricsTest) This

[GitHub] [zookeeper] jhuan31 closed pull request #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics

2019-05-23 Thread GitBox
jhuan31 closed pull request #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [zookeeper] jhuan31 opened a new pull request #850: ZOOKEEPER-3309: Add sync processor metrics

2019-05-23 Thread GitBox
jhuan31 opened a new pull request #850: ZOOKEEPER-3309: Add sync processor metrics URL: https://github.com/apache/zookeeper/pull/850 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [zookeeper] jhuan31 closed pull request #850: ZOOKEEPER-3309: Add sync processor metrics

2019-05-23 Thread GitBox
jhuan31 closed pull request #850: ZOOKEEPER-3309: Add sync processor metrics URL: https://github.com/apache/zookeeper/pull/850 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [zookeeper] eolivelli commented on issue #956: ZOOKEEPER-3399: Remove logging in getGlobalOutstandingLimit for optimal performance.

2019-05-23 Thread GitBox
eolivelli commented on issue #956: ZOOKEEPER-3399: Remove logging in getGlobalOutstandingLimit for optimal performance. URL: https://github.com/apache/zookeeper/pull/956#issuecomment-495337360 retest ant build This is an

[GitHub] [zookeeper] eolivelli edited a comment on issue #955: ZOOKEEPER-3362: Create a simple checkstyle file

2019-05-23 Thread GitBox
eolivelli edited a comment on issue #955: ZOOKEEPER-3362: Create a simple checkstyle file URL: https://github.com/apache/zookeeper/pull/955#issuecomment-495336241 @anmolnar this is the same patch as the master one as @nkalmar reported. Can you merge it please ?

[GitHub] [zookeeper] eolivelli commented on issue #955: ZOOKEEPER-3362: Create a simple checkstyle file

2019-05-23 Thread GitBox
eolivelli commented on issue #955: ZOOKEEPER-3362: Create a simple checkstyle file URL: https://github.com/apache/zookeeper/pull/955#issuecomment-495336241 @anmolnar this is the same patch as the master one as @nkalmar reported. I will merge it

[GitHub] [zookeeper] eolivelli commented on issue #954: ZOOKEEPER-3263: JAVA9/11 Warnings: Illegal reflective access in zookeeper's kerberosUtil (3.5)

2019-05-23 Thread GitBox
eolivelli commented on issue #954: ZOOKEEPER-3263: JAVA9/11 Warnings: Illegal reflective access in zookeeper's kerberosUtil (3.5) URL: https://github.com/apache/zookeeper/pull/954#issuecomment-495336048 merging it now This

[GitHub] [zookeeper] eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for ZooKeeper - move remaining metrics to MetricsProvider

2019-05-23 Thread GitBox
eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for ZooKeeper - move remaining metrics to MetricsProvider URL: https://github.com/apache/zookeeper/pull/918#issuecomment-495335839 @lvfangmin rebased to latest master. I hope to be able to commit this patch

[GitHub] [zookeeper] eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for ZooKeeper - move remaining metrics to MetricsProvider

2019-05-23 Thread GitBox
eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for ZooKeeper - move remaining metrics to MetricsProvider URL: https://github.com/apache/zookeeper/pull/918#issuecomment-495332236 @anmolnar I will rebase this patch now.

[GitHub] [zookeeper] eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for ZooKeeper - move remaining metrics to MetricsProvider

2019-05-23 Thread GitBox
eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for ZooKeeper - move remaining metrics to MetricsProvider URL: https://github.com/apache/zookeeper/pull/918#issuecomment-495332110 retest maven build

[GitHub] [zookeeper] eolivelli commented on issue #954: ZOOKEEPER-3263: JAVA9/11 Warnings: Illegal reflective access in zookeeper's kerberosUtil (3.5)

2019-05-23 Thread GitBox
eolivelli commented on issue #954: ZOOKEEPER-3263: JAVA9/11 Warnings: Illegal reflective access in zookeeper's kerberosUtil (3.5) URL: https://github.com/apache/zookeeper/pull/954#issuecomment-495331727 @anmolnar sure, go ahead, I have already approved it

[jira] [Updated] (ZOOKEEPER-3401) Fix metric PROPOSAL_ACK_CREATION_LATENCY

2019-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3401: -- Labels: pull-request-available (was: ) > Fix metric PROPOSAL_ACK_CREATION_LATENCY

[GitHub] [zookeeper] jhuan31 opened a new pull request #957: ZOOKEEPER-3401: Fix metric PROPOSAL_ACK_CREATION_LATENCY

2019-05-23 Thread GitBox
jhuan31 opened a new pull request #957: ZOOKEEPER-3401: Fix metric PROPOSAL_ACK_CREATION_LATENCY URL: https://github.com/apache/zookeeper/pull/957 This is an automated message from the Apache Git Service. To respond to the

[jira] [Created] (ZOOKEEPER-3401) Fix metric PROPOSAL_ACK_CREATION_LATENCY

2019-05-23 Thread Jie Huang (JIRA)
Jie Huang created ZOOKEEPER-3401: Summary: Fix metric PROPOSAL_ACK_CREATION_LATENCY Key: ZOOKEEPER-3401 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3401 Project: ZooKeeper Issue

[GitHub] [zookeeper] jhuan31 opened a new pull request #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics

2019-05-23 Thread GitBox
jhuan31 opened a new pull request #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933 To address a potential flaky test in PR #849 (LearnerHandlerMetricsTest) This

[GitHub] [zookeeper] jhuan31 closed pull request #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics

2019-05-23 Thread GitBox
jhuan31 closed pull request #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [zookeeper] jhuan31 opened a new pull request #858: ZOOKEEPER-3321: Add metrics for Leader

2019-05-23 Thread GitBox
jhuan31 opened a new pull request #858: ZOOKEEPER-3321: Add metrics for Leader URL: https://github.com/apache/zookeeper/pull/858 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [zookeeper] jhuan31 closed pull request #858: ZOOKEEPER-3321: Add metrics for Leader

2019-05-23 Thread GitBox
jhuan31 closed pull request #858: ZOOKEEPER-3321: Add metrics for Leader URL: https://github.com/apache/zookeeper/pull/858 This is an automated message from the Apache Git Service. To respond to the message, please log on to

ZooKeeper_branch34_openjdk7 - Build # 2314 - Failure

2019-05-23 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/2314/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 47.73 KB...] [junit] Running

[GitHub] [zookeeper] anmolnar commented on issue #954: ZOOKEEPER-3263: JAVA9/11 Warnings: Illegal reflective access in zookeeper's kerberosUtil (3.5)

2019-05-23 Thread GitBox
anmolnar commented on issue #954: ZOOKEEPER-3263: JAVA9/11 Warnings: Illegal reflective access in zookeeper's kerberosUtil (3.5) URL: https://github.com/apache/zookeeper/pull/954#issuecomment-495296217 @eolivelli fancy to commit?

[GitHub] [zookeeper] anmolnar commented on issue #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server

2019-05-23 Thread GitBox
anmolnar commented on issue #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server URL: https://github.com/apache/zookeeper/pull/823#issuecomment-495295883 Patch committed to 3.5 and master branches. Thanks @maoling !

[GitHub] [zookeeper] asfgit closed pull request #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server

2019-05-23 Thread GitBox
asfgit closed pull request #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server URL: https://github.com/apache/zookeeper/pull/823 This is an automated message from the Apache Git Service. To respond to

Re: [DISCUSS] Is it time to remove Apache Ant from ZooKeeper?

2019-05-23 Thread Fangmin Lv
We’re still using ant as a build block internally on 3.6, working on moving to maven, will change soon, so it’s fine to remove ant. Fangmin On Thu, May 23, 2019 at 2:55 AM Norbert Kalmar wrote: > 3.4 will remain on Ant, we have decided/voted/discussed (not sure which was > it :) ) that not

[GitHub] [zookeeper] anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics

2019-05-23 Thread GitBox
anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933#issuecomment-495275519 @jhuan31 Please fix the build error. (warnings are now treated as errors)

[GitHub] [zookeeper] anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics

2019-05-23 Thread GitBox
anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933#issuecomment-495273982 retest this please This is an automated message from the

[GitHub] [zookeeper] anmolnar commented on issue #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server

2019-05-23 Thread GitBox
anmolnar commented on issue #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server URL: https://github.com/apache/zookeeper/pull/823#issuecomment-495273135 retest maven build This is an automated message

Re: Github & Jira notifications

2019-05-23 Thread Patrick Hunt
Nope. Regards, Patrick On Thu, May 23, 2019 at 1:35 AM Lars Francke wrote: > Me neither. I'm happy to keep the vote open a bit longer, we're in no rush. > > Patrick, do you have anything to add? > > On Mon, May 20, 2019 at 1:15 PM Andor Molnar wrote: > > > I’m not sure whether we have

Failed: ZOOKEEPER-2694 PreCommit Build #3781

2019-05-23 Thread Apache Jenkins Server
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2694 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3781/ ### ## LAST 60 LINES OF THE CONSOLE ###

Re: [DISCUSS] Is it time to remove Apache Ant from ZooKeeper?

2019-05-23 Thread Norbert Kalmar
3.4 will remain on Ant, we have decided/voted/discussed (not sure which was it :) ) that not long ago. Even maven is faulty on 3.4 ... So only 3.5 and master is on the vote. Thanks Enrico for working on this! On Wed, May 22, 2019 at 7:06 PM Enrico Olivelli wrote: > Il mer 22 mag 2019, 12:17

Re: [DISCUSS] Should we move contrib and recipes into separate repos?

2019-05-23 Thread Norbert Kalmar
I agree with Enrico on dropping contrib and keeping recipes. My reasons for dropping contrib projects: - There is not much, if anything, going on around contrib. Even before maven migration, it was a mess (it was duplicated in the tarball, some were built, some were not, kind of randomly). Take

[GitHub] [zookeeper] maoling commented on issue #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server

2019-05-23 Thread GitBox
maoling commented on issue #823: ZOOKEEPER-2694:sync CLI command does not wait for result from server URL: https://github.com/apache/zookeeper/pull/823#issuecomment-495143114 ping @anmolnar @eolivelli Could you plz take another look?

Build failed in Jenkins: ZooKeeper-trunk-owasp #372

2019-05-23 Thread Apache Jenkins Server
See Changes: [eolivelli] ZOOKEEPER-3311: Allow a delay to the transaction log flush -- [...truncated 14.67 KB...] [ivy:retrieve] confs: [default] [ivy:retrieve] 23

Re: Github & Jira notifications

2019-05-23 Thread Lars Francke
Me neither. I'm happy to keep the vote open a bit longer, we're in no rush. Patrick, do you have anything to add? On Mon, May 20, 2019 at 1:15 PM Andor Molnar wrote: > I’m not sure whether we have convinced Patrick entirely. > Before casting my vote, I’d be happy if we could reach consensus in