Re: [Request For Review] ZOOKEEPER-3474 a.k.a GH-1028

Il dom 18 ago 2019, 03:26 Zili Chen ha scritto: > Of course I volunteer to do. > Great > > To clarify the process, we want to merge checkstyle-strict.xml into > checkstyle.xml and thus turn on rules in current checkstyle-strict.xml > on project level, while also removing configurations in

Jenkins build is back to stable : zookeeper-master-maven #386

See

Re: [Request For Review] ZOOKEEPER-3474 a.k.a GH-1028

Of course I volunteer to do. To clarify the process, we want to merge checkstyle-strict.xml into checkstyle.xml and thus turn on rules in current checkstyle-strict.xml on project level, while also removing configurations in plugins field of pom.xml in submodules. Is this process expected? Best,

Re: thoughts about extension to multi semantics

> On Aug 17, 2019, at 4:41 PM, Ted Dunning wrote: > > On Sat, Aug 17, 2019 at 4:01 PM Jordan Zimmerman > wrote: > >> >> >> ... >>> I don't understand that. Watches can be set in a multi. >> >> Not in the public API: >>

Re: thoughts about extension to multi semantics

On Sat, Aug 17, 2019 at 4:01 PM Jordan Zimmerman wrote: > > > ... > > I don't understand that. Watches can be set in a multi. > > Not in the public API: > https://github.com/apache/zookeeper/blob/master/zookeeper-server/src/main/java/org/apache/zookeeper/Op.java > - is it supported in the

Re: thoughts about extension to multi semantics

> On Aug 17, 2019, at 2:50 PM, Ted Dunning wrote: > > > > On Sat, Aug 17, 2019 at 10:19 AM Jordan Zimmerman > wrote: > Some thoughts: > > It doesn't really help with any of the "standard" recipes as they all need to > set watches. > > I don't understand

Re: thoughts about extension to multi semantics

On Sat, Aug 17, 2019 at 10:19 AM Jordan Zimmerman < jor...@jordanzimmerman.com> wrote: > Some thoughts: > > It doesn't really help with any of the "standard" recipes as they all need > to set watches. I don't understand that. Watches can be set in a multi. > Not to open a can of worms, but if

Re: [Request For Review] ZOOKEEPER-3474 a.k.a GH-1028

We have merged this useful work. Now we have to merge the two checkstyle files/plugin executions into only one. We have one project wide configuration (all projects, contrib...) that check for '@author' and the new one that is a full checkstyle run. Tison, do you want to complete the work?

Re: thoughts about extension to multi semantics

Some thoughts: It doesn't really help with any of the "standard" recipes as they all need to set watches. Not to open a can of worms, but if there were a firehose version of watches that could be set independently, this type of multi-op could radically simplify some of the recipes. i.e. one

Jenkins build is still unstable: zookeeper-master-maven-jdk12 #97

See

Re: thoughts about extension to multi semantics

On Sat, Aug 17, 2019, 8:33 AM Michael Han wrote: > >> I would guess that it actually gets very, very little > > Can't speak for others, but for the zookeeper clusters I maintain > internally, multi was used extensively in certain use cases. > Cool! Very glad to hear it. >

Re: thoughts about extension to multi semantics

Being lazy, I would suggest only the tests we already have. Existence and version. On Sat, Aug 17, 2019, 5:30 AM Enrico Olivelli wrote: > Il sab 17 ago 2019, 08:01 Ted Dunning ha scritto: > > > It definitely sounds like a nice feature. > > > > The important question is what is the actual

Jenkins build is still unstable: zookeeper-master-maven-jdk12 #96

See

Jenkins build is still unstable: zookeeper-master-maven #385

See

Build failed in Jenkins: zookeeper-master-maven-owasp #99

See Changes: [hanm] ZOOKEEPER-3475: Enable Checkstyle configuration on zookeeper-server -- [...truncated 272.39 KB...] Generating

Re: thoughts about extension to multi semantics

>> I would guess that it actually gets very, very little Can't speak for others, but for the zookeeper clusters I maintain internally, multi was used extensively in certain use cases. >> how much would an extension to multi actually be used This looks like a chicken egg problem to me. I feel

ZooKeeper_branch35_jdk8 - Build # 1508 - Still Failing

See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1508/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 68.42 KB...] [junit] Tests run: 1, Failures:

Re: thoughts about extension to multi semantics

Il sab 17 ago 2019, 08:01 Ted Dunning ha scritto: > It definitely sounds like a nice feature. > > The important question is what is the actual importance after you multiply > it by the amount of usage it gets. > > For instance, I know that multi gets a bit of usage, but I would guess that > it

ZooKeeper_branch34_openjdk8 - Build # 423 - Failure

See https://builds.apache.org/job/ZooKeeper_branch34_openjdk8/423/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 44.24 KB...] [junit] Tests run: 1,

Build failed in Jenkins: zookeeper-master-maven-owasp #98

See -- [...truncated 262.35 KB...] Generating

Jenkins build is back to normal : ZooKeeper-trunk-owasp #460

See

Re: thoughts about extension to multi semantics

It definitely sounds like a nice feature. The important question is what is the actual importance after you multiply it by the amount of usage it gets. For instance, I know that multi gets a bit of usage, but I would guess that it actually gets very, very little. It might even most of the cases