Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/653
retest this please
---
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/659#discussion_r224197413
--- Diff:
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java
---
@@ -402,4 +421,129 @@ public File getConfFile
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/628
@enixon It is.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/659
No response for 2 days. Committing it silently as you guys approved it.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/653
This is committed too to 3.5 and master to reduce flaky test pressure.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/651
retest this please
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/627
@ivmaykov Please rebase this one, because the original SSL PR has been
merged.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/651
retest this please
---
GitHub user anmolnar opened a pull request:
https://github.com/apache/zookeeper/pull/668
ZOOKEEPER-3165. Java 10:
X509UtilTest.testCreateSSLContextWithoutTrustStorePassword fails
We use JKS format explicitly, but the tests created the keystore and
truststore with the default
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/668
@ivmaykov
You might be interested in this change. I wonder why only a single test was
failing, because of this.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/666
Given that this is only the backport of #650 I think we're good to go.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/666
Committed to branch-3.5. Thanks @Reidd !
Please close this PR.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/567
@suyogmapara Please rebase your commits, because you've merge conflicts.
Also please add more detailed documentation to the patch by capturing the
most important notes that were mention
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/668
Looks like the reason is that Java API requires non-empty password for p12
files. That's why the only failing test is the one with empty password. JKS
format still allows to store keys wi
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/651
retest this please
---
Github user anmolnar closed the pull request at:
https://github.com/apache/zookeeper/pull/660
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/651
@hanm do you still -1 this?
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/300
@lavacat @lvfangmin
This is a potential flaky test fix you might want to take a quick look.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/661
Committed to master branch. Thanks @tamaashu !
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/664
Committed to branch-3.4. Thanks @tamaashu !
Please close this PR.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/663
Committed to branch-3.5. Thanks @tamaashu !
Please close this PR.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/627
@ivmaykov Sure. I hate committing my own patches, rather wait for others to
review and merge. Anyway, if no one shows up tomorrow, I'll commit it myself.
---
Github user anmolnar closed the pull request at:
https://github.com/apache/zookeeper/pull/668
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/668
Committed to branch-3.5
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/651
retest this please
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/655
retest this please
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/627
@ivmaykov It's in now.
You can go ahead with the 2nd part.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/652
@revans2 We might need another committer to take a look.
Also you probably need to trigger another build to get a green one.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/647
I still have bad feelings about introducing `RetryRule` in this patch. I
haven't seen connectionLoss errors recently on the builds, neither on this
patch after the fix and not sure it
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/150
@jeffwidman You're right. @fpj is able to close it.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/567
retest this please
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/648
retest this please
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/651
Committed. Thanks for the reviews.
@hanm If you still do have any concerns, please let me know, I'll address
them in a separate patch.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/672
Merged to master branch. Thanks @nkalmar !
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/674
Merged to branch-3.5. Thanks @nkalmar !
Please close this PR.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/675
Merged to branch-3.4. Thanks @nkalmar !
Please close this PR.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/651
@hanm According to Clover report:
https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-clover/184/clover-report/org/apache/zookeeper/server/EphemeralType.html
The method
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/300
@lavacat Issue happened here too in the latest build.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/300
Looks like follower that the client is trying to reconnect at line 116 is
stuck with revalidating the session:
```
2018-10-24 12:20:31,215 [myid:] - INFO [NIOWorkerThread-1:Learner
GitHub user anmolnar opened a pull request:
https://github.com/apache/zookeeper/pull/677
ZOOKEEPER-2807. DONT COMMIT - Testing flaky testNodeDataChanged
Enabled trace logging.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/677
retest this please
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/677
retest this please
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/300
@lavacat It's pretty much clear to me that there's a deadlock in the
follower probably at the change where it's waiting for commits to be processed:
```
zk
Github user anmolnar closed the pull request at:
https://github.com/apache/zookeeper/pull/677
---
GitHub user anmolnar opened a pull request:
https://github.com/apache/zookeeper/pull/682
ZOOKEEPER-2807. Flaky test:
org.apache.zookeeper.test.WatchEventWhenAutoResetTest.testNodeDataChanged
Mark the test as ignored.
Please see https://issues.apache.org/jira/browse/ZOOKEEPER
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/682#discussion_r228334877
--- Diff:
zookeeper-server/src/test/java/org/apache/zookeeper/test/WatchEventWhenAutoResetTest.java
---
@@ -95,6 +96,7 @@ public void setUp
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/530
@timothyjward Do you still working on this?
Would you please rebase and create a separate patch for the master branch?
Once it's applied in there, we can merge this one too and clos
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/247
Ping @hanm @maoling @lvfangim
This is a blocker for the 3.5 release. Can we move on with the review?
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/647
@lvfangmin Sounds acceptable.
If the flaky cannot be fixed with my suggestion (waiting for client to
disconnect), let's put the retry back in.
I'll commit afterwards. Thanks.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/647
retest this please
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/682
@lvfangmin Moved bunch of common code to Before/After.
Also changed the logic to call `setData` in order to verify
`NodeDataChanged` event.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/628
@enixon @hanm I think that's the same `free()` issue. My feeling is that
it must be somewhere in test cleanup section (if there's any) when it tries to
free some resource twice.
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/652
@revans2 Please rebase.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/629
@maoling I agreed with @lvfangmin . Please port this patch to master.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/682
retest this please
---
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/678#discussion_r228737596
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java ---
@@ -221,15 +279,45 @@ public SSLContext createSSLContext(ZKConfig
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/678#discussion_r228760044
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java ---
@@ -221,15 +279,45 @@ public SSLContext createSSLContext(ZKConfig
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/678#discussion_r228763521
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java ---
@@ -221,15 +279,45 @@ public SSLContext createSSLContext(ZKConfig
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/678#discussion_r228805464
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java ---
@@ -221,15 +279,45 @@ public SSLContext createSSLContext(ZKConfig
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/678#discussion_r228958680
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java ---
@@ -167,47 +222,50 @@ public SSLContext createSSLContext(ZKConfig
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/678#discussion_r228961395
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java ---
@@ -360,4 +476,26 @@ private void configureSSLServerSocket
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/678#discussion_r228957739
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java ---
@@ -167,47 +222,50 @@ public SSLContext createSSLContext(ZKConfig
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/678#discussion_r228963670
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/util/PemReader.java ---
@@ -0,0 +1,224 @@
+/*
+ * Licensed under the Apache
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/678#discussion_r228958388
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java ---
@@ -79,12 +82,56
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/682
If there's no objection, I'll get this in tomorrow.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/678
@ivmaykov What was the problem with using `FileNameUtils`?
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/652
Merged to 3.5 and master branches. Thanks @revans2 !
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/648
Committed. Thanks @revans2 !
Please close this PR.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/540
@timelapsewithinlive would you please close this PR?
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/676
@aajisaka I'm a little bit confused with this patch, because I cannot find
the class `TestingQuorumPeerMain` which was overwritten the `getQuorumPeer()`
method as mentioned in the Jira. Whe
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/689
@tumativ This patch makes sense to me and looks like a nice improvement.
In the Jira you're saying "also complete the remaining dead watchers when
interrupt happen", but I
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/678
retest this please
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/686
@TyqITstudent Please create pull request for the master branch first. We
can talk about integrating this into 3.5, but we don't accept new features for
3.4
Would be better t
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/678
What's wrong with this build?
@ivmaykov Does it work for you locally?
---
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r230973999
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ResponseCache.java
---
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r230975652
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerCnxn.java ---
@@ -68,29 +70,74 @@
private volatile boolean
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r230973727
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxn.java
---
@@ -235,10 +237,12 @@ void handleWrite(SelectionKey k
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r230973904
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ResponseCache.java
---
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r230973619
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxn.java
---
@@ -151,12 +148,17 @@ void sendBufferSync(ByteBuffer bb
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r230974144
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ResponseCache.java
---
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r230973324
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/DumbWatcher.java ---
@@ -69,7 +69,7 @@ public void sendCloseSession
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/671
Sorry @tamaashu , I missed your comment.
I'm @anmolnar btw, somebody has already stolen "andor". :)
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/678
@ivmaykov It's in:
`zookeeper-server/src/test/resources/test-github-pr.sh`
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/671
Committed to master branch. Thanks @tamaashu !
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/685
This is merged. Thanks @lvfangmin !
Please close this PR.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/678
It's not findbugs, core and contrib tests are failing, but I cannot see why:
```
[exec] -1 core tests. The patch failed core unit tests.
[exec] -1 contrib
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/678
Now it's green. I'll merge it.
Previously the findbugs subprocess has been killed for some reason.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/678
Merged to 3.5 and master branches. Thanks @ivmaykov !
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/689
@tumativ Only 2 days passed, let's give some chance for the community to
review your code.
I'm particularly interested in @lvfangmin 's opinion.
---
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/689#discussion_r231610533
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/watch/WatcherCleaner.java
---
@@ -50,6 +50,8 @@
private volatile
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/662
Committed to 3.5 and master branches. Thanks @andreareale !
Please create separate pull request for branch-3.4
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/647
Merged. Thanks @lvfangmin !
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/697
Merged.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/698
Committed. Thanks @tamaashu !
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/567
retest this please
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/567
@suyogmapara Let's try to get a green build.
---
GitHub user anmolnar opened a pull request:
https://github.com/apache/zookeeper/pull/700
ZOOKEEPER-1441 Some test cases are failing because Port bind issue.
Fixes the Java 11 build issue. Details are in Jira.
You can merge this pull request into a Git repository by running
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/567
Committed to master branch. Thanks @suyogmapara !
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/699
Committed. Thanks @andreareale !
Please assign the jira to yourself and close this PR.
---
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/700#discussion_r232840801
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxnFactory.java
---
@@ -181,7 +181,7 @@ protected void fastCloseSock
701 - 800 of 891 matches
Mail list logo
