Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/106
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user arshadmohammad opened a pull request:
https://github.com/apache/zookeeper/pull/254
ZOOKEEPER-2775: ZK Client not able to connect with Xid out of order error
Once client enters into Xid out of order issue, It never comes to normal
state. It keeps trying to connect and
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/254#discussion_r116871274
--- Diff: src/java/test/org/apache/zookeeper/SaslAuthTest.java ---
@@ -0,0 +1,187 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/254#discussion_r116871380
--- Diff: src/java/test/org/apache/zookeeper/SaslAuthTest.java ---
@@ -0,0 +1,187 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/254#discussion_r116871534
--- Diff: src/java/test/org/apache/zookeeper/SaslAuthTest.java ---
@@ -0,0 +1,187 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/254#discussion_r116872750
--- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java ---
@@ -1080,6 +1080,8 @@ private void startConnect() throws IOException
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/254
zooKeeperSaslClient == null is already used in tunnelAuthInProgress()
which is quite different from saslLoginFailed being false. So I think we can
not do above change.
---
If your
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/254
Thanks @afine @hanm for the reviews. Addressed the comments, Please have a
look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/254#discussion_r117014954
--- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java ---
@@ -1054,6 +1054,8 @@ private void sendPing() {
private boolean
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/254#discussion_r117016986
--- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java ---
@@ -1054,6 +1054,8 @@ private void sendPing() {
private boolean
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/254#discussion_r117021379
--- Diff: src/java/test/org/apache/zookeeper/SaslAuthTest.java ---
@@ -16,54 +16,58 @@
* limitations under the License
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/254
This PR can be merged to master and branch-3.5 only. I will raise another
pull request for branch-3.4
---
If your project is set up for it, you can reply to this email and have your
GitHub user arshadmohammad opened a pull request:
https://github.com/apache/zookeeper/pull/278
ZOOKEEPER-2775: ZK Client not able to connect with Xid out of order error
Same as PR https://github.com/apache/zookeeper/pull/254 but this is for
branch-3.4
You can merge this pull
Github user arshadmohammad closed the pull request at:
https://github.com/apache/zookeeper/pull/278
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/282#discussion_r122586367
--- Diff:
src/java/main/org/apache/zookeeper/server/auth/SASLAuthenticationProvider.java
---
@@ -38,11 +38,6 @@ public String getScheme
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/282#discussion_r122586398
--- Diff: src/java/test/org/apache/zookeeper/test/SaslSuperUserTest.java ---
@@ -0,0 +1,118 @@
+/**
+ * Licensed to the Apache Software
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/282#discussion_r122586475
--- Diff: src/java/test/org/apache/zookeeper/test/SaslSuperUserTest.java ---
@@ -0,0 +1,118 @@
+/**
+ * Licensed to the Apache Software
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/282#discussion_r123329247
--- Diff:
src/java/main/org/apache/zookeeper/server/auth/SASLAuthenticationProvider.java
---
@@ -38,11 +38,6 @@ public String getScheme
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/279#discussion_r126481060
--- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java ---
@@ -1436,7 +1436,7 @@ public String create(final String path, byte data[],
List
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/279#discussion_r126482088
--- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java ---
@@ -1535,7 +1535,7 @@ public String create(final String path, byte data[],
List
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/279#discussion_r128291070
--- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java ---
@@ -1436,7 +1436,7 @@ public String create(final String path, byte data[],
List
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/304
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
GitHub user arshadmohammad opened a pull request:
https://github.com/apache/zookeeper/pull/338
ZOOKEEPER-1260:Audit logging in ZooKeeper servers.
Audit logging in ZooKeeper Servers.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r134566109
--- Diff: src/docs/src/documentation/content/xdocs/site.xml ---
@@ -52,6 +52,7 @@ See http://forrest.apache.org/docs/linking.html for more
info
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r134566167
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml ---
@@ -931,7 +931,19 @@ server.3=zoo3:2888:3888
feature
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r134566240
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAuditLogs.xml
---
@@ -0,0 +1,205 @@
+
+
+http://www.oasis-open.org/docbook
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136144283
--- Diff: conf/log4j.properties ---
@@ -63,3 +63,20 @@
log4j.appender.TRACEFILE.File=${zookeeper.tracelog.dir}/${zookeeper.tracelog.fil
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136146630
--- Diff: conf/log4j.properties ---
@@ -63,3 +63,20 @@
log4j.appender.TRACEFILE.File=${zookeeper.tracelog.dir}/${zookeeper.tracelog.fil
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136149088
--- Diff: src/docs/src/documentation/content/xdocs/index.xml ---
@@ -66,6 +66,7 @@
Hierarchical
quorums
Observers - non
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136150114
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml ---
@@ -931,7 +931,19 @@ server.3=zoo3:2888:3888
feature
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136150155
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAuditLogs.xml
---
@@ -0,0 +1,205 @@
+
+
+http://www.oasis-open.org/docbook
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136154472
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAuditLogs.xml
---
@@ -0,0 +1,205 @@
+
+
+http://www.oasis-open.org/docbook
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136154783
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAuditLogs.xml
---
@@ -0,0 +1,205 @@
+
+
+http://www.oasis-open.org/docbook
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136155728
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAuditLogs.xml
---
@@ -0,0 +1,205 @@
+
+
+http://www.oasis-open.org/docbook
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136157192
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAuditLogs.xml
---
@@ -0,0 +1,205 @@
+
+
+http://www.oasis-open.org/docbook
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136157257
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAuditLogs.xml
---
@@ -0,0 +1,205 @@
+
+
+http://www.oasis-open.org/docbook
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136157705
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAuditLogs.xml
---
@@ -0,0 +1,205 @@
+
+
+http://www.oasis-open.org/docbook
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136158827
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAuditLogs.xml
---
@@ -0,0 +1,205 @@
+
+
+http://www.oasis-open.org/docbook
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136158981
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAuditLogs.xml
---
@@ -0,0 +1,205 @@
+
+
+http://www.oasis-open.org/docbook
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136161116
--- Diff: src/java/main/org/apache/zookeeper/audit/ZKAuditLogger.java ---
@@ -0,0 +1,118 @@
+/**
+ * Licensed to the Apache Software
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136162453
--- Diff:
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java ---
@@ -465,6 +490,129 @@ public void processRequest(Request
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136166929
--- Diff:
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java ---
@@ -476,6 +624,33 @@ private boolean connClosedByClient(Request
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136166969
--- Diff:
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java ---
@@ -476,6 +624,33 @@ private boolean connClosedByClient(Request
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136168432
--- Diff: src/java/main/org/apache/zookeeper/server/ServerCnxnFactory.java
---
@@ -54,6 +54,7 @@
*/
static final ByteBuffer
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136169721
--- Diff: src/java/test/org/apache/zookeeper/server/util/AuthUtilTest.java
---
@@ -0,0 +1,58 @@
+/**
+ * Licensed to the Apache Software
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136172475
--- Diff: src/java/test/org/apache/zookeeper/audit/ZKAuditLoggerTest.java
---
@@ -0,0 +1,377 @@
+/**
+ * Licensed to the Apache Software
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136173824
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAuditLogs.xml
---
@@ -0,0 +1,205 @@
+
+
+http://www.oasis-open.org/docbook
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136175120
--- Diff: src/java/test/org/apache/zookeeper/server/util/AuthUtilTest.java
---
@@ -0,0 +1,58 @@
+/**
+ * Licensed to the Apache Software
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136176181
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAuditLogs.xml
---
@@ -0,0 +1,205 @@
+
+
+http://www.oasis-open.org/docbook
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136865485
--- Diff: src/java/main/org/apache/zookeeper/server/ServerCnxnFactory.java
---
@@ -54,6 +54,7 @@
*/
static final ByteBuffer
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136865979
--- Diff: src/java/main/org/apache/zookeeper/audit/AuditConstants.java ---
@@ -0,0 +1,37 @@
+/**
+ * Licensed to the Apache Software
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136866016
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAuditLogs.xml
---
@@ -0,0 +1,205 @@
+
+
+http://www.oasis-open.org/docbook
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/338
Thanks @hanm @afine for reviewing this feature. I have addressed all the
comments, Please have a look.
---
GitHub user arshadmohammad opened a pull request:
https://github.com/apache/zookeeper/pull/112
ZOOKEEPER-2355:Ephemeral node is never deleted if follower fails while
reading the proposal packet
ZOOKEEPER-2355:Ephemeral node is never deleted if follower fails while
reading the
GitHub user arshadmohammad opened a pull request:
https://github.com/apache/zookeeper/pull/113
ZOOKEEPER-2517:jute.maxbuffer is ignored
ZOOKEEPER-2517:jute.maxbuffer is ignored
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user arshadmohammad opened a pull request:
https://github.com/apache/zookeeper/pull/119
ZOOKEEPER-2251:Add Client side packet response timeout to avoid infinite
wait.
Add Client side packet response timeout to avoid infinite wait.
You can merge this pull request into a Git
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/119
Thanks @anmolnar @hanm for your reviews, I will address the comments and
update MR.
---
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/119#discussion_r203928289
--- Diff: src/java/main/org/apache/zookeeper/KeeperException.java ---
@@ -387,6 +389,8 @@ public void setCode(int code
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/119#discussion_r203928395
--- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java ---
@@ -1495,10 +1504,21 @@ public ReplyHeader submitRequest(RequestHeader h,
Record
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/119#discussion_r203928468
--- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java ---
@@ -1495,10 +1504,21 @@ public ReplyHeader submitRequest(RequestHeader h,
Record
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/119#discussion_r204881819
--- Diff: src/java/main/org/apache/zookeeper/KeeperException.java ---
@@ -387,6 +389,8 @@ public void setCode(int code
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/119#discussion_r204882089
--- Diff: src/java/main/org/apache/zookeeper/KeeperException.java ---
@@ -843,4 +847,13 @@ public ReconfigDisabledException(String path
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/119#discussion_r204885587
--- Diff: src/java/main/org/apache/zookeeper/client/ZKClientConfig.java ---
@@ -56,9 +56,15 @@
@SuppressWarnings("deprec
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r217179296
--- Diff:
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java ---
@@ -465,6 +488,127 @@ public void processRequest(Request
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r217179236
--- Diff:
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java ---
@@ -250,30 +267,36 @@ public void processRequest(Request
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r217179644
--- Diff: src/java/main/org/apache/zookeeper/audit/ZKAuditLogger.java ---
@@ -0,0 +1,117 @@
+/**
+ * Licensed to the Apache Software
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r217179715
--- Diff:
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java ---
@@ -465,6 +488,127 @@ public void processRequest(Request
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r218066854
--- Diff: src/java/main/org/apache/zookeeper/ZKUtil.java ---
@@ -168,4 +169,41 @@ private static void visitSubTreeDFSHelper(ZooKeeper
zk, final
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r218067686
--- Diff: conf/log4j.properties ---
@@ -63,3 +63,20 @@
log4j.appender.TRACEFILE.File=${zookeeper.tracelog.dir}/${zookeeper.tracelog.fil
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r218068308
--- Diff: conf/log4j.properties ---
@@ -63,3 +63,20 @@
log4j.appender.TRACEFILE.File=${zookeeper.tracelog.dir}/${zookeeper.tracelog.fil
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r218073947
--- Diff: src/java/main/org/apache/zookeeper/audit/AuditConstants.java ---
@@ -0,0 +1,37 @@
+/**
+ * Licensed to the Apache Software
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/338
Hi all, please find performance impact analysis in jira comments.
---
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/338
@pmoust I was pointing to comments:
[1](https://issues.apache.org/jira/browse/ZOOKEEPER-1260?focusedCommentId=16612302&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabp
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/137#discussion_r97247778
--- Diff: src/lastRevision.bat ---
@@ -16,8 +16,9 @@ rem See the License for the specific language governing
permissions and
rem limitations
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/153#discussion_r97257715
--- Diff: src/java/test/org/apache/zookeeper/test/ClientBase.java ---
@@ -664,4 +664,32 @@ public static String join(String separator, Object
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/137
I verified on windows. Other than one minor problem the current changes
look good to me.
commit hash is getting added with one extra space at the end.
here is srvr command output
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/137
I think we should handle it in the VerGen. Can we trim and then assign the
value to rev variable
As:
rev=rev.trim()
---
If your project is set up for it, you can reply to this
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/137
Thanks @eribeiro for working on this issue.
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/95
LGTM, I will commit it.
@eribeiro do you have any comment?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user arshadmohammad opened a pull request:
https://github.com/apache/zookeeper/pull/160
ZOOKEEPER-2680:Correct DataNode.getChildren() inconsistent behaviour.
DataNode.getChildren() API behavior should be changed and it should always
return empty set if the node does not have
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/160#discussion_r98743966
--- Diff: src/java/test/org/apache/zookeeper/server/DataNodeTest.java ---
@@ -0,0 +1,54 @@
+/**
+ * Licensed to the Apache Software
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/160#discussion_r98743925
--- Diff: src/java/test/org/apache/zookeeper/server/DataNodeTest.java ---
@@ -0,0 +1,54 @@
+/**
+ * Licensed to the Apache Software
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/160
1. yes, changes should be applied to branch-3.4 and branch-3.5 also. I will
raise merge request for branch-3.4 and branch-3.5 after it is committed to
master
2. This is very much
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/160
checking the CI failure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user arshadmohammad opened a pull request:
https://github.com/apache/zookeeper/pull/161
ZOOKEEPER-2680: Correct DataNode.getChildren() inconsistent behaviour.
:branch-3.5
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user arshadmohammad opened a pull request:
https://github.com/apache/zookeeper/pull/162
ZOOKEEPER-2680: Correct DataNode.getChildren() inconsistent behaviour.
:branch-3.4
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/161
CI failure is because of qa-test-pullrequest is not present in branch-3.5
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/162
CI failure is because of qa-test-pullrequest is not present in branch-3.4
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user arshadmohammad opened a pull request:
https://github.com/apache/zookeeper/pull/163
ZOOKEEPER-2682:Make it optional to fail build on test failure
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arshadmohammad
GitHub user arshadmohammad opened a pull request:
https://github.com/apache/zookeeper/pull/164
ZOOKEEPER-2682: Make it optional to fail build on test failure
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arshadmohammad
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/164
Closing this PR as it is committed to branch-3.4. Commit id is
3ea68e7a99278daf4d7424ce825c6e8315c39198
Thanks @rakeshr for commiting this PR
---
If your project is set up for it, you
Github user arshadmohammad closed the pull request at:
https://github.com/apache/zookeeper/pull/164
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/170#discussion_r100673430
--- Diff: ivy.xml ---
@@ -78,30 +78,38
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/170#discussion_r100673515
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/auth/MiniKdcTest.java ---
@@ -18,8 +18,8 @@
package
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/170
+1, LGTM
I will commit this PR today if no more review comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user arshadmohammad closed the pull request at:
https://github.com/apache/zookeeper/pull/162
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user arshadmohammad closed the pull request at:
https://github.com/apache/zookeeper/pull/161
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/170
Thanks @eribeiro for the review,
Sorry, I saw you comment just now after committing this PR, missed you in
the reviewers list.
---
If your project is set up for it, you can reply to
GitHub user arshadmohammad opened a pull request:
https://github.com/apache/zookeeper/pull/175
ZOOKEEPER-2683: RaceConditionTest is flaky
RaceConditionTest assertion is wrong, It fails when old leader becomes
leader again.
You can merge this pull request into a Git repository by
GitHub user arshadmohammad opened a pull request:
https://github.com/apache/zookeeper/pull/176
ZOOKEEPER-2687:Deadlock while shutting down the Leader server.
Leader server enters into deadlock while shutting down itself. Shutdown of
the leader server is called from the synchronized
1 - 100 of 132 matches
Mail list logo
