Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/97#discussion_r86679336
--- Diff: src/java/test/bin/test-github-pr.sh ---
@@ -0,0 +1,612 @@
+#!/usr/bin/env bash
+# Licensed under the Apache License, Version 2.0
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/97#discussion_r86679319
--- Diff: src/java/test/bin/test-github-pr.sh ---
@@ -0,0 +1,612 @@
+#!/usr/bin/env bash
+# Licensed under the Apache License, Version 2.0
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/96#discussion_r86679075
--- Diff: src/java/test/org/apache/zookeeper/test/ClientBase.java ---
@@ -356,7 +356,7 @@ private static int getPort(String hostPort
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/96#discussion_r86679106
--- Diff:
src/java/test/org/apache/zookeeper/test/ReconfigExceptionTest.java ---
@@ -0,0 +1,220 @@
+/**
+ * Licensed to the Apache Software
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/96#discussion_r86679094
--- Diff:
src/java/test/org/apache/zookeeper/test/ReconfigExceptionTest.java ---
@@ -0,0 +1,220 @@
+/**
+ * Licensed to the Apache Software
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/96#discussion_r86679058
--- Diff: src/java/test/org/apache/zookeeper/server/DataTreeTest.java ---
@@ -200,29 +198,34 @@ public void
testSerializeDoesntLockDataNodeWhileWriting
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/96#discussion_r86678939
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml ---
@@ -1108,6 +1109,42 @@ server.3=zoo3:2888:3888
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/96#discussion_r86679034
--- Diff: src/java/main/org/apache/zookeeper/server/DataTree.java ---
@@ -245,15 +245,25 @@ public DataTree() {
addConfigNode
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/97#discussion_r86679277
--- Diff: src/java/test/bin/test-github-pr.sh ---
@@ -0,0 +1,612 @@
+#!/usr/bin/env bash
+# Licensed under the Apache License, Version 2.0
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/97#discussion_r86679330
--- Diff: src/java/test/bin/test-github-pr.sh ---
@@ -0,0 +1,612 @@
+#!/usr/bin/env bash
+# Licensed under the Apache License, Version 2.0
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/97
agreed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/102#discussion_r86902396
--- Diff: src/java/main/org/apache/jute/compiler/CGenerator.java ---
@@ -61,70 +61,88 @@ void genCode() throws IOException
GitHub user breed opened a pull request:
https://github.com/apache/zookeeper/pull/90
ZOOKEEPER-761: Remove *synchronous* calls from the *single-threaded* C
client API
the synchronous calls from a single-threaded client do not work. this patch
makes using them in a single
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/104
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/90#discussion_r87652058
--- Diff: src/c/src/zookeeper.c ---
@@ -4052,6 +3958,76 @@ int zoo_amulti(zhandle_t *zh, int count, const
zoo_op_t *ops,
return (rc <
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/90
@fpj on the plus side that failure validates that the change is correct :)
(it is trying to use a sync API with a non threaded test)
---
If your project is set up for it, you can reply
GitHub user breed opened a pull request:
https://github.com/apache/zookeeper/pull/117
ZOOKEEPER-2325: Data inconsistency if all snapshots empty or missing
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/breed/zookeeper ZOOKEEPER
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/90#discussion_r92719995
--- Diff: src/c/tests/TestClient.cc ---
@@ -47,6 +47,10 @@ struct buff_struct_2 {
char *buffer;
};
+// TODO(br33d): the vast majority
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/120
commited. thanx everyone for reviewing and brian for your contribution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/120
hmm this is committed. anyone understands why it doesn't autoclose?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/120
hmm, perhaps you are right. i don't think the script is working for me
properly... checking.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/120
it shows up in https://git-wip-us.apache.org/repos/asf?p=zookeeper.git
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/120
@eribeiro i think this is ready to go. do you feel that your question has
been answer sufficiently?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/100
+1 everything looks good from our side. we don't use that error code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/117
@hanm i can't seem to find your comment :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/117#discussion_r90523518
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java ---
@@ -165,8 +165,22 @@ public File getSnapDir
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/117#discussion_r90523812
--- Diff:
src/java/test/org/apache/zookeeper/test/EmptiedSnapshotRecoveryTest.java ---
@@ -0,0 +1,134 @@
+/**
+ * Licensed to the Apache Software
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/117#discussion_r90791441
--- Diff:
src/java/test/org/apache/zookeeper/test/EmptiedSnapshotRecoveryTest.java ---
@@ -0,0 +1,134 @@
+/**
+ * Licensed to the Apache Software
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/262
i think it would be much better to extend ZOOKEEPER-1277 to more
transparently do the rollover without a full leader election.
the main issue i have with shortening the epoch size
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194501452
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java ---
@@ -64,6 +66,8 @@
protected InetSocketAddress
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194498695
--- Diff: src/java/main/org/apache/zookeeper/common/ZKConfig.java ---
@@ -107,14 +99,33 @@ private void init() {
* this configuration
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/353
+1
thanx @lvfangmin ! this looks good to me. are you okay with this @anmolnar ?
---
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/548#discussion_r197933819
--- Diff: src/java/test/org/apache/zookeeper/common/NetUtilsTest.java ---
@@ -0,0 +1,46 @@
+package apache.zookeeper.common;
--- End diff
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/579
hey @mjeelanimsft when i did the commit, your email address came up wrong.
i think i fixed it, but you might want to check your git config.
thanx for the submission!
---
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/583
ok @lvfangmin i'll commit this once the conflict is resolved.
---
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/588#discussion_r207597400
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java ---
@@ -1165,6 +1165,58 @@ synchronized public long
startForwarding(LearnerHandler
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/588#discussion_r207596633
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java ---
@@ -1165,6 +1165,58 @@ synchronized public long
startForwarding(LearnerHandler
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/588#discussion_r207597633
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java ---
@@ -86,6 +86,7 @@
QuorumCnxManager manager
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/586#discussion_r207599621
--- Diff: src/contrib/zkpython/src/c/zookeeper.c ---
@@ -387,8 +387,8 @@ int parse_acls(struct ACL_vector *acls, PyObject
*pyacls)
PyObject *perms
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/584#discussion_r205959572
--- Diff: src/java/main/org/apache/zookeeper/server/DataTree.java ---
@@ -478,7 +478,10 @@ public void createNode(final String path, byte data[],
List acl
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/560
+1 i approve. thanx for handling the commit @hanm !
---
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/565
+1 let's make this happen
---
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/555#discussion_r205669958
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java ---
@@ -792,7 +792,14 @@ public boolean syncFollower(long peerLastZxid
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/584
i'm not sure this is an issue. there is a single thread
(FileRequestProcessor) that does all the mutations, so i don't think there is a
race here. there might be a race in other places, but we need
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/579#discussion_r205666190
--- Diff: src/c/tests/TestClient.cc ---
@@ -325,7 +326,17 @@ class Zookeeper_simpleSystem : public
CPPUNIT_NS::TestFixture
CPPUNIT_ASSERT(zk
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/579#discussion_r205666180
--- Diff: src/c/src/zookeeper.c ---
@@ -842,11 +842,16 @@ static int resolve_hosts(const zhandle_t *zh, const
char *hosts_in, addrvec_t
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/548
+1 i'll kick jenkins
---
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r205667305
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -102,6 +102,20 @@
/** Maximum time we allow for elapsed
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r205667420
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -102,6 +102,21 @@
/** Maximum time we allow for elapsed
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r205667343
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -102,6 +102,21 @@
/** Maximum time we allow for elapsed
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/583
@nkalmar i think fixing whitespace is good if it is in proximity of the
code you are changing, which i think is the case in this diff.
the logic looks good to me! thanx @lvfangmin
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/573
i'll kick it again and see if it works.
---
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/579#discussion_r205666254
--- Diff: src/c/tests/zkServer.sh ---
@@ -77,7 +77,7 @@ fi
if [ "x${base_dir}" == "x" ]
then
-zk_base=&
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/579#discussion_r205666234
--- Diff: src/c/tests/zkServer.sh ---
@@ -77,7 +77,7 @@ fi
if [ "x${base_dir}" == "x" ]
then
-zk_base=&
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/566
i agree with @maoling, logging it with every warning seems overkill. the
rest of the change looks great though. are you ok with removing the extra words
in the log message?
---
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/563#discussion_r205668951
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
@@ -1128,9 +1128,9 @@ public void processPacket(ServerCnxn cnxn, ByteBuffer
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/585
wow! what's going on with this patch? it's huge?
---
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/545#discussion_r205663822
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
@@ -866,6 +866,9 @@ public void setServerCnxnFactory(ServerCnxnFactory
factory
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/545#discussion_r205663866
--- Diff:
src/java/test/org/apache/zookeeper/server/persistence/UtilTest.java ---
@@ -0,0 +1,91 @@
+/**
--- End diff --
did you mean
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/563
thank you @bothejjms !
---
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/606
+1 thank you @lvfangmin
---
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/593#discussion_r212782182
--- Diff: zookeeper-docs/src/documentation/content/xdocs/zookeeperAdmin.xml
---
@@ -1641,6 +1641,24 @@ server.3=zoo3:2888:3888
Default
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/605#discussion_r212781611
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java ---
@@ -452,7 +452,7 @@ public void testElectionFraud() throws
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/586#discussion_r212781950
--- Diff: src/contrib/zkpython/src/c/zookeeper.c ---
@@ -387,8 +387,8 @@ int parse_acls(struct ACL_vector *acls, PyObject
*pyacls)
PyObject *perms
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/556
it would be nice to get this in. i'm on vacation right now. @anmolnar or
@phunt do you have any idea how we can debug what is going on on jenkins?
---
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/562
+1 looks like this one is good to go. i'll kick off the tests again. if it
passes, do you want to commit @hanm , or shall i?
---
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/561#discussion_r201304775
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
@@ -1047,14 +1047,19 @@ public void processConnectRequest(ServerCnxn cnxn
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/561#discussion_r201303059
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
@@ -754,7 +754,7 @@ public void finishSessionInit(ServerCnxn cnxn, boolean
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/561#discussion_r201304401
--- Diff:
src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java ---
@@ -878,10 +880,13 @@ protected void pRequest(Request request) throws
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/561#discussion_r201304579
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
@@ -1047,14 +1047,19 @@ public void processConnectRequest(ServerCnxn cnxn
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/561#discussion_r201303257
--- Diff: src/java/main/org/apache/zookeeper/jmx/MBeanRegistry.java ---
@@ -124,9 +124,7 @@ private void unregister(String path,ZKMBeanInfo bean)
throws
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/561#discussion_r201304300
--- Diff:
src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java ---
@@ -817,10 +817,12 @@ protected void pRequest(Request request) throws
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/554
+1 nice! english si hadr! thank you.
---
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/556
yes, it did look like they passed, but it stayed as failed. kicking again.
---
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/556
+1 thank you @maoling !
i've restarted the build. if it passes, i'll get this committed.
---
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/353
ok, with two +1s i'll be committing this one.
---
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/559
+1 thanks for the submission. if there are no objections, i'll commit this
tomorrow
---
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/560#discussion_r200716591
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java ---
@@ -399,8 +399,30 @@ public void save(DataTree dataTree
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/562#discussion_r200717310
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -905,6 +908,12 @@ public void run
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/558
+1 i agree. thanx you. will commit tomorrow if no -1 votes
---
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/353
quick question, is it ok that the voting happens here rather than the jira?
i thought comments would be bridged over, but that doesn't seem to be
happening...
---
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/624#discussion_r217873955
--- Diff: zookeeper-docs/src/documentation/content/xdocs/zookeeperAdmin.xml
---
@@ -265,18 +266,25 @@ server.3=zoo3:2888:3888
role="
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/624
thanks for remembering to update the doc @maoling !
---
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/624#discussion_r217873847
--- Diff: zookeeper-docs/src/documentation/content/xdocs/zookeeperAdmin.xml
---
@@ -265,18 +266,25 @@ server.3=zoo3:2888:3888
role="
84 matches
Mail list logo
