GitHub user eolivelli opened a pull request:
https://github.com/apache/zookeeper/pull/76
ZOOKEEPER-2460 Remove javacc dependency from public Maven pom
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eolivelli/zookeeper ZOOKEEPER
GitHub user eolivelli opened a pull request:
https://github.com/apache/zookeeper/pull/165
ZOOKEEPER-2665 Port QA github pull request build to branch 3.4 and 3.5
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eolivelli/zookeeper
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/165
@eribeiro that you for reviewing this.
IMHO it it just a variable name. The script is basically the same as in the
trunk version. I think it would be better to leave all versions as much
Github user eolivelli closed the pull request at:
https://github.com/apache/zookeeper/pull/76
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/76
Now can zookeeper accepts PRs what should I do to make the QA bot pick
this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/116
@arshadmohammad I have deleted the file
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/116
I will update the PR as soon as possible. Thank you
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/222#discussion_r36880
--- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java ---
@@ -1325,6 +1325,23 @@ public synchronized void close() throws
InterruptedException
GitHub user eolivelli opened a pull request:
https://github.com/apache/zookeeper/pull/222
ZOOKEEPER-2697 Handle graceful stop of ZookKeeper client
Add a ZooKeeper.close(int timeout) method which waits for internal
resources to be released
You can merge this pull request into a Git
GitHub user eolivelli opened a pull request:
https://github.com/apache/zookeeper/pull/227
ZOOKEEPER-2755 Allow to subclass ClientCnxnSocketNetty and NettyServerCnxn
Little refactoring to use only SocketAddress instead of RemoteSocketAddress
and make it possible to create subclasses
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/165
@hanm the patch is almost the same as for trunk, just a work of "copy and
paste"
Eventually you can compare the diff with #97
---
If your project is set up for it, you
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/227
@ivankelly thank you for your time
> The commit message explains what the patch is doing, but not why. The
reason I'm pushing back a lot on this, is that I think it adds indirect
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/227
@ivankelly I have rebased the patch to latest master and updated the commit
message
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/227
For my use cases server to server is not required and netty is not yet
supported on that side.
Eventually I can work in the future to introduce netty
---
If your project is set up
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/227
@ivankelly I have some cases in which I will use in production. I have some
app which can be installed both in clusters and in single machine deployment.
I know zk server is not born to run
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/227
@ivankelly thanks for taking a look.
I do not have numbers about local transport vs loopback.
The first use case is to run unit tests of applications which use zk
eithout opening ports
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/227
@ivankelly
I understand your point
This is another usecase of an use which hacked zookeeper in order to
achieve a similar goal.
http://mail-archives.apache.org/mod_mbox
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/222#discussion_r113415006
--- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java ---
@@ -1325,6 +1325,23 @@ public synchronized void close() throws
InterruptedException
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/222
@hanm This patch only adds a new method, with no changes to the rest of the
library and it does not break binary compatibility.
So IMHO It can be safely added to 3.5.x branch to. But I am
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/222
@Randgalt @hanm can you review please ?
Wish: can this patch be merged in 3.5 branch too ?
@Randgalt I will be happy to submit a PR for curator once this new method
gets
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/222#discussion_r113902401
--- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java ---
@@ -1325,6 +1325,20 @@ public synchronized void close() throws
InterruptedException
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/227#discussion_r113903695
--- Diff: src/java/test/org/apache/zookeeper/test/NettyLocalSuiteTest.java
---
@@ -0,0 +1,35 @@
+/**
+ * Licensed to the Apache Software
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/222
@hanm thank you for your review.
I have added a javadoc note on the close() method and the @since tag.
Thank for including this in the 3.5.4 release too
---
If your project is set
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/227#discussion_r115932842
--- Diff: src/java/test/org/apache/zookeeper/test/NettyLocalSuiteTest.java
---
@@ -0,0 +1,35 @@
+/**
+ * Licensed to the Apache Software
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/227#discussion_r120951358
--- Diff: src/java/test/org/apache/zookeeper/test/NettyLocalSuiteTest.java
---
@@ -0,0 +1,35 @@
+/**
+ * Licensed to the Apache Software
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/227#discussion_r114798834
--- Diff: src/java/test/org/apache/zookeeper/test/NettyLocalSuiteTest.java
---
@@ -0,0 +1,35 @@
+/**
+ * Licensed to the Apache Software
Github user eolivelli closed the pull request at:
https://github.com/apache/zookeeper/pull/227
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/227
@ivankelly @afine @hanm
I am going to close this pull request and the associated JIRA ticket if
this approach is not interesting
---
If your project is set up for it, you can reply
GitHub user eolivelli opened a pull request:
https://github.com/apache/zookeeper/pull/524
ZOOKEEPER-3043: QuorumKerberosHostBasedAuthTest fails on Linux box: Unable
to parse:includedir /etc/krb5.conf.d/
Fixes QuorumKerberosHostBasedAuthTest, see ZOOKEEPER-3043
- upgrade
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/524
I will send another patch for 3.4.
---
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/524#discussion_r189660714
--- Diff: build.xml ---
@@ -55,8 +55,8 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyl
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/524#discussion_r189661235
--- Diff: build.xml ---
@@ -55,8 +55,8 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyl
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/524#discussion_r189661074
--- Diff: build.xml ---
@@ -55,8 +55,8 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyl
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/524
Maybe I tried 1.1.1 will send patch tomorrow.
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/524
@phunt patch ready for master
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/524
retest this please
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/524
@phunt
Patch on branch 3.4 #532
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/524
@phunt
I have cleaned up.
I did a 'git commit -a' by mistake.
I am preparing patch for 3.4
---
GitHub user eolivelli opened a pull request:
https://github.com/apache/zookeeper/pull/532
ZOOKEEPER-3043: QuorumKerberosHostBasedAuthTest fails on Linux box: Unable
to parse:includedir /etc/krb5.conf.d/
Change test directory for KerberosTestUtils from test.dir to build.test.dir
Github user eolivelli closed the pull request at:
https://github.com/apache/zookeeper/pull/532
---
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/546#discussion_r197768825
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/RemotePeerBeanTest.java ---
@@ -36,7 +36,7 @@ public void
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/546
@anmolnar tests added as you requested. Now it looks better.
I have understood what you meant, I did not use Mockito, I cannot mock the
class I am testing
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/546
@anmolnar sure, thanks.
I will add tests. I prefer using Mockito in this case, it makes it clear
that we are testing only a part of the class
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/546
@enixon @anmolnar
IMHO I answered to all of your questions
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/546
@anmolnar ready to go now
---
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/546#discussion_r197497322
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -2069,4 +2073,9 @@ public QuorumCnxManager createCnxnManager
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/546
@anmolnar
I checked the code, in my opinion the *id* inside current vote is the id of
what the local peer thinks the leader is. See for instance updateServerState,
in which state
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/546
@anmolnar
This round:
- Explicit unit test for LocalPeerBean, which is using a mock QuorumPeer
- Explicit unit test for QuorumPeer
all the code changes are now covered.
---
Github user eolivelli closed the pull request at:
https://github.com/apache/zookeeper/pull/546
---
GitHub user eolivelli reopened a pull request:
https://github.com/apache/zookeeper/pull/546
ZOOKEEPER-3066 Expose on JMX of Followers the id of the current leader
Expose a new JMX attribute "isLeader" in RemotePeerBean and LocalPeerBean
You can merge this pull request
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/546
retest this please
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/546
@anmolnar how ? Seems that magic Jenkins words 'retest this please' does
not work on ZK
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/546
@anmolnar green light !
please cherry pick to 4.5 branch
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/546
@anmolnar thank you so much.
---
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/546#discussion_r197604271
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -2069,4 +2073,9 @@ public QuorumCnxManager createCnxnManager
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/546#discussion_r197496922
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -2069,4 +2073,9 @@ public QuorumCnxManager createCnxnManager
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/136
News on this great feature?
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/546
@anmolnar I see with your point.
Will update the patch soon
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/546
@ivankelly I have cleaned up the patch, restoring all trailing white spaces.
I am trying to find the best way to force a leader election in
HierarchicalQuorumTest but I am not finding
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/549
Doesn't the merge script do a squash?
---
Github user eolivelli commented on the pull request:
https://github.com/apache/zookeeper/commit/cac68c3503d207c5f7d955ba582dfe3bfa22cb9b#commitcomment-29499666
Interesting so the test used 3 zeroes
---
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/457#discussion_r168304302
--- Diff: src/java/test/org/apache/zookeeper/test/WatcherAuthTest.java ---
@@ -0,0 +1,84 @@
+package org.apache.zookeeper.test;
+
+import
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/457#discussion_r168303288
--- Diff: src/java/test/org/apache/zookeeper/test/WatcherAuthTest.java ---
@@ -0,0 +1,84 @@
+package org.apache.zookeeper.test;
+
+import
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/457#discussion_r168302735
--- Diff:
src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java ---
@@ -310,6 +313,9 @@ public void respondToServer(byte[] serverToken
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/457#discussion_r168302873
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
@@ -1101,8 +1102,16 @@ public void processPacket(ServerCnxn cnxn
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/450#discussion_r168301786
--- Diff:
src/java/test/org/apache/zookeeper/server/persistence/FileTxnSnapLogTest.java
---
@@ -35,92 +38,181 @@
public class
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/546
@nkalmar @ivankelly
thanks for your help
I have added a restart of the first 3 servers in the cluster.
This is enough to see leadership change, but I did not add specific
GitHub user eolivelli opened a pull request:
https://github.com/apache/zookeeper/pull/546
ZOOKEEPER-3066 Expose on JMX of Followers the id of the current leader
Expose a new JMX attribute "isLeader" in RemotePeerBean and LocalPeerBean
You can merge this pull request
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/546
Patch contains a fix on trailing spaces for each file I have touched (I can
revert this if you prefer).
I would like to cherry pick to 3.5 branch
---
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/546#discussion_r196841132
--- Diff:
src/java/test/org/apache/zookeeper/test/HierarchicalQuorumTest.java ---
@@ -227,37 +227,73 @@ void startServers(boolean withObservers) throws
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/546
@anmolnar @nkalmar @ivankelly
Thank you all for helping me with this patch.
I have added a bunch of Mockito based tests.
About the existing test..I have only added a check
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/582
@pravsingh thank you for taking a look.
We are going to design a zookeeper proprierary internal API mostly because
we want the project to be owner of its own internal instrumentation system
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/582#discussion_r205936167
--- Diff: src/java/main/org/apache/zookeeper/metrics/Counter.java ---
@@ -0,0 +1,47 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/582
@hanm @anmolnar do you have cycles for review?
If this approach is good I can send the second part, about booting the
provider in the server and providing some sample instrumentation
---
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/582#discussion_r207704611
--- Diff: src/java/main/org/apache/zookeeper/metrics/Gauge.java ---
@@ -0,0 +1,35 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/582#discussion_r207704605
--- Diff: src/java/main/org/apache/zookeeper/metrics/MetricsContext.java ---
@@ -0,0 +1,61 @@
+/**
+ * Licensed to the Apache Software
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/582#discussion_r207705040
--- Diff: src/java/main/org/apache/zookeeper/metrics/Counter.java ---
@@ -0,0 +1,47 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/580
I think it will be easier for FB guys to merge their work to community repo
and then we can move to the new system.
Otherwise the two forks will never converge.
So I will lean
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/580
@jtuple in my opinion it is better to allow all of changes coming from
Facebook to be merged in as soon as possible.
Having only one common codebase is necessary in order to work together
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/582
@anmolnar you are right.
MetricsContext will be like a namespace, I expect that each
component/submodule will have its own MetricsContext.
This is useful for two reasons/usecases
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/582
@anmolnar you are right.
MetricsContext will be like a namespace, I expect that each
component/submodule will have its own MetricsContext.
This is useful for two reasons/usecases
Github user eolivelli closed the pull request at:
https://github.com/apache/zookeeper/pull/598
---
GitHub user eolivelli reopened a pull request:
https://github.com/apache/zookeeper/pull/598
ZOOKEEPER-3120 add NetBeans nbproject directory to .gitignore
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eolivelli/zookeeper fix
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/582
I will add more docs.
Seems that we are agreeing on this way.
I will send a new patch based on this branch (or on master if we merge this
patch)
New step is about booting
GitHub user eolivelli opened a pull request:
https://github.com/apache/zookeeper/pull/598
add NetBeans nbproject directory to .gitignore
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eolivelli/zookeeper fix/netbeans-nbproject
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/598
@anmolnar recent Apache NetBeans versions create an "nbproject" directory.
I would like to add this directory to .gitignore, there are already a bunch
of NB related d
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/580
@anmolnar this change is a backport from Facebook fork.
in PR #582 I have started a brand new work, to design and implement a long
term ZK internal API to instrument server and client
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/582
@anmolnar that you for catching those file, I did a 'git add .' too
aggressively.
@lvfangmin I have addressed you comments
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/582
Shall we commit this patch ? So we can make little steps forward. This
change does not impact how zk works, it is safe
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/582
@anmolnar thank you for following up on this.
Background of this issue is on JIRA
https://issues.apache.org/jira/browse/ZOOKEEPER-3092
the plan is the following:
- send
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/582
@anmolnar I have updated the docs.
Using ant javadoc will not produce an usefull javadoc site, most package
will be empty.
Which is the command to use to build the full docs ?
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/582
Cool.
Will follow up with the next part.
Thank you
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/582
Btw I think this is good to go now
---
GitHub user eolivelli opened a pull request:
https://github.com/apache/zookeeper/pull/601
WIP - ZOOKEEPER-3123 MetricsProvider Lifecycle in ZooKeeper Server
Manage the lifecycle of a MetricsProvider inside a ZooKeeper server.
- handle configuration
- start and configure
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/601
tagging @anmolnar @lvfangmin
---
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/601#discussion_r212544888
--- Diff:
src/java/main/org/apache/zookeeper/metrics/impl/NullMetricsProvider.java ---
@@ -0,0 +1,100 @@
+/**
+ * Licensed to the Apache
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/601#discussion_r212545767
--- Diff:
src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java ---
@@ -117,13 +121,23 @@ public void runFromConfig(ServerConfig config
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/601#discussion_r212986954
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java ---
@@ -141,6 +145,16 @@ public void runFromConfig(QuorumPeerConfig
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/601#discussion_r213002472
--- Diff:
src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java ---
@@ -117,13 +121,23 @@ public void runFromConfig(ServerConfig config
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/601
@anmolnar @lvfangmin please take a look to my questions , so that we can
move forward.
---
1 - 100 of 281 matches
Mail list logo
