Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r92326091
--- Diff:
src/java/test/org/apache/zookeeper/server/ServerCxnExceptionsTest.java ---
@@ -0,0 +1,170 @@
+/**
+ * Licensed to the Apache Software
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r92326078
--- Diff:
src/java/test/org/apache/zookeeper/server/ServerCxnExceptionsTest.java ---
@@ -0,0 +1,170 @@
+/**
+ * Licensed to the Apache Software
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r92326026
--- Diff:
src/java/test/org/apache/zookeeper/server/ServerCxnExceptionsTest.java ---
@@ -0,0 +1,170 @@
+/**
+ * Licensed to the Apache Software
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r92283709
--- Diff:
src/java/test/org/apache/zookeeper/server/ServerCxnExceptionsTest.java ---
@@ -0,0 +1,170 @@
+/**
+ * Licensed to the Apache Software
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r92296453
--- Diff:
src/java/test/org/apache/zookeeper/server/ServerCxnExceptionsTest.java ---
@@ -0,0 +1,170 @@
+/**
+ * Licensed to the Apache Software
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r92297258
--- Diff:
src/java/test/org/apache/zookeeper/server/ServerCxnExceptionsTest.java ---
@@ -0,0 +1,170 @@
+/**
+ * Licensed to the Apache Software
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r92296064
--- Diff:
src/java/test/org/apache/zookeeper/server/MockNettyServerCnxn.java ---
@@ -0,0 +1,65 @@
+/**
+ * Licensed to the Apache Software
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r92266304
--- Diff:
src/java/test/org/apache/zookeeper/server/ServerCxnExceptionsTest.java ---
@@ -0,0 +1,170 @@
+/**
+ * Licensed to the Apache Software
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r92282690
--- Diff:
src/java/test/org/apache/zookeeper/server/ServerCxnExceptionsTest.java ---
@@ -0,0 +1,170 @@
+/**
+ * Licensed to the Apache Software
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r92297351
--- Diff:
src/java/test/org/apache/zookeeper/server/ServerCxnExceptionsTest.java ---
@@ -0,0 +1,170 @@
+/**
+ * Licensed to the Apache Software
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r92297692
--- Diff:
src/java/test/org/apache/zookeeper/server/ServerCxnExceptionsTest.java ---
@@ -0,0 +1,170 @@
+/**
+ * Licensed to the Apache Software
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r92298117
--- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java ---
@@ -694,7 +690,7 @@ public void sendResponse(ReplyHeader h, Record r,
String
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r92269582
--- Diff:
src/java/test/org/apache/zookeeper/server/ServerCxnExceptionsTest.java ---
@@ -0,0 +1,170 @@
+/**
+ * Licensed to the Apache Software
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r92274772
--- Diff:
src/java/test/org/apache/zookeeper/server/ServerCxnExceptionsTest.java ---
@@ -0,0 +1,170 @@
+/**
+ * Licensed to the Apache Software
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r92264074
--- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java ---
@@ -716,7 +716,12 @@ public void process(WatchedEvent event) {
//
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r92269683
--- Diff:
src/java/test/org/apache/zookeeper/server/ServerCxnExceptionsTest.java ---
@@ -0,0 +1,170 @@
+/**
+ * Licensed to the Apache Software
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r92271380
--- Diff:
src/java/test/org/apache/zookeeper/server/ServerCxnExceptionsTest.java ---
@@ -0,0 +1,170 @@
+/**
+ * Licensed to the Apache Software
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r92266393
--- Diff:
src/java/test/org/apache/zookeeper/server/ServerCxnExceptionsTest.java ---
@@ -0,0 +1,170 @@
+/**
+ * Licensed to the Apache Software
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r92268597
--- Diff:
src/java/test/org/apache/zookeeper/server/ServerCxnExceptionsTest.java ---
@@ -0,0 +1,170 @@
+/**
+ * Licensed to the Apache Software
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r90963807
--- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java ---
@@ -71,7 +71,7 @@
NettyServerCnxnFactory factory;
boolean
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r90963562
--- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java ---
@@ -71,7 +71,7 @@
NettyServerCnxnFactory factory;
boolean
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r90960756
--- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java ---
@@ -71,7 +71,7 @@
NettyServerCnxnFactory factory;
boolean
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r90953900
--- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java ---
@@ -71,7 +71,7 @@
NettyServerCnxnFactory factory;
boolean
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r90942133
--- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java ---
@@ -71,7 +71,7 @@
NettyServerCnxnFactory factory;
boolean
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r90935413
--- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java ---
@@ -71,7 +71,7 @@
NettyServerCnxnFactory factory;
boolean
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r90924628
--- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java ---
@@ -71,7 +71,7 @@
NettyServerCnxnFactory factory;
boolean
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r90783210
--- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java ---
@@ -71,7 +71,7 @@
NettyServerCnxnFactory factory;
boolean
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r90782724
--- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java ---
@@ -716,7 +716,12 @@ public void process(WatchedEvent event) {
//
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r90782565
--- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java ---
@@ -71,7 +71,7 @@
NettyServerCnxnFactory factory;
boolean
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r90762715
--- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java ---
@@ -165,31 +163,35 @@ public void process(WatchedEvent event) {
@Override
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r90763391
--- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java ---
@@ -716,7 +716,12 @@ public void process(WatchedEvent event) {
//
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r90762620
--- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java ---
@@ -71,7 +71,7 @@
NettyServerCnxnFactory factory;
boolean
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r90553827
--- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java ---
@@ -165,31 +163,35 @@ public void process(WatchedEvent event) {
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r90549964
--- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java ---
@@ -716,7 +716,12 @@ public void process(WatchedEvent event) {
//
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r90550930
--- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java ---
@@ -165,31 +163,35 @@ public void process(WatchedEvent event) {
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r86691087
--- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java ---
@@ -716,7 +716,12 @@ public void process(WatchedEvent event) {
//
Github user rgs1 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r86679205
--- Diff:
src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java ---
@@ -842,7 +868,26 @@ private void addCnxn(NIOServerCnxn cnxn) {
Github user rgs1 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r86679164
--- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java ---
@@ -716,7 +716,12 @@ public void process(WatchedEvent event) {
//
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r86673997
--- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java ---
@@ -716,7 +716,12 @@ public void process(WatchedEvent event) {
//
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r86674430
--- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java ---
@@ -716,7 +716,12 @@ public void process(WatchedEvent event) {
//
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r86674332
--- Diff:
src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java ---
@@ -842,7 +868,26 @@ private void addCnxn(NIOServerCnxn cnxn) {
Github user rgs1 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r86672337
--- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java ---
@@ -716,7 +716,12 @@ public void process(WatchedEvent event) {
//
Github user rgs1 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r86672419
--- Diff:
src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java ---
@@ -105,8 +115,26 @@ public void channelConnected(ChannelHandlerContext
Github user rgs1 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r86672349
--- Diff:
src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java ---
@@ -630,6 +640,22 @@ public static ByteBuffer getDirectBuffer() {
Github user rgs1 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r86672326
--- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java ---
@@ -716,7 +716,12 @@ public void process(WatchedEvent event) {
//
Github user rgs1 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r86672385
--- Diff:
src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java ---
@@ -842,7 +868,26 @@ private void addCnxn(NIOServerCnxn cnxn) {
GitHub user yufeldman opened a pull request:
https://github.com/apache/zookeeper/pull/99
ZOOKEEPER-2549 Add exception handling to sendResponse
Fix for:
As NettyServerCnxn.sendResponse() allows all the exception to bubble up it
can stop main ZK requests processing thread
47 matches
Mail list logo
