[
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15769038#comment-15769038
]
Michael Han commented on ZOOKEEPER-2479:
[~rakeshr] A small change is required for this patch
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15766572#comment-15766572
]
Rakesh R commented on ZOOKEEPER-2479:
-
Thanks [~fpj] and [~hanm] for the discussion. I've closed
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15766565#comment-15766565
]
ASF GitHub Bot commented on ZOOKEEPER-2479:
---
Github user rakeshadr commented on the issue:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15766566#comment-15766566
]
ASF GitHub Bot commented on ZOOKEEPER-2479:
---
Github user rakeshadr closed the pull request
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15766542#comment-15766542
]
Flavio Junqueira commented on ZOOKEEPER-2479:
-
I don't know why it didn't close the pull
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15766354#comment-15766354
]
Michael Han commented on ZOOKEEPER-2479:
Good point - wondering how did this patch targeting
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15766271#comment-15766271
]
Rakesh R commented on ZOOKEEPER-2479:
-
IIUC, its not done cherry pick to branch-3.4, because I've
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15766232#comment-15766232
]
Michael Han commented on ZOOKEEPER-2479:
[~rakeshr] I think you could just close PR 130
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15764710#comment-15764710
]
Rakesh R commented on ZOOKEEPER-2479:
-
Thank you [~fpj] for final reviews and commits.
[Pull
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15764338#comment-15764338
]
Hudson commented on ZOOKEEPER-2479:
---
FAILURE: Integrated in Jenkins build ZooKeeper-trunk #3202 (See
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15764259#comment-15764259
]
Flavio Junqueira commented on ZOOKEEPER-2479:
-
+1, thanks for the patch, [~rakeshr].
>
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15764247#comment-15764247
]
ASF GitHub Bot commented on ZOOKEEPER-2479:
---
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15756521#comment-15756521
]
Rakesh R commented on ZOOKEEPER-2479:
-
OK, I've created
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15756517#comment-15756517
]
ASF GitHub Bot commented on ZOOKEEPER-2479:
---
GitHub user rakeshadr opened a pull request:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15754176#comment-15754176
]
Flavio Junqueira commented on ZOOKEEPER-2479:
-
if there is no issue with having two pull
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15753450#comment-15753450
]
Rakesh R commented on ZOOKEEPER-2479:
-
Thanks [~fpj], I need to do the changes separately for
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15724267#comment-15724267
]
Rakesh R commented on ZOOKEEPER-2479:
-
I think, this task will be useful to ZK-1045 feature.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15692915#comment-15692915
]
Rakesh R commented on ZOOKEEPER-2479:
-
[~rgs], [~fpj], I've tried an attempt to fix your review
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675943#comment-15675943
]
Hadoop QA commented on ZOOKEEPER-2479:
--
-1 overall. GitHub Pull Request Build
+1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675912#comment-15675912
]
ASF GitHub Bot commented on ZOOKEEPER-2479:
---
Github user rakeshadr commented on a diff in
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675883#comment-15675883
]
ASF GitHub Bot commented on ZOOKEEPER-2479:
---
Github user rgs1 commented on a diff in the
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675882#comment-15675882
]
ASF GitHub Bot commented on ZOOKEEPER-2479:
---
Github user rgs1 commented on a diff in the
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675758#comment-15675758
]
ASF GitHub Bot commented on ZOOKEEPER-2479:
---
Github user rakeshadr commented on the issue:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15666073#comment-15666073
]
ASF GitHub Bot commented on ZOOKEEPER-2479:
---
Github user fpj commented on the issue:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15666049#comment-15666049
]
Rakesh R commented on ZOOKEEPER-2479:
-
[~fpj], please let me know anything else to be done for
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15635624#comment-15635624
]
ASF GitHub Bot commented on ZOOKEEPER-2479:
---
Github user eribeiro commented on a diff in the
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15635085#comment-15635085
]
ASF GitHub Bot commented on ZOOKEEPER-2479:
---
Github user rakeshadr commented on a diff in
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633784#comment-15633784
]
ASF GitHub Bot commented on ZOOKEEPER-2479:
---
Github user eribeiro commented on a diff in the
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633544#comment-15633544
]
Rakesh R commented on ZOOKEEPER-2479:
-
OK, attached new patch generated from git master.
> Add
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15632978#comment-15632978
]
Flavio Junqueira commented on ZOOKEEPER-2479:
-
OK, but to be clear, if you do a diff,
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15632783#comment-15632783
]
Rakesh R commented on ZOOKEEPER-2479:
-
bq. It seems zk svn trunk doesn't have the latest code
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15632634#comment-15632634
]
Flavio Junqueira commented on ZOOKEEPER-2479:
-
Yeah, we've switched to git and I don't
32 matches
Mail list logo
