Re: Proposed changes to RelEng's OSX build and test infrastructure

2013-11-22 Thread Andrew McCreight
Note that we currently have a large set of intermittent 10.8 OSX opt-only leaks-until-shutdown with the debugger: https://bugzilla.mozilla.org/show_bug.cgi?id=942102 I don't know if these will show up on 10.9 or not, or if they really matter that much. Andrew - Original Message -

A/B testing with telemetry

2013-11-22 Thread Henri Sivonen
Do we have a formalized way to do A/B testing with telemetry? That is, assuming that there is a telemetry probe that measures problem symptoms and a boolean pref for turning on a potential solution, is there a way the declare the pref as something that telemetry queries can be constrained by so

Re: Unified builds

2013-11-22 Thread Mike Hommey
On Thu, Nov 14, 2013 at 05:49:33PM -0500, Ehsan Akhgari wrote: I've started to work on a project in my spare time to switch us to use unified builds for C/C++ compilation. The way that unified builds work is by using the UNIFIED_SOURCES instead of the SOURCES variable in moz.build files.

Is for...of on a live DOM node list supposed to do the right thing?

2013-11-22 Thread Benjamin Smedberg
Is for..of on live DOM nodelists supposed to correctly iterate even when items are removed from the list? I have a testcase where this does not seem to be working correctly: http://jsfiddle.net/f8xzQ/ Is there a simple way to do this correctly? --BDS

Re: Is for...of on a live DOM node list supposed to do the right thing?

2013-11-22 Thread Jason Orendorff
On 11/22/13 8:40 AM, Benjamin Smedberg wrote: Is for..of on live DOM nodelists supposed to correctly iterate even when items are removed from the list? I have a testcase where this does not seem to be working correctly: http://jsfiddle.net/f8xzQ/ Is there a simple way to do this correctly?

Re: Proposed changes to RelEng's OSX build and test infrastructure

2013-11-22 Thread Armen Zambrano Gasparnian
- Original Message - From: Mike Hommey m...@glandium.org To: John O'Duinn jodu...@mozilla.com Cc: dev. planning dev-plann...@lists.mozilla.org, dev-platform@lists.mozilla.org, release rele...@mozilla.com Sent: Friday, November 22, 2013 1:34:46 AM Subject: Re: Proposed changes to

Re: Unified builds

2013-11-22 Thread Ehsan Akhgari
On 2013-11-21 1:12 PM, ISHIKAWA,chiaki wrote: (2013/11/22 2:17), Ehsan Akhgari wrote: FWIW if this proves to be common, it's a huge problem since it would affect our crash stats etc... :( Well, if the problem is related to the symptom that I observed with the use of -gsplit-dwarf option with

Re: Unified builds

2013-11-22 Thread Ehsan Akhgari
On 2013-11-22 8:33 AM, Mike Hommey wrote: On Thu, Nov 14, 2013 at 05:49:33PM -0500, Ehsan Akhgari wrote: I've started to work on a project in my spare time to switch us to use unified builds for C/C++ compilation. The way that unified builds work is by using the UNIFIED_SOURCES instead of the

Re: Is there any reason not to shut down bonsai?

2013-11-22 Thread Aki Sasaki
On 11/21/13 8:56 PM, Jed Davis wrote: On Thu, Nov 21, 2013 at 05:41:27PM -0500, Boris Zbarsky wrote: On 11/21/13 3:15 PM, Gavin Sharp wrote: It would be good to explore alternatives to Bonsai. https://github.com/mozilla/mozilla-central is supposed to have full CVS history, right? We're

Re: Proposed changes to RelEng's OSX build and test infrastructure

2013-11-22 Thread Ted Mielczarek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I think this plan is generally sound. Users are moving en-masse to 10.9 with the free update, so we should focus our resources there, and keep 10.6 around to support those users that can't update for hardware reasons. I just have one point of

RE: Re: Proposed changes to RelEng's OSX build and test infrastructure

2013-11-22 Thread Zambrano Gasparnian, Armen
Hi Andrew, That's good to know. Thanks! Sent from Samsung tabletAndrew McCreight amccrei...@mozilla.com wrote:Note that we currently have a large set of intermittent 10.8 OSX opt-only leaks-until-shutdown with the debugger:   https://bugzilla.mozilla.org/show_bug.cgi?id=942102 I don't know

Re: Is for...of on a live DOM node list supposed to do the right thing?

2013-11-22 Thread Boris Zbarsky
On 11/22/13 9:40 AM, Benjamin Smedberg wrote: Is for..of on live DOM nodelists supposed to correctly iterate even when items are removed from the list? I believe the current behavior is identical to what would happen with an array here. Consider http://jsfiddle.net/hpmHg/3/ The core issue

Re: Unified builds

2013-11-22 Thread Boris Zbarsky
On 11/22/13 11:41 AM, Ehsan Akhgari wrote: Hmm to the best of my knowledge, we don't generate the *.i files unless if you explicitly request them. Is that what you did in that build? ccache obvously always generates .i files, since those are what it uses as its cache key. And then it

Re: Is there any reason not to shut down bonsai?

2013-11-22 Thread Boris Zbarsky
On 11/22/13 12:11 PM, Aki Sasaki wrote: I'm not seeing this in gecko-dev; can you find this same issue in that repo? No, this one behaves sanely. Going to the parent of the relevant changeset gets you to a changeset where layout/html/forms/src/nsGfxTextControlFrame2.cpp is present, and

Re: Is there any reason not to shut down bonsai?

2013-11-22 Thread Aki Sasaki
On 11/22/13 1:06 PM, Boris Zbarsky wrote: On 11/22/13 12:11 PM, Aki Sasaki wrote: I'm not seeing this in gecko-dev; can you find this same issue in that repo? No, this one behaves sanely. Going to the parent of the relevant changeset gets you to a changeset where

Fwd: [Planned Maintenance Notification] Tree Closure and MTV1 Office Downtime Nov 22 1815 - Nov 23 0100 PT

2013-11-22 Thread Hal Wine
Original Message Subject:[Planned Maintenance Notification] Tree Closure and MTV1 Office Downtime Date: Fri, 22 Nov 2013 19:34:55 - From: notificati...@mozilla.com Short Summary : Due to a planned power outage in the building that hosts the

Please use NS_WARN_IF instead of NS_ENSURE_SUCCESS

2013-11-22 Thread Benjamin Smedberg
With the landing of bug 672843, the NS_ENSURE_* macros are now considered deprecated. If you are writing code that wants to issue warnings when methods fail, please either use NS_WARNING directly or use the new NS_WARN_IF macro. if (NS_WARN_IF(somethingthatshouldbetrue)) return

Re: Proposed changes to RelEng's OSX build and test infrastructure

2013-11-22 Thread Johnathan Nightingale
On Nov 22, 2013, at 12:29 PM, Ted Mielczarek wrote: On 11/21/2013 4:56 PM, John O'Duinn wrote: 6) If a developer lands a patch that works on 10.9, but it fails somehow on 10.7 or 10.8, it is unlikely that we would back out the fix, and we would instead tell users to upgrade to 10.9 anyways,

Re: Unified builds

2013-11-22 Thread Ehsan Akhgari
On Fri, Nov 22, 2013 at 1:02 PM, Boris Zbarsky bzbar...@mit.edu wrote: On 11/22/13 11:41 AM, Ehsan Akhgari wrote: Hmm to the best of my knowledge, we don't generate the *.i files unless if you explicitly request them. Is that what you did in that build? ccache obvously always generates .i

Re: Unified builds

2013-11-22 Thread Gregory Szorc
On Nov 22, 2013, at 13:16, Ehsan Akhgari ehsan.akhg...@gmail.com wrote: On Fri, Nov 22, 2013 at 1:02 PM, Boris Zbarsky bzbar...@mit.edu wrote: On 11/22/13 11:41 AM, Ehsan Akhgari wrote: Hmm to the best of my knowledge, we don't generate the *.i files unless if you explicitly request them.

Re: Please use NS_WARN_IF instead of NS_ENSURE_SUCCESS

2013-11-22 Thread Daniel Holbert
On 11/22/2013 12:18 PM, Benjamin Smedberg wrote: If you are writing code that wants to issue warnings when methods fail, please either use NS_WARNING directly or use the new NS_WARN_IF macro. if (NS_WARN_IF(somethingthatshouldbetrue)) return NS_ERROR_INVALID_ARG; if

RE: Re: Proposed changes to RelEng's OSX build and test infrastructure

2013-11-22 Thread Zambrano Gasparnian, Armen
I want to explicitely disable *all* 10.7 testing (unlike mentioned on point 8) at once by the end of Tuesday as it gains us no clear value (please help me if I'm missing anything wrt to its value on release branches). I would like to have this extra 10.6 machines verified in preparation for

RE: Re: Proposed changes to RelEng's OSX build and test infrastructure

2013-11-22 Thread Zambrano Gasparnian, Armen
Yes, that's right. Moving it to back fill in low demand would make it more noticeable. We have to have backfilling coverage tools to fix this in the coming year. Thanks Mike. Sent from Samsung tabletMike Hommey m...@glandium.org wrote:On Fri, Nov 22, 2013 at 08:33:31AM -0800, Armen Zambrano

Re: Unified builds

2013-11-22 Thread Ehsan Akhgari
On 2013-11-22 4:25 PM, Gregory Szorc wrote: On Nov 22, 2013, at 13:16, Ehsan Akhgari ehsan.akhg...@gmail.com wrote: On Fri, Nov 22, 2013 at 1:02 PM, Boris Zbarsky bzbar...@mit.edu wrote: On 11/22/13 11:41 AM, Ehsan Akhgari wrote: Hmm to the best of my knowledge, we don't generate the *.i

Re: Unified builds

2013-11-22 Thread Mike Hommey
On Fri, Nov 22, 2013 at 07:24:14PM -0500, Ehsan Akhgari wrote: On 2013-11-22 4:25 PM, Gregory Szorc wrote: On Nov 22, 2013, at 13:16, Ehsan Akhgari ehsan.akhg...@gmail.com wrote: On Fri, Nov 22, 2013 at 1:02 PM, Boris Zbarsky bzbar...@mit.edu wrote: On 11/22/13 11:41 AM, Ehsan Akhgari

nsIBrowserDomWindow question

2013-11-22 Thread Look, Yuriy
Hi, nsIBrowserDomWindow does not get recognized in C++ code, even though nsIBrowserDomWindow.h is #included. Do I need to do anything differently compare to other interfaces? Thank you in advance, Yuriy Look | Software Developer | Compuware APM yuriy.l...@compuware.com 

Re: nsIBrowserDomWindow question

2013-11-22 Thread Josh Matthews
Are you using the correct nsIBrowserDOMWindow capitalization? Cheers, Josh On 11/23/2013 09:31 AM, Look, Yuriy wrote: Hi, nsIBrowserDomWindow does not get recognized in C++ code, even though nsIBrowserDomWindow.h is #included. Do I need to do anything differently compare to other