I didn't know this existed. I filed bug 995763 to get this link added to
the 'review requested' email to hopefully increase visibility.
On Sat, Apr 12, 2014 at 12:10 PM, Kartikaya Gupta kgu...@mozilla.comwrote:
Just a reminder that this page exists:
On Sat, Apr 12, 2014 at 8:29 AM, Gregory Szorc g...@mozilla.com wrote:
I came across the following articles on source control and code review:
* https://secure.phabricator.com/book/phabflavor/article/
recommendations_on_revision_control/
*
On 4/13/2014 4:42 PM, Robert O'Callahan wrote:
Honestly, I think we're already pretty close to most of those
recommendations, most of the time. More descriptive commit messages
is the only recommendation there that is not commonly followed, as far
as I can see.
I was thinking about it, and
On Fri, 11 Apr 2014 13:29:01 -0700, Gregory Szorc wrote:
https://secure.phabricator.com/book/phabflavor/article/writing_reviewable_code
I would be thrilled if we started adopting some of the
recommendations such as more descriptive commit messages and many,
smaller commits over fewer,
I also added a link at
https://developer.mozilla.org/en-US/docs/Developer_Guide/How_to_Submit_a_Patch#Creating_a_patch
Benoit Girard writes:
I didn't know this existed. I filed bug 995763 to get this link added to
the 'review requested' email to hopefully increase visibility.
On Sat, Apr
Joshua Cranmer . writes:
On 4/13/2014 4:42 PM, Robert O'Callahan wrote:
Honestly, I think we're already pretty close to most of those
recommendations, most of the time.
Some experienced Mozillians are breaking up their large changes
well, but some are not. And many less experienced
6 matches
Mail list logo
