On Tue, Jul 7, 2015 at 6:10 PM, Michael Layzell mich...@thelayzells.com wrote:
No, I never checked if it happens on an optimized build, but as C++ follows
an as-if principal, which means that code has to execute as if those
temporaries had been created. Unfortunately, AddRef and Release are
On Wed, Jul 8, 2015 at 6:52 AM, Gabor Krizsanits gkrizsan...@mozilla.com
wrote:
On Wed, Jul 8, 2015 at 1:05 AM, Bobby Holley bobbyhol...@gmail.com
wrote:
The priority is to automatically rewrite our source with a unified style.
foo - aFoo is reasonably safe, whereas aFoo-foo is not, at
On Wed, Jul 8, 2015 at 1:05 AM, Bobby Holley bobbyhol...@gmail.com wrote:
On Tue, Jul 7, 2015 at 3:59 PM, Eric Rahm er...@mozilla.com wrote:
I'm not a huge fan of the 'aFoo' style, but I am a huge fan of
consistency. So if we want to change the style guide we should update our
codebase,
On 08/07/15 07:17, Kyle Machulis wrote:
If you've had requirements for an external library with an LGPL license, we
now have a place to put them. There's still some odd things that you have
to do with symbol visibility to get this to work (feel free to ping me or
hit #build on IRC if you have
On 2015-07-08 2:17 AM, Kyle Machulis wrote:
If you've had requirements for an external library with an LGPL license, we
now have a place to put them.
This is fully awesome.
- mhoye
___
dev-platform mailing list
dev-platform@lists.mozilla.org
On 07/08/2015 04:05 AM, Milan Sreckovic wrote:
Jeff encouraged me to add more things to this thread, so I’m blaming him. So,
some random thoughts.
After getting paid to write code for 20+ years and then showing up at Mozilla,
and seeing the a prefix, I thought “this is brilliant, how come
Do you actually have any data how many % of Gecko devs would prefer not using
aFoo?
I mean it makes no sense to change to foo, if most of the devs prefer aFoo.
Similarly I would stop objecting the change if majority of the devs say
yes, please change this coding style which Mozilla has had
On 07/07/2015 11:34 PM, Jeff Gilbert wrote:
Outvars are good candidates for having markings in the variable name.
`aFoo` for all arguments is a poor solution for this, though.
On Tue, Jul 7, 2015 at 1:22 PM, smaug opet...@mozilla.com wrote:
On 07/07/2015 11:18 PM, Jeff Gilbert wrote:
On
I brought this up on IRC, but I think this is worth taking to the list:
Replacing TemporaryRef with already_AddRefed has already caused at least one
leak because already_AddRefed does not call Release() on the pointer it holds
if nothing takes ownership of that pointer before its destructor
On Tue, Jul 7, 2015 at 9:59 AM, Seth Fowler mfow...@mozilla.com wrote:
I brought this up on IRC, but I think this is worth taking to the list:
Replacing TemporaryRef with already_AddRefed has already caused at least
one leak because already_AddRefed does not call Release() on the pointer it
We're already working on a static analysis in
https://bugzilla.mozilla.org/show_bug.cgi?id=1180993 which will prevent
code like that from passing try.
Hopefully that will help with your concerns.
On 2015-07-07 12:59 PM, Seth Fowler wrote:
I brought this up on IRC, but I think this is worth
The Web API documentation community meeting, with representatives from
the technical evangelism and the API development teams, will take place
on Thursday at 8 AM Pacific Time (see http://bit.ly/1GghwBR for your
time zone).
Typical meetings include news about recent API development progress and
On Wed, Jul 8, 2015 at 3:52 AM, Gabor Krizsanits gkrizsan...@mozilla.com
wrote:
The priority is to automatically rewrite our source with a unified style.
foo - aFoo is reasonably safe, whereas aFoo-foo is not, at least with
the
current tools. So we either need to combine the rewrite tools
On 7/8/2015 3:08, Gregory Szorc wrote:
On Tue, Jul 7, 2015 at 5:13 PM, Jeff Gilbert jgilb...@mozilla.com wrote:
On Tue, Jul 7, 2015 at 3:59 PM, Eric Rahm er...@mozilla.com wrote:
I'm not a huge fan of the 'aFoo' style, but I am a huge fan of
consistency. So if we want to change the style
As of bug 1176300 landing (and hopefully sticking), we now have a place for
LGPL symbols in gecko. There's a new shared library called lgpllibs
(because I am horrible at naming things but it should at least be obvious
what it is). Currently it holds libsoundtouch, which is LGPL with
exception, but
On Wed, Jul 8, 2015 at 4:45 PM, Karl Tomlinson mozn...@karlt.net wrote:
I think we could relax the 'a' prefix requirement to be a
convention used when identifying the variable as a parameter is
useful. My opinion is that this is useful for most parameters in
all non-trivial functions, but
Bobby Holley writes:
On Wed, Jul 8, 2015 at 4:45 PM, Karl Tomlinson mozn...@karlt.net wrote:
I think we could relax the 'a' prefix requirement to be a
convention used when identifying the variable as a parameter is
useful. My opinion is that this is useful for most parameters in
all
Bobby Holley writes:
On Wed, Jul 8, 2015 at 3:52 AM, Gabor Krizsanits gkrizsan...@mozilla.com
wrote:
The priority is to automatically rewrite our source with a unified style.
foo - aFoo is reasonably safe, whereas aFoo-foo is not, at least with
the
current tools. So we either need to
18 matches
Mail list logo
