Notifications of new private downloads

2013-01-13 Thread Neil
nsIDownloadManagerUI has had an aUsePrivateUI parameter added to its show() method. However, it gets passed in an id, which makes no sense in per-window private browsing i.e. if aUsePrivateUI is set then you can't actually find out which download has just started. I also see that nsIDownloadMa

Re: removing warning/debug messages from NSPR (debug) logging

2013-01-03 Thread Neil
Nathan Froyd wrote: If you have objections to this change, please speak up, either here or in bug 794178. set NSPR_LOG_FILE=WinDebug is currently the only way to get assertions and warnings logged in the debugger output window. (Other output, such as dump(), is special-cased.) -- Warning:

Re: Use of "instanceof SomeDOMInterface" in chrome and extensions

2013-01-03 Thread Neil
Bobby Holley wrote: In the long term, I'd like for Xray wrappers to behave more logically with respect to the prototype chain than they have in the past. Some nodes, such as HTMLImageElement nodes, expose more properties on their "Xray" wrappers than on their content wrappers. Does this apply

Re: Use of "instanceof SomeDOMInterface" in chrome and extensions

2013-01-01 Thread Neil
Bobby Holley wrote: You can do things like "new contentWindow.XMLHttpRequest" That's a good example, thanks. -- Warning: May contain traces of nuts. ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-

Re: Use of "instanceof SomeDOMInterface" in chrome and extensions

2012-12-31 Thread Neil
Bobby Holley wrote: In the long term, I'd like for Xray wrappers to behave more logically with respect to the prototype chain than they have in the past. I believe that Peter has already taken the first step by giving us meaningful Xrays to DOM prototypes and interface objects What does mean

Re: Use of "instanceof SomeDOMInterface" in chrome and extensions

2012-12-31 Thread Neil
Boris Zbarsky wrote: On 12/30/12 4:43 PM, Neil wrote: (I would actually expect the proto of an Xray for a content object to be an [xpconnect wrapped native prototype] If you expect that for WebIDL objects... you're going to be disappointed. ;) Yeah, well I still wish Xrays had

Re: Use of "instanceof SomeDOMInterface" in chrome and extensions

2012-12-30 Thread Neil
Boris Zbarsky wrote: Alternately, we could do something where the proto chain of an Xray for a content object passes through the corresponding chrome prototypes, not through Xrays for the content window's prototypes. That would presumably make "el instanceof el.ownerDocument.defaultView.HTML

Re: Use of "instanceof SomeDOMInterface" in chrome and extensions

2012-12-28 Thread Neil
Boris Zbarsky wrote: On 12/28/12 3:54 AM, Neil wrote: How does removing nsIDOM* stuff without removing nsIDOMNode reduce memory usage There are elements that implement multiple nsIDOM*, last I checked. But if you're keeping nsIDOMNode, then you might as well keep the most po

Re: Use of "instanceof SomeDOMInterface" in chrome and extensions

2012-12-28 Thread Neil
Neil wrote: Boris Zbarsky wrote: Unfortunately, that's not how instanceof works in JS. Try it with Object instead of HTMLAnchorElement... Making foo instanceof Array false across globals was an extension-breaking change when it happened. Fortunately we have Array.isArray these days.

Re: Use of "instanceof SomeDOMInterface" in chrome and extensions

2012-12-28 Thread Neil
Boris Zbarsky wrote: Unfortunately, that's not how instanceof works in JS. Try it with Object instead of HTMLAnchorElement... Making foo instanceof Array false across globals was an extension-breaking change when it happened. Fortunately we have Array.isArray these days. -- Warning: May c

Re: Use of "instanceof SomeDOMInterface" in chrome and extensions

2012-12-28 Thread Neil
Justin Dolske wrote: On 12/27/12 3:33 PM, Neil wrote: Justin Dolske wrote: What happens today (and in the future), with something like: // Hello, I am chrome code adding an anchor to content var noob = document.createElement("a"); gBrowser.contentDocument.body.appendChild(n

Re: nsTArray > is not reentrant

2012-12-28 Thread Neil
Jonas Sicking wrote: There's nothing special about XPCOM objects here. While this is clearly true, I still feel it's getting away from my original point, because I was trying to compare with nsCOMArray. -- Warning: May contain traces of nuts. ___

Re: Use of "instanceof SomeDOMInterface" in chrome and extensions

2012-12-28 Thread Neil
Boris Zbarsky wrote: On 12/27/12 1:54 PM, Neil wrote: Presumably this involves completely removing all XPIDL DOM interfaces from HTML nodes, thus saving one vtable entry per node? There are cases in which we can remove nsIDOM* stuff without removing nsIDOMNode/Element/HTMLElement. Which

Re: Use of "instanceof SomeDOMInterface" in chrome and extensions

2012-12-27 Thread Neil
Justin Dolske wrote: What happens today (and in the future), with something like: // Hello, I am chrome code adding an anchor to content var noob = document.createElement("a"); gBrowser.contentDocument.body.appendChild(noob); If you're lucky, you append a XUL element to the content docu

Re: nsTArray > is not reentrant

2012-12-27 Thread Neil
Jonas Sicking wrote: On Dec 18, 2012 4:15 AM, "Neil" wrote: While investigating the possibility of switching nsCOMArray away from nsVoidArray it occurred to me that nsCOMArray takes steps to ensure internal consistency before releasing removed elements; this is because it

Re: Use of "instanceof SomeDOMInterface" in chrome and extensions

2012-12-27 Thread Neil
Boris Zbarsky wrote: We have a bunch of chrome and extension code that does things like "instanceof HTMLAnchorElement" (and likewise with other DOM interfaces). c-c MXR suggests 305 cases of "instanceof HTML.*Element". There are also 18 "instanceof XUL.*Element, 13 "instanceof Element", 14 "i

Re: Fwd: A question about multithreading in gecko using javascript

2012-12-20 Thread Neil
David Rajchenbach-Teller wrote: On 12/20/12 7:27 AM, Ray You wrote: How can we start a real thread in gecko using javascript and use XPCOM in it? Is dispatching events to /nsIStreamTransportService/ or /nsIThreadManager.newThread(0) /the right way? I don't think this is supported anym

Re: NS_NewArrayEnumerator

2012-12-19 Thread Neil
Benjamin Smedberg wrote: On 12/18/2012 11:05 AM, Neil wrote: While looking at tbsaunde's patch to remove the nsISupportsArray version of NS_NewArrayEnumerator I noticed that many users of NS_NewArrayEnumerator copy entries from a hash into a temporary array which they then enumerate,

NS_NewArrayEnumerator

2012-12-18 Thread Neil
While looking at tbsaunde's patch to remove the nsISupportsArray version of NS_NewArrayEnumerator I noticed that many users of NS_NewArrayEnumerator copy entries from a hash into a temporary array which they then enumerate, which works by creating an instance of an enumerator class that recopie

nsTArray > is not reentrant

2012-12-18 Thread Neil
While investigating the possibility of switching nsCOMArray away from nsVoidArray it occurred to me that nsCOMArray takes steps to ensure internal consistency before releasing removed elements; this is because it's potentially possible for Release() to invoke arbitrary code; if this code ends u

Re: Synchronous loading of data: URLs

2012-12-12 Thread Neil
Jonathan Kew wrote: On 11/12/12 10:51, Neil wrote: Neil wrote: Jonathan Kew wrote: You shouldn't normally see a flash of fallback text unless the font is particularly slow to load; the text should be invisible until the font is available. We aim to hide the text until the font is

Re: Synchronous loading of data: URLs

2012-12-11 Thread Neil
Neil wrote: Jonathan Kew wrote: You shouldn't normally see a flash of fallback text unless the font is particularly slow to load; the text should be invisible until the font is available. We aim to hide the text until the font is ready, unless it takes more than a few seconds to load.

Re: Integrating ICU into Mozilla build

2012-12-08 Thread Neil Harris
ppropriate. -- Neil ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Synchronous loading of data: URLs

2012-12-06 Thread Neil
Jonathan Kew wrote: You shouldn't normally see a flash of fallback text unless the font is particularly slow to load; the text should be invisible until the font is available. We aim to hide the text until the font is ready, unless it takes more than a few seconds to load. (The timeout is conf

Re: Synchronous loading of data: URLs

2012-12-05 Thread Neil
John Daggett wrote: Last time I looked, Webkit caches activated fonts, so the second time the UA loads the same font (e.g. in a different document) it will be shown immediately without fallback content first. Ah, so that explains the fallback flash I experience on a site I frequent that make

Re: Super-review, what shall we do with you?

2012-12-04 Thread Neil
Blake Kaplan wrote: Neil wrote: static const PRUnichar* kResetBackupDirectory = NS_LITERAL_STRING("resetBackupDirectory").get(); Isn't this an anti-pattern anyway because the string (and the memory owned by it) will get destructed after the semicolon

Re: Super-review, what shall we do with you?

2012-12-01 Thread Neil
On a side note, what can we do about checking for unusually verbose or inefficient constructs? Examples: static const PRUnichar* kResetBackupDirectory = NS_LITERAL_STRING("resetBackupDirectory").get(); This is technically incorrect on systems that don't support a 16-bit char type (short wcha

Re: Use of MOZ_MAKE_FLAGS Considered Unnecessary

2012-11-28 Thread Neil
Gregory Szorc wrote: https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=7f5e2a9addff http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=7f5e2a9addff http://hg.mozilla.org/integration/mozilla-inbound/rev/ba730945bc6d https://bugzilla.mozilla.org/show_bug.cgi?id=815219 -- W

Re: Converting IDOMNode to IDOMHTMLInputElement fails

2012-11-20 Thread Neil
Kyle Huey wrote: The IID of nsIDOMHTMLInputElement changed from Gecko 16 to Gecko 17. You are probably compiling against headers for Gecko 16. How does bug 813264 affect this? -- Warning: May contain traces of nuts. ___ dev-platform mailing list d

Re: Proposal: Not shipping experimental APIs on the release channel

2012-11-13 Thread Neil
Henri Sivonen wrote: On Tue, Nov 13, 2012 at 12:14 PM, Neil wrote: Henri Sivonen wrote: On Fri, Nov 9, 2012 at 7:38 PM, Neil wrote: Is there any way we can make it so that the prefixed version doesn't work unless you attempt (and presumably fail) to detect the unpre

Re: Migrating mozilla-central builds to the Windows 8 SDK

2012-11-13 Thread Neil
jim.math...@gmail.com wrote: Key notes - * The 8.0 SDK requires Windows 7 (or Windows Server 2008 R2) -- Warning: May contain traces of nuts. ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platf

Re: Proposed style guide modification: using declarations and nested namespaces

2012-11-13 Thread Neil
Robert O'Callahan wrote: On Mon, Nov 12, 2012 at 8:37 PM, Jeff Walden wrote: We ended up removing the nested |using| above and making all SpiderMonkey headers qualify everything with mozilla::. We use few enough things from mozilla:: so far that we switched to |using mozilla::RangedPtr| an

Re: Proposal: Not shipping prefixed APIs on the release channel

2012-11-13 Thread Neil
Henri Sivonen wrote: On Fri, Nov 9, 2012 at 7:38 PM, Neil wrote: Is there any way we can make it so that the prefixed version doesn't work unless you attempt (and presumably fail) to detect the unprefixed version? What purpose would the prefix serve in such a scenario?

Re: Proposed policy change: reusability of tests by other browsers

2012-11-11 Thread Neil
Aryeh Gregor wrote: Currently we only check that no test fails that's not on the per-file whitelist of expected fails, and in practice that works fine for us. If we wanted to be pickier, we could list all expected results, both pass and fail, and verify that the lists exactly match. This is

Re: Proposal: Not shipping prefixed APIs on the release channel

2012-11-09 Thread Neil
Is there any way we can make it so that the prefixed version doesn't work unless you attempt (and presumably fail) to detect the unprefixed version? -- Warning: May contain traces of nuts. ___ dev-platform mailing list dev-platform@lists.mozilla.org h

Re: nsXPIDLArray

2012-10-22 Thread Neil
Joshua Cranmer wrote: On 10/21/2012 12:31 PM, Neil wrote: While reviewing a patch that had to call into login manager from C++ I noticed that we don't have an RAII class for handling the array outparam. Would one be appreciated? I have written something that I call nsXPIDLArray, whi

nsXPIDLArray

2012-10-21 Thread Neil
While reviewing a patch that had to call into login manager from C++ I noticed that we don't have an RAII class for handling the array outparam. Would one be appreciated? I have written something that I call nsXPIDLArray, which so far has the following features: * Most of the work handled b

Re: Proposal: Remove Linux PGO Testing

2012-10-11 Thread Neil
Tim Taubert wrote: Nobody likes running debug builds because they're slower I always run debug builds. What does that make me? ;-) -- Warning: May contain traces of nuts. ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.moz

Re: IMPORTANT: Do not pull from inbound

2012-10-05 Thread Neil
Ehsan Akhgari wrote: use a better revision control system Or a better file system perhaps ;-) -- Warning: May contain traces of nuts. ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: mach has landed

2012-10-05 Thread Neil
Nicholas Nethercote wrote: On Thu, Oct 4, 2012 at 10:18 AM, Justin Lebar wrote: 1) Build errors are hard to identify with make. Parallel execution can make them even harder to track down. Poor output from invoked processes is also a problem. I have a script [1] which works well en

Re: NS_New$THING vs. new $THING

2012-10-03 Thread Neil
Nathan Froyd wrote: IMHO, the current state of affairs for bug 792169 is a little ugly, insofar as you do: #include "nsArray.h" ... nsCOMPtr = nsArray::Create(); ... I can certainly see the advantages of #include "nsIMutableArray.h" ... nsCOMPtr array = NewIArray(); [I'm assuming here

Re: NS_New$THING vs. new $THING

2012-10-01 Thread Neil
Ehsan Akhgari wrote: There might be times where you want the concrete type of the thing that your ctor function returns to be opaque, in which case it might make sense to go with the NS_NewFoo style of method. That might even apply here, since my understanding was that mutable arrays need to

Re: "ERROR: Logon failure: unknown user name or bad password." on mochitests

2012-09-27 Thread Neil
Neil wrote: Also, you might find you actually need to grant permission on a containing folder. Actually, it looks as if wmiprvse.exe doesn't inherit permissions, and it should have the following permissions, or at least, this is the output of CACLS %windir%\system32\wbem\wmiprvse.exe

Re: "ERROR: Logon failure: unknown user name or bad password." on mochitests

2012-09-27 Thread Neil
Clint Talbert wrote: On 9/26/2012 8:32 AM, Armen Zambrano G. wrote: On 12-09-26 6:45 AM, Neil wrote: Perhaps the file system permissions are incorrect and NT AUTHORITY\NETWORK SERVICE doesn't have permission to access C:\WINDOWS\system32\wbem\wmiprvse.exe ? You might be right. How

Re: Type of nullptr on Mac OS X 10.7 debug

2012-09-27 Thread Neil
Henri Sivonen wrote: I had void operator=(const jArray& other) where jArray is a struct and void operator=(L zero) where L is in practice int32_t and argument zero is only ever 0. void operator=(L zero) { // Make assigning null to an array in Java delete the buffer in C++

Re: "ERROR: Logon failure: unknown user name or bad password." on mochitests

2012-09-26 Thread Neil
Armen Zambrano G. wrote: Hi all, Recently we've set up some new XP slaves that fail on mochitest jobs due to this error: "ERROR: Logon failure: unknown user name or bad password." Unfortunately, I have not been able what is triggering that error (I can't find the strings in our code). If y

Re: What would be the right approach to hide scrollbars for one document?

2012-09-25 Thread Neil
Paul Rouget wrote: For the Firefox Developer Tools, we need to be able to hide the scrollbars of a document (in the "Responsive Design Tool"). Scrollbars are native anonymous content so most stylesheets just don't see them (the obvious exception is of course chrome://global/skin/scrollbars

Re: Type of nullptr on Mac OS X 10.7 debug

2012-09-21 Thread Neil
Henri Sivonen wrote: Use case: Catching nullptr assignment in operator=. That's not a very enlightening description of a use case... which overloads do you already have, and which one is the compiler using when you don't want it to? -- Warning: May contain traces of nuts.

Re: No more egg-info directories in source directory

2012-09-05 Thread Neil
Blair McBride wrote: On 5/09/2012 6:13 a.m., Gregory Szorc wrote: $ hg status -u | grep .egg-info | xargs rm -rf $ git ls-files -o '*.egg-info*' | xargs rm -rf Those of you on Windows will notice this doesn't work, thanks to Windows-style paths. The following will: $ hg status -un | grep

Re: New XPIDL attribute: [infallible]

2012-08-24 Thread Neil
Justin Lebar wrote: %{C++ inline int32_t GetFoo() { int32_t result; nsresult rv = GetFoo(&result); MOZ_ASSERT(NS_SUCCEEDED(rv)); return result; } %} Alternative approach? inline int32_t Foo(int32_t result = 0) { GetFoo(&result); return result; } -- Warning: May contain

Re: New XPIDL attribute: [infallible]

2012-08-24 Thread Neil
Justin Lebar wrote: So now you can do nsCOMPtr foo; int32_t f = foo->GetFoo(); Why was I expecting this to be Foo()? (Perhaps unreasonably.) I rejected the first approach because it meant that every call to GetFoo from XPCOM would need to go through two virtual calls: GetFoo(int32_t*) an

Re: Gecko switched to use standard integer types

2012-08-24 Thread Neil
Makoto Kato wrote: How about PRUptrdiff? Most cases can changes to uintptr_t. Which surprised me, but then I guess NSPR didn't have a true uintptr_t type. I did find one use of PRUptrdiff that should have been size_t though. -- Warning: May contain traces of nuts. __

Re: Moving Away from Makefile's

2012-08-24 Thread Neil
Gregory Szorc wrote: We want feedback on the file format to use for the new build manifest files. Is there a good reason to shoehorn everything into a single file format? -- Warning: May contain traces of nuts. ___ dev-platform mailing list dev-plat

Re: Moving Away from Makefile's

2012-08-22 Thread Neil
Gregory Szorc wrote: Up until now, the focus has been on making Makefile.in's themselves generic and data-driven. We would use pymake's API to parse, load, and extract data from Makefile.in's to construct the build definition. In the long run, we'd realize that using make files for data defini

Re: Components.utils.import caches?

2012-08-20 Thread Neil
Benjamin Smedberg wrote: On 8/20/2012 9:25 AM, sebastiang...@gmail.com wrote: Am Dienstag, 1. Februar 2011 06:16:50 UTC+1 schrieb johnjbarton: I recall reading some rumors about Components.utils.import being cached in such a way that devs can't change the source and see changes. Any truth t

Re: Access Windows system variable from chrome JavaScript

2012-08-17 Thread Neil
Malintha Adikari wrote: I want to access system variable in Windows OS from my firebug extension. Can I do that ? Is it possible to access OS system variables inside the chrome JavaScript ? Did you mean environment variable? In that case use https://developer.mozilla.org/en-US/docs/XPCOM_I

Re: Proposed policy change: reusability of tests by other browsers

2012-08-16 Thread Neil
Ehsan Akhgari wrote: On the testharness.js side, we have things like assert_regexp_match, for example. I would argue that whether or not assert_regexp_match(a, /foo/, "msg") is more readable than ok(/foo/.match(a), "msg") is very subjective and depends on what the author of the test is used t

Re: XUL Runner, and the future.

2012-08-16 Thread Neil
Dave Townsend wrote: On 08/15/12 12:41, Ben Hearsum wrote: On 08/15/12 02:57 PM, Justin Wood (Callek) wrote: XULRunner is currently an unsupported piece of software, we don't run tests for it, and we *barely* ensure it still builds. I don't think this is true. It's not tier1, but we ship i

Trying to fix bug 524337

2012-08-14 Thread Neil
Since I don't have Vista, I haven't really been able to look at bug 524337, but recently I installed a VM with Windows 8 Preview so I was able to see what was going on. On Windows the outer textbox is styled with the textbox appearance, which is handled by the native theme code. In Windows c

Re: WheelEvent of DOM Level 3 Events now landed

2012-08-13 Thread Neil
Masayuki Nakano wrote: On 2012/08/13 4:57, Neil wrote: it seems as if you can't make the wheel scroll more slowly any more? Currently, yes. The reason for not supporting slower scrolling isn't technical reason. It needs some additional code. E.g., 0.5px scroll isn't suppo

Re: WheelEvent of DOM Level 3 Events now landed

2012-08-12 Thread Neil
Masayuki Nakano wrote: By the changes, some prefs of mousewheel.* don't make sense now. They are replaced with new prefs: * mousewheel.(horizscroll.)?(withshiftkey|withaltkey|withmetakey|withcontrolkey|withnokey).sysnumlines Just removed. * mousewheel.(horizscroll.)?(withshift

Re: Switching to stdint types on mozilla-central

2012-08-10 Thread Neil
Ehsan Akhgari wrote: So, PRIntn should be converted to int and PRUintn to unsigned, is that correct? Yes please. -- Warning: May contain traces of nuts. ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/

Re: Switching to stdint types on mozilla-central

2012-08-10 Thread Neil
Mike Hommey wrote: That PRIntn is int is an implementation detail. The intent when using int and int32_t/PRInt32 is different. We should keep it that way. Yes, this is roughly what I was trying to say*, I just couldn't think of the word "intent" at the time. Thanks! *The intent when using

Re: Switching to stdint types on mozilla-central

2012-08-10 Thread Neil
Mike Hommey wrote: On Fri, Aug 10, 2012 at 09:24:57AM +0100, Neil wrote: Ehsan Akhgari wrote: PRIntn -> int32_t PRUintn -> uint32_t http://mxr.mozilla.org/comm-central/source/mozilla/nsprpub/pr/include/prtypes.h#385 typedef int PRIntn; typedef unsigned int PRUintn; What

Re: Switching to stdint types on mozilla-central

2012-08-10 Thread Neil
Ehsan Akhgari wrote: PRIntn -> int32_t PRUintn -> uint32_t http://mxr.mozilla.org/comm-central/source/mozilla/nsprpub/pr/include/prtypes.h#385 typedef int PRIntn; typedef unsigned int PRUintn; ... -- Warning: May contain traces of nuts. ___ dev-pl

Re: MDN Kuma wiki launch Friday at 10 AM PDT

2012-08-04 Thread Neil
Justin Lebar wrote: rendering literal < and > characters inside instead of < and > That would make it difficult to put a literal "" inside a block though. -- Warning: May contain traces of nuts. ___ dev-platform mailing list dev-platform@lists.mo

Re: XULRunner builds on Mac and Windows are currently broken

2012-08-03 Thread Neil
Ben Hearsum wrote: Windows fails to compile: https://bugzilla.mozilla.org/show_bug.cgi?id=779910 How do these builds differ from stock Firefox builds, is it just the .mozconfig? -- Warning: May contain traces of nuts. ___ dev-platform mailing lis

Re: PGO and Windows

2012-08-03 Thread Neil
Jean-Marc Desperrier wrote: BTW the last time I had Seamonkey use all the 32-bits adress space, the result was *really* bad. A system down to it's knees, and not able to close the Seamonkey process anymore. It's harder to get the same thing with Firefox, the lazy tab opening helps :-) You ca

Re: GECKO 14: How to get thread safe object of nsIWebProgress

2012-08-01 Thread Neil
sali...@gmail.com wrote: My use case is, I have RPC listener in addon, which is called from some other application. On receiving of RPC event, I need to load a specific URL to the browser. For this I need nsIWebNavigation object in RPC handler. If there is a way to load the URL to the browser

Re: GECKO 14: How to get thread safe object of nsIWebProgress

2012-07-31 Thread Neil
sali...@gmail.com wrote: I have gone through the document "https://developer.mozilla.org/en/XPCOM/Making_cross-thread_calls_using_runnables";, which tells about how to run a method asynchronously. I hove no issue in calling the a method asynchronously. I have problem in sharing the object bet

<    1   2   3   4