Re: Code coverage take 2, and other code hygiene tools

2013-07-10 Thread Joshua Cranmer 
On 6/24/2013 8:50 PM, Clint Talbert wrote: Decoder and Jcranmer got code coverage working on Try[1]. They'd like to expand this into something that runs automatically, generating results over time so that we can actually know what our code coverage status is with our major run-on-checkin test

Re: Code coverage take 2, and other code hygiene tools

2013-07-10 Thread Dave Townsend
On 6/24/2013 6:50 PM, Clint Talbert wrote: Decoder and Jcranmer got code coverage working on Try[1]. They'd like to expand this into something that runs automatically, generating results over time so that we can actually know what our code coverage status is with our major run-on-checkin test

Re: Code coverage take 2, and other code hygiene tools

2013-07-10 Thread Neil
Joshua Cranmer  wrote: if you use --disable-debug --enable-optimize='-g' Custom optimisation flags are not supported and should never have been used to turn on symbols anyway; you should use --disable-debug --enable-debug-symbols --disable-optimize instead. -- Warning: May contain traces

Re: Code coverage take 2, and other code hygiene tools

2013-07-10 Thread Joshua Cranmer 
On 6/25/2013 1:19 PM, Dave Townsend wrote: I wish we could get JS code coverage too though. I think JS code coverage is a worthy goal, but it shouldn't block getting automated code coverage. The problem is that getting this to work reliably basically requires changes in the JS engine in the

Re: Code coverage take 2, and other code hygiene tools

2013-07-10 Thread Ms2ger
On 06/25/2013 03:50 AM, Clint Talbert wrote: So, the key things I want to know: * Will you support code coverage? Would it be useful to your work to have a regularly scheduled code coverage build test run? I have looked at decoder's older code coverage data [1] before, and found it very

Re: Code coverage take 2, and other code hygiene tools

2013-07-01 Thread Ted Mielczarek
On 6/24/2013 11:02 PM, Justin Lebar wrote: Under what circumstances would you expect the code coverage build to break but all our other builds to remain green? Most of the issues I saw with our old code coverage setup were directly related to them not matching our normal production builds. We

Re: Code coverage take 2, and other code hygiene tools

2013-06-25 Thread Ehsan Akhgari
On 2013-06-25 1:42 PM, Clint Talbert wrote: On 6/24/2013 8:02 PM, Justin Lebar wrote: Under what circumstances would you expect the code coverage build to break but all our other builds to remain green? Sorry, I should have been more clear. For builds, I think it would be pretty unusual for

Re: Code coverage take 2, and other code hygiene tools

2013-06-25 Thread L. David Baron
On Monday 2013-06-24 18:50 -0700, Clint Talbert wrote: So, the key things I want to know: * Will you support code coverage? Would it be useful to your work to have a regularly scheduled code coverage build test run? * Would you want to additionally consider using something like JS-Lint for

Re: Code coverage take 2, and other code hygiene tools

2013-06-25 Thread Jed Davis
On Mon, Jun 24, 2013 at 08:02:26PM -0700, Justin Lebar wrote: Under what circumstances would you expect the code coverage build to break but all our other builds to remain green? Anywhere you're using -Werror. I ran into this in a past life with GCC's may-use-uninitialized warning; if it's

Re: Code coverage take 2, and other code hygiene tools

2013-06-25 Thread Kyle Huey
On Tue, Jun 25, 2013 at 1:40 PM, L. David Baron dba...@dbaron.org wrote: On Monday 2013-06-24 18:50 -0700, Clint Talbert wrote: So, the key things I want to know: * Will you support code coverage? Would it be useful to your work to have a regularly scheduled code coverage build test run?