Re: Exact rooting is now enabled on desktop

2014-01-22 Thread Terrence Cole
On 01/20/2014 12:53 PM, Cameron Kaiser wrote: On 1/17/14 1:24 PM, Terrence Cole wrote: SpiderMonkey will no longer scan the stack for live roots; you must now wrap all GC thing pointers that live on the stack across a GC in the JS::Rooted template for SpiderMonkey to see them. See the comments

Re: Exact rooting is now enabled on desktop

2014-01-20 Thread Cameron Kaiser
On 1/17/14 1:24 PM, Terrence Cole wrote: SpiderMonkey will no longer scan the stack for live roots; you must now wrap all GC thing pointers that live on the stack across a GC in the JS::Rooted template for SpiderMonkey to see them. See the comments in js/public/RootingAPI.h and the guide on the

Re: Exact rooting is now enabled on desktop

2014-01-20 Thread Nicholas Nethercote
On Fri, Jan 17, 2014 at 3:22 PM, Jim Blandy j...@mozilla.com wrote: I've never heard of a major project escaping from conservative GC once it had entered that state of sin; nor have I heard of anyone implementing a moving collector after starting with a non-moving collector. There's no better

Re: Exact rooting is now enabled on desktop

2014-01-19 Thread Chris Peterson
On 1/18/14, 9:04 AM, Terrence Cole wrote: Great question! We have a tool called GC zeal in builds with --enable-gc-zeal and in all debug builds unconditionally. It adds a small runtime overhead, but gives us fine-grained control over when GC's happen and adds several verification modes for

Re: Exact rooting is now enabled on desktop

2014-01-18 Thread Benjamin Smedberg
On 1/17/2014 4:24 PM, Terrence Cole wrote: Exact stack rooting is now enabled by default on desktop builds of firefox. Does this mean that the moving GC is also enabled, or is that a later step? If we see an increase in the crash rate for nightly builds, is it likely that they will share a

Re: Exact rooting is now enabled on desktop

2014-01-18 Thread Terrence Cole
On 01/18/2014 07:08 AM, Benjamin Smedberg wrote: On 1/17/2014 4:24 PM, Terrence Cole wrote: Exact stack rooting is now enabled by default on desktop builds of firefox. Does this mean that the moving GC is also enabled, or is that a later step? No, moving GC is a later step. We are targeting

Re: Exact rooting is now enabled on desktop

2014-01-18 Thread Andrew McCreight
- Original Message - Great question! We have a tool called GC zeal in builds with --enable-gc-zeal and in all debug builds unconditionally. It adds a small runtime overhead, but gives us fine-grained control over when GC's happen and adds several verification modes for debugging

Exact rooting is now enabled on desktop

2014-01-17 Thread Terrence Cole
Exact stack rooting is now enabled by default on desktop builds of firefox. What this Means === SpiderMonkey will no longer scan the stack for live roots; you must now wrap all GC thing pointers that live on the stack across a GC in the JS::Rooted template for SpiderMonkey to see

Re: Exact rooting is now enabled on desktop

2014-01-17 Thread Robert O'Callahan
Congratulations! This has been an epic journey :-). Rob -- Jtehsauts tshaei dS,o n Wohfy Mdaon yhoaus eanuttehrotraiitny eovni le atrhtohu gthot sf oirng iyvoeu rs ihnesa.rt sS?o Whhei csha iids teoa stiheer :p atroa lsyazye,d 'mYaonu,r sGients uapr,e tfaokreg iyvoeunr, 'm aotr atnod

Re: Exact rooting is now enabled on desktop

2014-01-17 Thread Jason Orendorff
On 1/17/14 3:24 PM, Terrence Cole wrote: Exact stack rooting is now enabled by default on desktop builds of firefox. *standing ovation forever* -j ___ dev-platform mailing list dev-platform@lists.mozilla.org

Re: Exact rooting is now enabled on desktop

2014-01-17 Thread Jim Blandy
On 01/17/2014 01:24 PM, Terrence Cole wrote: Exact stack rooting is now enabled by default on desktop builds of firefox. I've never heard of a major project escaping from conservative GC once it had entered that state of sin; nor have I heard of anyone implementing a moving collector after