Re: Intent to require `mach try` for submitting to Try

2017-09-25 Thread Aki Sasaki
On 9/16/17 6:43 AM, Eric Rescorla wrote: > 2. There are a lot more people writing code for Firefox than developing the > internal tools, so in general, costs on those people should be avoided. On Mon, Sep 18, 2017 at 5:16 AM, Eric Rescorla wrote: > And having something complex

Re: Intent to require `mach try` for submitting to Try

2017-09-20 Thread Panos Astithas
On Tue, Sep 19, 2017 at 7:20 PM, Andrew McCreight wrote: > I've been using git for years now to develop Firefox, and I feel like it is > a first class experience. There's a one time cost to setting up cinnabar, > but after that, everything just works, including |mach try|

Re: Intent to require `mach try` for submitting to Try

2017-09-20 Thread Jean-Yves Avenard
On Tue, Sep 19, 2017 at 7:21 PM, Eric Rescorla wrote: > I've also had cinnabar fail badly at various times, and then it's been > pretty unclear what > the service level guarantees for that were. > > time to try again maybe? I use git with cinnabar on windows, linux and mac, and I

Re: Intent to require `mach try` for submitting to Try

2017-09-19 Thread Eric Rescorla
On Tue, Sep 19, 2017 at 10:21 AM, Eric Rescorla wrote: > > On Tue, Sep 19, 2017 at 9:20 AM, Andrew McCreight > wrote: > >> On Tue, Sep 19, 2017 at 8:49 AM, Eric Rescorla wrote: >> >> > Generally no, but this is an unfortunate consequence of

Re: Intent to require `mach try` for submitting to Try

2017-09-19 Thread Eric Rescorla
On Tue, Sep 19, 2017 at 9:20 AM, Andrew McCreight wrote: > On Tue, Sep 19, 2017 at 8:49 AM, Eric Rescorla wrote: > > > Generally no, but this is an unfortunate consequence of Mozilla's > decision > > a while ago to pick a VCS which has not turned out to be

Re: Intent to require `mach try` for submitting to Try

2017-09-19 Thread Bobby Holley
On Tue, Sep 19, 2017 at 9:20 AM, Andrew McCreight wrote: > On Tue, Sep 19, 2017 at 8:49 AM, Eric Rescorla wrote: > > > Generally no, but this is an unfortunate consequence of Mozilla's > decision > > a while ago to pick a VCS which has not turned out to be

Re: Intent to require `mach try` for submitting to Try

2017-09-19 Thread Andrew McCreight
On Tue, Sep 19, 2017 at 8:49 AM, Eric Rescorla wrote: > Generally no, but this is an unfortunate consequence of Mozilla's decision > a while ago to pick a VCS which has not turned out to be the dominant > choice (not placing blame here, but I think it's clear that's how it's >

Re: Intent to require `mach try` for submitting to Try

2017-09-19 Thread Eric Rescorla
On Tue, Sep 19, 2017 at 8:40 AM, Aki Sasaki wrote: > On 9/16/17 6:43 AM, Eric Rescorla wrote: > >> 2. There are a lot more people writing code for Firefox than developing >> the >> internal tools, so in general, costs on those people should be avoided. > > > > On Mon, Sep

Re: Intent to require `mach try` for submitting to Try

2017-09-18 Thread Myk Melez
James Graham 2017 September 18 at 02:56 5. Allows vanilla git and hg on the client side, but requires something complex, custom, and scary on the server side to allow pushing to either repo. Could be possible if we eliminate ~all manual pushes (i.e. everything

Re: Intent to require `mach try` for submitting to Try

2017-09-18 Thread Gregory Szorc
On Fri, Sep 15, 2017 at 10:21 PM, ISHIKAWA,chiaki wrote: > Does "mozilla/mach try" will work for try-comm-central? > > (Well, I know there has been a general talk of moving thunderbird to > somewhere else, but it is not going to happen overnight.) > I'm not sure. There's

Re: Intent to require `mach try` for submitting to Try

2017-09-18 Thread Eric Rescorla
On Mon, Sep 18, 2017 at 2:56 AM, James Graham wrote: > On 18/09/17 04:05, Eric Rescorla wrote: > > But that's just a general observation; if you look at this specific case, >>> it might not be much effort to support native git for richer/future try >>> pushing. But that's

Re: Intent to require `mach try` for submitting to Try

2017-09-18 Thread Eric Rescorla
On Mon, Sep 18, 2017 at 1:10 AM, Henri Sivonen wrote: > On Mon, Sep 18, 2017 at 6:05 AM, Eric Rescorla wrote:> > I don't think that's true, for the reasons I indicated above. Rather, > > there's a policy decision about whether we are going to have Git as a >

Re: Intent to require `mach try` for submitting to Try

2017-09-18 Thread James Graham
On 18/09/17 04:05, Eric Rescorla wrote: But that's just a general observation; if you look at this specific case, it might not be much effort to support native git for richer/future try pushing. But that's very different from requiring all the tools to support native git on an equal basis. And

Re: Intent to require `mach try` for submitting to Try

2017-09-18 Thread James Graham
On 18/09/17 09:27, Samael Wang wrote: In a rare case that we need to send a "CLOSED TREE" try job, will we be able to do that with ./mach try? Last time I didn't use mach try to submit try job was because of that. That doesn't work right now, but it should be easy to add a --closed-tree flag

Re: Intent to require `mach try` for submitting to Try

2017-09-18 Thread Samael Wang
In a rare case that we need to send a "CLOSED TREE" try job, will we be able to do that with ./mach try? Last time I didn't use mach try to submit try job was because of that. ___ dev-platform mailing list dev-platform@lists.mozilla.org

Re: Intent to require `mach try` for submitting to Try

2017-09-18 Thread Henri Sivonen
On Mon, Sep 18, 2017 at 6:05 AM, Eric Rescorla wrote:> I don't think that's true, for the reasons I indicated above. Rather, > there's a policy decision about whether we are going to have Git as a > first-class thing or whether we are going to continue force everyone who > uses Git

Re: Intent to require `mach try` for submitting to Try

2017-09-17 Thread Eric Rescorla
On Sun, Sep 17, 2017 at 12:09 PM, Steve Fink wrote: > On 9/16/17 6:43 AM, Eric Rescorla wrote: > >> On Fri, Sep 15, 2017 at 9:25 PM, Gregory Szorc wrote: >> >> >> I'd prefer to take a data-driven approach to answering the question of "do >>> we need to

Re: Intent to require `mach try` for submitting to Try

2017-09-17 Thread Steve Fink
On 9/16/17 6:43 AM, Eric Rescorla wrote: On Fri, Sep 15, 2017 at 9:25 PM, Gregory Szorc wrote: I'd prefer to take a data-driven approach to answering the question of "do we need to support vanilla Git." I wish I had local developer metrics or results from a recent developer

Re: Intent to require `mach try` for submitting to Try

2017-09-17 Thread Marco Bonardo
On Sun, Sep 17, 2017 at 6:05 AM, Andrew Halberstadt wrote: > Interesting, please file a bug either way and CC me. It worked > for me back when it first landed, though I haven't tried it since. > I'll see if I can reproduce sometime this week. Done:

Re: Intent to require `mach try` for submitting to Try

2017-09-16 Thread Andrew Halberstadt
Interesting, please file a bug either way and CC me. It worked for me back when it first landed, though I haven't tried it since. I'll see if I can reproduce sometime this week. On Sat, Sep 16, 2017 at 4:31 AM Marco Bonardo wrote: > I have a problem with try fuzzy, not

Re: Intent to require `mach try` for submitting to Try

2017-09-16 Thread Eric Rescorla
On Fri, Sep 15, 2017 at 9:25 PM, Gregory Szorc wrote: > On Fri, Sep 15, 2017 at 8:37 PM, Eric Rescorla wrote: > >> >> >> On Fri, Sep 15, 2017 at 8:33 PM, Gregory Szorc wrote: >> >>> On Fri, Sep 15, 2017 at 7:44 PM, Eric Rescorla

Re: Intent to require `mach try` for submitting to Try

2017-09-16 Thread Marco Bonardo
I have a problem with try fuzzy, not sure if it's just my system, so didn't file a bug yet. On Windows it always hangs after it tries to cleanup its own stuff at the end, I must terminate it and manually uncommit and purge the config file. Does anyone have the same problem?

Re: Intent to require `mach try` for submitting to Try

2017-09-15 Thread ISHIKAWA,chiaki
Does "mozilla/mach try" will work for try-comm-central? (Well, I know there has been a general talk of moving thunderbird to somewhere else, but it is not going to happen overnight.) TIA ___ dev-platform mailing list dev-platform@lists.mozilla.org

Re: Intent to require `mach try` for submitting to Try

2017-09-15 Thread Eric Rescorla
On Fri, Sep 15, 2017 at 8:33 PM, Gregory Szorc wrote: > On Fri, Sep 15, 2017 at 7:44 PM, Eric Rescorla wrote: > >> What happens if you are using git? >> > > git-cinnabar is already supported. > Supported how? Do I have to have special remote names? Special

Re: Intent to require `mach try` for submitting to Try

2017-09-15 Thread Gregory Szorc
On Fri, Sep 15, 2017 at 7:44 PM, Eric Rescorla wrote: > What happens if you are using git? > git-cinnabar is already supported. Vanilla git is TBD. I see bug 1400470 was just filed for that. > > On Fri, Sep 15, 2017 at 3:30 PM, Gregory Szorc wrote: > >> The

Re: Intent to require `mach try` for submitting to Try

2017-09-15 Thread Andrew Halberstadt
Yes, we'd like to make it the default eventually. I've been holding off for now, but expect it will be switched to the default at some point in Q4 or Q1. If you don't want to wait and are tired of typing 'fuzzy' each time, you can create a ~/.mozbuild/machrc file and add: [try] default = fuzzy On

Re: Intent to require `mach try` for submitting to Try

2017-09-15 Thread Eric Rescorla
What happens if you are using git? -Ekr On Fri, Sep 15, 2017 at 3:30 PM, Gregory Szorc wrote: > The Try Service ("Try") is a mechanism that allows developers to schedule > tasks in automation. The main API for that service is "Try Syntax" (e.g. > "try: -b o -p linux -u

Re: Intent to require `mach try` for submitting to Try

2017-09-15 Thread Boris Zbarsky
On 9/15/17 10:08 PM, Steve Fink wrote: I've never used it, but it already has pretty much exactly this. Look at --save, --preset, and --list-presets under ./mach help try syntax Ah, I see. Alright, I'll give this a shot. -Boris ___ dev-platform

Re: Intent to require `mach try` for submitting to Try

2017-09-15 Thread Gregory Szorc
On Fri, Sep 15, 2017 at 6:58 PM, Boris Zbarsky wrote: > On 9/15/17 6:30 PM, Gregory Szorc wrote: > >> we'd like to require the use of `mach try` for Try >> submissions. >> > > So just to be clear, instead of being able to "hg push -f try" will one > now need to do "./mach try

Re: Intent to require `mach try` for submitting to Try

2017-09-15 Thread Steve Fink
On 9/15/17 6:58 PM, Boris Zbarsky wrote: On 9/15/17 6:30 PM, Gregory Szorc wrote: we'd like to require the use of `mach try` for Try submissions. So just to be clear, instead of being able to "hg push -f try" will one now need to do "./mach try syntax ." and put in the actual syntax

Re: Intent to require `mach try` for submitting to Try

2017-09-15 Thread Boris Zbarsky
On 9/15/17 6:30 PM, Gregory Szorc wrote: we'd like to require the use of `mach try` for Try submissions. So just to be clear, instead of being able to "hg push -f try" will one now need to do "./mach try syntax ." and put in the actual syntax string on every single try push? The reason

Re: Intent to require `mach try` for submitting to Try

2017-09-15 Thread Gregory Szorc
On Fri, Sep 15, 2017 at 4:51 PM, Nicholas Nethercote wrote: > Are there docs on how to use `./mach try`? `./mach help try` doesn't give > much detail. > `mach try` has sub-commands. Run `mach help try syntax` and `mach help try fuzzy` for more useful docs. The former is

Re: Intent to require `mach try` for submitting to Try

2017-09-15 Thread Gregory Szorc
On Fri, Sep 15, 2017 at 4:48 PM, Nick Fitzgerald wrote: > Does `mach try` still require `git cinnabar` when using a `git` checkout > of m-c, or does it work with `moz-git-tools` now too? > It currently requires git-cinnabar. TBH, I forgot about this. Supporting

Re: Intent to require `mach try` for submitting to Try

2017-09-15 Thread Nicholas Nethercote
I should have been clearer: I'm not so worried about the syntax, so long as https://mozilla-releng.net/trychooser/ still exists. What's unclear to me is the revision management/selection side of things. Nick On Sat, Sep 16, 2017 at 9:57 AM, Kris Maglione wrote: > `mach

Re: Intent to require `mach try` for submitting to Try

2017-09-15 Thread Kris Maglione
`mach try` is basically just a wrapper around try syntax, with the added ability to specify paths to directories you want to add tests for. It suffers the same lack of documentation that try syntax in general does. Trychooser now generates `mach try` command lines in addition to commit

Re: Intent to require `mach try` for submitting to Try

2017-09-15 Thread Bobby Holley
FWIW, I've found |./mach try fuzzy| to be very intuitive and kind of the best of both worlds for command-line vs GUI. I don't know what the non-fuzzy version does, but perhaps fuzzy should be the default. On Fri, Sep 15, 2017 at 4:51 PM, Nicholas Nethercote wrote: > Are

Re: Intent to require `mach try` for submitting to Try

2017-09-15 Thread Nicholas Nethercote
Are there docs on how to use `./mach try`? `./mach help try` doesn't give much detail. Also, will https://mozilla-releng.net/trychooser/ still work? I'm generally more of a command line person than a GUI person, but this is one case where I find the GUI approach far more usable. Nick On Sat,

Re: Intent to require `mach try` for submitting to Try

2017-09-15 Thread Nick Fitzgerald
Does `mach try` still require `git cinnabar` when using a `git` checkout of m-c, or does it work with `moz-git-tools` now too? Thanks, Nick On Fri, Sep 15, 2017 at 3:30 PM, Gregory Szorc wrote: > The Try Service ("Try") is a mechanism that allows developers to schedule >

Re: Intent to require `mach try` for submitting to Try

2017-09-15 Thread Gregory Szorc
On Fri, Sep 15, 2017 at 3:39 PM, Botond Ballo wrote: > Will submitting to try from MozReview (or Phabricator once that > replaces MozReview) still work? I think there is important value in > being able to submit to try without a local checkout. > Yes. And I agree there is

Re: Intent to require `mach try` for submitting to Try

2017-09-15 Thread Botond Ballo
Will submitting to try from MozReview (or Phabricator once that replaces MozReview) still work? I think there is important value in being able to submit to try without a local checkout. Cheers, Botond ___ dev-platform mailing list

Intent to require `mach try` for submitting to Try

2017-09-15 Thread Gregory Szorc
The Try Service ("Try") is a mechanism that allows developers to schedule tasks in automation. The main API for that service is "Try Syntax" (e.g. "try: -b o -p linux -u xpcshell"). And the transport channel for making that API call is a Mercurial changeset's commit message plus a version control