Re: Coding style: Making the `e` prefix for enum variants not mandatory?

2018-06-29 Thread Jeff Gilbert
I don't believe e-prefix adds sufficient value. Mutable statics *must* always be s-prefixed. If this is not the case I will gladly bring the codebase into compliance. On Fri, Jun 29, 2018 at 11:36 AM, smaug wrote: > On 06/29/2018 05:58 PM, Boris Zbarsky wrote: >> >> On 6/29/18 10:30 AM, Nathan

Re: Coding style: Making the `e` prefix for enum variants not mandatory?

2018-06-29 Thread Jean-Yves Avenard
On 29/06/2018 16:58, Boris Zbarsky wrote: On 6/29/18 10:30 AM, Nathan Froyd wrote: Given the language-required qualification for `enum class` and a more Rust-alike syntax, I would feel comfortable with saying CamelCase `enum class` is the way to go. For what it's worth, I agree.  The point

Re: Coding style: Making the `e` prefix for enum variants not mandatory?

2018-06-29 Thread Boris Zbarsky
On 6/29/18 10:30 AM, Nathan Froyd wrote: Given the language-required qualification for `enum class` and a more Rust-alike syntax, I would feel comfortable with saying CamelCase `enum class` is the way to go. For what it's worth, I agree. The point of the "e" prefix is to highlight that you

Re: Coding style: Making the `e` prefix for enum variants not mandatory?

2018-06-29 Thread Nathan Froyd
On Thu, Jun 28, 2018 at 7:35 PM, Emilio Cobos Álvarez wrote: > Oh, I didn't realize that those peers were the only ones to be able to > update the style guide, sorry. I guess it makes sense. > > I can revert the change if needed and try to get sign-off from some of > those. > > Apologies again, I

Re: Rust crate approval

2018-06-29 Thread Tom Ritter
On Thu, Jun 28, 2018 at 11:42 PM, Nathan Froyd wrote: > We have generally trusted people to use good judgement in what they > use and how much review is required. Accordingly, I think you should > request review from the people who would normally review your code, > and if you have concerns