Re: Dropping support for compiling with MSVC in the near future

2018-12-07 Thread Honza Bambas
On 2018-12-07 04:23, Nathan Froyd wrote: On Thu, Dec 6, 2018 at 6:10 PM Gijs Kruitbosch wrote: Can someone elaborate on what this means for debugging on Windows, and for our onboarding story on Windows? At least in terms of stepping through, examining variables, etc., clang-cl is on par with

Re: Checking if an nsIURI came from a resource: URL

2018-12-07 Thread Henri Sivonen
On Fri, Dec 7, 2018 at 3:23 PM Daniel Veditz wrote: > > I'm afraid to ask why you want to treat these differently. I'd like to make out resource: URLs default to UTF-8 and skip (upcoming) detection between UTF-8 and the locale-affiliated legacy encoding. > Do you have a channel or a principal?

Checking if an nsIURI came from a resource: URL

2018-12-07 Thread Henri Sivonen
It appears that my the time resource: URLs reach the HTML parser, their scheme is reported as "file" (at least in debug builds). Is there a way to tell from an nsIURI that it was expanded from a resource: URL? -- Henri Sivonen hsivo...@mozilla.com ___

Re: Checking if an nsIURI came from a resource: URL

2018-12-07 Thread Daniel Veditz
I'm afraid to ask why you want to treat these differently. Do you have a channel or a principal? By itself nsIURI only describes the url itself, not its effective origin nor its redirect history. On Fri, Dec 7, 2018, 8:08 AM Henri Sivonen It appears that my the time resource: URLs reach the HTML

Re: Dropping support for compiling with MSVC in the near future

2018-12-07 Thread Simon Sapin
On 07/12/2018 00:08, Gijs Kruitbosch wrote: We're already making people install MSVS to get the relevant Windows SDKs (manually, not supported via ./mach bootstrap, and hopefully ticking the right boxes in the installer or they have to do it again until they do win at checkbox-golfing) We

Intent to Implement and Ship: break-before, break-after, break-inside CSS properties

2018-12-07 Thread Emilio Cobos Álvarez
Summary: Implement these properties to control breaks in the page, make page-break-{before,after} legacy shorthands of those. This work doesn't imply adding new layout functionality, just the style system rejiggering to make us comply with the spec and be compatible with other engines. Bug:

Re: Checking if an nsIURI came from a resource: URL

2018-12-07 Thread Henri Sivonen
On Fri, Dec 7, 2018 at 5:05 PM Dave Townsend wrote: > > This suggests that channel.originalURI should help: > https://searchfox.org/mozilla-central/source/netwerk/base/nsIChannel.idl#37 Indeed, getting both nsIURIs from the channel works. Thanks! -- Henri Sivonen hsivo...@mozilla.com

Re: Upcoming changes to our C++ Coding Style

2018-12-07 Thread Sylvestre Ledru
Le 05/12/2018 à 00:22, Botond Ballo a écrit : > Hi, I'd like to ask a couple of clarifications about process here: * Is clang-format invoked automatically as part of a pre-commit hook, or something like that? We have been working on that. There is a pending patch

Re: Checking if an nsIURI came from a resource: URL

2018-12-07 Thread Dave Townsend
This suggests that channel.originalURI should help: https://searchfox.org/mozilla-central/source/netwerk/base/nsIChannel.idl#37 On Fri, Dec 7, 2018 at 9:19 AM Henri Sivonen wrote: > On Fri, Dec 7, 2018 at 3:23 PM Daniel Veditz wrote: > > > > I'm afraid to ask why you want to treat these

Next Year in web-platform-tests - 2018/19 Edition

2018-12-07 Thread James Graham
Following the summary of what we've achieved in the previous year in web-platform-tests, I'd like to set out the plan for priorities in the coming year, and solicit feedback. There are several key things that we would like to achieve over the course of the year: * Give the platform team and

This year in web-platform-tests - 2018 edition

2018-12-07 Thread James Graham
Welcome to the second annual update on progress in cross-browser interop testing through web-platform-tests. This year has seen big improvements to the platform coverage of wpt, as well as increasing the number of features that can be tested with wpt, and the visibility of test results in

Re: Dropping support for compiling with MSVC in the near future

2018-12-07 Thread Ted Mielczarek
On Fri, Dec 7, 2018, at 8:37 AM, Simon Sapin wrote: > On 07/12/2018 00:08, Gijs Kruitbosch wrote: > > We're already making people install MSVS to get the relevant Windows > > SDKs (manually, not supported via ./mach bootstrap, and hopefully > > ticking the right boxes in the installer or they have

Re: Upcoming changes to our C++ Coding Style

2018-12-07 Thread Botond Ballo
On Fri, Dec 7, 2018 at 11:36 AM Sylvestre Ledru wrote: > In the meantime, we will be running a bot weekly to reformat the > mistakes and add the changeset into the ignore lists. > But in the long run this won’t be sustainable, so once we gain > confidence that a good number of developers have

Re: Dropping support for compiling with MSVC in the near future

2018-12-07 Thread Ted Mielczarek
On Thu, Dec 6, 2018, at 6:08 PM, Gijs Kruitbosch wrote: > Can someone elaborate on what this means for debugging on Windows, and > for our onboarding story on Windows? For debugging: as others have pointed out, nothing should change. For onboarding we will continue to require users to install

Re: Upcoming changes to our C++ Coding Style

2018-12-07 Thread Andrew Halberstadt
I think we should implement a) and do the formatting prior to submission. This prevents us from wasting reviewer time on format issues, and also makes sure that "what you see in phab, is what gets landed". On Fri, Dec 7, 2018, 2:04 PM Gregory Szorc, wrote: > On Fri, Dec 7, 2018 at 1:57 PM

Re: Dropping support for compiling with MSVC in the near future

2018-12-07 Thread Ted Mielczarek
On Thu, Dec 6, 2018, at 3:34 PM, Jonathan Kew wrote: > While I sympathize with the concern that "supporting more than one > compiler is a maintenance burden", this still leaves me feeling a little > uneasy. Ensuring that our code builds successfully with multiple > compilers is a useful way to

Re: Upcoming changes to our C++ Coding Style

2018-12-07 Thread Gregory Szorc
On Fri, Dec 7, 2018 at 1:57 PM Botond Ballo wrote: > On Fri, Dec 7, 2018 at 11:36 AM Sylvestre Ledru > wrote: > > In the meantime, we will be running a bot weekly to reformat the > > mistakes and add the changeset into the ignore lists. > > But in the long run this won’t be sustainable, so once

Re: Upcoming changes to our C++ Coding Style

2018-12-07 Thread Mike Hommey
On Fri, Dec 07, 2018 at 03:08:51PM -0500, Andrew Halberstadt wrote: > I think we should implement a) and do the formatting prior to submission. > This prevents us from wasting reviewer time on format issues, and also > makes sure that "what you see in phab, is what gets landed". Also, that would

Re: Dropping support for compiling with MSVC in the near future

2018-12-07 Thread Gabriele Svelto
On 06/12/18 15:39, Kris Maglione wrote: > As it stands, we need to remain compatible with at least GCC and Clang, > because some of our static analysis code still depends on GCC plugins. Some Linux distros will keep building Firefox with GCC so there's going to be at least some external users of