Re: PSA: Visual Studio 2017 15.6 now required to build 61+

2018-03-13 Thread Jeff Gilbert
Bumping to GCC6 has a tracking bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1444274 This would give us general c++14 capability. The only blocker I know of is updating Sixgill's (hazard analysis?) GCC version: https://bugzilla.mozilla.org/show_bug.cgi?id=1444543 If there are no other

Re: PSA: Visual Studio 2017 15.6 now required to build 61+

2018-03-13 Thread Jeff Gilbert
The patches have landed. Thanks! Are we ready to update this page?: https://developer.mozilla.org/en-US/docs/Mozilla/Using_CXX_in_Mozilla_code On Mon, Mar 12, 2018 at 5:29 PM, Ryan VanderMeulen wrote: > While I know I'm tempting fate by sending this out while the

Re: PSA: Core::Build Config has moved

2018-03-13 Thread Gregory Szorc
Bug 1406536 has the context. I should note that we now have shiny new components for aspects of the build workflow including bootstrapping, linting, static analysis, generated documentation, and CI task configuration. I encourage people to look at those components at

PSA: Core::Build Config has moved

2018-03-13 Thread Kartikaya Gupta
I was looking to file a bug in Core::Build Config and discovered it doesn't exist any more. :mccr8 told me there is now a "Firefox Build System" product that encompasses what used to be Core::Build Config. I'm not a build peer so I don't know anything more than this; if anybody wants more context

Re: Please try out clang-cl and lld-link on Windows

2018-03-13 Thread Bobby Holley
It's really exciting to see such rapid progress being made here. Thanks David! On Tue, Mar 13, 2018 at 7:31 AM, David Major wrote: > Link xul.dll in 20 seconds with this one weird trick! > > > Hi everyone, > > clang-cl builds of Firefox have come a long way, from being a

Re: Proposal to replace the NS_ASSERT function in JS with console.assert

2018-03-13 Thread Brian Grinstead
This has now landed in Bug 1431050 - remaining consumers were either migrated to console.assert or changed to throw an exception. You can continue to use console.assert instead of NS_ASSERT in JS. If you find a case where console logging from chrome code doesn't do what you expect please let me

Web-Feed subscription improvements

2018-03-13 Thread gdkags
Hello dear Firefox development community! As a fond user of the "subscribe to this page" button I sadly acknowledge to see the deprecation of navigator.registerContentHandler(). I'm not here to grouse about it, but rather inquire about any plans to have a user-friendly possibility for adding

Please try out clang-cl and lld-link on Windows

2018-03-13 Thread David Major
Link xul.dll in 20 seconds with this one weird trick! Hi everyone, clang-cl builds of Firefox have come a long way, from being a hobby project of a few developers to running static analysis in CI for more than a year now. The tools are in really good shape and should be ready for broader use

Re: FYI: sccache 0.2.6 released, contains fix for frequent hang in 0.2.5

2018-03-13 Thread Alex Gaynor
For macOS users this will hopefully be available from brew shortly: https://github.com/Homebrew/homebrew-core/pull/25164 Alex On Tue, Mar 13, 2018 at 9:21 AM, Ted Mielczarek wrote: > Hello, > > Yesterday I tagged and released sccache 0.2.6: >

Re: incremental compilation for opt Rust builds

2018-03-13 Thread Nathan Froyd
On Tue, Mar 13, 2018 at 3:10 AM, Henri Sivonen wrote: > On Tue, Mar 13, 2018 at 2:56 AM, Nathan Froyd wrote: >> (Our release builds use -O2 for Rust code.) > > What does cargo bench use by default? >

Re: incremental compilation for opt Rust builds

2018-03-13 Thread Alexis Beingessner
Oh and here's the one documented in the nightly docs, just for completeness # The benchmarking profile, used for `cargo bench` and `cargo test --release`.[profile.bench]opt-level = 3debug = falserpath = falselto = falsedebug-assertions = falsecodegen-units = 1panic = 'unwind'incremental =

Re: incremental compilation for opt Rust builds

2018-03-13 Thread Alexis Beingessner
The defaults of the various cargo profiles are documented here: https://doc.rust-lang.org/cargo/reference/manifest.html The relevant entry is: # The benchmarking profile, used for `cargo bench` and `cargo test --release`.[profile.bench]opt-level = 3debug = falserpath = falselto =

FYI: sccache 0.2.6 released, contains fix for frequent hang in 0.2.5

2018-03-13 Thread Ted Mielczarek
Hello, Yesterday I tagged and released sccache 0.2.6: https://github.com/mozilla/sccache/releases/tag/0.2.6 This contains a fix for a hang that users were encountering with sccache 0.2.5 due to the make jobserver support added in that version. If you are using 0.2.5 you will want to update. If

Re: PSA: Visual Studio 2017 15.6 now required to build 61+

2018-03-13 Thread Mike Hommey
On Tue, Mar 13, 2018 at 09:05:50AM +0200, Henri Sivonen wrote: > On Tue, Mar 13, 2018 at 2:29 AM, Ryan VanderMeulen > wrote: > > While I know I'm tempting fate by sending this out while the patches are > > still on autoland, I wanted to start giving people a heads-up

Re: incremental compilation for opt Rust builds

2018-03-13 Thread Henri Sivonen
On Tue, Mar 13, 2018 at 2:56 AM, Nathan Froyd wrote: > (Our release builds use -O2 for Rust code.) What does cargo bench use by default? (https://internals.rust-lang.org/t/default-opt-level-for-release-builds/4581 suggests -O3.) That is, is cargo bench for a crate that's

Re: PSA: Visual Studio 2017 15.6 now required to build 61+

2018-03-13 Thread Henri Sivonen
On Tue, Mar 13, 2018 at 2:29 AM, Ryan VanderMeulen wrote: > While I know I'm tempting fate by sending this out while the patches are > still on autoland, I wanted to start giving people a heads-up now that bug > 1424281 has been pushed, which will make Visual Studio