Re: Moving reviews to Phabricator

Just another reminder, On February 28 Bugzilla review flags will be disabled for Firefox and other mozilla-central products and components. From this point forward, all reviews of code changes to mozilla-central should be conducted in Phabricator. Please reach out in the #phabricator channel in i

Re: Moving reviews to Phabricator

For what it's worth, arcanist works fine for me in WSL, with a considerably less-horrifying installation process than on real Windows. With an alias you can call it from MozillaBuild as if it were native: alias arc="cmd //c ubuntu1804 run arc" On Wed, Feb 6, 2019 at 3:49 PM Jörg Knobloch wrote:

Re: Moving reviews to Phabricator

The NSS team still uplifts from https://hg.mozilla.org/projects/nss/ into m-c a few times per week (or as needed) using inbound .

Re: Moving reviews to Phabricator

On Fri, Feb 8, 2019 at 9:08 AM Andreas Tolfsen wrote: > Whilst I don’t have first hand experience, Phabricator has been > known to struggle with large patches, such as the result of upgrading > cargo dependencies under third_party/rust. Was a bug ever filed > on this? Bug 1492214 was filed for l

Re: Moving reviews to Phabricator

Also sprach Kim Moir: > Requiring Phabricator for code reviews will allow us to improve > code quality by running linters and static analysis tools automatically > on patches. It will also allow us to simplify and standardize our > engineering workflow by reducing the number of request queues tha

Re: Moving reviews to Phabricator

Thank you very much, really helpful information. On 2019/02/08 4:43, Kartikaya Gupta wrote: Ditto for git. Also note that when you click the "preview landing" button in Lando, the popup that shows the commits shows the author information on the patch, so you can use that to verify that the attri

Re: Moving reviews to Phabricator

Ditto for git. Also note that when you click the "preview landing" button in Lando, the popup that shows the commits shows the author information on the patch, so you can use that to verify that the attribution is correct. On Wed, Feb 6, 2019 at 8:10 PM Barret Rennie wrote: > > If you commit with

Re: Moving reviews to Phabricator

If you commit with `hg commit -u` and post it to Phabricator, it will show up as authored by you in Phabricator, but when it lands it will have the correct attribution (i.e., the user you specified with `-u`). - brennie On Wed, Feb 6, 2019 at 7:27 PM Masayuki Nakano wrote: > > I sometimes rewri

Re: Moving reviews to Phabricator

I sometimes rewrite patches from new contributor and commit them with `-u` and the contributors name and email address, and land the patches for them. E.g., https://bugzil.la/1513405 Is it possible to do that via Phabricator and Lando? If not, what should I do when I meet similar situation?

Re: Moving reviews to Phabricator

FWIW, I have exactly one machine with everything set up, and git-fetch/push and ssh into it in order to push up or pull down from moz-central. On Wed, Feb 6, 2019 at 12:49 PM Jörg Knobloch wrote: > > On 06/02/2019 21:42, Kim Moir wrote: > > On February 28 Bugzilla review flags will be disabled fo

Re: Moving reviews to Phabricator

On 06/02/2019 21:42, Kim Moir wrote: On February 28 Bugzilla review flags will be disabled for Firefox and other mozilla-central products and components. From this point forward, all reviews of code changes to mozilla-central should be conducted in Phabricator. Tasks that have been identified as

Moving reviews to Phabricator

On February 28 Bugzilla review flags will be disabled for Firefox and other mozilla-central products and components. From this point forward, all reviews of code changes to mozilla-central should be conducted in Phabricator. Tasks that have been identified as crucial to this transition have been se