[GitHub] activemq-artemis issue #780: ARTEMIS-735 Refactoring of JUnit Tests in artem...

Github user bennetelli commented on the issue: https://github.com/apache/activemq-artemis/pull/780 will take a look at this pr at thursday. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] activemq-artemis issue #855: Support outgoing AMQP connections

Github user lulf commented on the issue: https://github.com/apache/activemq-artemis/pull/855 @clebertsuconic In EnMasse(messaging-as-a-service), we use artemis for addresses that require store-and-forward semantics. Today, in order to have the broker connected to the router network,

[GitHub] activemq-artemis issue #548: Executor in JournalImpl for append operations

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/548 @barreiro I wil need a JIRA, can you raise one on Artemis --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] activemq-artemis issue #548: Executor in JournalImpl for append operations

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/548 @barreiro just a FYI: I'm working on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] activemq-artemis pull request #864: https://issues.apache.org/jira/browse/AR...

Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/864 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis issue #835: ARTEMIS-786 Store user's password in hash form ...

Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/835 @jbertram So I did some refactoring: * Now DefaultSensitiveStringCodec supports 2 kinds of masking one-way hashing and two-way encoding/decoding * one-way hashing is

[GitHub] activemq-artemis pull request #859: Upgrade Jolokia version

GitHub user paulgallagher75 opened a pull request: https://github.com/apache/activemq-artemis/pull/859 Upgrade Jolokia version You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulgallagher75/activemq-artemis

[GitHub] activemq-artemis issue #857: ARTEMIS-756 Introduced an example for CDI integ...

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/857 @johnament I feel pretty dumb now :/ on the confusion... I will take a look on the Closing exception. --- If your project is set up for it, you can reply to this email and

[GitHub] activemq-artemis pull request #859: Upgrade Jolokia version

Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/859 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis pull request #737: Added LargeStreamletTest file

Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/737 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis pull request #736: Remove thread.sleep in JDBCTest

Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/736 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis issue #855: Support outgoing AMQP connections

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/855 @lulf ok.. will merge it then --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] activemq-artemis pull request #860: ARTEMIS-817 and ARTEMIS-818 openwire fix...

GitHub user andytaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/860 ARTEMIS-817 and ARTEMIS-818 openwire fixes https://issues.apache.org/jira/browse/ARTEMIS-817 https://issues.apache.org/jira/browse/ARTEMIS-818 issues around Openwire

[GitHub] activemq-artemis issue #857: ARTEMIS-756 Introduced an example for CDI integ...

Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/857 I'm fine with moving the packages up since its just a client lib, not a true integration (as Clebert's described) --- If your project is set up for it, you can reply to this email and

[GitHub] activemq-artemis issue #857: ARTEMIS-756 Introduced an example for CDI integ...

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/857 @johnament I am thinking the CDI would be cool to be part of root, instead of integration. Same as the example, it would be moved under ./standard. --- If your project is

[GitHub] activemq-artemis issue #860: ARTEMIS-817 and ARTEMIS-818 openwire fixes

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/860 @andytaylor Can you add a bit more context to the commit? maybe a little / small description of what the issue was? otherwise I will have to open the JIRA when I'm (we)

[GitHub] activemq-artemis pull request #855: Support outgoing AMQP connections

Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/855 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: Many old open PRs

I don't really like the idea of empty commits laying around. It would be nice if infra could give us permission somehow to actually close these commits on github. On Mon, Oct 24, 2016 at 8:50 AM, Clebert Suconic wrote: > Yeah... that's what I meant by the "This

[GitHub] activemq-artemis issue #855: Support outgoing AMQP connections

Github user lulf commented on the issue: https://github.com/apache/activemq-artemis/pull/855 @clebertsuconic Added, thanks. I actually started out trying both the current 'integrated' approach and using vertx-proton. I decided to go down the current path based after initial

[GitHub] activemq-artemis issue #857: ARTEMIS-756 Introduced an example for CDI integ...

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/857 @johnament the example is using the same create plugin from maven. it will eventually replace broker.xml for the examples that need special configuration. Looking at

[GitHub] activemq-artemis issue #780: ARTEMIS-735 Refactoring of JUnit Tests in artem...

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/780 I fixed it myself with some git-fu while I merged it (amends and stuff) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] activemq-artemis pull request #780: ARTEMIS-735 Refactoring of JUnit Tests i...

Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/780 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis issue #780: ARTEMIS-735 Refactoring of JUnit Tests in artem...

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/780 I did this now since I'm about to make a release and wanted to finish most of what I could. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] activemq-artemis issue #861: ARTEMIS-756 Moving Client CDI as a main module

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/861 @johnament can you take a look... The only commit here is ARTEMIS-756 Moving Client CDI. The other two are already part of master, I'm not sure why github is showing 3

[GitHub] activemq-artemis pull request #857: ARTEMIS-756 Introduced an example for CD...

Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/857 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis pull request #861: ARTEMIS-756 Moving Client CDI as a main ...

GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/861 ARTEMIS-756 Moving Client CDI as a main module You can merge this pull request into a Git repository by running: $ git pull https://github.com/clebertsuconic/activemq-artemis

[GitHub] activemq-artemis pull request #862: Demonstrate my troubles when autocreatin...

Github user jdanekrh closed the pull request at: https://github.com/apache/activemq-artemis/pull/862 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis issue #862: Demonstrate my troubles when autocreating jms.t...

Github user jdanekrh commented on the issue: https://github.com/apache/activemq-artemis/pull/862 Sorry, I did not intend to raise this as PR here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] activemq-artemis pull request #862: Demonstrate my troubles when autocreatin...

GitHub user jdanekrh opened a pull request: https://github.com/apache/activemq-artemis/pull/862 Demonstrate my troubles when autocreating jms.topic and a producer You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis pull request #861: ARTEMIS-756 Moving Client CDI as a main ...

Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/861#discussion_r84736447 --- Diff: artemis-rest/src/main/java/org/apache/activemq/artemis/rest/Jms.java --- @@ -0,0 +1,174 @@ +/* + * Licensed to the Apache

[GitHub] activemq-artemis issue #861: ARTEMIS-756 Moving Client CDI as a main module

Github user johnament commented on the issue: https://github.com/apache/activemq-artemis/pull/861 I'm fine with the CDI stuff going in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] activemq-artemis pull request #863: Demonstrate my troubles when autocreatin...

Github user jdanekrh closed the pull request at: https://github.com/apache/activemq-artemis/pull/863 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] activemq-artemis pull request #863: Demonstrate my troubles when autocreatin...

GitHub user jdanekrh opened a pull request: https://github.com/apache/activemq-artemis/pull/863 Demonstrate my troubles when autocreating jms.topic and a producer You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis pull request #861: ARTEMIS-756 Moving Client CDI as a main ...

Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/861#discussion_r84735762 --- Diff: artemis-rest/src/test/java/org/apache/activemq/artemis/rest/test/JMSTest.java --- @@ -0,0 +1,270 @@ +/* + * Licensed to the

[GitHub] activemq-artemis pull request #861: ARTEMIS-756 Moving Client CDI as a main ...

Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/861#discussion_r84735622 --- Diff: artemis-rest/src/main/java/org/apache/activemq/artemis/rest/integration/EmbeddedRestActiveMQ.java --- @@ -41,7 +41,7 @@ protected void

[GitHub] activemq-artemis pull request #861: ARTEMIS-756 Moving Client CDI as a main ...

Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/861#discussion_r84735689 --- Diff: artemis-rest/src/test/java/org/apache/activemq/artemis/rest/test/Embedded.java --- @@ -0,0 +1,91 @@ +/* + * Licensed to the

[GitHub] activemq-artemis pull request #861: ARTEMIS-756 Moving Client CDI as a main ...

Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/861#discussion_r84735729 --- Diff: artemis-rest/src/test/java/org/apache/activemq/artemis/rest/test/EmbeddedTest.java --- @@ -0,0 +1,161 @@ +/* + * Licensed to

[GitHub] activemq-artemis pull request #861: ARTEMIS-756 Moving Client CDI as a main ...

Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/861#discussion_r84735576 --- Diff: artemis-rest/src/main/java/org/apache/activemq/artemis/rest/Jms.java --- @@ -0,0 +1,174 @@ +/* + * Licensed to the Apache

[GitHub] activemq-artemis pull request #861: ARTEMIS-756 Moving Client CDI as a main ...

Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/861#discussion_r84735641 --- Diff: artemis-rest/src/main/java/org/apache/activemq/artemis/rest/integration/EmbeddedRestActiveMQJMS.java --- @@ -20,9 +20,9 @@ import

[GitHub] activemq-artemis pull request #864: https://issues.apache.org/jira/browse/AR...

Github user cshannon commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/864#discussion_r84760382 --- Diff: pom.xml --- @@ -128,8 +128,8 @@ UTF-8 UTF-8 - 1.7 - 1.7 + 1.8 --- End diff --

[GitHub] activemq-artemis pull request #864: https://issues.apache.org/jira/browse/AR...

Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/864#discussion_r84759299 --- Diff: pom.xml --- @@ -128,8 +128,8 @@ UTF-8 UTF-8 - 1.7 - 1.7 + 1.8 --- End diff

[GitHub] activemq-artemis pull request #864: https://issues.apache.org/jira/browse/AR...

GitHub user cshannon opened a pull request: https://github.com/apache/activemq-artemis/pull/864 https://issues.apache.org/jira/browse/ARTEMIS-819 Increasing the minimum required version of Java to Java 8 You can merge this pull request into a Git repository by running: $ git

Re: [DISCUSS] Require Java 8 for 5.15 and Artemis

Based on the feedback so far I went ahead and bumped 5.x to version 8 and I opened up a PR for Artemis to do the same. On Thu, Oct 20, 2016 at 9:26 AM, Christopher Shannon < christopher.l.shan...@gmail.com> wrote: > I would be ok bumping the major version for Artemis but I don't think I'd > want

Re: Many old open PRs

On Mon, Oct 24, 2016 at 10:39 AM, Christopher Shannon wrote: > I don't really like the idea of empty commits laying around. It would be > nice if infra could give us permission somehow to actually close these > commits on github. +1 although I can see why Infra

Re: Many old open PRs

You can also push up the commits to a separate branch, which closes the PR, then delete that branch (note you have to eventually push a real commit on top so there will be a short delay until someone commits to git in a non-delete fashion). John On Mon, Oct 24, 2016 at 4:25 PM Clebert Suconic

Re: Many old open PRs

I thought about that, create a fake branch for fake commits... I just didn't like it, that's why i didn't suggest it. On Artemis we usually get a good response on PRs... there was just one exception that the guy never came back and I used the empty commit here:

Re: Many old open PRs

Yeah... that's what I meant by the "This closes #..." but if you are rejecting a PR, you will need the empty commit living in a branch. If we are ok with that, we can just add the empty commit. On Mon, Oct 24, 2016 at 12:45 AM, Jean-Baptiste Onofré wrote: > You can also

[GitHub] activemq-artemis issue #855: Support outgoing AMQP connections

Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/855 @lulf ok, I would merge it with this commit also: https://github.com/clebertsuconic/activemq-artemis/commit/efc6e2dccf8ba8ae3e3909ba26ff8c4122bb8d0e Did you

[GitHub] activemq-artemis pull request #864: https://issues.apache.org/jira/browse/AR...

Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/864#discussion_r84773789 --- Diff: pom.xml --- @@ -128,8 +128,8 @@ UTF-8 UTF-8 - 1.7 - 1.7 + 1.8 --- End

[GitHub] activemq-artemis pull request #861: ARTEMIS-756 Moving Client CDI as a main ...

Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/861 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: Many old open PRs

On Mon, Oct 24, 2016 at 4:33 PM Clebert Suconic wrote: > I thought about that, create a fake branch for fake commits... > > I just didn't like it, that's why i didn't suggest it. > Curious as to why. The permanent record's in the email threads. And yes, I suspect

Re: Many old open PRs

On Mon, Oct 24, 2016 at 4:55 PM, John D. Ament wrote: > On Mon, Oct 24, 2016 at 4:33 PM Clebert Suconic > wrote: > >> I thought about that, create a fake branch for fake commits... >> >> I just didn't like it, that's why i didn't suggest it. > >

Re: Many old open PRs

On Mon, Oct 24, 2016 at 4:28 PM, John D. Ament wrote: > You can also push up the commits to a separate branch, which closes the PR, > then delete that branch (note you have to eventually push a real commit on > top so there will be a short delay until someone commits to git