[GitHub] activemq-artemis pull request #2005: ARTEMIS-1797 Auto-create-address flag s...

2018-04-10 Thread gaohoward
GitHub user gaohoward opened a pull request: https://github.com/apache/activemq-artemis/pull/2005 ARTEMIS-1797 Auto-create-address flag shouldn't block temp destination creation When creating a temp destination and auto-create-address set to false, the broker throws an

[GitHub] activemq-artemis pull request #2006: ARTEMIS-1798 DEBUG message bad write me...

2018-04-10 Thread stanlyDoge
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/2006 ARTEMIS-1798 DEBUG message bad write method arg count - fix When the logging level was set up to DEBUG, FluentPropertyBeanIntrospectorWithIgnores threw an exception at org.apache.acti

[GitHub] activemq-artemis pull request #1999: ARTEMIS-1790 Improve Topology Member Fi...

2018-04-10 Thread stanlyDoge
Github user stanlyDoge commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1999#discussion_r180413588 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnection.java --- @@ -511,6 +511,45 @@

[GitHub] activemq-artemis pull request #2007: ARTEMIS-1799 - Add a NotificationActive...

2018-04-10 Thread cshannon
GitHub user cshannon opened a pull request: https://github.com/apache/activemq-artemis/pull/2007 ARTEMIS-1799 - Add a NotificationActiveMQServerPlugin Adds a new plugin that will support sending new types of notifications for broker events which will allow enhanced broker monitor

[GitHub] activemq-artemis pull request #2007: ARTEMIS-1799 - Add a NotificationActive...

2018-04-10 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2007#discussion_r180448672 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/CoreNotificationType.java --- @@ -39,7 +39,15

[GitHub] activemq-artemis pull request #2007: ARTEMIS-1799 - Add a NotificationActive...

2018-04-10 Thread cshannon
Github user cshannon commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2007#discussion_r180449915 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/CoreNotificationType.java --- @@ -39,7 +39,15 @@

[GitHub] activemq-artemis pull request #2007: ARTEMIS-1799 - Add a NotificationActive...

2018-04-10 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2007#discussion_r180457921 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/CoreNotificationType.java --- @@ -39,7 +39,15

[GitHub] activemq-artemis pull request #2007: ARTEMIS-1799 - Add a NotificationActive...

2018-04-10 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2007#discussion_r180458900 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/CoreNotificationType.java --- @@ -39,7 +39,15

[GitHub] activemq-artemis pull request #2006: ARTEMIS-1798 DEBUG message bad write me...

2018-04-10 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2006#discussion_r180460101 --- Diff: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireProtocolManager.

[GitHub] activemq-artemis issue #2007: ARTEMIS-1799 - Add a NotificationActiveMQServe...

2018-04-10 Thread cshannon
Github user cshannon commented on the issue: https://github.com/apache/activemq-artemis/pull/2007 I don't understand the confusion. That call just calls off to any registered plugins if they exist. This commit is a brand new plugin that implements the afterDeliver call and fires off

Re: Board report for April 2018

2018-04-10 Thread Bruce Snyder
Hi Michael, I have granted you r/w permissions to the wiki, so you should be able to edit the page now. Bruce On Mon, Apr 9, 2018 at 1:45 PM, Michael André Pearce < michael.andre.pea...@me.com> wrote: > Hi Bruce, > > It seems same issue as last time, i don’t have rights to edit directly. > > Ca

Re: Board report for April 2018

2018-04-10 Thread Bruce Snyder
I am getting rather desperate to have someone describe the project activity for ActiveMQ, Artemis as well as NMS, CMS, etc. if you work on the project, can you please contribute to the April board report via the wiki? https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=75977784 Your

[GitHub] activemq-artemis issue #2006: ARTEMIS-1798 DEBUG message bad write method ar...

2018-04-10 Thread stanlyDoge
Github user stanlyDoge commented on the issue: https://github.com/apache/activemq-artemis/pull/2006 @clebertsuconic Renamed. ---

[GitHub] activemq-artemis issue #2007: ARTEMIS-1799 - Add a NotificationActiveMQServe...

2018-04-10 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2007 @cshannon I see. .thanks for the clarification. merging it. ---

[GitHub] activemq-artemis pull request #2007: ARTEMIS-1799 - Add a NotificationActive...

2018-04-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2007 ---

[GitHub] activemq-artemis issue #2006: ARTEMIS-1798 DEBUG message bad write method ar...

2018-04-10 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2006 nice one.. thanks.. will wait the check and merge it ---

Re: Board report for April 2018

2018-04-10 Thread Justin Bertram
I added the Artemis 2.5.0 release including some highlighted features from that release. I hope the level-of-detail was appropriate. Please adjust if necessary. Thanks! Justin On Tue, Apr 10, 2018 at 10:22 AM, Bruce Snyder wrote: > I am getting rather desperate to have someone describe the pro

[GitHub] activemq-artemis issue #2007: ARTEMIS-1799 - Add a NotificationActiveMQServe...

2018-04-10 Thread cshannon
Github user cshannon commented on the issue: https://github.com/apache/activemq-artemis/pull/2007 @clebertsuconic - thanks for merging ---

[GitHub] activemq-artemis pull request #2006: ARTEMIS-1798 DEBUG message bad write me...

2018-04-10 Thread jdanekrh
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2006#discussion_r180483597 --- Diff: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireProtocolManager.java

[GitHub] activemq-artemis issue #2005: ARTEMIS-1797 Auto-create-address flag shouldn'...

2018-04-10 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2005 @gaohoward by block did you mean avoid? When you say block I was expecting a client blocking or not completing. ---

[GitHub] activemq-artemis pull request #2006: ARTEMIS-1798 DEBUG message bad write me...

2018-04-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2006 ---

[GitHub] activemq-artemis pull request #1999: ARTEMIS-1790 Improve Topology Member Fi...

2018-04-10 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1999#discussion_r180507233 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnection.java --- @@ -511,6 +511,4

[GitHub] activemq-artemis issue #1999: ARTEMIS-1790 Improve Topology Member Finding

2018-04-10 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1999 only issue I see is.. if this is broken.. then Topology::getMember(TransportConfiguration) is probably broken as well? That's used on freezeConnections and ScaleDownHandler

[GitHub] activemq-artemis issue #2005: ARTEMIS-1797 Auto-create-address flag shouldn'...

2018-04-10 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2005 I will merge it .. but I will rename the commit message. ---

[GitHub] activemq-artemis pull request #2005: ARTEMIS-1797 Auto-create-address flag s...

2018-04-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2005 ---

[GitHub] activemq pull request #281: AMQ-6930 Expose an environment variable to allow...

2018-04-10 Thread alvinlin123
GitHub user alvinlin123 opened a pull request: https://github.com/apache/activemq/pull/281 AMQ-6930 Expose an environment variable to allow redirect stdout/stderr to a file This change does not modify the default behavior, the default behavior is still to pipe stdout/stderr to /dev

[GitHub] activemq-artemis pull request #2008: ARTEMIS-1800 - fix duplicate metrics up...

2018-04-10 Thread cshannon
GitHub user cshannon opened a pull request: https://github.com/apache/activemq-artemis/pull/2008 ARTEMIS-1800 - fix duplicate metrics update on scheduled message cancel When removing scheduled messages from a queue the scheduled message metrics were being decremented twice You c

[GitHub] activemq-artemis pull request #2008: ARTEMIS-1800 - fix duplicate metrics up...

2018-04-10 Thread cshannon
Github user cshannon closed the pull request at: https://github.com/apache/activemq-artemis/pull/2008 ---

Re: Board report for April 2018

2018-04-10 Thread Bruce Snyder
Thank you, Justin! Bruce On Tue, Apr 10, 2018 at 10:06 AM, Justin Bertram wrote: > I added the Artemis 2.5.0 release including some highlighted features from > that release. I hope the level-of-detail was appropriate. Please adjust if > necessary. Thanks! > > > Justin > > On Tue, Apr 10, 2018 a

[GitHub] activemq pull request #281: AMQ-6930 Expose an environment variable to allow...

2018-04-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq/pull/281 ---

[GitHub] activemq-artemis pull request #2009: ARTEMIS-1800 - Fix metrics decrement on...

2018-04-10 Thread cshannon
GitHub user cshannon opened a pull request: https://github.com/apache/activemq-artemis/pull/2009 ARTEMIS-1800 - Fix metrics decrement on scheduled message cancel The queue metrics were being decremented improperly because on iteration over the cancelled scheduled messages because

[GitHub] activemq-artemis pull request #1999: ARTEMIS-1790 Improve Topology Member Fi...

2018-04-10 Thread gaohoward
Github user gaohoward commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1999#discussion_r180614044 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnection.java --- @@ -511,6 +511,45 @@

[GitHub] activemq-artemis issue #1999: ARTEMIS-1790 Improve Topology Member Finding

2018-04-10 Thread gaohoward
Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1999 ok I'll take care of them. ---

[GitHub] activemq-artemis issue #1999: ARTEMIS-1790 Improve Topology Member Finding

2018-04-10 Thread gaohoward
Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1999 @clebertsuconic @stanlyDoge done. ---

[GitHub] activemq-artemis pull request #2010: ARTEMIS-1801 removing null-unchecked de...

2018-04-10 Thread stanlyDoge
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/2010 ARTEMIS-1801 removing null-unchecked dereferences There were some cases where value was checked for null and later directly dereferenced without check. I added checks. I am not sure ab

[GitHub] activemq-artemis pull request #2010: ARTEMIS-1801 removing null-unchecked de...

2018-04-10 Thread stanlyDoge
Github user stanlyDoge commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2010#discussion_r180649567 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java --- @@ -2769,7 +2769,7 @@ public Q