[GitHub] michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r250776531 ## File path:

[GitHub] clebertsuconic commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
clebertsuconic commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r250776567 ## File path:

[GitHub] clebertsuconic commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
clebertsuconic commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r250776970 ## File path:

[GitHub] ehsavoie commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.

2019-01-24 Thread GitBox
ehsavoie commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r250783079 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r250812517 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r250812517 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2516: ARTEMIS-2192 fix listener for LegacyLDAPSecuritySettingPlugin

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2516: ARTEMIS-2192 fix listener for LegacyLDAPSecuritySettingPlugin URL: https://github.com/apache/activemq-artemis/pull/2516#discussion_r250764887 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r250779232 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r250779232 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r250825292 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r250809081 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r250809792 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r250810104 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r250814957 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r250814957 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r250814957 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r250814957 ## File path:

[GitHub] asfgit closed pull request #2519: ARTEMIS-2238 Fixing QueueQuery on every single send on topics

2019-01-24 Thread GitBox
asfgit closed pull request #2519: ARTEMIS-2238 Fixing QueueQuery on every single send on topics URL: https://github.com/apache/activemq-artemis/pull/2519 This is an automated message from the Apache Git Service. To respond

[GitHub] clebertsuconic commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
clebertsuconic commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r250777278 ## File path:

[GitHub] clebertsuconic commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
clebertsuconic commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r250808877 ## File path:

[GitHub] clebertsuconic commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
clebertsuconic commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r250808742 ## File path:

[GitHub] asfgit merged pull request #17: AMQCPP-643: Add an option to time out connection attempts when blocked in ensureConnectionInfoSent

2019-01-24 Thread GitBox
asfgit merged pull request #17: AMQCPP-643: Add an option to time out connection attempts when blocked in ensureConnectionInfoSent URL: https://github.com/apache/activemq-cpp/pull/17 This is an automated message from the

[GitHub] michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r250761629 ## File path:

[GitHub] michaelandrepearce commented on issue #2519: ARTEMIS-2238 Fixing QueueQuery on every single send on topics

2019-01-24 Thread GitBox
michaelandrepearce commented on issue #2519: ARTEMIS-2238 Fixing QueueQuery on every single send on topics URL: https://github.com/apache/activemq-artemis/pull/2519#issuecomment-457346877 Have left some comments This is an

[GitHub] michaelandrepearce commented on a change in pull request #2519: ARTEMIS-2238 Fixing QueueQuery on every single send on topics

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2519: ARTEMIS-2238 Fixing QueueQuery on every single send on topics URL: https://github.com/apache/activemq-artemis/pull/2519#discussion_r250767135 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r250776531 ## File path:

[GitHub] clebertsuconic commented on a change in pull request #2518: NO-JIRA fix race condition in QueueQueryTest

2019-01-24 Thread GitBox
clebertsuconic commented on a change in pull request #2518: NO-JIRA fix race condition in QueueQueryTest URL: https://github.com/apache/activemq-artemis/pull/2518#discussion_r250747119 ## File path:

[GitHub] clebertsuconic commented on a change in pull request #2518: NO-JIRA fix race condition in QueueQueryTest

2019-01-24 Thread GitBox
clebertsuconic commented on a change in pull request #2518: NO-JIRA fix race condition in QueueQueryTest URL: https://github.com/apache/activemq-artemis/pull/2518#discussion_r250747842 ## File path:

[GitHub] clebertsuconic opened a new pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
clebertsuconic opened a new pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520 This is an automated message from the Apache Git Service. To

[GitHub] michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r250814254 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r250814254 ## File path:

[GitHub] michaelandrepearce opened a new pull request #2521: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
michaelandrepearce opened a new pull request #2521: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2521 This is an automated message from the Apache Git Service. To

[GitHub] asfgit closed pull request #2516: ARTEMIS-2192 fix listener for LegacyLDAPSecuritySettingPlugin

2019-01-24 Thread GitBox
asfgit closed pull request #2516: ARTEMIS-2192 fix listener for LegacyLDAPSecuritySettingPlugin URL: https://github.com/apache/activemq-artemis/pull/2516 This is an automated message from the Apache Git Service. To respond

[GitHub] ehsavoie commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.

2019-01-24 Thread GitBox
ehsavoie commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r250782433 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r250805377 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r250814254 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r250816406 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r250761629 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r250761629 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r250775737 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r250775737 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r250780506 ## File path:

[GitHub] michaelandrepearce commented on issue #2521: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
michaelandrepearce commented on issue #2521: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2521#issuecomment-457402626 @clebertsuconic little less of a complete refactor, but addresses the issues. thought id offer it up as an

[GitHub] jbertram commented on a change in pull request #2518: NO-JIRA fix race condition in QueueQueryTest

2019-01-24 Thread GitBox
jbertram commented on a change in pull request #2518: NO-JIRA fix race condition in QueueQueryTest URL: https://github.com/apache/activemq-artemis/pull/2518#discussion_r250754348 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r250779232 ## File path:

[GitHub] clebertsuconic commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
clebertsuconic commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r250800199 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r250809792 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r250812700 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r250815971 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r250814254 ## File path:

[GitHub] clebertsuconic commented on a change in pull request #2521: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
clebertsuconic commented on a change in pull request #2521: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2521#discussion_r250829575 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2521: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2521: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2521#discussion_r250828872 ## File path:

[GitHub] michaelandrepearce closed pull request #2521: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
michaelandrepearce closed pull request #2521: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2521 This is an automated message from the Apache Git Service. To respond

[GitHub] michaelandrepearce commented on a change in pull request #2521: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2521: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2521#discussion_r250828204 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r250825292 ## File path:

[GitHub] clebertsuconic commented on a change in pull request #2521: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
clebertsuconic commented on a change in pull request #2521: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2521#discussion_r250826843 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r250825292 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r250825292 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r250825292 ## File path:

[GitHub] clebertsuconic commented on a change in pull request #2521: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
clebertsuconic commented on a change in pull request #2521: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2521#discussion_r250827739 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2521: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2521: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2521#discussion_r250828872 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2521: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2521: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2521#discussion_r250828872 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2521: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2521: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2521#discussion_r250828872 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2521: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2521: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2521#discussion_r250828872 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r250825292 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2521: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2521: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2521#discussion_r250828872 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2521: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2521: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2521#discussion_r250835700 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2521: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2521: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2521#discussion_r250835700 ## File path:

[GitHub] michaelandrepearce commented on issue #2520: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
michaelandrepearce commented on issue #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#issuecomment-457422187 sent a pr to your branch to address my comments on this, and also unify logic with ActiveMQSession

[GitHub] michaelandrepearce commented on a change in pull request #2521: ARTEMIS-2238 Enhancement to queueQuery on producer

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2521: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2521#discussion_r250828872 ## File path:

[GitHub] asfgit closed pull request #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods

2019-01-24 Thread GitBox
asfgit closed pull request #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods URL: https://github.com/apache/activemq-artemis/pull/2427 This is an automated message from the

[GitHub] michaelandrepearce commented on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods

2019-01-24 Thread GitBox
michaelandrepearce commented on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods URL: https://github.com/apache/activemq-artemis/pull/2427#issuecomment-457110595 @franz1981 merge, this is really great stuff.

[GitHub] michaelandrepearce edited a comment on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods

2019-01-24 Thread GitBox
michaelandrepearce edited a comment on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods URL: https://github.com/apache/activemq-artemis/pull/2427#issuecomment-457110595 @franz1981 merged, this is really great stuff. thanks!

[GitHub] michaelandrepearce commented on a change in pull request #2287: ARTEMIS-2069 Backup doesn't activate after shared store is reconnected

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2287: ARTEMIS-2069 Backup doesn't activate after shared store is reconnected URL: https://github.com/apache/activemq-artemis/pull/2287#discussion_r250604071 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2287: ARTEMIS-2069 Backup doesn't activate after shared store is reconnected

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2287: ARTEMIS-2069 Backup doesn't activate after shared store is reconnected URL: https://github.com/apache/activemq-artemis/pull/2287#discussion_r250605719 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2287: ARTEMIS-2069 Backup doesn't activate after shared store is reconnected

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2287: ARTEMIS-2069 Backup doesn't activate after shared store is reconnected URL: https://github.com/apache/activemq-artemis/pull/2287#discussion_r250605719 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2287: ARTEMIS-2069 Backup doesn't activate after shared store is reconnected

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2287: ARTEMIS-2069 Backup doesn't activate after shared store is reconnected URL: https://github.com/apache/activemq-artemis/pull/2287#discussion_r250605929 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r250700525 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r250702023 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r250701848 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r250701848 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2516: ARTEMIS-2192 fix listener for LegacyLDAPSecuritySettingPlugin

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2516: ARTEMIS-2192 fix listener for LegacyLDAPSecuritySettingPlugin URL: https://github.com/apache/activemq-artemis/pull/2516#discussion_r250706777 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2516: ARTEMIS-2192 fix listener for LegacyLDAPSecuritySettingPlugin

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2516: ARTEMIS-2192 fix listener for LegacyLDAPSecuritySettingPlugin URL: https://github.com/apache/activemq-artemis/pull/2516#discussion_r250707350 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2516: ARTEMIS-2192 fix listener for LegacyLDAPSecuritySettingPlugin

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2516: ARTEMIS-2192 fix listener for LegacyLDAPSecuritySettingPlugin URL: https://github.com/apache/activemq-artemis/pull/2516#discussion_r250706777 ## File path:

[GitHub] michaelandrepearce commented on issue #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.

2019-01-24 Thread GitBox
michaelandrepearce commented on issue #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517#issuecomment-457289566 This **really** needs a test case, to a) validate the fix, and b) ensure no

[GitHub] michaelandrepearce removed a comment on issue #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.

2019-01-24 Thread GitBox
michaelandrepearce removed a comment on issue #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517#issuecomment-457289566 This **really** needs a test case, to a) validate the fix, and b) ensure

[GitHub] michaelandrepearce commented on issue #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.

2019-01-24 Thread GitBox
michaelandrepearce commented on issue #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517#issuecomment-457290572 This really needs a test case A) validate the fix (and validate any

[GitHub] jbertram commented on a change in pull request #2516: ARTEMIS-2192 fix listener for LegacyLDAPSecuritySettingPlugin

2019-01-24 Thread GitBox
jbertram commented on a change in pull request #2516: ARTEMIS-2192 fix listener for LegacyLDAPSecuritySettingPlugin URL: https://github.com/apache/activemq-artemis/pull/2516#discussion_r250717165 ## File path:

[GitHub] jbertram opened a new pull request #2516: ARTEMIS-2192 fix listener for LegacyLDAPSecuritySettingPlugin

2019-01-24 Thread GitBox
jbertram opened a new pull request #2516: ARTEMIS-2192 fix listener for LegacyLDAPSecuritySettingPlugin URL: https://github.com/apache/activemq-artemis/pull/2516 This is an automated message from the Apache Git Service. To

[GitHub] ehsavoie opened a new pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.

2019-01-24 Thread GitBox
ehsavoie opened a new pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517 * Ensuring that all threadPoolFactories are created under a privileged block so the threads created are

[GitHub] michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r250700525 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.

2019-01-24 Thread GitBox
michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r250701848 ## File path:

[GitHub] jbertram opened a new pull request #2518: NO-JIRA fix race condition in QueueQueryTest

2019-01-24 Thread GitBox
jbertram opened a new pull request #2518: NO-JIRA fix race condition in QueueQueryTest URL: https://github.com/apache/activemq-artemis/pull/2518 This is an automated message from the Apache Git Service. To respond to the

[GitHub] clebertsuconic opened a new pull request #2519: ARTEMIS-2238 Fixing QueueQuery on every single send on topics

2019-01-24 Thread GitBox
clebertsuconic opened a new pull request #2519: ARTEMIS-2238 Fixing QueueQuery on every single send on topics URL: https://github.com/apache/activemq-artemis/pull/2519 This is an automated message from the Apache Git

[GitHub] clebertsuconic commented on a change in pull request #2518: NO-JIRA fix race condition in QueueQueryTest

2019-01-24 Thread GitBox
clebertsuconic commented on a change in pull request #2518: NO-JIRA fix race condition in QueueQueryTest URL: https://github.com/apache/activemq-artemis/pull/2518#discussion_r250731204 ## File path:

[GitHub] clebertsuconic commented on a change in pull request #2518: NO-JIRA fix race condition in QueueQueryTest

2019-01-24 Thread GitBox
clebertsuconic commented on a change in pull request #2518: NO-JIRA fix race condition in QueueQueryTest URL: https://github.com/apache/activemq-artemis/pull/2518#discussion_r250731249 ## File path:

[GitHub] clebertsuconic commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.

2019-01-24 Thread GitBox
clebertsuconic commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r250732153 ## File path:

[GitHub] jbertram commented on a change in pull request #2518: NO-JIRA fix race condition in QueueQueryTest

2019-01-24 Thread GitBox
jbertram commented on a change in pull request #2518: NO-JIRA fix race condition in QueueQueryTest URL: https://github.com/apache/activemq-artemis/pull/2518#discussion_r250733623 ## File path:

[GitHub] jbertram commented on a change in pull request #2518: NO-JIRA fix race condition in QueueQueryTest

2019-01-24 Thread GitBox
jbertram commented on a change in pull request #2518: NO-JIRA fix race condition in QueueQueryTest URL: https://github.com/apache/activemq-artemis/pull/2518#discussion_r250736801 ## File path: