[GitHub] ant pull request #69: Allow more control over JUnit libraries and Ant runtim...

2018-10-11 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant/pull/69 Allow more control over JUnit libraries and Ant runtime libraries for users of junitlauncher I've been sitting on these changes for a while now trying to complete this work and then get some i

[GitHub] ant issue #69: Allow more control over JUnit libraries and Ant runtime libra...

2018-10-11 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/69 The build.xml changes that I committed look a bit wrong. Fixing them to a working version. --- - To unsubscribe, e-mail: dev

[GitHub] ant issue #69: Allow more control over JUnit libraries and Ant runtime libra...

2018-10-11 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/69 The build actually caught a genuine issue that this build.xml was meant to catch. I have now added a 3rd commit to this PR which fixes that issue. I'll be squashing these commits before mergin

[GitHub] ant issue #69: Allow more control over location of JUnit libraries for users...

2018-10-23 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/69 I'll merge this one tomorrow if there aren't any objections. However, even after this being merged, I'm open for any suggestions/review ab

[GitHub] ant issue #69: Allow more control over location of JUnit libraries for users...

2018-10-29 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/69 Thanks Stefan. I'll go ahead and merge this today and include a note in WHATSNEW. --- - To unsubscribe, e-mail: dev-uns

[GitHub] ant pull request #69: Allow more control over location of JUnit libraries fo...

2018-10-29 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant/pull/69 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant pull request #76: bz-43144 - Improve the performance of the tar task whe...

2018-10-31 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant/pull/76 bz-43144 - Improve the performance of the tar task when it uses a zipfileset https://bz.apache.org/bugzilla/show_bug.cgi?id=43144 is an issue where users have reported that the tar task is extremely

[GitHub] ant pull request #:

2018-11-01 Thread jaikiran
Github user jaikiran commented on the pull request: https://github.com/apache/ant/commit/0cb9d22b77dda1dcabba91d4c2a1616d0042d16c#commitcomment-31143975 In src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/StandaloneLauncher.java: In src/main/org/apache/tools/ant

[GitHub] ant pull request #76: bz-43144 - Improve the performance of the tar task whe...

2018-11-01 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant/pull/76 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant issue #76: bz-43144 - Improve the performance of the tar task when it us...

2018-11-01 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/76 I'm going to put this on hold for a bit and won't merge it yet, for the reasons noted in the recent comments in the li

[GitHub] ant issue #76: bz-43144 - Improve the performance of the tar task when it us...

2018-11-06 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/76 >> Looks as if you had found a solution with minimal API impact that can be extended to cases other than just tar although I'm afraid we are using resource collections wrapping resource col

[GitHub] ant issue #80: Added tasks for JDK's jmod and jlink tools.

2018-12-06 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/80 this is ok to test --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h

[GitHub] ant issue #81: Fix rare ConcurrentModificationException when running with Pa...

2018-12-11 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/81 this is ok to test --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h

[GitHub] ant issue #81: Fix rare ConcurrentModificationException when running with Pa...

2018-12-11 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/81 I don't have enough knowledge about the thread safety aspects of the `Project` class. Stefan (@bodewig) would know more. However, having look at its code, I see similar locks and thread s

[GitHub] ant issue #81: Fix rare ConcurrentModificationException when running with Pa...

2018-12-11 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/81 > @jaikiran I think the test does exhibit the multithreaded scenario, I ran it prior to the Project changes to ensure it did fail. My Java is a bit rusty, but I believe the 2 separate ExecutorServic

[GitHub] ant issue #81: Fix rare ConcurrentModificationException when running with Pa...

2018-12-11 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/81 @mharmer, what name would you like us to add to our contributors list (https://github.com/apache/ant/blob/master/CONTRIBUTORS) for your contribution

[GitHub] ant pull request #80: Added tasks for JDK's jmod and jlink tools.

2018-12-11 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/80#discussion_r240889855 --- Diff: src/main/org/apache/tools/ant/taskdefs/modules/Jmod.java --- @@ -0,0 +1,1282 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] ant-ivy pull request: IVY-1526 Use parent pom's license (if any) i...

2015-08-21 Thread jaikiran
Github user jaikiran commented on the pull request: https://github.com/apache/ant-ivy/pull/7#issuecomment-133562903 Haven't heard any inputs on the mailing list nor here. Not sure how active the project is. --- If your project is set up for it, you can reply to this email and

[GitHub] ant-ivy pull request: IVY-1526 Use parent pom's license (if any) i...

2015-08-30 Thread jaikiran
Github user jaikiran commented on the pull request: https://github.com/apache/ant-ivy/pull/7#issuecomment-136157678 Thanks @nlalevee for merging this. Glad to see the contribution being accepted. Will send out PRs for other issues that I have started looking into. --- If your

[GitHub] ant-ivy pull request: IVY-1526 Use parent pom's license (if any) i...

2015-08-30 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant-ivy/pull/7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] ant-ivy pull request: IVY-1522 Windows OS file path resolution fix

2015-08-30 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/8 IVY-1522 Windows OS file path resolution fix The commit here fixes the issue reported in https://issues.apache.org/jira/browse/IVY-1522. This commit includes a new test method to verify

[GitHub] ant-ivy pull request: IVY-1522 Windows OS file path resolution fix

2015-08-30 Thread jaikiran
Github user jaikiran commented on the pull request: https://github.com/apache/ant-ivy/pull/8#issuecomment-136174686 Thanks for testing this. I'll see if I can borrow a Windows OS to come up with a proper fix and test for this. Closing this for now. --- If your project is set u

[GitHub] ant-ivy pull request: IVY-1522 Windows OS file path resolution fix

2015-08-30 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant-ivy/pull/8 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] ant-ivy pull request #10: Fix for IVY-1531

2016-12-07 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/10 Fix for IVY-1531 The commit here contains a potential fix for the issue reported in https://issues.apache.org/jira/browse/IVY-1531. Maven pom.xml allows dependency exclusion to include

[GitHub] ant-ivy pull request #11: IVY-1499 Prevent potential NPE during retrieve

2016-12-11 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/11 IVY-1499 Prevent potential NPE during retrieve The commit here adds a null check to prevent a potential NPE that is reported in JIRA https://issues.apache.org/jira/browse/IVY-1499 You can merge

[GitHub] ant-ivy pull request #12: IVY-1482 Fix potential NPE in XmlReportOutputter

2016-12-11 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/12 IVY-1482 Fix potential NPE in XmlReportOutputter The commit here adds a null check to prevent potential NPE reported in JIRA https://issues.apache.org/jira/browse/IVY-1482 You can merge this

[GitHub] ant-ivy pull request #12: IVY-1482 Fix potential NPE in XmlReportOutputter

2016-12-12 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant-ivy/pull/12 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] ant-ivy issue #12: IVY-1482 Fix potential NPE in XmlReportOutputter

2016-12-12 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/12 Closing this PR, since the commit here https://github.com/apache/ant-ivy/commit/c4bb60046de9ffdd1cf07cfcdba201df06b194dd handles it in a better way. --- If your project is set up for it, you can

[GitHub] ant-ivy issue #11: IVY-1499 Prevent potential NPE during retrieve

2017-05-16 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/11 Closing for now, since I need to revisit this to see if this is still valid --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] ant-ivy pull request #11: IVY-1499 Prevent potential NPE during retrieve

2017-05-16 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant-ivy/pull/11 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] ant-ivy pull request #13: Dummy PR - Do not merge

2017-05-17 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/13 Dummy PR - Do not merge This is just a dummy PR to test the PR integration with Jenkins jobs on Apache infra You can merge this pull request into a Git repository by running: $ git pull

[GitHub] ant-ivy issue #13: Dummy PR - Do not merge

2017-05-17 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/13 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] ant-ivy pull request #16: Fix download URL for findbugs task

2017-05-17 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/16 Fix download URL for findbugs task The commit here fixes the download URL used in the `init-findbugs` task, that has been failing[1] for a while due to reference to an URL that no longer works

[GitHub] ant-ivy pull request #17: Fix IVY-1478

2017-05-17 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/17 Fix IVY-1478 The commit here fixes the issue reported in https://issues.apache.org/jira/browse/IVY-1478 and also includes a test case to verify the changes. The fix involves setting the

[GitHub] ant-ivy pull request #13: Dummy PR - Do not merge

2017-05-17 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant-ivy/pull/13 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] ant-ivy pull request #18: Fix IVY-1448

2017-05-18 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/18 Fix IVY-1448 The commit here fixes the issue reported in https://issues.apache.org/jira/browse/IVY-1448 and also includes a test case to verify the fix. **Note that this issue isn&#

[GitHub] ant-ivy pull request #19: IVY-1554 - Add (conditional) support for SHA-256 S...

2017-05-18 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/19 IVY-1554 - Add (conditional) support for SHA-256 SHA-512 and SHA-384 checksum algorithms The commit here adds support for SHA-256, SHA-512 and SHA-384 algorithms as requested in https

[GitHub] ant-ivy pull request #20: Fix IVY-1522

2017-05-18 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/20 Fix IVY-1522 The commit here contains a potential fix for the issue reported in https://issues.apache.org/jira/browse/IVY-1522. This PR also contains a test case to verify the fix

[GitHub] ant-ivy issue #20: Fix IVY-1522

2017-05-19 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/20 Looking at the logs, the BasicURLHandler seems to have crashed because the Jenkins process was killed due to: ``` [junit] Running org.apache.ivy.util.url.BasicURLHandlerTest

[GitHub] ant-ivy issue #20: Fix IVY-1522

2017-05-19 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/20 The latest build completed successfully https://builds.apache.org/job/Ivy-GithubPR/15/console. Coming to the question: > Why not sticking only to well-known versioning sche

[GitHub] ant-ivy pull request #21: Fix IVY-1495

2017-05-19 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/21 Fix IVY-1495 The commit here is a potential fix for the issue reported in https://issues.apache.org/jira/browse/IVY-1495. The issue happens when the `ivysettings.xml` is being parsed and the

[GitHub] ant-ivy issue #21: Fix IVY-1495

2017-05-19 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/21 FWIW - the test failures don't look related. That specific testcase though probably needs to be looked into separately though, since it keeps failing once in a while on Jenkins. --- If

[GitHub] ant-ivy pull request #22: Fix transient test failures

2017-05-19 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/22 Fix transient test failures The `WarnCircularDependencyStrategyTest` fails once in a while on Jenkins. Looking at the testcase, it resets/updates a shared JVM level logger instance (via

[GitHub] ant-ivy issue #21: Fix IVY-1495

2017-05-19 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/21 >> That WarnCircularDependencyStrategyTest testcase though probably needs to be looked into separately, since it keeps failing once in a while on Jenkins. I think this https://gith

[GitHub] ant-ivy pull request #22: Fix transient test failures

2017-05-19 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant-ivy/pull/22 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] ant-ivy issue #22: Fix transient test failures

2017-05-19 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/22 Looks like this didn't help. It failed again (passes locally): >> [junit] Running org.apache.ivy.plugins.circular.WarnCircularDependencyStrategyTest [junit] Tests run:

[GitHub] ant-ivy pull request #23: Use the specified timeout for connections in Basic...

2017-05-20 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/23 Use the specified timeout for connections in BasicURLHandler The commit here fixes the `BasicURLHandler` to use the specified timeout for connection timeout. It also updates the

[GitHub] ant-ivy issue #20: Fix IVY-1522

2017-05-20 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/20 I think both me and Nicolas agree that this "fix" isn't going to solve the case where this and other similar characters can't be fully supported as long as we are using t

[GitHub] ant-ivy pull request #24: Fix IVY-1555

2017-05-21 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/24 Fix IVY-1555 The commit here includes a fix and test case for the issue reported in https://issues.apache.org/jira/browse/IVY-1555 where the absence of a `optional` settings file included in

[GitHub] ant-ivy pull request #25: Upgrade to latest Ant release (non-Java 8 one)

2017-05-21 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/25 Upgrade to latest Ant release (non-Java 8 one) The commit here upgrades the Ant dependencies to the latest released ones. A few notes about the dependencies: - `org.apache.ant:ant

[GitHub] ant-ivy pull request #26: Upgrade to latest JSCH versions

2017-05-21 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/26 Upgrade to latest JSCH versions The commit here upgrades the `jsch` library dependencies to the latest released versions. You can merge this pull request into a Git repository by running

[GitHub] ant-ivy issue #20: Fix IVY-1522

2017-05-21 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/20 >> So @jaikiran, would you consider rewrite the unit test to just test FileUtil.dissect ? Yes, certainly. I will update this PR with the testcase tomorrow. --- If your project is

[GitHub] ant-ivy issue #20: Fix IVY-1522

2017-05-22 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/20 I've now updated this PR to not focus on the usage of `:` in versions and instead test the FileUtil's method itself. --- If your project is set up for it, you can reply to this emai

[GitHub] ant-ivy pull request #27: Fix IVY-1540

2017-05-23 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/27 Fix IVY-1540 The commit here fixes the issue reported in https://issues.apache.org/jira/browse/IVY-1540. The dependency tree task now takes into account any potential circular dependencies that

[GitHub] ant-ivyde pull request #2: Minor change to update the year in the NOTICE fil...

2017-05-23 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivyde/pull/2 Minor change to update the year in the NOTICE file Just a minor change to the NOTICE file to update the year. This is an attempt to get the Jenkins autmoated PR builds going. You can

[GitHub] ant-ivyde pull request #2: Minor change to update the year in the NOTICE fil...

2017-05-23 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant-ivyde/pull/2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] ant-ivyde pull request #3: Update the year in copyright messages

2017-05-23 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivyde/pull/3 Update the year in copyright messages The commit here updates the year in copyright messages. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] ant-ivyde pull request #3: Update the year in copyright messages

2017-05-23 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant-ivyde/pull/3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] ant-ivyde issue #3: Update the year in copyright messages

2017-05-23 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivyde/pull/3 Updating this PR didn't trigger it now. Will recreate a new PR and try --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] ant-ivyde pull request #4: Update the year in copyright messages

2017-05-23 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivyde/pull/4 Update the year in copyright messages Updates the year in copyright messages. This PR is an attempt to get the Jenkins PR builds going and can be merged once that works. You can merge

[GitHub] ant-ivyde issue #4: Update the year in copyright messages

2017-05-24 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivyde/pull/4 Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] ant-ivy issue #27: Fix IVY-1540

2017-05-24 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/27 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] ant-ivy pull request #27: Fix IVY-1540

2017-05-24 Thread jaikiran
GitHub user jaikiran reopened a pull request: https://github.com/apache/ant-ivy/pull/27 Fix IVY-1540 The commit here fixes the issue reported in https://issues.apache.org/jira/browse/IVY-1540. The dependency tree task now takes into account any potential circular dependencies that

[GitHub] ant-ivy pull request #27: Fix IVY-1540

2017-05-24 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant-ivy/pull/27 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] ant-ivy issue #22: Fix transient test failures

2017-05-24 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/22 That's a good find. Looking at that testcase now again, with this additional detail that you noted, I think the problem here is that the `AbstractLogCircularDependencyStrategy` ends up us

[GitHub] ant-ivy pull request #30: Fix transient test failures

2017-05-24 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/30 Fix transient test failures The commit here fixes the transient test failures that we keep seeing in `WarnCircularDependencyStrategyTest`. More details about the fix are in this previous PR https

[GitHub] ant-ivy issue #30: Fix transient test failures

2017-05-24 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/30 Jenkins seems to have picked up the disabled Matrix job for this run. I'll wait for that to get sorted out. --- If your project is set up for it, you can reply to this email and have your

[GitHub] ant-ivy issue #27: Fix IVY-1540

2017-05-25 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/27 Now that the transient failure fixes have been merged and the Jenkins PR jobs are working, going to reopen this to trigger a new run of Jenkins. --- If your project is set up for it, you can reply

[GitHub] ant-ivy pull request #27: Fix IVY-1540

2017-05-25 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant-ivy/pull/27 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] ant-ivy pull request #27: Fix IVY-1540

2017-05-25 Thread jaikiran
GitHub user jaikiran reopened a pull request: https://github.com/apache/ant-ivy/pull/27 Fix IVY-1540 The commit here fixes the issue reported in https://issues.apache.org/jira/browse/IVY-1540. The dependency tree task now takes into account any potential circular dependencies that

[GitHub] ant-ivy issue #21: Fix IVY-1495

2017-05-25 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/21 Reopening this one --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] ant-ivy pull request #21: Fix IVY-1495

2017-05-25 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant-ivy/pull/21 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] ant-ivy pull request #21: Fix IVY-1495

2017-05-25 Thread jaikiran
GitHub user jaikiran reopened a pull request: https://github.com/apache/ant-ivy/pull/21 Fix IVY-1495 The commit here is a potential fix for the issue reported in https://issues.apache.org/jira/browse/IVY-1495. The issue happens when the `ivysettings.xml` is being parsed and the

[GitHub] ant-ivy pull request #20: Fix IVY-1522

2017-05-25 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant-ivy/pull/20 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] ant-ivy pull request #20: Fix IVY-1522

2017-05-25 Thread jaikiran
GitHub user jaikiran reopened a pull request: https://github.com/apache/ant-ivy/pull/20 Fix IVY-1522 The commit here contains a potential fix for the issue reported in https://issues.apache.org/jira/browse/IVY-1522. This PR also contains a test case to verify the fix

[GitHub] ant-ivy pull request #34: Fix IVY-1528

2017-05-27 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/34 Fix IVY-1528 The commit here fixes the issue reported in https://issues.apache.org/jira/browse/IVY-1528 and includes a test case to verify the fix. With this fix, the `classifier` extra attribute

[GitHub] ant-ivy issue #27: Fix IVY-1540

2017-05-28 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/27 I forgot to include a sample of how the circular dependency is now going to be reported in the dependency tree output. Here's a sample of it: ``` [ivy:dependenc

[GitHub] ant-ivy pull request #35: Use Java 7 as the minimum required Java version

2017-05-29 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/35 Use Java 7 as the minimum required Java version Now that the vote to upgrade the minimal required Java version has been passed[1], the commit here upgrades the version to Java 7. [1

[GitHub] ant-ivy issue #34: Fix IVY-1528

2017-05-29 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/34 >> we dont use @author Fixed - removed that tag. I will setup my IDE accordingly. >> TestXmlHelper -- if xPathExpression would be a String and the method compi

[GitHub] ant-ivy issue #34: Fix IVY-1528

2017-05-30 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/34 I used >> git fetch github pull/34/head:PR-34 >> git checkout PR-34 >> Some ideas? What does the output of: ```git status``` and then

[GitHub] ant-ivy pull request #37: Don't pollute the source lib folder during ivy ret...

2017-05-31 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/37 Don't pollute the source lib folder during ivy retrieval in test The `IvyRetrieveBuildFileTest` triggers a Ant project build during the test case and issues a `ivy:retrieve` through the build

[GitHub] ant-ivy issue #36: Replace emma with jacoco

2017-05-31 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/36 >> I found out that JUnit tests polute run.classpath by placing an empty jar in /lib, which breaks eg javadoc. Any ideas which test may do that? I believe this PR https://github.com/

[GitHub] ant-ivy pull request #38: IVY-1475 Throw an explicit BuildException if cache...

2017-06-02 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/38 IVY-1475 Throw an explicit BuildException if cachefileset cannot determine a common base directory The commit here enhances the implementation of `cachefileset` task to throw an explicit

[GitHub] ant-ivy pull request #40: Fix regression in tutorials

2017-06-02 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/40 Fix regression in tutorials The commit here fixes some issues in tutorials, that went unnoticed in some of our recent changes. You can merge this pull request into a Git repository by running

[GitHub] ant-ivy pull request #44: IVY-1561 - Enhancement to take into account enviro...

2017-06-12 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/44 IVY-1561 - Enhancement to take into account environment and system properties while evaluation Maven pom property references The commit in this PR introduces the enhancement requested in https

[GitHub] ant-ivy issue #38: IVY-1475 Throw an explicit BuildException if cachefileset...

2017-06-13 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/38 >> requireCommonBaseDir: >>could we replace firstPath by base==null? >> line 115: additional comment: >>'fail fast: ...' >>line

[GitHub] ant-ivy issue #38: IVY-1475 Throw an explicit BuildException if cachefileset...

2017-06-13 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/38 >> Maybe we could extract the method into FileUtil later. I went ahead and moved it to `FileUtil` since it does make sense for it to be there. --- If your project is set up for i

[GitHub] ant-ivy pull request #38: IVY-1475 Throw an explicit BuildException if cache...

2017-06-13 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant-ivy/pull/38 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] ant-ivy issue #38: IVY-1475 Throw an explicit BuildException if cachefileset...

2017-06-13 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/38 Closing this PR, because looking at the commits in master branch, it looks like Jan already pulled in this commit. Thanks @janmaterne --- If your project is set up for it, you can reply to this

[GitHub] ant-ivy pull request #46: Fix the build of tutorials

2017-06-15 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/46 Fix the build of tutorials The commit here fixes the tutorials build which currently is running into build failures. You can merge this pull request into a Git repository by running: $ git

[GitHub] ant-ivy pull request #47: Move to asciidoc for documentation

2017-06-15 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/47 Move to asciidoc for documentation This PR contains multiple commits, which together are a first step towards moving the current `xooki` backed documentation to `asciidoc`. The commits are

[GitHub] ant-ivy pull request #46: Fix the build of tutorials

2017-06-17 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant-ivy/pull/46 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] ant-ivy issue #45: Generics + foreach loops and Java 7 in util (except Filte...

2017-06-18 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/45 Thanks for the PR. Merged. P.S: Someone else will have to close this PR, till I understand how I can auto-close this or get access to a close button. --- If your project is set up for it

[GitHub] ant-ivy pull request #48: Generics and Java 7 syntax in osgi and plugins pac...

2017-07-01 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/48#discussion_r125162592 --- Diff: src/java/org/apache/ivy/plugins/signer/bouncycastle/OpenPGPSignatureGenerator.java --- @@ -161,7 +159,7 @@ private PGPSecretKey readSecretKey

[GitHub] ant-ivy pull request #48: Generics and Java 7 syntax in osgi and plugins pac...

2017-07-01 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/48#discussion_r125161935 --- Diff: src/java/org/apache/ivy/plugins/signer/bouncycastle/OpenPGPSignatureGenerator.java --- @@ -161,7 +159,7 @@ private PGPSecretKey readSecretKey

[GitHub] ant-ivy issue #48: Generics and Java 7 syntax in osgi and plugins packages

2017-07-01 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/48 >> https://stackoverflow.com/questions/30454635/when-using-for-a-primitive-and-a-boxed-value-is-autoboxing-done-or-is-unbox Thanks - the JLS sections[1][2] mentioned in there answ

[GitHub] ant-ivy issue #51: Fix some string comparisons with ==

2017-07-09 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/51 Thanks for the PR. This has now been merged. I had to fix the `ModuleDescriptorMemoryCacheTest` which got exposed by (valid) changes in this PR. --- If your project is set up for it, you can

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-13 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127395633 --- Diff: src/java/org/apache/ivy/osgi/p2/XMLInputParser.java --- @@ -19,12 +19,11 @@ import java.io.IOException; import java.io.InputStream

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-13 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127395788 --- Diff: src/java/org/apache/ivy/osgi/repo/AbstractFSManifestIterable.java --- @@ -44,9 +44,9 @@ public AbstractFSManifestIterable(T root

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-13 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127395825 --- Diff: src/java/org/apache/ivy/osgi/repo/AbstractFSManifestIterable.java --- @@ -44,9 +44,9 @@ public AbstractFSManifestIterable(T root

  1   2   3   4   5   6   7   8   >