Re: Backports to consider for 1.6.4?

2019-12-26 Thread Graham Leggett
On 30 Aug 2018, at 05:30, William A Rowe Jr wrote: > Second; > Are we comfortable adding a dependency on autoconf-archive? > This macro below dates back to 2010. If we are not, I can > revert this. In any case, I think it would be unwise to introduce > this before 1.7, we generally haven't change

Re: Backports to consider for 1.6.4?

2018-08-31 Thread Nick Kew
> Pull request #5 https://github.com/apache/apr/pull/5/files > corresponds to https://bz.apache.org/bugzilla/show_bug.cgi?id=61985 > Yann and I are neutral on dodging (fd == -1), what do others think? > This would be a trivial one-line fix if we adopt it. > > Are there any committers with an op

Re: Backports to consider for 1.6.4?

2018-08-30 Thread William A Rowe Jr
On Wed, Aug 29, 2018 at 10:30 PM, William A Rowe Jr wrote: > First; > Pull request #5 https://github.com/apache/apr/pull/5/files > corresponds to https://bz.apache.org/bugzilla/show_bug.cgi?id=61985 > Yann and I are neutral on dodging (fd == -1), what do others think? > This would be a trivial on

Re: Backports to consider for 1.6.4?

2018-08-30 Thread William A Rowe Jr
On Wed, Aug 29, 2018 at 10:40 PM, William A Rowe Jr wrote: > On Wed, Aug 29, 2018 at 10:30 PM, William A Rowe Jr > wrote: > >> >> Second; >> Are we comfortable adding a dependency on autoconf-archive? >> This macro below dates back to 2010. If we are not, I can >> revert this. >> > > And note I'

Re: Backports to consider for 1.6.4?

2018-08-29 Thread William A Rowe Jr
On Wed, Aug 29, 2018 at 10:30 PM, William A Rowe Jr wrote: > > Second; > Are we comfortable adding a dependency on autoconf-archive? > This macro below dates back to 2010. If we are not, I can > revert this. > And note I'll need to tweak the buildcheck.sh if we choose to keep the dependency, it

Backports to consider for 1.6.4?

2018-08-29 Thread William A Rowe Jr
First; Pull request #5 https://github.com/apache/apr/pull/5/files corresponds to https://bz.apache.org/bugzilla/show_bug.cgi?id=61985 Yann and I are neutral on dodging (fd == -1), what do others think? This would be a trivial one-line fix if we adopt it. Second; Are we comfortable adding a depende