Re:: svn commit: r1828369 - in /apr/apr/trunk: include/apr_reslist.h util-misc/apr_reslist.c

On Mon, Apr 16, 2018 at 6:22 AM, Ruediger Pluem wrote: > > On 04/16/2018 12:04 PM, Yann Ylavic wrote: >> On Mon, Apr 16, 2018 at 8:45 AM, Ruediger Pluem wrote: >>> >>> On 04/14/2018 02:32 AM, Yann Ylavic wrote: > > I think there are scenarios where LIFO is

Re: svn commit: r1828369 - in /apr/apr/trunk: include/apr_reslist.h util-misc/apr_reslist.c

> On Apr 16, 2018, at 7:22 AM, Ruediger Pluem wrote: > > > > I think there are scenarios where LIFO is useful, but the question is if > these are frequent enough to warrant LIFO / > FIFO as an option. > As an option, yes. But not, in my opinion, a behind-the-curtains

Re: svn commit: r1828369 - in /apr/apr/trunk: include/apr_reslist.h util-misc/apr_reslist.c

On 04/16/2018 12:04 PM, Yann Ylavic wrote: > On Mon, Apr 16, 2018 at 8:45 AM, Ruediger Pluem wrote: >> >> On 04/14/2018 02:32 AM, Yann Ylavic wrote: >>> >>> IOW, this simple patch would work equally for me (and could go in any >>> version): >>> >>> Index:

Re: svn commit: r1828369 - in /apr/apr/trunk: include/apr_reslist.h util-misc/apr_reslist.c

On Mon, Apr 16, 2018 at 6:04 AM, Yann Ylavic wrote: > On Mon, Apr 16, 2018 at 8:45 AM, Ruediger Pluem wrote: >> >> On 04/14/2018 02:32 AM, Yann Ylavic wrote: >>> >>> IOW, this simple patch would work equally for me (and could go in any >>> version): >>>

Re: svn commit: r1828369 - in /apr/apr/trunk: include/apr_reslist.h util-misc/apr_reslist.c

On Mon, Apr 16, 2018 at 8:45 AM, Ruediger Pluem wrote: > > On 04/14/2018 02:32 AM, Yann Ylavic wrote: >> >> IOW, this simple patch would work equally for me (and could go in any >> version): >> >> Index: util-misc/apr_reslist.c >>

Re: svn commit: r1828369 - in /apr/apr/trunk: include/apr_reslist.h util-misc/apr_reslist.c

On 04/14/2018 02:32 AM, Yann Ylavic wrote: > On Sat, Apr 14, 2018 at 2:18 AM, Yann Ylavic wrote: >> >> when the ttl is to be >> checked against the resource we should always peek it as LIFO (i.e. >> s/fifo/1/ in the first peek_resource() of reslist_acquire() in my >>

Re: svn commit: r1828369 - in /apr/apr/trunk: include/apr_reslist.h util-misc/apr_reslist.c

On Sat, Apr 14, 2018 at 2:18 AM, Yann Ylavic wrote: > > when the ttl is to be > checked against the resource we should always peek it as LIFO (i.e. > s/fifo/1/ in the first peek_resource() of reslist_acquire() in my > patch). > This would prevent starvation, and we should

Re: svn commit: r1828369 - in /apr/apr/trunk: include/apr_reslist.h util-misc/apr_reslist.c

To expand a bit... On Sat, Apr 14, 2018 at 1:46 AM, Yann Ylavic wrote: > On Sat, Apr 14, 2018 at 12:54 AM, Nick Kew wrote: >> >>> On 13 Apr 2018, at 21:46, Yann Ylavic wrote: >>> >>> On Fri, Apr 13, 2018 at 7:30 PM, William A Rowe Jr

Re: svn commit: r1828369 - in /apr/apr/trunk: include/apr_reslist.h util-misc/apr_reslist.c

On Sat, Apr 14, 2018 at 12:54 AM, Nick Kew wrote: > >> On 13 Apr 2018, at 21:46, Yann Ylavic wrote: >> >> On Fri, Apr 13, 2018 at 7:30 PM, William A Rowe Jr >> wrote: >>> I'm still unclear why you believe we need APR to purge the elts

Re: svn commit: r1828369 - in /apr/apr/trunk: include/apr_reslist.h util-misc/apr_reslist.c

> On 13 Apr 2018, at 21:46, Yann Ylavic wrote: > > On Fri, Apr 13, 2018 at 7:30 PM, William A Rowe Jr > wrote: >> I'm still unclear why you believe we need APR to purge the elts when the >> user chooses to flip the fifo/lifo switch. That seems very

Re: svn commit: r1828369 - in /apr/apr/trunk: include/apr_reslist.h util-misc/apr_reslist.c

On Fri, Apr 13, 2018 at 7:30 PM, William A Rowe Jr wrote: > I'm still unclear why you believe we need APR to purge the elts when the > user chooses to flip the fifo/lifo switch. That seems very wrong to me, the > consumer can do so if that is what they desire. To be clear

Re: svn commit: r1828369 - in /apr/apr/trunk: include/apr_reslist.h util-misc/apr_reslist.c

On Thu, Apr 12, 2018 at 11:13 PM, William A Rowe Jr wrote: > On Thu, Apr 12, 2018 at 12:56 PM, Ruediger Pluem wrote: >> >> >> Other options: >> >> 2. Reverse the order in the ring when apr_reslist_fifo_set is called. >> >> Of course both options require a

Re: svn commit: r1828369 - in /apr/apr/trunk: include/apr_reslist.h util-misc/apr_reslist.c

On Thu, Apr 12, 2018 at 7:56 PM, Ruediger Pluem wrote: > > Other options: > > 1. Destroy all reslist elements when apr_reslist_fifo_set is called. > 2. Reverse the order in the ring when apr_reslist_fifo_set is called. Good idea, I'll go for 1. unless someone beats me at it

Re: svn commit: r1828369 - in /apr/apr/trunk: include/apr_reslist.h util-misc/apr_reslist.c

On Thu, Apr 12, 2018 at 12:56 PM, Ruediger Pluem wrote: > > > Other options: > > 2. Reverse the order in the ring when apr_reslist_fifo_set is called. > > Of course both options require a lock. Here's an odd idea. What if the *traversal* were reversed based on the lifo bit,

Re: svn commit: r1828369 - in /apr/apr/trunk: include/apr_reslist.h util-misc/apr_reslist.c

On 04/11/2018 01:26 PM, Yann Ylavic wrote: > On Fri, Apr 6, 2018 at 10:18 AM, Yann Ylavic wrote: >> On Fri, Apr 6, 2018 at 8:57 AM, Ruediger Pluem wrote: >>> >>> I don't think that a remark is strong enough here. I would like to >>> see this parameter

Re: svn commit: r1828369 - in /apr/apr/trunk: include/apr_reslist.h util-misc/apr_reslist.c

On Fri, Apr 6, 2018 at 10:18 AM, Yann Ylavic wrote: > On Fri, Apr 6, 2018 at 8:57 AM, Ruediger Pluem wrote: >> >> I don't think that a remark is strong enough here. I would like to >> see this parameter either added to a new apr_reslist_create_ex or if >>

Re: svn commit: r1828369 - in /apr/apr/trunk: include/apr_reslist.h util-misc/apr_reslist.c

On Fri, Apr 6, 2018 at 10:18 AM, Yann Ylavic wrote: > On Fri, Apr 6, 2018 at 8:57 AM, Ruediger Pluem wrote: >> >> I don't think that a remark is strong enough here. I would like to >> see this parameter either added to a new apr_reslist_create_ex or if >>

Re: svn commit: r1828369 - in /apr/apr/trunk: include/apr_reslist.h util-misc/apr_reslist.c

On Fri, Apr 6, 2018 at 8:57 AM, Ruediger Pluem wrote: > > I don't think that a remark is strong enough here. I would like to > see this parameter either added to a new apr_reslist_create_ex or if > we want to stick with apr_reslist_fifo_set it should return an error > if

Re: svn commit: r1828369 - in /apr/apr/trunk: include/apr_reslist.h util-misc/apr_reslist.c

On 04/04/2018 07:43 PM, yla...@apache.org wrote: > Author: ylavic > Date: Wed Apr 4 17:43:46 2018 > New Revision: 1828369 > > URL: http://svn.apache.org/viewvc?rev=1828369=rev > Log: > reslist: follow up to r1828289: adjust maintenance top too. > > Also, clarify in doxygen when