Re: Review Request 65911: [ATLAS-2480]: Regression, Tag Propagation : Deleting the table with lineage and tag

2018-03-07 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65911/#review198854
---


Ship it!




Ship It!

- Madhan Neethiraj


On March 6, 2018, 3:34 a.m., Sarath Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65911/
> ---
> 
> (Updated March 6, 2018, 3:34 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2480
> https://issues.apache.org/jira/browse/ATLAS-2480
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> When deleting the table with lineage and tag, propagated edges also needs to 
> be removed and impacted entity vertices needs to be updated.
> 
> 
> Diffs
> -
> 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> 9d56fa96 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
>  2b62a687 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
>  0ba06b94 
> 
> 
> Diff: https://reviews.apache.org/r/65911/diff/2/
> 
> 
> Testing
> ---
> 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/139/console
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>

Re: Review Request 65911: [ATLAS-2480]: Regression, Tag Propagation : Deleting the table with lineage and tag

2018-03-06 Thread Sarath Subramanian 


> On March 5, 2018, 10:34 p.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
> > Lines 338 (patched)
> > 
> >
> > there is another deleteTypeVertex() method, with additional parameter 
> > 'boolean force'. Shouldn't removeTagPropagation() be called from there as 
> > well? Please review.

deleteTypeVertex(AtlasVertex instanceVertex, boolean force) is called from 
delateAllTraits() and removeTagPropagation() is called before the method 
deleteTypeVertex(instanceVertex, force).

deleteAllTraits(deletionCandidateVertex) 
  deleteTypeVertex(AtlasVertex instanceVertex, TypeCategory typeCategory, 
boolean force)
deleteTypeVertex(AtlasVertex instanceVertex, boolean force)


- Sarath


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65911/#review198681
---


On March 5, 2018, 7:34 p.m., Sarath Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65911/
> ---
> 
> (Updated March 5, 2018, 7:34 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2480
> https://issues.apache.org/jira/browse/ATLAS-2480
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> When deleting the table with lineage and tag, propagated edges also needs to 
> be removed and impacted entity vertices needs to be updated.
> 
> 
> Diffs
> -
> 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> 9d56fa96 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
>  2b62a687 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
>  0ba06b94 
> 
> 
> Diff: https://reviews.apache.org/r/65911/diff/2/
> 
> 
> Testing
> ---
> 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/139/console
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>

Re: Review Request 65911: [ATLAS-2480]: Regression, Tag Propagation : Deleting the table with lineage and tag

2018-03-05 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65911/#review198681
---


Fix it, then Ship it!





repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
Lines 338 (patched)


there is another deleteTypeVertex() method, with additional parameter 
'boolean force'. Shouldn't removeTagPropagation() be called from there as well? 
Please review.


- Madhan Neethiraj


On March 6, 2018, 3:34 a.m., Sarath Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65911/
> ---
> 
> (Updated March 6, 2018, 3:34 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2480
> https://issues.apache.org/jira/browse/ATLAS-2480
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> When deleting the table with lineage and tag, propagated edges also needs to 
> be removed and impacted entity vertices needs to be updated.
> 
> 
> Diffs
> -
> 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> 9d56fa96 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
>  2b62a687 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
>  0ba06b94 
> 
> 
> Diff: https://reviews.apache.org/r/65911/diff/2/
> 
> 
> Testing
> ---
> 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/139/console
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>

Re: Review Request 65911: [ATLAS-2480]: Regression, Tag Propagation : Deleting the table with lineage and tag

2018-03-05 Thread Sarath Subramanian 


> On March 5, 2018, 7:40 p.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
> > Lines 335 (patched)
> > 
> >
> > removeTagPropagation() expects a classificationVertex as argument; is 
> > the instanceVertex here a classificationVertex?

Yes, in this context - the vertex to delete is a classificationVertex. If the 
vertex is of type trait, delete the edge, trait vertex and all propagated edges


- Sarath


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65911/#review198679
---


On March 5, 2018, 7:34 p.m., Sarath Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65911/
> ---
> 
> (Updated March 5, 2018, 7:34 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2480
> https://issues.apache.org/jira/browse/ATLAS-2480
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> When deleting the table with lineage and tag, propagated edges also needs to 
> be removed and impacted entity vertices needs to be updated.
> 
> 
> Diffs
> -
> 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> 9d56fa96 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
>  2b62a687 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
>  0ba06b94 
> 
> 
> Diff: https://reviews.apache.org/r/65911/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>

Re: Review Request 65911: [ATLAS-2480]: Regression, Tag Propagation : Deleting the table with lineage and tag

2018-03-05 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65911/#review198679
---




repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
Lines 335 (patched)


removeTagPropagation() expects a classificationVertex as argument; is the 
instanceVertex here a classificationVertex?


- Madhan Neethiraj


On March 6, 2018, 3:34 a.m., Sarath Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65911/
> ---
> 
> (Updated March 6, 2018, 3:34 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2480
> https://issues.apache.org/jira/browse/ATLAS-2480
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> When deleting the table with lineage and tag, propagated edges also needs to 
> be removed and impacted entity vertices needs to be updated.
> 
> 
> Diffs
> -
> 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> 9d56fa96 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
>  2b62a687 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
>  0ba06b94 
> 
> 
> Diff: https://reviews.apache.org/r/65911/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>