Re: Review Request 73097: ATLAS-4086: Python Client Fixes - Basic Search and Bulk Entities using GUIDs

2020-12-24 Thread Madhan Neethiraj
> On Dec. 17, 2020, 8:27 p.m., Madhan Neethiraj wrote: > > intg/src/main/python/apache_atlas/model/instance.py > > Line 70 (original), 74 (patched) > > > > > > Many coding standards suggest line length of 80, but

Re: Review Request 73097: ATLAS-4086: Python Client Fixes - Basic Search and Bulk Entities using GUIDs

2020-12-22 Thread Mariusz Górski
> On Dec. 17, 2020, 8:27 p.m., Madhan Neethiraj wrote: > > intg/src/main/python/apache_atlas/model/instance.py > > Line 70 (original), 74 (patched) > > > > > > Many coding standards suggest line length of 80, but

Re: Review Request 73097: ATLAS-4086: Python Client Fixes - Basic Search and Bulk Entities using GUIDs

2020-12-21 Thread Madhan Neethiraj
> On Dec. 17, 2020, 8:27 p.m., Madhan Neethiraj wrote: > > intg/src/main/python/apache_atlas/client/discovery.py > > Line 25 (original), 28 (patched) > > > > > > While I appreciate many guidelines in pep8, I find

Re: Review Request 73097: ATLAS-4086: Python Client Fixes - Basic Search and Bulk Entities using GUIDs

2020-12-21 Thread Verdan Mahmood
> On Dec. 17, 2020, 8:27 p.m., Madhan Neethiraj wrote: > > intg/src/main/python/apache_atlas/client/discovery.py > > Line 25 (original), 28 (patched) > > > > > > While I appreciate many guidelines in pep8, I find

Re: Review Request 73097: ATLAS-4086: Python Client Fixes - Basic Search and Bulk Entities using GUIDs

2020-12-18 Thread nokvrlmsiyqrwuAB nokvrlmsyquaprAB
> On Дек. 17, 2020, 8:27 п.п., Madhan Neethiraj wrote: > > intg/src/main/python/apache_atlas/client/discovery.py > > Line 25 (original), 28 (patched) > > > > > > While I appreciate many guidelines in pep8, I find

Re: Review Request 73097: ATLAS-4086: Python Client Fixes - Basic Search and Bulk Entities using GUIDs

2020-12-17 Thread Madhan Neethiraj
> On Dec. 17, 2020, 8:27 p.m., Madhan Neethiraj wrote: > > intg/src/main/python/apache_atlas/model/instance.py > > Line 31 (original), 31 (patched) > > > > > > What is the advantage of replacing argument default

Re: Review Request 73097: ATLAS-4086: Python Client Fixes - Basic Search and Bulk Entities using GUIDs

2020-12-17 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73097/#review222360 --- intg/src/main/python/apache_atlas/client/discovery.py Line 25