Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

2016-09-16 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51660/ --- (Updated Sept. 16, 2016, 10:55 p.m.) Review request for atlas, Madhan

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

2016-09-15 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51660/#review149172 ---

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

2016-09-15 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51660/ --- (Updated Sept. 16, 2016, 5:40 a.m.) Review request for atlas, Madhan

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

2016-09-14 Thread Shwetha GS
> On Sept. 13, 2016, 4:40 a.m., Shwetha GS wrote: > > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java, > > line 309 > > > > > > This is equals check - typename equals keyword. Does it

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

2016-09-14 Thread Shwetha GS
> On Sept. 13, 2016, 4:40 a.m., Shwetha GS wrote: > > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java, > > line 309 > > > > > > This is equals check - typename equals keyword. Does it

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

2016-09-13 Thread Apoorv Naik
> On Sept. 13, 2016, 4:40 a.m., Shwetha GS wrote: > > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java, > > line 309 > > > > > > This is equals check - typename equals keyword. Does it

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

2016-09-12 Thread Apoorv Naik
> On Sept. 13, 2016, 4:40 a.m., Shwetha GS wrote: > > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java, > > line 309 > > > > > > This is equals check - typename equals keyword. Does it

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

2016-09-12 Thread Apoorv Naik
> On Sept. 12, 2016, 8:24 a.m., Shwetha GS wrote: > > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java, > > line 295 > > > > > > TypeSystem.verifyTypes() has all the validations.

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

2016-09-12 Thread Apoorv Naik
> On Sept. 13, 2016, 4:40 a.m., Shwetha GS wrote: > > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java, > > line 309 > > > > > > This is equals check - typename equals keyword. Does it

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

2016-09-12 Thread Shwetha GS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51660/#review148651 ---

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

2016-09-12 Thread Shwetha GS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51660/#review148465 ---

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

2016-09-07 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51660/#review148130 --- Ship it! Ship It! - Madhan Neethiraj On Sept. 6, 2016,

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

2016-09-06 Thread Apoorv Naik
> On Sept. 6, 2016, 11:20 p.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java, > > line 296 > > > > > > Is it necessary to create ImmutableList for the

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

2016-09-06 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51660/ --- (Updated Sept. 6, 2016, 11:27 p.m.) Review request for atlas, Madhan

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

2016-09-06 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51660/#review147940 ---

Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait

2016-09-06 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51660/ --- (Updated Sept. 6, 2016, 10:07 p.m.) Review request for atlas, Madhan