Re: [DISCUSS] Remove findbugs from sdks/java

Last time I checked, errorprone didn't enforce nullness typing. Does it now? IMO that's the only P0 in our static analysis toolchain. Kenn On Wed, Jun 27, 2018 at 9:52 AM Scott Wegner wrote: > FYI, now that the ErrorProne migration is complete [1] it's a good time to > discuss whether FindBugs

Re: [DISCUSS] Remove findbugs from sdks/java

FYI, now that the ErrorProne migration is complete [1] it's a good time to discuss whether FindBugs should be removed or not. I haven't compared the set of checks we are doing with FindBugs vs ErrorProne. If ErrorProne can replace the checks from FindBugs then I'm in favor of getting rid of it.

Re: [DISCUSS] Remove findbugs from sdks/java

Awesome! In the meantime I've tried out Gradle + Checker and unfortunately compilation hung. It could be due to any subset of Gradle, Checker, Errorprone. I would not expect a performance problem, since Checker is "pluggable type systems" and type checking is a very fast sort of analysis. Also I

Re: [DISCUSS] Remove findbugs from sdks/java

Thank you guys : D On Wed, May 30, 2018 at 9:20 AM Scott Wegner wrote: > Sorry to revive an old thread, but I wanted to give a shout-out and say > thank you to Ismaël and Tim who have been quickly chipping away at the > ErrorProne backlog. We started with 47 ErrorProne JIRA's [1], and in two >

Re: [DISCUSS] Remove findbugs from sdks/java

Sorry to revive an old thread, but I wanted to give a shout-out and say thank you to Ismaël and Tim who have been quickly chipping away at the ErrorProne backlog. We started with 47 ErrorProne JIRA's [1], and in two weeks we're down to just 17 [2]. Thanks! [1]

Re: [DISCUSS] Remove findbugs from sdks/java

As part of the error-prone effort Tim has been also cleaning other static analysis warnings as reported by IntelliJ's Inspect -> Analyze code. I think this is a good moment to grok some of those too e.g. scoping, unused variables, redundancies, etc. So I hope the others taking part this work try

Re: [DISCUSS] Remove findbugs from sdks/java

Thanks Tim. I think we will be able to remove findbugs after some run/check using ErrorProne and see the gaps. Regards JB Le 18 mai 2018 à 07:49, à 07:49, Tim Robertson a écrit: >Thank you all. > >I think this is clear. Removing findbugs can happen at a future

Re: [DISCUSS] Remove findbugs from sdks/java

Thank you all. I think this is clear. Removing findbugs can happen at a future point. @Scott - I've been working through the java IO error prone issues (some already merged, some with open PRs now) so will take those IO Jiras. I will enable failOnWarning, address dependency issues for findbugs

Re: [DISCUSS] Remove findbugs from sdks/java

+0.02173913 I'm happy to replace FindBugs with ErrorProne, but we need to first upgrade ErrorProne analyzer warnings to errors. Currently the codebase is full of warning spam, and there's no enforcement preventing future violations from being added. I've done the work for enforcing ErrorProne

Re: [DISCUSS] Remove findbugs from sdks/java

+0.7 also. Findbugs support for more recent versions of Java is lacking and the maintenance seems frozen in time. As a possible plan b can we identify the missing important validations to identify how much we lose and if it is considerable, maybe we can create a minimal configuration for those,

Re: [DISCUSS] Remove findbugs from sdks/java

+0.7 I think we should work to remove findbugs. Errorprone covers most of the same stuff but better and faster. The one thing I'm not sure about is nullness analysis. Findbugs has some serious limitations there but it really improves code quality and prevents blunders. I'm not sure errorprone