[jira] [Commented] (BROOKLYN-354) Rebind failed (when an NingxController entity's hostname sensor was null)

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532828#comment-15532828 ] ASF GitHub Bot commented on BROOKLYN-354: - Github user asfgit closed the pull request at:

[GitHub] brooklyn-server pull request #360: BROOKLYN-354: Rebind failed (when an Ning...

2016-09-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/360 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (BROOKLYN-354) Rebind failed (when an NingxController entity's hostname sensor was null)

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532824#comment-15532824 ] ASF GitHub Bot commented on BROOKLYN-354: - Github user aledsage commented on the issue:

[GitHub] brooklyn-server issue #358: Allow REST API to return the config key's constr...

2016-09-29 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/358 @neykov Comment addressed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] brooklyn-server issue #354: Config keys and parameters can now be marked as ...

2016-09-29 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/354 Close this in favor of #358 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] brooklyn-server pull request #354: Config keys and parameters can now be mar...

2016-09-29 Thread tbouron
Github user tbouron closed the pull request at: https://github.com/apache/brooklyn-server/pull/354 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (BROOKLYN-325) Restarting Brooklyn while entity deploying: entity shown as deploying indefinitely

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532813#comment-15532813 ] ASF GitHub Bot commented on BROOKLYN-325: - Github user aledsage commented on a diff in the pull

[GitHub] brooklyn-server issue #360: BROOKLYN-354: Rebind failed (when an NingxContro...

2016-09-29 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/360 The jenkins build got past core and software-base (i.e. the code that this PR touches) before timing out, so I'm going to merge this. --- If your project is set up for it, you can reply

[GitHub] brooklyn-server pull request #356: BROOKLYN-325 Rebind entity starting (init...

2016-09-29 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/356#discussion_r81139618 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/RebindIteration.java --- @@ -687,8 +689,13 @@ protected void manageTheObjects() {

[GitHub] brooklyn-library issue #65: Implements new constraint API

2016-09-29 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-library/pull/65 Not valid anymore as https://github.com/apache/brooklyn-server/pull/358 does not change the internal API anymore --- If your project is set up for it, you can reply to this email and have

[GitHub] brooklyn-library pull request #65: Implements new constraint API

2016-09-29 Thread tbouron
Github user tbouron closed the pull request at: https://github.com/apache/brooklyn-library/pull/65 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (BROOKLYN-354) Rebind failed (when an NingxController entity's hostname sensor was null)

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532803#comment-15532803 ] ASF GitHub Bot commented on BROOKLYN-354: - Github user aledsage commented on the issue:

[GitHub] brooklyn-server issue #360: BROOKLYN-354: Rebind failed (when an NingxContro...

2016-09-29 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/360 The test failure looks unrelated. It failed while building Brooklyn CAMP REST API (after 30:21 min): ``` Build timed out (after 60 minutes). Marking the build as aborted. ...

[GitHub] brooklyn-server issue #282: Added attribute to DSL for immediate return of s...

2016-09-29 Thread grkvlt
Github user grkvlt commented on the issue: https://github.com/apache/brooklyn-server/pull/282 @ahgittin @aledsage closing this, based on feedback from mailing list --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] brooklyn-server pull request #358: Allow REST API to return the pinned confi...

2016-09-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/358#discussion_r81173978 --- Diff: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/catalog/SpecParameterParsingTest.java --- @@ -66,19 +66,20 @@ public

[GitHub] brooklyn-server pull request #358: Allow REST API to return the pinned confi...

2016-09-29 Thread neykov
Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/358#discussion_r81183657 --- Diff: core/src/main/java/org/apache/brooklyn/core/config/BasicConfigKey.java --- @@ -184,7 +192,7 @@ public String getDescription() {

[GitHub] brooklyn-server pull request #337: Add config inheritance to customizers key

2016-09-29 Thread grkvlt
Github user grkvlt closed the pull request at: https://github.com/apache/brooklyn-server/pull/337 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server issue #337: Add config inheritance to customizers key

2016-09-29 Thread grkvlt
Github user grkvlt commented on the issue: https://github.com/apache/brooklyn-server/pull/337 @ahgittin understood; i will work on the change you suggest instead. closing this for now --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] brooklyn-server pull request #358: Allow REST API to return the pinned confi...

2016-09-29 Thread neykov
Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/358#discussion_r81173329 --- Diff: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/catalog/SpecParameterParsingTest.java --- @@ -66,19 +66,20 @@ public

[GitHub] brooklyn-server pull request #358: Allow REST API to return the pinned confi...

2016-09-29 Thread neykov
Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/358#discussion_r81174007 --- Diff: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/catalog/SpecParameterParsingTest.java --- @@ -66,19 +66,20 @@ public

[GitHub] brooklyn-server pull request #358: Allow REST API to return the pinned confi...

2016-09-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/358#discussion_r81181965 --- Diff: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/catalog/SpecParameterParsingTest.java --- @@ -66,19 +66,20 @@ public

[GitHub] brooklyn-server pull request #282: Added attribute to DSL for immediate retu...

2016-09-29 Thread grkvlt
Github user grkvlt closed the pull request at: https://github.com/apache/brooklyn-server/pull/282 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server pull request #358: Allow REST API to return the pinned confi...

2016-09-29 Thread neykov
Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/358#discussion_r81185833 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/domain/EntityConfigSummary.java --- @@ -18,43 +18,82 @@ */ package

[GitHub] brooklyn-server pull request #358: Allow REST API to return the pinned confi...

2016-09-29 Thread neykov
Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/358#discussion_r81185580 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/domain/EntityConfigSummary.java --- @@ -18,43 +18,82 @@ */ package

[GitHub] brooklyn-server pull request #358: Allow REST API to return the pinned confi...

2016-09-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/358#discussion_r81188720 --- Diff: core/src/main/java/org/apache/brooklyn/core/config/BasicConfigKey.java --- @@ -184,7 +192,7 @@ public String getDescription() {

[GitHub] brooklyn-server pull request #358: Allow REST API to return the pinned confi...

2016-09-29 Thread neykov
Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/358#discussion_r81185397 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/domain/EntityConfigSummary.java --- @@ -18,43 +18,82 @@ */ package

[GitHub] brooklyn-server pull request #358: Allow REST API to return the pinned confi...

2016-09-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/358#discussion_r8119 --- Diff: rest/rest-api/src/main/java/org/apache/brooklyn/rest/domain/EntityConfigSummary.java --- @@ -18,43 +18,82 @@ */ package

[GitHub] brooklyn-server issue #358: Allow REST API to return the pinned config key a...

2016-09-29 Thread neykov
Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/358 In summary - looks good. Only concerned about introducing `constraints` which breaks persistence compatibility. Suggest reverting all related changes and making the predicate -> string

[jira] [Resolved] (BROOKLYN-354) Rebind failed (when an NingxController entity's hostname sensor was null)

2016-09-29 Thread Aled Sage (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aled Sage resolved BROOKLYN-354. Resolution: Fixed Fix Version/s: 0.10.0 > Rebind failed (when an NingxController entity's

[jira] [Commented] (BROOKLYN-354) Rebind failed (when an NingxController entity's hostname sensor was null)

2016-09-29 Thread Aled Sage (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533907#comment-15533907 ] Aled Sage commented on BROOKLYN-354: Unit tests merged in

[jira] [Commented] (BROOKLYN-325) Restarting Brooklyn while entity deploying: entity shown as deploying indefinitely

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534122#comment-15534122 ] ASF GitHub Bot commented on BROOKLYN-325: - Github user aledsage commented on the issue:

[jira] [Commented] (BROOKLYN-325) Restarting Brooklyn while entity deploying: entity shown as deploying indefinitely

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534121#comment-15534121 ] ASF GitHub Bot commented on BROOKLYN-325: - Github user aledsage commented on a diff in the pull

[GitHub] brooklyn-server issue #356: BROOKLYN-325 Rebind entity starting

2016-09-29 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/356 @iyovcheva I've added a couple more minor comments. Can you please address those, and then I think this is good to merge! --- If your project is set up for it, you can reply to this email

[GitHub] brooklyn-server issue #356: BROOKLYN-325 Rebind entity starting

2016-09-29 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/356 @neykov any comments you have are much appreciated as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (BROOKLYN-325) Restarting Brooklyn while entity deploying: entity shown as deploying indefinitely

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534125#comment-15534125 ] ASF GitHub Bot commented on BROOKLYN-325: - Github user aledsage commented on the issue:

[GitHub] brooklyn-server issue #355: Reduce decisions for HostAndPort which will be u...

2016-09-29 Thread bostko
Github user bostko commented on the issue: https://github.com/apache/brooklyn-server/pull/355 Code looks more sensible this way and will be very easy to isolate parts of it related with choosing the IP. However testing those is best to be done live with the current code. I

[jira] [Created] (BROOKLYN-355) brooklyn-server's rest-api has a test dependency on brooklyn-ui repo

2016-09-29 Thread Aled Sage (JIRA)
Aled Sage created BROOKLYN-355: -- Summary: brooklyn-server's rest-api has a test dependency on brooklyn-ui repo Key: BROOKLYN-355 URL: https://issues.apache.org/jira/browse/BROOKLYN-355 Project: Brooklyn

Build failed in Jenkins: brooklyn-master-windows #2

2016-09-29 Thread Apache Jenkins Server
See -- Started by user svet [EnvInject] - Loading node environment variables. Building remotely on windows1 (Windows) in workspace > git

[jira] [Created] (BROOKLYN-353) Best-practice for adding endpoints to the REST interface?

2016-09-29 Thread JIRA
Francesco Chicchiriccò created BROOKLYN-353: --- Summary: Best-practice for adding endpoints to the REST interface? Key: BROOKLYN-353 URL: https://issues.apache.org/jira/browse/BROOKLYN-353

[jira] [Commented] (BROOKLYN-353) Best-practice for adding endpoints to the REST interface?

2016-09-29 Thread Andrea Turli (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532206#comment-15532206 ] Andrea Turli commented on BROOKLYN-353: --- Hi [~ilgrosso], I don't think we have any best practice

[GitHub] brooklyn-server issue #359: Utils tidy

2016-09-29 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/359 Build failure is real: missing import for `Maybe` in `Asserts.java`: ``` [ERROR]

[GitHub] brooklyn-server pull request #359: Utils tidy

2016-09-29 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/359#discussion_r81085872 --- Diff: utils/common/src/main/java/org/apache/brooklyn/test/Asserts.java --- @@ -1381,4 +1381,18 @@ public static void assertSize(Iterable list,

[jira] [Commented] (BROOKLYN-353) Best-practice for adding endpoints to the REST interface?

2016-09-29 Thread Svetoslav Neykov (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532288#comment-15532288 ] Svetoslav Neykov commented on BROOKLYN-353: --- That's a good advice from [~andreaturli]. You can

[GitHub] brooklyn-server pull request #359: Utils tidy

2016-09-29 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/359#discussion_r81085479 --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/text/Identifiers.java --- @@ -168,9 +168,11 @@ public static String

[GitHub] brooklyn-server issue #359: Utils tidy

2016-09-29 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/359 LGTM. Build failure must be fixed before merging. Other two comments are extremely minor. Happy for you to merge when you're ready. --- If your project is set up for it, you can reply

[jira] [Commented] (BROOKLYN-353) Best-practice for adding endpoints to the REST interface?

2016-09-29 Thread JIRA
[ https://issues.apache.org/jira/browse/BROOKLYN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532223#comment-15532223 ] Francesco Chicchiriccò commented on BROOKLYN-353: - Hi [~andreaturli] nice to see you

[jira] [Commented] (BROOKLYN-353) Best-practice for adding endpoints to the REST interface?

2016-09-29 Thread Andrea Turli (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532260#comment-15532260 ] Andrea Turli commented on BROOKLYN-353: --- Likewise, [~ilgrosso] Sounds reasonable, but I agree it

[jira] [Commented] (BROOKLYN-353) Best-practice for adding endpoints to the REST interface?

2016-09-29 Thread JIRA
[ https://issues.apache.org/jira/browse/BROOKLYN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532317#comment-15532317 ] Francesco Chicchiriccò commented on BROOKLYN-353: - This sounds interesting, thanks! Is

[jira] [Commented] (BROOKLYN-353) Best-practice for adding endpoints to the REST interface?

2016-09-29 Thread Andrea Turli (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532335#comment-15532335 ] Andrea Turli commented on BROOKLYN-353: --- [~ilgrosso] I guess this may be similar to what

[jira] [Created] (BROOKLYN-354) Rebind failed (when an NingxController entity's hostname sensor was null)

2016-09-29 Thread Aled Sage (JIRA)
Aled Sage created BROOKLYN-354: -- Summary: Rebind failed (when an NingxController entity's hostname sensor was null) Key: BROOKLYN-354 URL: https://issues.apache.org/jira/browse/BROOKLYN-354 Project:

[jira] [Commented] (BROOKLYN-353) Best-practice for adding endpoints to the REST interface?

2016-09-29 Thread Richard Downer (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532346#comment-15532346 ] Richard Downer commented on BROOKLYN-353: - The bad news [~ilgrosso] is that this project is

[jira] [Issue Comment Deleted] (BROOKLYN-353) Best-practice for adding endpoints to the REST interface?

2016-09-29 Thread Svetoslav Neykov (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Svetoslav Neykov updated BROOKLYN-353: -- Comment: was deleted (was: Removing, double post.) > Best-practice for adding

[jira] [Commented] (BROOKLYN-353) Best-practice for adding endpoints to the REST interface?

2016-09-29 Thread JIRA
[ https://issues.apache.org/jira/browse/BROOKLYN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532311#comment-15532311 ] Francesco Chicchiriccò commented on BROOKLYN-353: - It is not only matter of transforming

[jira] [Commented] (BROOKLYN-353) Best-practice for adding endpoints to the REST interface?

2016-09-29 Thread Richard Downer (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532312#comment-15532312 ] Richard Downer commented on BROOKLYN-353: - Francesco, Another alternative is one I've used

[jira] [Commented] (BROOKLYN-353) Best-practice for adding endpoints to the REST interface?

2016-09-29 Thread JIRA
[ https://issues.apache.org/jira/browse/BROOKLYN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532353#comment-15532353 ] Francesco Chicchiriccò commented on BROOKLYN-353: - Cool, I'm looking at it, thanks. >

[jira] [Commented] (BROOKLYN-353) Best-practice for adding endpoints to the REST interface?

2016-09-29 Thread JIRA
[ https://issues.apache.org/jira/browse/BROOKLYN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532351#comment-15532351 ] Francesco Chicchiriccò commented on BROOKLYN-353: - Looks good, thank you very much! One

[GitHub] brooklyn-dist pull request #52: Fix archetype test on Windows.

2016-09-29 Thread neykov
GitHub user neykov opened a pull request: https://github.com/apache/brooklyn-dist/pull/52 Fix archetype test on Windows. Fixes the following test error on windows: ``` [INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-remote-resources-plugin:1.5:process

[jira] [Commented] (BROOKLYN-353) Best-practice for adding endpoints to the REST interface?

2016-09-29 Thread Svetoslav Neykov (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532485#comment-15532485 ] Svetoslav Neykov commented on BROOKLYN-353: --- > Do you have any directions to do this? If you

[jira] [Comment Edited] (BROOKLYN-353) Best-practice for adding endpoints to the REST interface?

2016-09-29 Thread Svetoslav Neykov (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532486#comment-15532486 ] Svetoslav Neykov edited comment on BROOKLYN-353 at 9/29/16 11:10 AM: -

[jira] [Commented] (BROOKLYN-353) Best-practice for adding endpoints to the REST interface?

2016-09-29 Thread Svetoslav Neykov (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532486#comment-15532486 ] Svetoslav Neykov commented on BROOKLYN-353: --- > Do you have any directions to do this? If you

[GitHub] brooklyn-server pull request #358: Allow REST API to return the config key's...

2016-09-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/358#discussion_r81124231 --- Diff: core/src/main/java/org/apache/brooklyn/core/config/BasicConfigKey.java --- @@ -331,12 +337,19 @@ public ConfigInheritance

[GitHub] brooklyn-server pull request #358: Allow REST API to return the config key's...

2016-09-29 Thread neykov
Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/358#discussion_r81124282 --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/transform/EntityTransformer.java --- @@ -162,7 +163,7 @@ public static

[GitHub] brooklyn-server pull request #358: Allow REST API to return the config key's...

2016-09-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/358#discussion_r81124480 --- Diff: core/src/main/java/org/apache/brooklyn/core/config/BasicConfigKey.java --- @@ -331,12 +337,19 @@ public ConfigInheritance

[GitHub] brooklyn-server pull request #356: BROOKLYN-325 Rebind entity starting (init...

2016-09-29 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/356#discussion_r81124706 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/RebindIteration.java --- @@ -687,8 +689,13 @@ protected void manageTheObjects() {

[jira] [Commented] (BROOKLYN-325) Restarting Brooklyn while entity deploying: entity shown as deploying indefinitely

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532651#comment-15532651 ] ASF GitHub Bot commented on BROOKLYN-325: - Github user aledsage commented on a diff in the pull

[GitHub] brooklyn-server pull request #358: Allow REST API to return the config key's...

2016-09-29 Thread neykov
Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/358#discussion_r81124997 --- Diff: core/src/main/java/org/apache/brooklyn/core/config/BasicConfigKey.java --- @@ -331,12 +337,19 @@ public ConfigInheritance

[GitHub] brooklyn-server pull request #358: Allow REST API to return the config key's...

2016-09-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/358#discussion_r81125194 --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/transform/EntityTransformer.java --- @@ -162,7 +163,7 @@ public static

[GitHub] brooklyn-server pull request #358: Allow REST API to return the config key's...

2016-09-29 Thread neykov
Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/358#discussion_r81126063 --- Diff: api/src/main/java/org/apache/brooklyn/api/catalog/CatalogConfig.java --- @@ -34,5 +34,7 @@ * a higher value appears higher in the

[GitHub] brooklyn-server pull request #358: Allow REST API to return the config key's...

2016-09-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/358#discussion_r81126447 --- Diff: api/src/main/java/org/apache/brooklyn/api/catalog/CatalogConfig.java --- @@ -34,5 +34,7 @@ * a higher value appears higher in

[GitHub] brooklyn-server pull request #358: Allow REST API to return the config key's...

2016-09-29 Thread neykov
Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/358#discussion_r81126432 --- Diff: core/src/main/java/org/apache/brooklyn/core/config/BasicConfigKey.java --- @@ -331,12 +337,19 @@ public ConfigInheritance

[jira] [Commented] (BROOKLYN-354) Rebind failed (when an NingxController entity's hostname sensor was null)

2016-09-29 Thread Aled Sage (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532513#comment-15532513 ] Aled Sage commented on BROOKLYN-354: Looking higher up in the log file, I see this the exception

[GitHub] brooklyn-server pull request #360: BROOKLYN-354: Rebind failed (when an Ning...

2016-09-29 Thread aledsage
GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/360 BROOKLYN-354: Rebind failed (when an NingxController entity's hostname sensor was null) As stated in https://issues.apache.org/jira/browse/BROOKLYN-354, the underlying issue was already

[GitHub] brooklyn-dist pull request #52: Fix archetype test on Windows.

2016-09-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-dist/pull/52 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] brooklyn-server issue #360: BROOKLYN-354: Rebind failed (when an NingxContro...

2016-09-29 Thread bostko
Github user bostko commented on the issue: https://github.com/apache/brooklyn-server/pull/360 Looks good! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] brooklyn-server pull request #358: Allow REST API to return the config key's...

2016-09-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/358#discussion_r81123322 --- Diff: api/src/main/java/org/apache/brooklyn/api/catalog/CatalogConfig.java --- @@ -34,5 +34,7 @@ * a higher value appears higher in

[GitHub] brooklyn-docs pull request #113: Improvements to java blueprint docs for OSG...

2016-09-29 Thread neykov
Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/113#discussion_r81114384 --- Diff: guide/java/archetype.md --- @@ -26,11 +26,13 @@ Alternatively, all options can be supplied at the command line. For example, if creating

[GitHub] brooklyn-docs pull request #113: Improvements to java blueprint docs for OSG...

2016-09-29 Thread neykov
Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/113#discussion_r81115064 --- Diff: guide/java/bundle-dependencies.md --- @@ -0,0 +1,118 @@ +--- +title: Handling Bundle Dependencies +layout: website-normal +---

Jenkins build is back to normal : brooklyn-client-master #23

2016-09-29 Thread Apache Jenkins Server
See

[jira] [Commented] (BROOKLYN-354) Rebind failed (when an NingxController entity's hostname sensor was null)

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532540#comment-15532540 ] ASF GitHub Bot commented on BROOKLYN-354: - GitHub user aledsage opened a pull request:

[GitHub] brooklyn-dist issue #52: Fix archetype test on Windows.

2016-09-29 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-dist/pull/52 LGTM; much nicer using the valid URL `extra://brooklyn-sample-extra-repo-url`. Merging now. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] brooklyn-server pull request #358: Allow REST API to return the config key's...

2016-09-29 Thread neykov
Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/358#discussion_r81121259 --- Diff: api/src/main/java/org/apache/brooklyn/api/catalog/CatalogConfig.java --- @@ -34,5 +34,7 @@ * a higher value appears higher in the

[GitHub] brooklyn-server issue #360: BROOKLYN-354: Rebind failed (when an NingxContro...

2016-09-29 Thread ygy
Github user ygy commented on the issue: https://github.com/apache/brooklyn-server/pull/360 All tests are passing. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[jira] [Commented] (BROOKLYN-354) Rebind failed (when an NingxController entity's hostname sensor was null)

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532605#comment-15532605 ] ASF GitHub Bot commented on BROOKLYN-354: - Github user ygy commented on the issue:

[GitHub] brooklyn-server pull request #358: Allow REST API to return the config key's...

2016-09-29 Thread neykov
Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/358#discussion_r81121933 --- Diff: core/src/main/java/org/apache/brooklyn/core/config/BasicConfigKey.java --- @@ -331,12 +337,19 @@ public ConfigInheritance

[GitHub] brooklyn-server pull request #358: Allow REST API to return the config key's...

2016-09-29 Thread neykov
Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/358#discussion_r81122190 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/BasicSpecParameter.java --- @@ -247,17 +248,17 @@ public String toString() {

[GitHub] brooklyn-server pull request #358: Allow REST API to return the config key's...

2016-09-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/358#discussion_r81122326 --- Diff: api/src/main/java/org/apache/brooklyn/api/catalog/CatalogConfig.java --- @@ -34,5 +34,7 @@ * a higher value appears higher in

[GitHub] brooklyn-server pull request #358: Allow REST API to return the config key's...

2016-09-29 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/358#discussion_r81122413 --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/BasicSpecParameter.java --- @@ -247,17 +248,17 @@ public String toString() {

[GitHub] brooklyn-server pull request #358: Allow REST API to return the config key's...

2016-09-29 Thread neykov
Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/358#discussion_r81122524 --- Diff: api/src/main/java/org/apache/brooklyn/api/catalog/CatalogConfig.java --- @@ -34,5 +34,7 @@ * a higher value appears higher in the

[GitHub] brooklyn-server pull request #356: BROOKLYN-325 Rebind entity starting (init...

2016-09-29 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/356#discussion_r81123434 --- Diff: core/src/main/java/org/apache/brooklyn/core/entity/lifecycle/ServiceStateLogic.java --- @@ -153,6 +153,26 @@ private ServiceStateLogic()

[jira] [Commented] (BROOKLYN-325) Restarting Brooklyn while entity deploying: entity shown as deploying indefinitely

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532634#comment-15532634 ] ASF GitHub Bot commented on BROOKLYN-325: - Github user aledsage commented on a diff in the pull

[GitHub] brooklyn-server pull request #356: BROOKLYN-325 Rebind entity starting

2016-09-29 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/356#discussion_r81239092 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/BasicEntityRebindSupport.java --- @@ -237,13 +239,21 @@ protected void

[jira] [Commented] (BROOKLYN-325) Restarting Brooklyn while entity deploying: entity shown as deploying indefinitely

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534113#comment-15534113 ] ASF GitHub Bot commented on BROOKLYN-325: - Github user aledsage commented on a diff in the pull

[GitHub] brooklyn-server pull request #356: BROOKLYN-325 Rebind entity starting

2016-09-29 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/356#discussion_r81239553 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/BasicEntityRebindSupport.java --- @@ -237,13 +239,21 @@ protected void