[GitHub] brooklyn-server pull request #716: Fixing/disabling failing integration test...

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/716 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server issue #715: Feature/http commnand effector improvements

Github user andreaturli commented on the issue: https://github.com/apache/brooklyn-server/pull/715 thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

Build failed in Jenkins: brooklyn-server-master #618

See Changes: [andrea.turli] manage content-type urlencoded [andrea.turli] add javadoc to HttpCommandEffector [andrea.turli] more unit tests [andrea.turli] address @geomacy comments

[GitHub] brooklyn-server pull request #715: Feature/http commnand effector improvemen...

Github user andreaturli commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/715#discussion_r120352362 --- Diff: core/src/main/java/org/apache/brooklyn/core/effector/http/HttpCommandEffector.java --- @@ -88,7 +91,9 @@ public static

[GitHub] brooklyn-server pull request #715: Feature/http commnand effector improvemen...

Github user andreaturli commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/715#discussion_r120353161 --- Diff: core/src/main/java/org/apache/brooklyn/core/effector/http/HttpCommandEffector.java --- @@ -88,7 +91,9 @@ public static

[GitHub] brooklyn-server pull request #715: Feature/http commnand effector improvemen...

Github user andreaturli commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/715#discussion_r120353271 --- Diff: core/src/main/java/org/apache/brooklyn/core/effector/http/HttpCommandEffector.java --- @@ -72,7 +74,8 @@ * It deals with some

[GitHub] brooklyn-server issue #718: WIP - DO NOT MERGE - improve OSGi serialization ...

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/718 currently when xstream writes a reference to a java type it checks whether that class comes from a bundle and if so it prefixes the reference with the bundle name. in the past some things

[GitHub] brooklyn-server issue #718: WIP - DO NOT MERGE - improve OSGi serialization ...

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/718 in `SpecConverter`, if the catalog item ID is set i think that implies the java type so we _could_ skip writing and _should_ ignore it (just use the catalog item ID) when reading. that

[GitHub] brooklyn-server issue #718: WIP - DO NOT MERGE - improve OSGi serialization ...

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/718 we also need a way to fix existing deployments that suffer this problem. any of the above fixes should suffice, but i wonder whether there is a workaround that doesn't involve upgrading

[GitHub] brooklyn-client pull request #53: show bundle info and message when doing `c...

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-client/pull/53 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server issue #672: Bundle uninstall and snapshot

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/672 Thanks @geomacy. Merged https://github.com/apache/brooklyn-client/pull/53 following @Graeme-Miller 's review there but as I'm a go newbie (g00b ?) appreciate any comments you have there.

[GitHub] brooklyn-client issue #53: show bundle info and message when doing `catalog ...

Github user geomacy commented on the issue: https://github.com/apache/brooklyn-client/pull/53 Looks good to me too! Sorry about late review but wouldn't have had any comments anyway :-) --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] brooklyn-server issue #719: Check versionedName to avoid NPE.

Github user geomacy commented on the issue: https://github.com/apache/brooklyn-server/pull/719 Hm, build fails with same error - I can't reproduce that however. I did reproduce the original error, then built everything successfully after making the change above. Odd... --- If your

[GitHub] brooklyn-server issue #719: Check versionedName to avoid NPE.

Github user geomacy commented on the issue: https://github.com/apache/brooklyn-server/pull/719 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] brooklyn-server pull request #604: WIP DO NOT MERGE Fixes to testManuallyAdd...

Github user geomacy closed the pull request at: https://github.com/apache/brooklyn-server/pull/604 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server issue #604: WIP DO NOT MERGE Fixes to testManuallyAdd...

Github user geomacy commented on the issue: https://github.com/apache/brooklyn-server/pull/604 Just going to close this PR, it can be revived when we think it's important to get round to those comments. --- If your project is set up for it, you can reply to this email and have your

Build failed in Jenkins: brooklyn-server-master #617

See Changes: [alex.heneveld] basic support for uninstalling bundle, and sketch of reinstall [alex.heneveld] record the containing bundle for any catalog item / registered type [alex.heneveld] uninstall

[GitHub] brooklyn-server pull request #715: Feature/http commnand effector improvemen...

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/715#discussion_r120345288 --- Diff: core/src/main/java/org/apache/brooklyn/core/effector/http/HttpCommandEffector.java --- @@ -72,7 +74,8 @@ * It deals with some

[GitHub] brooklyn-server pull request #715: Feature/http commnand effector improvemen...

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/715#discussion_r120344061 --- Diff: core/src/main/java/org/apache/brooklyn/core/effector/http/HttpCommandEffector.java --- @@ -88,7 +91,9 @@ public static final

[GitHub] brooklyn-server pull request #715: Feature/http commnand effector improvemen...

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/715#discussion_r120347806 --- Diff: core/src/main/java/org/apache/brooklyn/core/effector/http/HttpCommandEffector.java --- @@ -211,7 +226,7 @@ private HttpRequest

[GitHub] brooklyn-server pull request #715: Feature/http commnand effector improvemen...

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/715#discussion_r12033 --- Diff: core/src/main/java/org/apache/brooklyn/core/effector/http/HttpCommandEffector.java --- @@ -88,7 +91,9 @@ public static final

[GitHub] brooklyn-server pull request #715: Feature/http commnand effector improvemen...

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/715#discussion_r120349310 --- Diff: core/src/test/java/org/apache/brooklyn/core/effector/http/HttpCommandEffectorTest.java --- @@ -248,6 +248,27 @@ public void

[GitHub] brooklyn-server pull request #717: Fix/disable integration tests

GitHub user neykov opened a pull request: https://github.com/apache/brooklyn-server/pull/717 Fix/disable integration tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/neykov/brooklyn-server fix-integration-tests-4

[GitHub] brooklyn-server issue #672: Bundle uninstall and snapshot

Github user geomacy commented on the issue: https://github.com/apache/brooklyn-server/pull/672 Tests all look good, I added test672a.zip to catalog ``` [geoff:] master(+0/-889)* ± br catalog add test672a.zip myTestEnt:0.12.0.SNAPSHOT myOtherTest:0.12.0.SNAPSHOT

[GitHub] brooklyn-server pull request #672: Bundle uninstall and snapshot

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/672 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server pull request #715: Feature/http commnand effector improvemen...

Github user andreaturli commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/715#discussion_r120356395 --- Diff: core/src/test/java/org/apache/brooklyn/core/effector/http/HttpCommandEffectorTest.java --- @@ -248,6 +248,27 @@ public void

[GitHub] brooklyn-server issue #715: Feature/http commnand effector improvements

Github user andreaturli commented on the issue: https://github.com/apache/brooklyn-server/pull/715 @geomacy I think I've addressed all of your comments. please let me know if it is good to merge --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] brooklyn-server pull request #715: Feature/http commnand effector improvemen...

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/715 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server issue #719: Check versionedName to avoid NPE.

Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/719 LGTM, will wait for the tests to pass and merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] brooklyn-server issue #719: Check versionedName to avoid NPE.

Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/719 retest this please, after deleting the workspace --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] brooklyn-server issue #719: Check versionedName to avoid NPE.

Github user geomacy commented on the issue: https://github.com/apache/brooklyn-server/pull/719 Hm very strange - it looks as if the test hasn't pulled the [change](https://github.com/apache/brooklyn-server/pull/719/files#diff-774e93f2e6ad061ee24dbb975abff1d0R174), see

[GitHub] brooklyn-server pull request #719: Check versionedName to avoid NPE.

GitHub user geomacy opened a pull request: https://github.com/apache/brooklyn-server/pull/719 Check versionedName to avoid NPE. Fixes break from https://github.com/apache/brooklyn-server/pull/672, I merged without re-running unit tests :-( You can merge this pull request into a

[GitHub] brooklyn-server pull request #719: Check versionedName to avoid NPE.

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/719 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server issue #719: Check versionedName to avoid NPE.

Github user geomacy commented on the issue: https://github.com/apache/brooklyn-server/pull/719 Looks like it is fetching the apache master instead of the branch from my fork, as below. Note `c545381152a22df29d16c063fd6cd2fab4ec7b33` is my change but it is fetching from ```

Jenkins build is back to normal : brooklyn-server-master #619

See

[GitHub] brooklyn-server issue #719: Check versionedName to avoid NPE.

Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/719 Tests pass locally, merging. Will investigate jenkins issue separately. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If