[GitHub] [incubator-brpc] hairet opened a new issue #678: 关于一致性hash只支持32位key问题

2019-03-04 Thread GitBox
hairet opened a new issue #678: 关于一致性hash只支持32位key问题 URL: https://github.com/apache/incubator-brpc/issues/678 **Describe the bug (描述bug)** 现在https://github.com/apache/incubator-brpc/blob/master/src/brpc/policy/consistent_hashing_load_balancer.cpp里面会有32位hash key限制 ![image](https:

[GitHub] [incubator-brpc] hairet commented on issue #678: 关于一致性hash只支持32位key问题

2019-03-04 Thread GitBox
hairet commented on issue #678: 关于一致性hash只支持32位key问题 URL: https://github.com/apache/incubator-brpc/issues/678#issuecomment-469514797 看了下,是不是因为murmurhash3没有64位版本的问题? This is an automated message from the Apache Git Service. To

[GitHub] [incubator-brpc] chenzhangyi commented on issue #673: 在ConsistentHashingLoadBalancer中某些服务节点可能不会加在HASH环中

2019-03-04 Thread GitBox
chenzhangyi commented on issue #673: 在ConsistentHashingLoadBalancer中某些服务节点可能不会加在HASH环中 URL: https://github.com/apache/incubator-brpc/issues/673#issuecomment-469525572 addressfailedaswell只要这个server还在ns中,就会一直成功 This is an autom

[GitHub] [incubator-brpc] zyearn opened a new pull request #679: Fix CMakeLists.txt of example/auto_concurrency_limiter

2019-03-04 Thread GitBox
zyearn opened a new pull request #679: Fix CMakeLists.txt of example/auto_concurrency_limiter URL: https://github.com/apache/incubator-brpc/pull/679 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-brpc] zyearn commented on issue #672: example/auto_concurrency_limiter/CMakeLists.txt line15 proto file is wrong

2019-03-04 Thread GitBox
zyearn commented on issue #672: example/auto_concurrency_limiter/CMakeLists.txt line15 proto file is wrong URL: https://github.com/apache/incubator-brpc/issues/672#issuecomment-469528156 Fixed in https://github.com/apache/incubator-brpc/pull/679

[GitHub] [incubator-brpc] choleraehyq opened a new issue #680: brpc 是否支持 grpc 的 streaming 模式?

2019-03-06 Thread GitBox
choleraehyq opened a new issue #680: brpc 是否支持 grpc 的 streaming 模式? URL: https://github.com/apache/incubator-brpc/issues/680 从文档看似乎只支持 baidu-rpc 协议的 streaming 模式,但是 baidu-rpc 协议没有 Go 的客户端。 This is an automated message from the

[GitHub] [incubator-brpc] TousakaRin edited a comment on issue #630: 开启Rpcz之后服务FATAL

2019-03-06 Thread GitBox
TousakaRin edited a comment on issue #630: 开启Rpcz之后服务FATAL URL: https://github.com/apache/incubator-brpc/issues/630#issuecomment-468863041 是否可以考虑使用智能指针来避免这个问题,即在每个controller里保存一份parent span的shared_ptr,提交的时候进行析构,让最后一个提交的controller来提交整个trace。 @jamesge

[GitHub] [incubator-brpc] hairet commented on issue #678: 关于一致性hash只支持32位key问题

2019-03-06 Thread GitBox
hairet commented on issue #678: 关于一致性hash只支持32位key问题 URL: https://github.com/apache/incubator-brpc/issues/678#issuecomment-470366685 已经自行基于google cityhash,做了一次Hash128to64来封装解决 This is an automated message from the Apache Git S

[GitHub] [incubator-brpc] TousakaRin closed issue #643: check 失败: CHECK(NULL == _write_head.load(butil::memory_order_relaxed));

2019-03-06 Thread GitBox
TousakaRin closed issue #643: check 失败: CHECK(NULL == _write_head.load(butil::memory_order_relaxed)); URL: https://github.com/apache/incubator-brpc/issues/643 This is an automated message from the Apache Git Service. To res

[GitHub] [incubator-brpc] hairet opened a new issue #681: brpc的baidu协议不支持catch异常,是处于什么考虑

2019-03-07 Thread GitBox
hairet opened a new issue #681: brpc的baidu协议不支持catch异常,是处于什么考虑 URL: https://github.com/apache/incubator-brpc/issues/681 **Is your feature request related to a problem? (你需要的功能是否与某个问题有关?)** 现在有些业务调用一些底层库会抛异常,但是只有thrift等协议会catch,而如果是baidu协议,会一直回溯到完全无关的堆栈再coredump,不利于提示业务分析问题。 **Desc

[GitHub] [incubator-brpc] walterzhaoJR opened a new issue #682: Compile problem

2019-03-10 Thread GitBox
walterzhaoJR opened a new issue #682: Compile problem URL: https://github.com/apache/incubator-brpc/issues/682 **Describe the bug (描述bug)** ![image](https://user-images.githubusercontent.com/22393698/54082492-9b64d780-4351-11e9-88b4-c6b53dafce6f.png) **To Reproduce (复现方法)**

[GitHub] [incubator-brpc] TousakaRin closed pull request #683: Create circuit_breaker.md

2019-03-10 Thread GitBox
TousakaRin closed pull request #683: Create circuit_breaker.md URL: https://github.com/apache/incubator-brpc/pull/683 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [incubator-brpc] TousakaRin opened a new pull request #683: Create circuit_breaker.md

2019-03-10 Thread GitBox
TousakaRin opened a new pull request #683: Create circuit_breaker.md URL: https://github.com/apache/incubator-brpc/pull/683 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-brpc] TousakaRin opened a new pull request #684: add doc for circuit breaker

2019-03-10 Thread GitBox
TousakaRin opened a new pull request #684: add doc for circuit breaker URL: https://github.com/apache/incubator-brpc/pull/684 添加了文档 This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [incubator-brpc] liangjianqun closed issue #671: Client与Server出现网络断开25秒,期间一直无法连接

2019-03-10 Thread GitBox
liangjianqun closed issue #671: Client与Server出现网络断开25秒,期间一直无法连接 URL: https://github.com/apache/incubator-brpc/issues/671 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [incubator-brpc] liangjianqun commented on issue #671: Client与Server出现网络断开25秒,期间一直无法连接

2019-03-10 Thread GitBox
liangjianqun commented on issue #671: Client与Server出现网络断开25秒,期间一直无法连接 URL: https://github.com/apache/incubator-brpc/issues/671#issuecomment-471373567 交换机网络模块有问题 This is an automated message from the Apache Git Service. To resp

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #684: add doc for circuit breaker

2019-03-11 Thread GitBox
jamesge commented on a change in pull request #684: add doc for circuit breaker URL: https://github.com/apache/incubator-brpc/pull/684#discussion_r264182199 ## File path: docs/cn/circuit_breaker.md ## @@ -0,0 +1,62 @@ +# 熔断功能 +当我们发起一个rpc之后,brpc首先会从名字服务(naming service)拿到一个可

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #684: add doc for circuit breaker

2019-03-11 Thread GitBox
jamesge commented on a change in pull request #684: add doc for circuit breaker URL: https://github.com/apache/incubator-brpc/pull/684#discussion_r264181659 ## File path: docs/cn/circuit_breaker.md ## @@ -0,0 +1,62 @@ +# 熔断功能 +当我们发起一个rpc之后,brpc首先会从名字服务(naming service)拿到一个可

[GitHub] [incubator-brpc] leihuxi closed issue #668: 可以支持多进程模型吗

2019-03-11 Thread GitBox
leihuxi closed issue #668: 可以支持多进程模型吗 URL: https://github.com/apache/incubator-brpc/issues/668 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #684: add doc for circuit breaker

2019-03-11 Thread GitBox
zyearn commented on a change in pull request #684: add doc for circuit breaker URL: https://github.com/apache/incubator-brpc/pull/684#discussion_r264505515 ## File path: docs/cn/circuit_breaker.md ## @@ -0,0 +1,62 @@ +# 熔断功能 +当我们发起一个rpc之后,brpc首先会从名字服务(naming service)拿到一个可用

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #684: add doc for circuit breaker

2019-03-11 Thread GitBox
zyearn commented on a change in pull request #684: add doc for circuit breaker URL: https://github.com/apache/incubator-brpc/pull/684#discussion_r264507689 ## File path: docs/cn/circuit_breaker.md ## @@ -0,0 +1,62 @@ +# 熔断功能 +当我们发起一个rpc之后,brpc首先会从名字服务(naming service)拿到一个可用

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #684: add doc for circuit breaker

2019-03-11 Thread GitBox
zyearn commented on a change in pull request #684: add doc for circuit breaker URL: https://github.com/apache/incubator-brpc/pull/684#discussion_r264504536 ## File path: docs/cn/circuit_breaker.md ## @@ -0,0 +1,62 @@ +# 熔断功能 +当我们发起一个rpc之后,brpc首先会从名字服务(naming service)拿到一个可用

[GitHub] [incubator-brpc] jamesge merged pull request #684: add doc for circuit breaker

2019-03-12 Thread GitBox
jamesge merged pull request #684: add doc for circuit breaker URL: https://github.com/apache/incubator-brpc/pull/684 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-brpc] cdjingit opened a new issue #685: Thrift protocol中序列化的请求时,writeStructBegin 和 writeFieldBegin中的服务名和请求的名是固定的。无法定制

2019-03-13 Thread GitBox
cdjingit opened a new issue #685: Thrift protocol中序列化的请求时,writeStructBegin 和 writeFieldBegin中的服务名和请求的名是固定的。无法定制 URL: https://github.com/apache/incubator-brpc/issues/685 **Describe the bug (描述bug)** [如题:] thrift_protocol.cpp的SerializeThriftRequest函数中 ``` char struct_b

[GitHub] [incubator-brpc] cdjingit commented on issue #685: Thrift protocol中序列化的请求时,writeStructBegin 和 writeFieldBegin中的服务名和请求的名是固定的。无法定制

2019-03-13 Thread GitBox
cdjingit commented on issue #685: Thrift protocol中序列化的请求时,writeStructBegin 和 writeFieldBegin中的服务名和请求的名是固定的。无法定制 URL: https://github.com/apache/incubator-brpc/issues/685#issuecomment-472337947 @kenshinxf This is an automated m

[GitHub] [incubator-brpc] yjhjstz opened a new issue #686: bug: _rq is full, capacity=4096

2019-03-13 Thread GitBox
yjhjstz opened a new issue #686: bug: _rq is full, capacity=4096 URL: https://github.com/apache/incubator-brpc/issues/686 **Describe the bug (描述bug)** E0121 00:11:10.885643 22582 task_group_inl.h:88] _rq is full, capacity=4096 连接端口无响应,QPS掉0, cpu掉0 **To Reproduce (复现方法)**

[GitHub] [incubator-brpc] kenshinxf commented on issue #685: Thrift protocol中序列化的请求时,writeStructBegin 和 writeFieldBegin中的服务名和请求的名是固定的。无法定制

2019-03-13 Thread GitBox
kenshinxf commented on issue #685: Thrift protocol中序列化的请求时,writeStructBegin 和 writeFieldBegin中的服务名和请求的名是固定的。无法定制 URL: https://github.com/apache/incubator-brpc/issues/685#issuecomment-472354485 > **Describe the bug (描述bug)** > [如题:] > > thrift_protocol.cpp的SerializeThriftRequest函数中

[GitHub] [incubator-brpc] yjhjstz commented on issue #670: 关于wait_task卡死问题

2019-03-13 Thread GitBox
yjhjstz commented on issue #670: 关于wait_task卡死问题 URL: https://github.com/apache/incubator-brpc/issues/670#issuecomment-472356099 https://github.com/apache/incubator-brpc/issues/686 This is an automated message from the Apache

[GitHub] [incubator-brpc] yjhjstz edited a comment on issue #670: 关于wait_task卡死问题

2019-03-13 Thread GitBox
yjhjstz edited a comment on issue #670: 关于wait_task卡死问题 URL: https://github.com/apache/incubator-brpc/issues/670#issuecomment-472356099 https://github.com/apache/incubator-brpc/issues/686 也是类似 This is an automated message from

[GitHub] [incubator-brpc] cdjingit commented on issue #685: Thrift protocol中序列化的请求时,writeStructBegin 和 writeFieldBegin中的服务名和请求的名是固定的。无法定制

2019-03-13 Thread GitBox
cdjingit commented on issue #685: Thrift protocol中序列化的请求时,writeStructBegin 和 writeFieldBegin中的服务名和请求的名是固定的。无法定制 URL: https://github.com/apache/incubator-brpc/issues/685#issuecomment-472372750 因为有些服务server端的实现不是基于brpc的。比如,我们现在开发brpc支持cassandra thrift, 就有很多不同的方法和请求名称。 这里似乎应该直接调用req->raw

[GitHub] [incubator-brpc] cdjingit edited a comment on issue #685: Thrift protocol中序列化的请求时,writeStructBegin 和 writeFieldBegin中的服务名和请求的名是固定的。无法定制

2019-03-13 Thread GitBox
cdjingit edited a comment on issue #685: Thrift protocol中序列化的请求时,writeStructBegin 和 writeFieldBegin中的服务名和请求的名是固定的。无法定制 URL: https://github.com/apache/incubator-brpc/issues/685#issuecomment-472372750 因为有些服务server端的实现不是基于brpc的。比如,我们现在开发brpc支持cassandra thrift, 就有很多不同的方法和请求名称。 这里似乎应该直接调用r

[GitHub] [incubator-brpc] jamesge commented on issue #685: Thrift protocol中序列化的请求时,writeStructBegin 和 writeFieldBegin中的服务名和请求的名是固定的。无法定制

2019-03-13 Thread GitBox
jamesge commented on issue #685: Thrift protocol中序列化的请求时,writeStructBegin 和 writeFieldBegin中的服务名和请求的名是固定的。无法定制 URL: https://github.com/apache/incubator-brpc/issues/685#issuecomment-472384256 这个struct叫什么无所谓的,你说的是不是多args情况下如何传入的问题 -

[GitHub] [incubator-brpc] jamesge commented on issue #686: bug: _rq is full, capacity=4096

2019-03-13 Thread GitBox
jamesge commented on issue #686: bug: _rq is full, capacity=4096 URL: https://github.com/apache/incubator-brpc/issues/686#issuecomment-472384801 应急的bthread照样可能用光,到时还是类似的问题,“应急”是没法通用的。这里的根本解决方法是让创建bthread处的bthread/pthread阻塞,但改动很大。

[GitHub] [incubator-brpc] cdjingit commented on issue #685: Thrift protocol中序列化的请求时,writeStructBegin 和 writeFieldBegin中的服务名和请求的名是固定的。无法定制

2019-03-13 Thread GitBox
cdjingit commented on issue #685: Thrift protocol中序列化的请求时,writeStructBegin 和 writeFieldBegin中的服务名和请求的名是固定的。无法定制 URL: https://github.com/apache/incubator-brpc/issues/685#issuecomment-472393193 不是多参数的问题,是指序列化到buf的struct名称 和field名称无所谓?不影响server解析?不会吧 --

[GitHub] [incubator-brpc] cdjingit removed a comment on issue #685: Thrift protocol中序列化的请求时,writeStructBegin 和 writeFieldBegin中的服务名和请求的名是固定的。无法定制

2019-03-13 Thread GitBox
cdjingit removed a comment on issue #685: Thrift protocol中序列化的请求时,writeStructBegin 和 writeFieldBegin中的服务名和请求的名是固定的。无法定制 URL: https://github.com/apache/incubator-brpc/issues/685#issuecomment-472393193 不是多参数的问题,是指序列化到buf的struct名称 和field名称无所谓?不影响server解析?不会吧 --

[GitHub] [incubator-brpc] cdjingit commented on issue #685: Thrift protocol中序列化的请求时,writeStructBegin 和 writeFieldBegin中的服务名和请求的名是固定的。无法定制

2019-03-13 Thread GitBox
cdjingit commented on issue #685: Thrift protocol中序列化的请求时,writeStructBegin 和 writeFieldBegin中的服务名和请求的名是固定的。无法定制 URL: https://github.com/apache/incubator-brpc/issues/685#issuecomment-472405405 ok 了解了 所谓半描述的 只要field顺序不变就可以。那就没问题了。多参数的情况,是当作一个struct里的多个fields处理的,没有问题。

[GitHub] [incubator-brpc] cdjingit closed issue #685: Thrift protocol中序列化的请求时,writeStructBegin 和 writeFieldBegin中的服务名和请求的名是固定的。无法定制

2019-03-13 Thread GitBox
cdjingit closed issue #685: Thrift protocol中序列化的请求时,writeStructBegin 和 writeFieldBegin中的服务名和请求的名是固定的。无法定制 URL: https://github.com/apache/incubator-brpc/issues/685 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-brpc] jiansongjay opened a new issue #687: GCC 63, PB 3.0.0, gflag 2.2.0编译出错

2019-03-13 Thread GitBox
jiansongjay opened a new issue #687: GCC 63, PB 3.0.0, gflag 2.2.0编译出错 URL: https://github.com/apache/incubator-brpc/issues/687 如题编译一直出错,附件是make的日志 `/ home//homeapp//appworkspace//workspaceincubator/-incubatorbrpc-/brpcsrc//srcbvar/gflag.cpp:86: undefined reference to `google/:

[GitHub] [incubator-brpc] sige5566 opened a new issue #688: bthread_cond_signal中的一点疑问

2019-03-13 Thread GitBox
sige5566 opened a new issue #688: bthread_cond_signal中的一点疑问 URL: https://github.com/apache/incubator-brpc/issues/688 bthread::CondInternal* ic = reinterpret_cast(c); 如何理解 ic is probably dereferenced after fetch_add, This i

[GitHub] [incubator-brpc] yjhjstz commented on issue #644: bthread_id_join->butex_wait死锁问题

2019-03-13 Thread GitBox
yjhjstz commented on issue #644: bthread_id_join->butex_wait死锁问题 URL: https://github.com/apache/incubator-brpc/issues/644#issuecomment-472702018 >瞬时相同的butex_wait操作大于总线程数的时候 @hairet 是什么意思? This is an automated message fr

[GitHub] [incubator-brpc] zyearn opened a new issue #689: Add switch on/off flag and user-define path to PrometheusMetricsService

2019-03-13 Thread GitBox
zyearn opened a new issue #689: Add switch on/off flag and user-define path to PrometheusMetricsService URL: https://github.com/apache/incubator-brpc/issues/689 1. Add switch on/off flag to PrometheusMetricsService 2. Add user-define path, such as '/brpc_metrics' instead of '/metrics

[GitHub] [incubator-brpc] GardianT commented on issue #649: 支持热点情况下的一致性hash?

2019-03-14 Thread GitBox
GardianT commented on issue #649: 支持热点情况下的一致性hash? URL: https://github.com/apache/incubator-brpc/issues/649#issuecomment-472770219 我来回捞这个问题了。。。我在想这个是不是在说 Rendezvous hashing ? This is an automated message from the Apache Git Se

[GitHub] [incubator-brpc] GardianT commented on issue #649: 支持热点情况下的一致性hash?

2019-03-14 Thread GitBox
GardianT commented on issue #649: 支持热点情况下的一致性hash? URL: https://github.com/apache/incubator-brpc/issues/649#issuecomment-473129356 一致性hash的话,每个server处理的range是不确定的。对于有cache的系统,这样很可能有严重的cache颠簸问题;所以我理解这个问题是在说一致性hash有没有解决cache颠簸问题的比较好的方案 ---

[GitHub] [incubator-brpc] cxxcunow commented on issue #231: cpu profiler 问题

2019-03-15 Thread GitBox
cxxcunow commented on issue #231: cpu profiler 问题 URL: https://github.com/apache/incubator-brpc/issues/231#issuecomment-473219164 你的问题解决了吗?我试验了直接brpc连接,如果再编译example,运行就会报错释放两次内存。后来你怎么弄的? This is an automated message from the A

[GitHub] [incubator-brpc] cxxcunow opened a new issue #690: cpu profile 问题

2019-03-18 Thread GitBox
cxxcunow opened a new issue #690: cpu profile 问题 URL: https://github.com/apache/incubator-brpc/issues/690 直接下载代码,默认参数编译brpc和echo c++的test例子,运行echo_server,报错: Check failed: !internal_init_start_has_run: Heap-check constructor called twice. Perhaps you both linked in the heap checker, and

[GitHub] [incubator-brpc] yanglimingcn opened a new pull request #691: Add Mysql Protocol, only support text protocol now, not support trans…

2019-03-18 Thread GitBox
yanglimingcn opened a new pull request #691: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/691 brpc只支持MySQL 4.1 及之后的版本的文本协议。目前还不支持事务、Prepare statement,未来将会支持。目前支持的鉴权方式为mysql_native_password ---

[GitHub] [incubator-brpc] yanglimingcn closed pull request #691: Add Mysql Protocol, only support text protocol now, not support trans…

2019-03-18 Thread GitBox
yanglimingcn closed pull request #691: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/691 This is an automated message from the Apache Git Service. T

[GitHub] [incubator-brpc] yanglimingcn opened a new pull request #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-03-18 Thread GitBox
yanglimingcn opened a new pull request #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692 Add Mysql Protocol, only support text protocol now, not support transaction, not support prepare statement. issue #2

[GitHub] [incubator-brpc] jamesge merged pull request #679: Fix CMakeLists.txt of example/auto_concurrency_limiter

2019-03-18 Thread GitBox
jamesge merged pull request #679: Fix CMakeLists.txt of example/auto_concurrency_limiter URL: https://github.com/apache/incubator-brpc/pull/679 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-03-18 Thread GitBox
jamesge commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#discussion_r266726972 ## File path: src/brpc/mysql_command.cpp ## @@ -0,0 +1,43 @@ +// Copyrigh

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-03-18 Thread GitBox
jamesge commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#discussion_r266727251 ## File path: src/brpc/mysql_command.cpp ## @@ -0,0 +1,43 @@ +// Copyrigh

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-03-18 Thread GitBox
jamesge commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#discussion_r266726539 ## File path: src/brpc/mysql_command.cpp ## @@ -0,0 +1,43 @@ +// Copyrigh

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-03-18 Thread GitBox
jamesge commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#discussion_r266728338 ## File path: src/brpc/mysql_reply.cpp ## @@ -0,0 +1,740 @@ +#include "br

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-03-18 Thread GitBox
jamesge commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#discussion_r266728291 ## File path: src/brpc/mysql_reply.cpp ## @@ -0,0 +1,740 @@ +#include "br

[GitHub] [incubator-brpc] yanglimingcn commented on issue #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-03-18 Thread GitBox
yanglimingcn commented on issue #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#issuecomment-474212299 @jamesge 好的,你整体看看吧,有什么问题,我到时候集中修改一下。 T

[GitHub] [incubator-brpc] leonwu327 commented on issue #658: client未开启ssl,出现core,调用栈显示在ssl相关函数上。

2019-03-18 Thread GitBox
leonwu327 commented on issue #658: client未开启ssl,出现core,调用栈显示在ssl相关函数上。 URL: https://github.com/apache/incubator-brpc/issues/658#issuecomment-474219457 请问现在这个问题有知道是什么原因了吗@old-bear?我们的环境中也出现了同样的问题,堆栈是一样的。core的时候没有其他的错误打印,只有两个CHECK信息: Check failed: NULL == _write_head.load(butil::memory_ord

[GitHub] [incubator-brpc] leonwu327 commented on issue #658: client未开启ssl,出现core,调用栈显示在ssl相关函数上。

2019-03-19 Thread GitBox
leonwu327 commented on issue #658: client未开启ssl,出现core,调用栈显示在ssl相关函数上。 URL: https://github.com/apache/incubator-brpc/issues/658#issuecomment-474241803 > fd=-1,Fail to read from fd=2797 SocketId=17179872856@10.89.53.21:9992@27623: Connection reset by peer" > 应该是链接被关闭后,不知道怎么又触发write了,我内部看下

[GitHub] [incubator-brpc] yanglimingcn commented on issue #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-03-19 Thread GitBox
yanglimingcn commented on issue #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#issuecomment-474671681 上边提到的问题已做修改,并且改了一点bug This is an autom

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-03-20 Thread GitBox
jamesge commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#discussion_r267204181 ## File path: src/brpc/mysql.cpp ## @@ -0,0 +1,508 @@ +// Copyright (c) 2

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-03-20 Thread GitBox
jamesge commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#discussion_r267206654 ## File path: src/brpc/policy/mysql_protocol.cpp ## @@ -0,0 +1,237 @@ +//

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-03-20 Thread GitBox
jamesge commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#discussion_r267203582 ## File path: src/brpc/socket.cpp ## @@ -1523,7 +1523,7 @@ int Socket::Wr

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-03-20 Thread GitBox
jamesge commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#discussion_r267206377 ## File path: src/brpc/mysql.cpp ## @@ -0,0 +1,508 @@ +// Copyright (c) 2

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-03-20 Thread GitBox
jamesge commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#discussion_r267203881 ## File path: src/brpc/mysql.h ## @@ -0,0 +1,187 @@ +// Copyright (c) 201

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-03-20 Thread GitBox
jamesge commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#discussion_r267205848 ## File path: src/brpc/mysql_command.cpp ## @@ -0,0 +1,45 @@ +// Copyrigh

[GitHub] [incubator-brpc] jamesge commented on issue #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-03-20 Thread GitBox
jamesge commented on issue #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#issuecomment-474713864 这里的基本问题还是mysql中response是怎么和request对上的, 如果有id,那就是通过correlation_id机制;如果是靠server端保证对一个request一定会回一个response(类似r

[GitHub] [incubator-brpc] jamesge edited a comment on issue #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-03-20 Thread GitBox
jamesge edited a comment on issue #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#issuecomment-474713864 这里的基本问题还是mysql中reply是怎么和command对上的, 如果有id,那就是通过correlation_id机制;如果是靠server端保证对一个command一定会回一个reply(类似

[GitHub] [incubator-brpc] jamesge edited a comment on issue #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-03-20 Thread GitBox
jamesge edited a comment on issue #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#issuecomment-474713864 这里的基本问题还是mysql中reply是怎么和command对上的, 如果有id,那就是通过correlation_id机制;如果是靠server端保证对一个command一定会回一个reply(类似

[GitHub] [incubator-brpc] jamesge edited a comment on issue #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-03-20 Thread GitBox
jamesge edited a comment on issue #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#issuecomment-474713864 这里的基本问题还是mysql中reply是怎么和command对上的, 如果有id,那就是通过correlation_id机制;如果是靠server端保证对一个command一定会回一个reply(类似

[GitHub] [incubator-brpc] DreamTeamWangbowen opened a new issue #693: brpc have not similiar pthread_detach? thread_join() is blocked

2019-03-20 Thread GitBox
DreamTeamWangbowen opened a new issue #693: brpc have not similiar pthread_detach? thread_join() is blocked URL: https://github.com/apache/incubator-brpc/issues/693 brpc have not similiar pthread_detach? thread_join() is blocked. I want to the current thread exit and free resource. f

[GitHub] [incubator-brpc] DreamTeamWangbowen commented on issue #693: brpc have not similiar pthread_detach? thread_join() is blocked

2019-03-20 Thread GitBox
DreamTeamWangbowen commented on issue #693: brpc have not similiar pthread_detach? thread_join() is blocked URL: https://github.com/apache/incubator-brpc/issues/693#issuecomment-474771920 @jamesge This is an automated messa

[GitHub] [incubator-brpc] zyearn opened a new pull request #694: Health check by rpc call

2019-03-20 Thread GitBox
zyearn opened a new pull request #694: Health check by rpc call URL: https://github.com/apache/incubator-brpc/pull/694 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #694: Health check by rpc call

2019-03-20 Thread GitBox
zyearn commented on a change in pull request #694: Health check by rpc call URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r267273523 ## File path: src/brpc/channel.cpp ## @@ -281,6 +281,15 @@ int Channel::Init(butil::EndPoint server_addr_and_port, r

[GitHub] [incubator-brpc] jamesge commented on issue #693: brpc have not similiar pthread_detach? thread_join() is blocked

2019-03-20 Thread GitBox
jamesge commented on issue #693: brpc have not similiar pthread_detach? thread_join() is blocked URL: https://github.com/apache/incubator-brpc/issues/693#issuecomment-474777255 bthreads are "detached" by default and joined or not-joined freely decided by users. You can perfectly start a b

[GitHub] [incubator-brpc] yanglimingcn commented on issue #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-03-20 Thread GitBox
yanglimingcn commented on issue #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#issuecomment-474778616 对,现在一个request里面可以写多个命令,用逗号分割,一个request对应一个response,response里面会有多个reply,每个reply对应一个命令的结果。现在的问题是连接在single

[GitHub] [incubator-brpc] yanglimingcn commented on issue #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-03-20 Thread GitBox
yanglimingcn commented on issue #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#issuecomment-474781405 mysql没有correlation_id机制,需要通过pipelined_count机制,但是如果一次执行10个命令,都执行成功了会有10个回复,如果有1个命令执行失败,那么后边的命令就不会有返回,返回的

[GitHub] [incubator-brpc] yanglimingcn commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-03-20 Thread GitBox
yanglimingcn commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#discussion_r267283363 ## File path: src/brpc/socket.cpp ## @@ -1523,7 +1523,7 @@ int Socke

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-03-20 Thread GitBox
jamesge commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#discussion_r267284976 ## File path: src/brpc/socket.cpp ## @@ -1523,7 +1523,7 @@ int Socket::Wr

[GitHub] [incubator-brpc] jamesge commented on issue #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-03-20 Thread GitBox
jamesge commented on issue #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#issuecomment-474786548 > 对,现在一个request里面可以写多个命令,用逗号分割,一个request对应一个response,response里面会有多个reply,每个reply对应一个命令的结果。现在的问题是连接在single模式下

[GitHub] [incubator-brpc] kevinmgyu opened a new issue #695: gflags(2.1.2-3),g++( 4:5.3.1-1ubuntu1) protobuf( 2.6.1-1.3) Linux make编译错误

2019-03-20 Thread GitBox
kevinmgyu opened a new issue #695: gflags(2.1.2-3),g++( 4:5.3.1-1ubuntu1) protobuf( 2.6.1-1.3) Linux make编译错误 URL: https://github.com/apache/incubator-brpc/issues/695 **Describe the bug (描述bug)** home/ubuntu/kevinmgyu/brpc/src/butil/logging.cc:1388: undefined reference to `google::Regis

[GitHub] [incubator-brpc] yanglimingcn commented on issue #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-03-20 Thread GitBox
yanglimingcn commented on issue #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#issuecomment-474809840 好的,那我就按照不支持single模式的方式调整。 This is an a

[GitHub] [incubator-brpc] DreamTeamWangbowen commented on issue #693: brpc have not similiar pthread_detach? thread_join() is blocked

2019-03-20 Thread GitBox
DreamTeamWangbowen commented on issue #693: brpc have not similiar pthread_detach? thread_join() is blocked URL: https://github.com/apache/incubator-brpc/issues/693#issuecomment-475089791 > bthreads are "detached" by default and joined or not-joined freely decided by users. You can perfec

[GitHub] [incubator-brpc] DreamTeamWangbowen removed a comment on issue #693: brpc have not similiar pthread_detach? thread_join() is blocked

2019-03-20 Thread GitBox
DreamTeamWangbowen removed a comment on issue #693: brpc have not similiar pthread_detach? thread_join() is blocked URL: https://github.com/apache/incubator-brpc/issues/693#issuecomment-475089791 > bthreads are "detached" by default and joined or not-joined freely decided by users. You ca

[GitHub] [incubator-brpc] DreamTeamWangbowen closed issue #693: brpc have not similiar pthread_detach? thread_join() is blocked

2019-03-20 Thread GitBox
DreamTeamWangbowen closed issue #693: brpc have not similiar pthread_detach? thread_join() is blocked URL: https://github.com/apache/incubator-brpc/issues/693 This is an automated message from the Apache Git Service. To res

[GitHub] [incubator-brpc] DreamTeamWangbowen commented on issue #693: brpc have not similiar pthread_detach? thread_join() is blocked

2019-03-20 Thread GitBox
DreamTeamWangbowen commented on issue #693: brpc have not similiar pthread_detach? thread_join() is blocked URL: https://github.com/apache/incubator-brpc/issues/693#issuecomment-475089915 oh,thank you very much,I misunderstand... ---

[GitHub] [incubator-brpc] DreamTeamWangbowen opened a new issue #693: brpc have not similiar pthread_detach? thread_join() is blocked

2019-03-20 Thread GitBox
DreamTeamWangbowen opened a new issue #693: brpc have not similiar pthread_detach? thread_join() is blocked URL: https://github.com/apache/incubator-brpc/issues/693 brpc have not similiar pthread_detach? thread_join() is blocked. I want to the current thread exit and free resource. f

[GitHub] [incubator-brpc] DreamTeamWangbowen commented on issue #693: brpc have not similiar pthread_detach? thread_join() is blocked

2019-03-20 Thread GitBox
DreamTeamWangbowen commented on issue #693: brpc have not similiar pthread_detach? thread_join() is blocked URL: https://github.com/apache/incubator-brpc/issues/693#issuecomment-475090132 > bthreads are "detached" by default and joined or not-joined freely decided by users. You can perfec

[GitHub] [incubator-brpc] DreamTeamWangbowen removed a comment on issue #693: brpc have not similiar pthread_detach? thread_join() is blocked

2019-03-20 Thread GitBox
DreamTeamWangbowen removed a comment on issue #693: brpc have not similiar pthread_detach? thread_join() is blocked URL: https://github.com/apache/incubator-brpc/issues/693#issuecomment-475089915 oh,thank you very much,I misunderstand... ---

[GitHub] [incubator-brpc] xuxiping opened a new issue #696: nameservice can't select server

2019-03-20 Thread GitBox
xuxiping opened a new issue #696: nameservice can't select server URL: https://github.com/apache/incubator-brpc/issues/696 **Describe the bug (描述bug)** nameservice can't select server after modify system time. **To Reproduce (复现方法)** modify system time.

[GitHub] [incubator-brpc] kevinmgyu commented on issue #695: gflags(2.1.2-3),g++( 4:5.3.1-1ubuntu1) protobuf( 2.6.1-1.3) Linux make编译错误

2019-03-20 Thread GitBox
kevinmgyu commented on issue #695: gflags(2.1.2-3),g++( 4:5.3.1-1ubuntu1) protobuf( 2.6.1-1.3) Linux make编译错误 URL: https://github.com/apache/incubator-brpc/issues/695#issuecomment-475103530 项目没人维护了吗 This is an automated messa

[GitHub] [incubator-brpc] kevinmgyu commented on issue #695: gflags(2.1.2-3),g++( 4:5.3.1-1ubuntu1) protobuf( 2.6.1-1.3) Linux make编译错误

2019-03-20 Thread GitBox
kevinmgyu commented on issue #695: gflags(2.1.2-3),g++( 4:5.3.1-1ubuntu1) protobuf( 2.6.1-1.3) Linux make编译错误 URL: https://github.com/apache/incubator-brpc/issues/695#issuecomment-475106478 cmake编译也报类似错误 [ 95%] Linking CXX executable ../output/bin/protoc-gen-mcpack /usr/bin/cmake: /us

[GitHub] [incubator-brpc] jamesge commented on issue #696: nameservice can't select server

2019-03-20 Thread GitBox
jamesge commented on issue #696: nameservice can't select server URL: https://github.com/apache/incubator-brpc/issues/696#issuecomment-475120794 什么nameservice? This is an automated message from the Apache Git Service. To respo

[GitHub] [incubator-brpc] chenzhangyi commented on issue #695: gflags(2.1.2-3),g++( 4:5.3.1-1ubuntu1) protobuf( 2.6.1-1.3) Linux make编译错误

2019-03-21 Thread GitBox
chenzhangyi commented on issue #695: gflags(2.1.2-3),g++( 4:5.3.1-1ubuntu1) protobuf( 2.6.1-1.3) Linux make编译错误 URL: https://github.com/apache/incubator-brpc/issues/695#issuecomment-475134215 检查下你的环境里面是不是有多个不同版本的gflags This i

[GitHub] [incubator-brpc] chenzhangyi commented on issue #682: Compile problem

2019-03-21 Thread GitBox
chenzhangyi commented on issue #682: Compile problem URL: https://github.com/apache/incubator-brpc/issues/682#issuecomment-475134544 先使用protobuf3.6或者更低的版本 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-brpc] scottzzq commented on issue #165: 在brpc接口内部core,但是使用gdb分析时遇到问题

2019-03-21 Thread GitBox
scottzzq commented on issue #165: 在brpc接口内部core,但是使用gdb分析时遇到问题 URL: https://github.com/apache/incubator-brpc/issues/165#issuecomment-475149777 我也遇到类似的问题,跟了一下gcc5.2源码 ![image](https://user-images.githubusercontent.com/1217132/54741088-4601b380-4bf8-11e9-8e1f-36d927b850ee.png) 这个地方 fs.

[GitHub] [incubator-brpc] scottzzq commented on issue #165: 在brpc接口内部core,但是使用gdb分析时遇到问题

2019-03-21 Thread GitBox
scottzzq commented on issue #165: 在brpc接口内部core,但是使用gdb分析时遇到问题 URL: https://github.com/apache/incubator-brpc/issues/165#issuecomment-475150739 执行到brpc内部挂掉: #0 0x7f0621a605f7 in raise () from /usr/lib64/libc.so.6 #1 0x7f0621a61ce8 in abort () from /usr/lib64/libc.so.6 #2 0

[GitHub] [incubator-brpc] kevinmgyu commented on issue #695: gflags(2.1.2-3),g++( 4:5.3.1-1ubuntu1) protobuf( 2.6.1-1.3) Linux make编译错误

2019-03-21 Thread GitBox
kevinmgyu commented on issue #695: gflags(2.1.2-3),g++( 4:5.3.1-1ubuntu1) protobuf( 2.6.1-1.3) Linux make编译错误 URL: https://github.com/apache/incubator-brpc/issues/695#issuecomment-475200414 没有呀,只有一个gflags This is an automated

[GitHub] [incubator-brpc] kevinmgyu commented on issue #695: gflags(2.1.2-3),g++( 4:5.3.1-1ubuntu1) protobuf( 2.6.1-1.3) Linux make编译错误

2019-03-21 Thread GitBox
kevinmgyu commented on issue #695: gflags(2.1.2-3),g++( 4:5.3.1-1ubuntu1) protobuf( 2.6.1-1.3) Linux make编译错误 URL: https://github.com/apache/incubator-brpc/issues/695#issuecomment-475200554 > 检查下你的环境里面是不是有多个不同版本的gflags 没有呀,只有一个gflags -

[GitHub] [incubator-brpc] cuisonghui opened a new issue #697: 客户端出现大量timeout

2019-03-21 Thread GitBox
cuisonghui opened a new issue #697: 客户端出现大量timeout URL: https://github.com/apache/incubator-brpc/issues/697 search() leaf error:host:*.bj,port:8104,brpc status code:1008,brpc error message:[E1008]Reached timeout=3000ms @10.162.10.51:8104,query:穿越时空之妃不能忍 timecost:3001 latency:3001291

[GitHub] [incubator-brpc] jamesge commented on issue #697: 客户端出现大量timeout

2019-03-21 Thread GitBox
jamesge commented on issue #697: 客户端出现大量timeout URL: https://github.com/apache/incubator-brpc/issues/697#issuecomment-475267029 先按[这个](https://github.com/apache/incubator-brpc/blob/master/docs/cn/server_debugging.md)排查一下 This

[GitHub] [incubator-brpc] kevinmgyu commented on issue #695: gflags(2.1.2-3),g++( 4:5.3.1-1ubuntu1) protobuf( 2.6.1-1.3) Linux make编译错误

2019-03-21 Thread GitBox
kevinmgyu commented on issue #695: gflags(2.1.2-3),g++( 4:5.3.1-1ubuntu1) protobuf( 2.6.1-1.3) Linux make编译错误 URL: https://github.com/apache/incubator-brpc/issues/695#issuecomment-475477445 root@VM-0-12-ubuntu:/usr/lib/x86_64-linux-gnu# find / -name libgflags.a /usr/lib/x86_64-linux-gnu/

  1   2   3   4   5   6   7   8   9   10   >