[GitHub] [incubator-brpc] jamesge commented on issue #710: add NOTICE.txt to address copyright

2019-04-02 Thread GitBox
jamesge commented on issue #710: add NOTICE.txt to address copyright URL: https://github.com/apache/incubator-brpc/pull/710#issuecomment-478894079 Thanks for the explanation, however the first question remains: why there's an additional ".txt" extension to "NOTICE"

[GitHub] [incubator-brpc] jamesge commented on issue #714: 如何使用channel?

2019-04-02 Thread GitBox
jamesge commented on issue #714: 如何使用channel? URL: https://github.com/apache/incubator-brpc/issues/714#issuecomment-478916248 举个例子具体描述一下你提到的"混乱"吧,包括协议、连接方式、版本等重要信息。 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-brpc] haolujun edited a comment on issue #714: 如何使用channel?

2019-04-02 Thread GitBox
haolujun edited a comment on issue #714: 如何使用channel? URL: https://github.com/apache/incubator-brpc/issues/714#issuecomment-478920017 HI: 大神,我刚刚看了一下以往的issue,发现了这个,https://github.com/apache/incubator-brpc/issues/454 ,我应该是和这里面一样的问题。已经知道怎么解决了,多谢!!!

[GitHub] [incubator-brpc] tanzhongyibidu commented on issue #710: add NOTICE.txt to address copyright

2019-04-02 Thread GitBox
tanzhongyibidu commented on issue #710: add NOTICE.txt to address copyright URL: https://github.com/apache/incubator-brpc/pull/710#issuecomment-478887075 Hi, gejun, Let me explain it in more details: 1. The LICENSE file located under the root of repo, should mention its

[GitHub] [incubator-brpc] tanzhongyibidu commented on issue #710: add NOTICE.txt to address copyright

2019-04-02 Thread GitBox
tanzhongyibidu commented on issue #710: add NOTICE.txt to address copyright URL: https://github.com/apache/incubator-brpc/pull/710#issuecomment-478900416 名字叫NOTICE,这是需要的,至于有的叫NOTICE.txt,有的叫NOTICE,都可以。 要不我改成NOTICE? This is

[GitHub] [incubator-brpc] tanzhongyibidu commented on issue #710: add NOTICE.txt to address copyright

2019-04-02 Thread GitBox
tanzhongyibidu commented on issue #710: add NOTICE.txt to address copyright URL: https://github.com/apache/incubator-brpc/pull/710#issuecomment-478917275 BTW: I add another file named Disclaimer, when I update the diff, it is merged automatically.

[GitHub] [incubator-brpc] jamesge commented on issue #710: add NOTICE.txt to address copyright

2019-04-02 Thread GitBox
jamesge commented on issue #710: add NOTICE.txt to address copyright URL: https://github.com/apache/incubator-brpc/pull/710#issuecomment-478915447 ok,保持一致吧 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-brpc] haolujun opened a new issue #714: 如何使用channel?

2019-04-02 Thread GitBox
haolujun opened a new issue #714: 如何使用channel? URL: https://github.com/apache/incubator-brpc/issues/714 HI : 当我并发请求同一个IP和端口后,结果经常会混乱。我每次请求都是用不同的channel。请问一下大神,我如何才能保证两次请求的结果不混乱呢?需要用connection_group?

[GitHub] [incubator-brpc] haolujun commented on issue #714: 如何使用channel?

2019-04-02 Thread GitBox
haolujun commented on issue #714: 如何使用channel? URL: https://github.com/apache/incubator-brpc/issues/714#issuecomment-478920017 HI: 大神,我刚刚看了一下以往的issue,发现了这个,https://github.com/apache/incubator-brpc/issues/454,我应该是和这里面一样的问题。已经知道怎么解决了,多谢!!!

[GitHub] [incubator-brpc] yanglimingcn commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-03-29 Thread GitBox
yanglimingcn commented on a change in pull request #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#discussion_r270436885 ## File path: src/brpc/mysql.cpp ## @@ -0,0 +1,516 @@ +// Copyright

[GitHub] [incubator-brpc] jamesge commented on issue #711: How to implement interceptor(or middleware)-like functionality before or after each rpc call?

2019-03-31 Thread GitBox
jamesge commented on issue #711: How to implement interceptor(or middleware)-like functionality before or after each rpc call? URL: https://github.com/apache/incubator-brpc/issues/711#issuecomment-478434454 [client-side

[GitHub] [incubator-brpc] zyearn commented on issue #715: http2 / grpc问题

2019-04-02 Thread GitBox
zyearn commented on issue #715: http2 / grpc问题 URL: https://github.com/apache/incubator-brpc/issues/715#issuecomment-479333074 原因:目前brpc client的h2setting是和req一起发过去的,这时用的是默认大小,如果超过这个值,就发不出去,那么client的h2setting也发不出去,server端的h2setting也不会回复给client,server端的window size就不能传到client

[GitHub] [incubator-brpc] yjhjstz commented on issue #715: http2 / grpc问题

2019-04-02 Thread GitBox
yjhjstz commented on issue #715: http2 / grpc问题 URL: https://github.com/apache/incubator-brpc/issues/715#issuecomment-479340643 server端是 grpc 服务,怎么改动windowsize? This is an automated message from the Apache Git Service. To

[GitHub] [incubator-brpc] yjhjstz commented on issue #715: http2 / grpc问题

2019-04-02 Thread GitBox
yjhjstz commented on issue #715: http2 / grpc问题 URL: https://github.com/apache/incubator-brpc/issues/715#issuecomment-479309302 @zyearn This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-brpc] yjhjstz opened a new issue #715: http2 / grpc问题

2019-04-02 Thread GitBox
yjhjstz opened a new issue #715: http2 / grpc问题 URL: https://github.com/apache/incubator-brpc/issues/715 **Describe the bug (描述bug)** [E2004]remote_window_left is not enough, data_size=629370 [R1][E2004]remote_window_left is not enough, data_size=629370 **To Reproduce (复现方法)**

[GitHub] [incubator-brpc] miniframework opened a new issue #716: Socket::Address 求教

2019-04-02 Thread GitBox
miniframework opened a new issue #716: Socket::Address 求教 URL: https://github.com/apache/incubator-brpc/issues/716 hi 能解释一下Address 里面的version ABA,version +1, version +2, version -1 的场景和为什么,设计原理?,这确实没看懂 尤其 if (nref > 1),if ((ver2 & 1)) if (ver1 == ver2 || ver1 + 1 == ver2)

[GitHub] [incubator-brpc] zyearn commented on issue #715: http2 / grpc问题

2019-04-02 Thread GitBox
zyearn commented on issue #715: http2 / grpc问题 URL: https://github.com/apache/incubator-brpc/issues/715#issuecomment-479346126 这个你要看grpc的文档了 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-brpc] zyearn opened a new pull request #717: Revive from all server failed

2019-04-03 Thread GitBox
zyearn opened a new pull request #717: Revive from all server failed URL: https://github.com/apache/incubator-brpc/pull/717 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-brpc] DreamTeamWangbowen commented on issue #693: brpc have not similiar pthread_detach? thread_join() is blocked

2019-03-20 Thread GitBox
DreamTeamWangbowen commented on issue #693: brpc have not similiar pthread_detach? thread_join() is blocked URL: https://github.com/apache/incubator-brpc/issues/693#issuecomment-475089791 > bthreads are "detached" by default and joined or not-joined freely decided by users. You can

[GitHub] [incubator-brpc] DreamTeamWangbowen closed issue #693: brpc have not similiar pthread_detach? thread_join() is blocked

2019-03-20 Thread GitBox
DreamTeamWangbowen closed issue #693: brpc have not similiar pthread_detach? thread_join() is blocked URL: https://github.com/apache/incubator-brpc/issues/693 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-brpc] kevinmgyu commented on issue #695: gflags(2.1.2-3),g++( 4:5.3.1-1ubuntu1) protobuf( 2.6.1-1.3) Linux make编译错误

2019-03-20 Thread GitBox
kevinmgyu commented on issue #695: gflags(2.1.2-3),g++( 4:5.3.1-1ubuntu1) protobuf( 2.6.1-1.3) Linux make编译错误 URL: https://github.com/apache/incubator-brpc/issues/695#issuecomment-475103530 项目没人维护了吗 This is an automated

[GitHub] [incubator-brpc] DreamTeamWangbowen commented on issue #693: brpc have not similiar pthread_detach? thread_join() is blocked

2019-03-20 Thread GitBox
DreamTeamWangbowen commented on issue #693: brpc have not similiar pthread_detach? thread_join() is blocked URL: https://github.com/apache/incubator-brpc/issues/693#issuecomment-475089915 oh,thank you very much,I misunderstand...

[GitHub] [incubator-brpc] DreamTeamWangbowen opened a new issue #693: brpc have not similiar pthread_detach? thread_join() is blocked

2019-03-20 Thread GitBox
DreamTeamWangbowen opened a new issue #693: brpc have not similiar pthread_detach? thread_join() is blocked URL: https://github.com/apache/incubator-brpc/issues/693 brpc have not similiar pthread_detach? thread_join() is blocked. I want to the current thread exit and free resource.

[GitHub] [incubator-brpc] DreamTeamWangbowen commented on issue #693: brpc have not similiar pthread_detach? thread_join() is blocked

2019-03-20 Thread GitBox
DreamTeamWangbowen commented on issue #693: brpc have not similiar pthread_detach? thread_join() is blocked URL: https://github.com/apache/incubator-brpc/issues/693#issuecomment-475090132 > bthreads are "detached" by default and joined or not-joined freely decided by users. You can

[GitHub] [incubator-brpc] DreamTeamWangbowen removed a comment on issue #693: brpc have not similiar pthread_detach? thread_join() is blocked

2019-03-20 Thread GitBox
DreamTeamWangbowen removed a comment on issue #693: brpc have not similiar pthread_detach? thread_join() is blocked URL: https://github.com/apache/incubator-brpc/issues/693#issuecomment-475089915 oh,thank you very much,I misunderstand...

[GitHub] [incubator-brpc] xuxiping opened a new issue #696: nameservice can't select server

2019-03-20 Thread GitBox
xuxiping opened a new issue #696: nameservice can't select server URL: https://github.com/apache/incubator-brpc/issues/696 **Describe the bug (描述bug)** nameservice can't select server after modify system time. **To Reproduce (复现方法)** modify system time.

[GitHub] [incubator-brpc] kevinmgyu commented on issue #695: gflags(2.1.2-3),g++( 4:5.3.1-1ubuntu1) protobuf( 2.6.1-1.3) Linux make编译错误

2019-03-20 Thread GitBox
kevinmgyu commented on issue #695: gflags(2.1.2-3),g++( 4:5.3.1-1ubuntu1) protobuf( 2.6.1-1.3) Linux make编译错误 URL: https://github.com/apache/incubator-brpc/issues/695#issuecomment-475106478 cmake编译也报类似错误 [ 95%] Linking CXX executable ../output/bin/protoc-gen-mcpack /usr/bin/cmake:

[GitHub] [incubator-brpc] jamesge commented on issue #696: nameservice can't select server

2019-03-21 Thread GitBox
jamesge commented on issue #696: nameservice can't select server URL: https://github.com/apache/incubator-brpc/issues/696#issuecomment-475120794 什么nameservice? This is an automated message from the Apache Git Service. To

[GitHub] [incubator-brpc] chenzhangyi commented on issue #682: Compile problem

2019-03-21 Thread GitBox
chenzhangyi commented on issue #682: Compile problem URL: https://github.com/apache/incubator-brpc/issues/682#issuecomment-475134544 先使用protobuf3.6或者更低的版本 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-brpc] chenzhangyi commented on issue #695: gflags(2.1.2-3),g++( 4:5.3.1-1ubuntu1) protobuf( 2.6.1-1.3) Linux make编译错误

2019-03-21 Thread GitBox
chenzhangyi commented on issue #695: gflags(2.1.2-3),g++( 4:5.3.1-1ubuntu1) protobuf( 2.6.1-1.3) Linux make编译错误 URL: https://github.com/apache/incubator-brpc/issues/695#issuecomment-475134215 检查下你的环境里面是不是有多个不同版本的gflags This

[GitHub] [incubator-brpc] reachfish commented on issue #699: Fail to select server from list

2019-03-25 Thread GitBox
reachfish commented on issue #699: Fail to select server from list URL: https://github.com/apache/incubator-brpc/issues/699#issuecomment-476446499 使用rr算法跑了两天,目前为止没有报这种问题 This is an automated message from the Apache Git

[GitHub] [incubator-brpc] liupengs closed pull request #702: fix a typo in bthread.h.

2019-03-25 Thread GitBox
liupengs closed pull request #702: fix a typo in bthread.h. URL: https://github.com/apache/incubator-brpc/pull/702 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-brpc] liupengs opened a new pull request #702: fix a typo in bthread.h.

2019-03-25 Thread GitBox
liupengs opened a new pull request #702: fix a typo in bthread.h. URL: https://github.com/apache/incubator-brpc/pull/702 fix a typo in bthread.h. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-brpc] darrenwang00 commented on issue #698: Fail to find protoc

2019-03-25 Thread GitBox
darrenwang00 commented on issue #698: Fail to find protoc URL: https://github.com/apache/incubator-brpc/issues/698#issuecomment-476457980 > try this: sh config_brpc.sh --headers=/usr/include --libs="/usr/lib64 /usr/bin/" ok , make success

[GitHub] [incubator-brpc] Xavier1994 opened a new issue #704: [grpc-java-client] grpc java client call brpc server get INTERNAL: HTTP/2 error code: FLOW_CONTROL_ERROR

2019-03-27 Thread GitBox
Xavier1994 opened a new issue #704: [grpc-java-client] grpc java client call brpc server get INTERNAL: HTTP/2 error code: FLOW_CONTROL_ERROR URL: https://github.com/apache/incubator-brpc/issues/704 **Describe the bug (描述bug)** I use a grpc-java-client to call brpc server, And I just

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #694: Health check by rpc call

2019-03-27 Thread GitBox
jamesge commented on a change in pull request #694: Health check by rpc call URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r269483082 ## File path: src/brpc/socket.cpp ## @@ -881,7 +861,7 @@ int Socket::SetFailed(int error_code, const char* error_fmt,

[GitHub] [incubator-brpc] GardianT commented on issue #649: 支持热点情况下的一致性hash?

2019-03-27 Thread GitBox
GardianT commented on issue #649: 支持热点情况下的一致性hash? URL: https://github.com/apache/incubator-brpc/issues/649#issuecomment-477005672 > @GardianT 你说的这种情况不是一致性哈希能解决的。用到一致性哈希的场景的前提之一就是server加载什么数据由client决定,但这里server加载什么是由自己决定的,类型场景还有机器学习model serving。这种场景中一个记录什么数据在哪里的高可用模块是无法绕开的,经常叫Meta

[GitHub] [incubator-brpc] GardianT commented on issue #649: 支持热点情况下的一致性hash?

2019-03-27 Thread GitBox
GardianT commented on issue #649: 支持热点情况下的一致性hash? URL: https://github.com/apache/incubator-brpc/issues/649#issuecomment-477010336 @jamesge 顺便多问下:这种场景下有机会或者比较成熟的方案 让server实现自适应的负载均衡么? 比如redis有slot的概念,server节点之间会通信每个server负责的slot信息。有节点失效的时候也重分配对应的slot,这样的。

[GitHub] [incubator-brpc] jamesge commented on issue #649: 支持热点情况下的一致性hash?

2019-03-27 Thread GitBox
jamesge commented on issue #649: 支持热点情况下的一致性hash? URL: https://github.com/apache/incubator-brpc/issues/649#issuecomment-477004736 @GardianT 你说的这种情况不是一致性哈希能解决的。用到一致性哈希的场景的前提之一就是server加载什么数据由client决定,但这里机器加载什么是由机器自己决定的,类型场景还有机器学习model serving。这种场景中一个记录什么数据在哪里的高可用模块是无法绕开的,经常叫Meta

[GitHub] [incubator-brpc] GardianT edited a comment on issue #649: 支持热点情况下的一致性hash?

2019-03-27 Thread GitBox
GardianT edited a comment on issue #649: 支持热点情况下的一致性hash? URL: https://github.com/apache/incubator-brpc/issues/649#issuecomment-476999369 (流量本身的)key为url,后端存储按照这个url全局有序。流量的(写入)存储过程中牵扯若干的词典,词典可能以domain,或者site为单位。所以server如果以这样的url为range做sharding条件,可以比较有效的提升词典cache的命中率。比如一个server a,处理的range是

[GitHub] [incubator-brpc] cuisonghui commented on issue #697: 客户端出现大量timeout

2019-03-27 Thread GitBox
cuisonghui commented on issue #697: 客户端出现大量timeout URL: https://github.com/apache/incubator-brpc/issues/697#issuecomment-477115220 目前已经定位到访问vars core dump的问题. ![Screenshot from 2019-03-27

[GitHub] [incubator-brpc] yjhjstz commented on issue #639: core文件有办法查看所有bthread的堆栈吗

2019-03-26 Thread GitBox
yjhjstz commented on issue #639: core文件有办法查看所有bthread的堆栈吗 URL: https://github.com/apache/incubator-brpc/issues/639#issuecomment-476489242 基本思路是提供一个全局变量的入口, bthread* g; 从g以链表的方式打印各个bthread, 并读取 bthread的stack。 This is an

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #694: Health check by rpc call

2019-03-26 Thread GitBox
jamesge commented on a change in pull request #694: Health check by rpc call URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r269020754 ## File path: src/brpc/socket.cpp ## @@ -92,6 +96,15 @@ DEFINE_int32(connect_timeout_as_unreachable, 3,

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #694: Health check by rpc call

2019-03-26 Thread GitBox
jamesge commented on a change in pull request #694: Health check by rpc call URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r269019674 ## File path: src/brpc/socket.cpp ## @@ -92,6 +96,15 @@ DEFINE_int32(connect_timeout_as_unreachable, 3,

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #694: Health check by rpc call

2019-03-26 Thread GitBox
jamesge commented on a change in pull request #694: Health check by rpc call URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268953327 ## File path: src/brpc/controller.h ## @@ -118,6 +118,8 @@ friend int StreamCreate(StreamId*, Controller&, const

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #694: Health check by rpc call

2019-03-26 Thread GitBox
jamesge commented on a change in pull request #694: Health check by rpc call URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268952699 ## File path: docs/cn/client.md ## @@ -242,7 +242,7 @@ locality-aware,优先选择延时低的下游,直到其延时高于其他机 |

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #694: Health check by rpc call

2019-03-26 Thread GitBox
jamesge commented on a change in pull request #694: Health check by rpc call URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268951992 ## File path: docs/cn/client.md ## @@ -242,7 +242,7 @@ locality-aware,优先选择延时低的下游,直到其延时高于其他机 |

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #694: Health check by rpc call

2019-03-26 Thread GitBox
jamesge commented on a change in pull request #694: Health check by rpc call URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268953517 ## File path: src/brpc/policy/dynpart_load_balancer.cpp ## @@ -122,7 +122,8 @@ int

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #694: Health check by rpc call

2019-03-26 Thread GitBox
jamesge commented on a change in pull request #694: Health check by rpc call URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268953856 ## File path: src/brpc/policy/randomized_load_balancer.cpp ## @@ -118,7 +118,8 @@ int

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #694: Health check by rpc call

2019-03-26 Thread GitBox
zyearn commented on a change in pull request #694: Health check by rpc call URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268964773 ## File path: docs/cn/client.md ## @@ -242,7 +242,7 @@ locality-aware,优先选择延时低的下游,直到其延时高于其他机 | -

[GitHub] [incubator-brpc] hairet opened a new issue #706: 关于signal_task里的ParkingLot _pending_signal32位可能溢出问题

2019-03-27 Thread GitBox
hairet opened a new issue #706: 关于signal_task里的ParkingLot _pending_signal32位可能溢出问题 URL: https://github.com/apache/incubator-brpc/issues/706 **Describe the bug (描述bug)**

[GitHub] [incubator-brpc] jamesge commented on issue #705: Received request 慢问题

2019-03-27 Thread GitBox
jamesge commented on issue #705: Received request 慢问题 URL: https://github.com/apache/incubator-brpc/issues/705#issuecomment-477152424 你这服务已经严重拥塞了,先寻找一下拥塞原因吧,如锁,资源限制etc This is an automated message from the Apache Git Service.

[GitHub] [incubator-brpc] jamesge commented on issue #704: [grpc-java-client] grpc java client call brpc server get INTERNAL: HTTP/2 error code: FLOW_CONTROL_ERROR

2019-03-27 Thread GitBox
jamesge commented on issue #704: [grpc-java-client] grpc java client call brpc server get INTERNAL: HTTP/2 error code: FLOW_CONTROL_ERROR URL: https://github.com/apache/incubator-brpc/issues/704#issuecomment-477153899 Did the RPC succeed when there's only one thread?

[GitHub] [incubator-brpc] scottzzq commented on issue #165: 在brpc接口内部core,但是使用gdb分析时遇到问题

2019-03-21 Thread GitBox
scottzzq commented on issue #165: 在brpc接口内部core,但是使用gdb分析时遇到问题 URL: https://github.com/apache/incubator-brpc/issues/165#issuecomment-475149777 我也遇到类似的问题,跟了一下gcc5.2源码 ![image](https://user-images.githubusercontent.com/1217132/54741088-4601b380-4bf8-11e9-8e1f-36d927b850ee.png) 这个地方

[GitHub] [incubator-brpc] scottzzq commented on issue #165: 在brpc接口内部core,但是使用gdb分析时遇到问题

2019-03-21 Thread GitBox
scottzzq commented on issue #165: 在brpc接口内部core,但是使用gdb分析时遇到问题 URL: https://github.com/apache/incubator-brpc/issues/165#issuecomment-475150739 执行到brpc内部挂掉: #0 0x7f0621a605f7 in raise () from /usr/lib64/libc.so.6 #1 0x7f0621a61ce8 in abort () from /usr/lib64/libc.so.6 #2

[GitHub] [incubator-brpc] cuisonghui opened a new issue #697: 客户端出现大量timeout

2019-03-21 Thread GitBox
cuisonghui opened a new issue #697: 客户端出现大量timeout URL: https://github.com/apache/incubator-brpc/issues/697 search() leaf error:host:*.bj,port:8104,brpc status code:1008,brpc error message:[E1008]Reached timeout=3000ms @10.162.10.51:8104,query:穿越时空之妃不能忍 timecost:3001 latency:3001291

[GitHub] [incubator-brpc] kevinmgyu commented on issue #695: gflags(2.1.2-3),g++( 4:5.3.1-1ubuntu1) protobuf( 2.6.1-1.3) Linux make编译错误

2019-03-21 Thread GitBox
kevinmgyu commented on issue #695: gflags(2.1.2-3),g++( 4:5.3.1-1ubuntu1) protobuf( 2.6.1-1.3) Linux make编译错误 URL: https://github.com/apache/incubator-brpc/issues/695#issuecomment-475200414 没有呀,只有一个gflags This is an

[GitHub] [incubator-brpc] kevinmgyu commented on issue #695: gflags(2.1.2-3),g++( 4:5.3.1-1ubuntu1) protobuf( 2.6.1-1.3) Linux make编译错误

2019-03-21 Thread GitBox
kevinmgyu commented on issue #695: gflags(2.1.2-3),g++( 4:5.3.1-1ubuntu1) protobuf( 2.6.1-1.3) Linux make编译错误 URL: https://github.com/apache/incubator-brpc/issues/695#issuecomment-475200554 > 检查下你的环境里面是不是有多个不同版本的gflags 没有呀,只有一个gflags

[GitHub] [incubator-brpc] zyearn commented on issue #700: grpc迁移brpc问题

2019-03-25 Thread GitBox
zyearn commented on issue #700: grpc迁移brpc问题 URL: https://github.com/apache/incubator-brpc/issues/700#issuecomment-476072707 需要把grpc自带的插件删掉 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-brpc] TousakaRin opened a new pull request #701: fix data race, adjust reset policy of CircuitBreaker

2019-03-25 Thread GitBox
TousakaRin opened a new pull request #701: fix data race, adjust reset policy of CircuitBreaker URL: https://github.com/apache/incubator-brpc/pull/701 1. fix sp->circuit_breaker->Reset() 时可能存在的data race 2.

[GitHub] [incubator-brpc] koujian commented on issue #700: grpc迁移brpc问题

2019-03-25 Thread GitBox
koujian commented on issue #700: grpc迁移brpc问题 URL: https://github.com/apache/incubator-brpc/issues/700#issuecomment-476097816 请问你们使用的是proto3吗? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-brpc] gydong commented on a change in pull request #694: Health check by rpc call

2019-03-24 Thread GitBox
gydong commented on a change in pull request #694: Health check by rpc call URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268469307 ## File path: src/brpc/socket.cpp ## @@ -979,6 +995,89 @@ void HealthCheckTask::OnDestroyingTask() { delete this;

[GitHub] [incubator-brpc] gydong commented on a change in pull request #694: Health check by rpc call

2019-03-24 Thread GitBox
gydong commented on a change in pull request #694: Health check by rpc call URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268469441 ## File path: src/brpc/socket.cpp ## @@ -746,6 +758,11 @@ int Socket::WaitAndReset(int32_t expected_nref) {

[GitHub] [incubator-brpc] zyearn commented on issue #700: grpc迁移brpc问题

2019-03-24 Thread GitBox
zyearn commented on issue #700: grpc迁移brpc问题 URL: https://github.com/apache/incubator-brpc/issues/700#issuecomment-476043492 ClientContext在brpc里面对应是Controller,把本来要赋给ClientContext值在Controller里面找到对应项。 ``` ClientContext context; Status status = stub_->SayHello(, request, ); ```

[GitHub] [incubator-brpc] gydong commented on a change in pull request #694: Health check by rpc call

2019-03-24 Thread GitBox
gydong commented on a change in pull request #694: Health check by rpc call URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268479078 ## File path: src/brpc/socket.cpp ## @@ -979,6 +995,89 @@ void HealthCheckTask::OnDestroyingTask() { delete this;

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #694: Health check by rpc call

2019-03-24 Thread GitBox
zyearn commented on a change in pull request #694: Health check by rpc call URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268477608 ## File path: src/brpc/socket.cpp ## @@ -979,6 +995,89 @@ void HealthCheckTask::OnDestroyingTask() { delete this;

[GitHub] [incubator-brpc] koujian commented on issue #700: grpc迁移brpc问题

2019-03-25 Thread GitBox
koujian commented on issue #700: grpc迁移brpc问题 URL: https://github.com/apache/incubator-brpc/issues/700#issuecomment-476068122

[GitHub] [incubator-brpc] koujian commented on issue #700: grpc迁移brpc问题

2019-03-25 Thread GitBox
koujian commented on issue #700: grpc迁移brpc问题 URL: https://github.com/apache/incubator-brpc/issues/700#issuecomment-476073459 不使用grpc自带的插件无法支持service语义,请问是要下载哪个插件来支持service语义 This is an automated message from the Apache Git

[GitHub] [incubator-brpc] koujian opened a new issue #700: grpc迁移brpc问题

2019-03-24 Thread GitBox
koujian opened a new issue #700: grpc迁移brpc问题 URL: https://github.com/apache/incubator-brpc/issues/700 grpc中根据pb文件转化的函数调用例子如下,第一个参数的类型是ClientContext*。但是brpc示例中SayHello的第一个参数是RpcController*类型,是因为protoc.exe版本的原因吗?? ClientContext context; // The actual RPC. Status status =

[GitHub] [incubator-brpc] koujian commented on issue #700: grpc迁移brpc问题

2019-03-25 Thread GitBox
koujian commented on issue #700: grpc迁移brpc问题 URL: https://github.com/apache/incubator-brpc/issues/700#issuecomment-476103525 谢谢,忘记加option cc_generic_services = true;了。 This is an automated message from the Apache Git

[GitHub] [incubator-brpc] koujian closed issue #700: grpc迁移brpc问题

2019-03-25 Thread GitBox
koujian closed issue #700: grpc迁移brpc问题 URL: https://github.com/apache/incubator-brpc/issues/700 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-brpc] zyearn commented on issue #700: grpc迁移brpc问题

2019-03-25 Thread GitBox
zyearn commented on issue #700: grpc迁移brpc问题 URL: https://github.com/apache/incubator-brpc/issues/700#issuecomment-476099549 不需要用任何插件,具体怎么生成service,参考一下example吧,然后把你的实现类改成继承生成的service This is an automated message from the

[GitHub] [incubator-brpc] darrenwang00 commented on issue #698: Fail to find protoc

2019-03-22 Thread GitBox
darrenwang00 commented on issue #698: Fail to find protoc URL: https://github.com/apache/incubator-brpc/issues/698#issuecomment-475840520 in centos , the protoc install in /usr/bin/protoc This is an automated message from

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #694: Health check by rpc call

2019-03-22 Thread GitBox
zyearn commented on a change in pull request #694: Health check by rpc call URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268381737 ## File path: src/brpc/socket.cpp ## @@ -780,6 +793,9 @@ void Socket::Revive() { } else {

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #694: Health check by rpc call

2019-03-22 Thread GitBox
zyearn commented on a change in pull request #694: Health check by rpc call URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268383593 ## File path: src/brpc/socket.cpp ## @@ -780,6 +793,9 @@ void Socket::Revive() { } else {

[GitHub] [incubator-brpc] reachfish commented on issue #699: Fail to select server from list

2019-03-23 Thread GitBox
reachfish commented on issue #699: Fail to select server from list URL: https://github.com/apache/incubator-brpc/issues/699#issuecomment-475856851 好, 那我先换下其他算法试试 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-brpc] darrenwang00 opened a new issue #698: Fail to find protoc

2019-03-22 Thread GitBox
darrenwang00 opened a new issue #698: Fail to find protoc URL: https://github.com/apache/incubator-brpc/issues/698 **Describe the bug (描述bug)** centos7 安装安装完所有依赖, sh config_brpc.sh --headers=/usr/include --libs=/usr/lib64 **To Reproduce (复现方法)** **Expected

[GitHub] [incubator-brpc] reachfish opened a new issue #699: Fail to select server from list

2019-03-23 Thread GitBox
reachfish opened a new issue #699: Fail to select server from list URL: https://github.com/apache/incubator-brpc/issues/699 当server负载较大时(32核,cpu 负载 300%~ 700% ), client会报 "[R1][E112]Fail to select server from list://127.0.0.1:10002 lb=la",

[GitHub] [incubator-brpc] jamesge commented on issue #699: Fail to select server from list

2019-03-23 Thread GitBox
jamesge commented on issue #699: Fail to select server from list URL: https://github.com/apache/incubator-brpc/issues/699#issuecomment-475856093 用其他算法有类似的现象么? This is an automated message from the Apache Git Service. To

[GitHub] [incubator-brpc] zyearn commented on issue #698: Fail to find protoc

2019-03-23 Thread GitBox
zyearn commented on issue #698: Fail to find protoc URL: https://github.com/apache/incubator-brpc/issues/698#issuecomment-475843854 try this: sh config_brpc.sh --headers=/usr/include --libs="/usr/lib64 /usr/bin/" This is an

[GitHub] [incubator-brpc] walterzhaoJR commented on issue #682: Compile problem

2019-03-25 Thread GitBox
walterzhaoJR commented on issue #682: Compile problem URL: https://github.com/apache/incubator-brpc/issues/682#issuecomment-476257127 ok let me have a try This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-brpc] x-x-p commented on issue #708: NamingService 初始化过多导致LOG(FATAL)

2019-04-03 Thread GitBox
x-x-p commented on issue #708: NamingService 初始化过多导致LOG(FATAL) URL: https://github.com/apache/incubator-brpc/issues/708#issuecomment-479725789 #708 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-brpc] x-x-p commented on issue #502: DoublyBufferedData扩展性受限于_SC_THREAD_KEYS_MAX只能到1024

2019-04-03 Thread GitBox
x-x-p commented on issue #502: DoublyBufferedData扩展性受限于_SC_THREAD_KEYS_MAX只能到1024 URL: https://github.com/apache/incubator-brpc/issues/502#issuecomment-479725723 什么时候能合并到主分支呢?#708 This is an automated message from the Apache

[GitHub] [incubator-brpc] Xavier1994 closed issue #704: [grpc-java-client] grpc java client call brpc server get INTERNAL: HTTP/2 error code: FLOW_CONTROL_ERROR

2019-04-04 Thread GitBox
Xavier1994 closed issue #704: [grpc-java-client] grpc java client call brpc server get INTERNAL: HTTP/2 error code: FLOW_CONTROL_ERROR URL: https://github.com/apache/incubator-brpc/issues/704 This is an automated message

[GitHub] [incubator-brpc] cdjingit commented on issue #465: Brpc couchbase

2019-04-04 Thread GitBox
cdjingit commented on issue #465: Brpc couchbase URL: https://github.com/apache/incubator-brpc/pull/465#issuecomment-479864006 这个已经开发完成了 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #592: lb configurable && consistency hash lb refactor

2019-04-04 Thread GitBox
jamesge commented on a change in pull request #592: lb configurable && consistency hash lb refactor URL: https://github.com/apache/incubator-brpc/pull/592#discussion_r272216066 ## File path: src/brpc/policy/consistent_hashing_load_balancer.cpp ## @@ -29,16 +31,111 @@

[GitHub] [incubator-brpc] jamesge commented on issue #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-04-04 Thread GitBox
jamesge commented on issue #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#issuecomment-480129822 > @jamesge 最近在考虑prepared statement 和 transaction的实现问题。这两个功能的特点是,需要在一个连接上面进行多次回话,在多次回话过程中连接需要独占。 >

[GitHub] [incubator-brpc] jamesge edited a comment on issue #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-04-04 Thread GitBox
jamesge edited a comment on issue #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#issuecomment-480129822 > @jamesge 最近在考虑prepared statement 和 transaction的实现问题。这两个功能的特点是,需要在一个连接上面进行多次回话,在多次回话过程中连接需要独占。 >

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #592: lb configurable && consistency hash lb refactor

2019-04-04 Thread GitBox
zyearn commented on a change in pull request #592: lb configurable && consistency hash lb refactor URL: https://github.com/apache/incubator-brpc/pull/592#discussion_r272432447 ## File path: src/brpc/load_balancer.h ## @@ -102,8 +104,21 @@ class LoadBalancer : public

[GitHub] [incubator-brpc] yanglimingcn commented on issue #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-04-04 Thread GitBox
yanglimingcn commented on issue #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#issuecomment-480142246 多次的交互如果对用户屏蔽,就需要像权限校验那样,在parseResponse的地方做多次的处理,我觉得这样可行。这样用户操作应该挺简洁的。而且single估计也可以了呢。 但是prepared

[GitHub] [incubator-brpc] cdjingit commented on a change in pull request #592: lb configurable && consistency hash lb refactor

2019-04-04 Thread GitBox
cdjingit commented on a change in pull request #592: lb configurable && consistency hash lb refactor URL: https://github.com/apache/incubator-brpc/pull/592#discussion_r272431987 ## File path: src/brpc/policy/consistent_hashing_load_balancer.cpp ## @@ -29,16 +31,111 @@

[GitHub] [incubator-brpc] yanglimingcn commented on issue #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-04-04 Thread GitBox
yanglimingcn commented on issue #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#issuecomment-480111084 @jamesge 最近在考虑prepared statement 和 transaction的实现问题。这两个功能的特点是,需要在一个连接上面进行多次回话,在多次回话过程中连接需要独占。

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #592: lb configurable && consistency hash lb refactor

2019-04-04 Thread GitBox
jamesge commented on a change in pull request #592: lb configurable && consistency hash lb refactor URL: https://github.com/apache/incubator-brpc/pull/592#discussion_r272427635 ## File path: src/brpc/policy/consistent_hashing_load_balancer.cpp ## @@ -29,16 +31,111 @@

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #592: lb configurable && consistency hash lb refactor

2019-04-04 Thread GitBox
jamesge commented on a change in pull request #592: lb configurable && consistency hash lb refactor URL: https://github.com/apache/incubator-brpc/pull/592#discussion_r272426700 ## File path: src/brpc/load_balancer.h ## @@ -102,8 +104,21 @@ class LoadBalancer : public

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #592: lb configurable && consistency hash lb refactor

2019-04-04 Thread GitBox
jamesge commented on a change in pull request #592: lb configurable && consistency hash lb refactor URL: https://github.com/apache/incubator-brpc/pull/592#discussion_r272426659 ## File path: src/brpc/load_balancer.h ## @@ -102,8 +104,21 @@ class LoadBalancer : public

[GitHub] [incubator-brpc] yjhjstz commented on issue #715: http2 / grpc问题

2019-04-04 Thread GitBox
yjhjstz commented on issue #715: http2 / grpc问题 URL: https://github.com/apache/incubator-brpc/issues/715#issuecomment-480106186 有更优雅的方式吗? This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-brpc] cdjingit commented on a change in pull request #592: lb configurable && consistency hash lb refactor

2019-04-04 Thread GitBox
cdjingit commented on a change in pull request #592: lb configurable && consistency hash lb refactor URL: https://github.com/apache/incubator-brpc/pull/592#discussion_r272430577 ## File path: src/brpc/load_balancer.h ## @@ -102,8 +104,21 @@ class LoadBalancer : public

[GitHub] [incubator-brpc] cdjingit commented on a change in pull request #592: lb configurable && consistency hash lb refactor

2019-04-04 Thread GitBox
cdjingit commented on a change in pull request #592: lb configurable && consistency hash lb refactor URL: https://github.com/apache/incubator-brpc/pull/592#discussion_r272430603 ## File path: src/brpc/load_balancer.h ## @@ -102,8 +104,21 @@ class LoadBalancer : public

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #694: Health check by rpc call

2019-03-28 Thread GitBox
jamesge commented on a change in pull request #694: Health check by rpc call URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r269980096 ## File path: src/brpc/details/health_check.cpp ## @@ -0,0 +1,233 @@ +// Copyright (c) 2014 Baidu, Inc. +// +//

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #694: Health check by rpc call

2019-03-28 Thread GitBox
jamesge commented on a change in pull request #694: Health check by rpc call URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r269979808 ## File path: src/brpc/details/health_check.h ## @@ -0,0 +1,33 @@ +// Copyright (c) 2014 Baidu, Inc. +// +// Licensed

  1   2   3   4   5   6   7   8   9   10   >