RE: svn commit: r1162745 - in /cocoon/cocoon3/trunk: cocoon-optional/pom.xml cocoon-stax/pom.xml parent/pom.xml

2011-09-05 Thread Nathaniel, Alfred
 -Original Message-
 From: Thorsten Scherler [mailto:scher...@gmail.com]
 Sent: Montag, 29. August 2011 14:16
 To: dev@cocoon.apache.org
 Subject: Re: svn commit: r1162745 - in /cocoon/cocoon3/trunk: cocoon-
 optional/pom.xml cocoon-stax/pom.xml parent/pom.xml
 
 On Mon, 2011-08-29 at 14:00 +0200, Francesco Chicchiriccò wrote:
 ...
  Since Jakarta RegExp is retired (see [1]), do you think it would be hard
  to rework the DirectoryGenerator in order to make use of
  java.util.regexp.* instead?
  Otherwise you can just add this dependency - with version - in
  parent/pom.xml and with optional modifier in cocoon-optional/pom.xml.
 
  One less dependency - even though optional - is better :-)
 
 Hmm, Jakarta RegExp does some things different and IMO much better then
 java.util. Even if it is retired that does not mean it is not worth
 using it, more since this way the component works exactly as in our
 prior versions. Not sure when I will find the time to look into a
 rewrite to use java regex.

I second Francesco that we should get rid of Jakarta RegExp before 3.0.
In the long run will pay off to use a good standard rather than a better 
non-standard.

When you say Jakarta does it different and better do you refer to the API or 
the regexp syntax?
If it is just converting the API calls, I can help.

I wonder whether for the average user it would not be more convenient if 
DirectoryGenerator would accept the same Ant-style globs as map:match rather 
than full-blown Perl-style regexps.

Cheers, Alfred.


The content of this e-mail is intended only for the confidential use of the 
person addressed. 
If you are not the intended recipient, please notify the sender and delete this 
e-mail immediately.
Thank you.


Re: svn commit: r1162745 - in /cocoon/cocoon3/trunk: cocoon-optional/pom.xml cocoon-stax/pom.xml parent/pom.xml

2011-08-29 Thread Francesco Chicchiriccò

Hi all,
please remember to keep version numbers in parent/pom.xml only, and to 
mark external dependencies as optional in cocoon-optional/pom.xml.


Regards.


On 29/08/2011 13:22, ilgro...@apache.org wrote:

Author: ilgrosso
Date: Mon Aug 29 11:22:28 2011
New Revision: 1162745

URL: http://svn.apache.org/viewvc?rev=1162745view=rev
Log:
Updating Spring and JUnit to latest releases; fixing optional dependencies. 
PLEASE KEEP VERSION NUMBERS IN parent/pom.xml

Modified:
 cocoon/cocoon3/trunk/cocoon-optional/pom.xml
 cocoon/cocoon3/trunk/cocoon-stax/pom.xml
 cocoon/cocoon3/trunk/parent/pom.xml

Modified: cocoon/cocoon3/trunk/cocoon-optional/pom.xml
URL: 
http://svn.apache.org/viewvc/cocoon/cocoon3/trunk/cocoon-optional/pom.xml?rev=1162745r1=1162744r2=1162745view=diff
==
--- cocoon/cocoon3/trunk/cocoon-optional/pom.xml (original)
+++ cocoon/cocoon3/trunk/cocoon-optional/pom.xml Mon Aug 29 11:22:28 2011
@@ -119,27 +119,13 @@
  dependency
  groupIdjavax.xml.bind/groupId
  artifactIdjaxb-api/artifactId
-version2.1/version
  optionaltrue/optional
  /dependency
  dependency
  groupIdcom.sun.xml.bind/groupId
  artifactIdjaxb-impl/artifactId
-version2.2/version
  optionaltrue/optional
  /dependency
-!-- DirGenerator --
-dependency
-groupIdjakarta-regexp/groupId
-artifactIdjakarta-regexp/artifactId
-version1.4/version
-/dependency
-!-- NekoGenerator --
-dependency
-groupIdnet.sourceforge.nekohtml/groupId
-artifactIdnekohtml/artifactId
-version1.9.15/version
-/dependency

  !-- Test libraries --
  dependency

Modified: cocoon/cocoon3/trunk/cocoon-stax/pom.xml
URL: 
http://svn.apache.org/viewvc/cocoon/cocoon3/trunk/cocoon-stax/pom.xml?rev=1162745r1=1162744r2=1162745view=diff
==
--- cocoon/cocoon3/trunk/cocoon-stax/pom.xml (original)
+++ cocoon/cocoon3/trunk/cocoon-stax/pom.xml Mon Aug 29 11:22:28 2011
@@ -40,7 +40,7 @@
  /dependency
  dependency
  groupIdorg.codehaus.woodstox/groupId
-artifactIdwstx-asl/artifactId
+artifactIdwoodstox-core-asl/artifactId
  optionaltrue/optional
  /dependency
  dependency
@@ -52,6 +52,7 @@
  groupIdcommons-io/groupId
  artifactIdcommons-io/artifactId
  /dependency
+
  !-- Logging --
  dependency
  groupIdorg.slf4j/groupId

Modified: cocoon/cocoon3/trunk/parent/pom.xml
URL: 
http://svn.apache.org/viewvc/cocoon/cocoon3/trunk/parent/pom.xml?rev=1162745r1=1162744r2=1162745view=diff
==
--- cocoon/cocoon3/trunk/parent/pom.xml (original)
+++ cocoon/cocoon3/trunk/parent/pom.xml Mon Aug 29 11:22:28 2011
@@ -26,7 +26,7 @@
  parent
  groupIdorg.apache/groupId
  artifactIdapache/artifactId
-version9/version
+version10/version
  relativePath/
  /parent

@@ -232,32 +232,32 @@
  dependency
  groupIdorg.springframework/groupId
  artifactIdspring-beans/artifactId
-version3.0.5.RELEASE/version
+version3.0.6.RELEASE/version
  /dependency
  dependency
  groupIdorg.springframework/groupId
  artifactIdspring-core/artifactId
-version3.0.5.RELEASE/version
+version3.0.6.RELEASE/version
  /dependency
  dependency
  groupIdorg.springframework/groupId
  artifactIdspring-context/artifactId
-version3.0.5.RELEASE/version
+version3.0.6.RELEASE/version
  /dependency
  dependency
  groupIdorg.springframework/groupId
  artifactIdspring-context-support/artifactId
-version3.0.5.RELEASE/version
+version3.0.6.RELEASE/version
  /dependency
  dependency
  groupIdorg.springframework/groupId
  artifactIdspring-aop/artifactId
-version3.0.5.RELEASE/version
+version3.0.6.RELEASE/version
  /dependency
  dependency
  groupIdorg.springframework/groupId
  artifactIdspring-web/artifactId
-version3.0.5.RELEASE/version
+version3.0.6.RELEASE/version
  /dependency
  dependency
  groupIdorg.springframework/groupId
@@ -339,7 +339,7 @@
  dependency
  groupIdnet.sf.ehcache/groupId
  artifactIdehcache-core/artifactId
-version2.4.3/version
+version2.4.4/version
  /dependency
  dependency
  groupIdnet.sourceforge.nekohtml/groupId
@@ -387,18 +387,18 @@
  /dependency
  dependency
  groupIdorg.codehaus.woodstox/groupId
-artifactIdwstx-asl/artifactId
-version4.0.6/version

Re: svn commit: r1162745 - in /cocoon/cocoon3/trunk: cocoon-optional/pom.xml cocoon-stax/pom.xml parent/pom.xml

2011-08-29 Thread Thorsten Scherler
On Mon, 2011-08-29 at 11:22 +, ilgro...@apache.org wrote:
 Author: ilgrosso
 Date: Mon Aug 29 11:22:28 2011
 New Revision: 1162745
 
 URL: http://svn.apache.org/viewvc?rev=1162745view=rev
 Log:
 Updating Spring and JUnit to latest releases; fixing optional dependencies. 
 PLEASE KEEP VERSION NUMBERS IN parent/pom.xml
 
 Modified:
 cocoon/cocoon3/trunk/cocoon-optional/pom.xml
...
 
 Modified: cocoon/cocoon3/trunk/cocoon-optional/pom.xml
 URL: 
 http://svn.apache.org/viewvc/cocoon/cocoon3/trunk/cocoon-optional/pom.xml?rev=1162745r1=1162744r2=1162745view=diff
 ==
 --- cocoon/cocoon3/trunk/cocoon-optional/pom.xml (original)
 +++ cocoon/cocoon3/trunk/cocoon-optional/pom.xml Mon Aug 29 11:22:28 2011
 @@ -119,27 +119,13 @@
  dependency
  groupIdjavax.xml.bind/groupId
  artifactIdjaxb-api/artifactId
 -version2.1/version
  optionaltrue/optional
  /dependency
  dependency
  groupIdcom.sun.xml.bind/groupId
  artifactIdjaxb-impl/artifactId
 -version2.2/version
  optionaltrue/optional
  /dependency
 -!-- DirGenerator --
 -dependency
 -   groupIdjakarta-regexp/groupId
 -   artifactIdjakarta-regexp/artifactId
 -   version1.4/version
 -/dependency 
 -!-- NekoGenerator --
 -dependency
 -  groupIdnet.sourceforge.nekohtml/groupId
 -  artifactIdnekohtml/artifactId
 -  version1.9.15/version
 -/dependency

Both components DirGenerator/NekoGenerator have deps that are not
present in the parent. Removing them will provoke a ClassNotFound
exception in case you use this components in your project. 

Can you please re-add this deps?

salu2
-- 
Thorsten Scherler thorsten.at.apache.org
codeBusters S.L. - web based systems
consulting, training and solutions
http://www.codebusters.es/



Re: svn commit: r1162745 - in /cocoon/cocoon3/trunk: cocoon-optional/pom.xml cocoon-stax/pom.xml parent/pom.xml

2011-08-29 Thread Francesco Chicchiriccò

Il 29/08/2011 13:34, Thorsten Scherler ha scritto:

On Mon, 2011-08-29 at 11:22 +, ilgro...@apache.org wrote:

Author: ilgrosso
Date: Mon Aug 29 11:22:28 2011
New Revision: 1162745

URL: http://svn.apache.org/viewvc?rev=1162745view=rev
Log:
Updating Spring and JUnit to latest releases; fixing optional dependencies. 
PLEASE KEEP VERSION NUMBERS IN parent/pom.xml

Modified:
 cocoon/cocoon3/trunk/cocoon-optional/pom.xml

...

Modified: cocoon/cocoon3/trunk/cocoon-optional/pom.xml
URL: 
http://svn.apache.org/viewvc/cocoon/cocoon3/trunk/cocoon-optional/pom.xml?rev=1162745r1=1162744r2=1162745view=diff
==
--- cocoon/cocoon3/trunk/cocoon-optional/pom.xml (original)
+++ cocoon/cocoon3/trunk/cocoon-optional/pom.xml Mon Aug 29 11:22:28 2011
@@ -119,27 +119,13 @@
  dependency
  groupIdjavax.xml.bind/groupId
  artifactIdjaxb-api/artifactId
-version2.1/version
  optionaltrue/optional
  /dependency
  dependency
  groupIdcom.sun.xml.bind/groupId
  artifactIdjaxb-impl/artifactId
-version2.2/version
  optionaltrue/optional
  /dependency
-!-- DirGenerator --
-dependency
-groupIdjakarta-regexp/groupId
-artifactIdjakarta-regexp/artifactId
-version1.4/version
-/dependency
-!-- NekoGenerator --
-dependency
-groupIdnet.sourceforge.nekohtml/groupId
-artifactIdnekohtml/artifactId
-version1.9.15/version
-/dependency

Both components DirGenerator/NekoGenerator have deps that are not present in 
the parent. Removing them will provoke a ClassNotFound exception in case you 
use this components in your project.

Can you please re-add this deps?


The idea behind cocoon-optional is that you have to add optional 
dependencies in your project, if you use a feature from cocoon-optional 
that actually needs an optional dependency.


Look for example to FOP.

Moreover, nekohtml is already declared in cocoon-optional POM, already 
correctly marked as optional.


Regards.

--
Francesco Chicchiriccò

Apache Cocoon Committer and PMC Member
http://people.apache.org/~ilgrosso/



Re: svn commit: r1162745 - in /cocoon/cocoon3/trunk: cocoon-optional/pom.xml cocoon-stax/pom.xml parent/pom.xml

2011-08-29 Thread Thorsten Scherler
On Mon, 2011-08-29 at 13:39 +0200, Francesco Chicchiriccò wrote:
 Il 29/08/2011 13:34, Thorsten Scherler ha scritto:
  On Mon, 2011-08-29 at 11:22 +, ilgro...@apache.org wrote:
  Author: ilgrosso
  Date: Mon Aug 29 11:22:28 2011
  New Revision: 1162745
 
  URL: http://svn.apache.org/viewvc?rev=1162745view=rev
  Log:
  Updating Spring and JUnit to latest releases; fixing optional 
  dependencies. PLEASE KEEP VERSION NUMBERS IN parent/pom.xml
 
  Modified:
   cocoon/cocoon3/trunk/cocoon-optional/pom.xml
  ...
  Modified: cocoon/cocoon3/trunk/cocoon-optional/pom.xml
  URL: 
  http://svn.apache.org/viewvc/cocoon/cocoon3/trunk/cocoon-optional/pom.xml?rev=1162745r1=1162744r2=1162745view=diff
  ==
  --- cocoon/cocoon3/trunk/cocoon-optional/pom.xml (original)
  +++ cocoon/cocoon3/trunk/cocoon-optional/pom.xml Mon Aug 29 11:22:28 2011
  @@ -119,27 +119,13 @@
dependency
groupIdjavax.xml.bind/groupId
artifactIdjaxb-api/artifactId
  -version2.1/version
optionaltrue/optional
/dependency
dependency
groupIdcom.sun.xml.bind/groupId
artifactIdjaxb-impl/artifactId
  -version2.2/version
optionaltrue/optional
/dependency
  -!-- DirGenerator --
  -dependency
  -groupIdjakarta-regexp/groupId
  -artifactIdjakarta-regexp/artifactId
  -version1.4/version
  -/dependency
  -!-- NekoGenerator --
  -dependency
  -groupIdnet.sourceforge.nekohtml/groupId
  -artifactIdnekohtml/artifactId
  -version1.9.15/version
  -/dependency
  Both components DirGenerator/NekoGenerator have deps that are not present 
  in the parent. Removing them will provoke a ClassNotFound exception in case 
  you use this components in your project.
 
  Can you please re-add this deps?
 
 The idea behind cocoon-optional is that you have to add optional 
 dependencies in your project, if you use a feature from cocoon-optional 
 that actually needs an optional dependency.
 
 Look for example to FOP.
 
 Moreover, nekohtml is already declared in cocoon-optional POM, already 
 correctly marked as optional.

ok regarding the neko, but still the jarkata is missing, isn't it?

salu2
-- 
Thorsten Scherler thorsten.at.apache.org
codeBusters S.L. - web based systems
consulting, training and solutions
http://www.codebusters.es/



Re: svn commit: r1162745 - in /cocoon/cocoon3/trunk: cocoon-optional/pom.xml cocoon-stax/pom.xml parent/pom.xml

2011-08-29 Thread Francesco Chicchiriccò

On 29/08/2011 13:55, Thorsten Scherler wrote:

On Mon, 2011-08-29 at 13:39 +0200, Francesco Chicchiriccò wrote:

Il 29/08/2011 13:34, Thorsten Scherler ha scritto:

On Mon, 2011-08-29 at 11:22 +, ilgro...@apache.org wrote:

Author: ilgrosso
Date: Mon Aug 29 11:22:28 2011
New Revision: 1162745

URL: http://svn.apache.org/viewvc?rev=1162745view=rev
Log:
Updating Spring and JUnit to latest releases; fixing optional dependencies. 
PLEASE KEEP VERSION NUMBERS IN parent/pom.xml

Modified:
  cocoon/cocoon3/trunk/cocoon-optional/pom.xml

...

Modified: cocoon/cocoon3/trunk/cocoon-optional/pom.xml
URL: 
http://svn.apache.org/viewvc/cocoon/cocoon3/trunk/cocoon-optional/pom.xml?rev=1162745r1=1162744r2=1162745view=diff
==
--- cocoon/cocoon3/trunk/cocoon-optional/pom.xml (original)
+++ cocoon/cocoon3/trunk/cocoon-optional/pom.xml Mon Aug 29 11:22:28 2011
@@ -119,27 +119,13 @@
   dependency
   groupIdjavax.xml.bind/groupId
   artifactIdjaxb-api/artifactId
-version2.1/version
   optionaltrue/optional
   /dependency
   dependency
   groupIdcom.sun.xml.bind/groupId
   artifactIdjaxb-impl/artifactId
-version2.2/version
   optionaltrue/optional
   /dependency
-!-- DirGenerator --
-dependency
-groupIdjakarta-regexp/groupId
-artifactIdjakarta-regexp/artifactId
-version1.4/version
-/dependency
-!-- NekoGenerator --
-dependency
-groupIdnet.sourceforge.nekohtml/groupId
-artifactIdnekohtml/artifactId
-version1.9.15/version
-/dependency

Both components DirGenerator/NekoGenerator have deps that are not present in 
the parent. Removing them will provoke a ClassNotFound exception in case you 
use this components in your project.

Can you please re-add this deps?

The idea behind cocoon-optional is that you have to add optional dependencies 
in your project, if you use a feature from cocoon-optional that actually needs 
an optional dependency.

Look for example to FOP.

Moreover, nekohtml is already declared in cocoon-optional POM, already 
correctly marked as optional.

ok regarding the neko, but still the jarkata is missing, isn't it?


Correct.
Since Jakarta RegExp is retired (see [1]), do you think it would be hard 
to rework the DirectoryGenerator in order to make use of 
java.util.regexp.* instead?
Otherwise you can just add this dependency - with version - in 
parent/pom.xml and with optional modifier in cocoon-optional/pom.xml.


One less dependency - even though optional - is better :-)

Regards.

[1] https://jakarta.apache.org/regexp/

--
Francesco Chicchiriccò

Apache Cocoon Committer and PMC Member
http://people.apache.org/~ilgrosso/



Re: svn commit: r1162745 - in /cocoon/cocoon3/trunk: cocoon-optional/pom.xml cocoon-stax/pom.xml parent/pom.xml

2011-08-29 Thread Thorsten Scherler
On Mon, 2011-08-29 at 14:00 +0200, Francesco Chicchiriccò wrote:
...
  Moreover, nekohtml is already declared in cocoon-optional POM, already 
  correctly marked as optional.
  ok regarding the neko, but still the jarkata is missing, isn't it?
 
 Correct.
 Since Jakarta RegExp is retired (see [1]), do you think it would be hard 
 to rework the DirectoryGenerator in order to make use of 
 java.util.regexp.* instead?
 Otherwise you can just add this dependency - with version - in 
 parent/pom.xml and with optional modifier in cocoon-optional/pom.xml.
 
 One less dependency - even though optional - is better :-)

Hmm, Jakarta RegExp does some things different and IMO much better then
java.util. Even if it is retired that does not mean it is not worth
using it, more since this way the component works exactly as in our
prior versions. Not sure when I will find the time to look into a
rewrite to use java regex.

salu2 
-- 
Thorsten Scherler thorsten.at.apache.org
codeBusters S.L. - web based systems
consulting, training and solutions
http://www.codebusters.es/