On 29/08/2011 13:55, Thorsten Scherler wrote:
On Mon, 2011-08-29 at 13:39 +0200, Francesco Chicchiriccò wrote:
Il 29/08/2011 13:34, Thorsten Scherler ha scritto:
On Mon, 2011-08-29 at 11:22 +0000, ilgro...@apache.org wrote:
Author: ilgrosso
Date: Mon Aug 29 11:22:28 2011
New Revision: 1162745
URL: http://svn.apache.org/viewvc?rev=1162745&view=rev
Log:
Updating Spring and JUnit to latest releases; fixing optional dependencies.
PLEASE KEEP VERSION NUMBERS IN parent/pom.xml
Modified:
cocoon/cocoon3/trunk/cocoon-optional/pom.xml
...
Modified: cocoon/cocoon3/trunk/cocoon-optional/pom.xml
URL:
http://svn.apache.org/viewvc/cocoon/cocoon3/trunk/cocoon-optional/pom.xml?rev=1162745&r1=1162744&r2=1162745&view=diff
==============================================================================
--- cocoon/cocoon3/trunk/cocoon-optional/pom.xml (original)
+++ cocoon/cocoon3/trunk/cocoon-optional/pom.xml Mon Aug 29 11:22:28 2011
@@ -119,27 +119,13 @@
<dependency>
<groupId>javax.xml.bind</groupId>
<artifactId>jaxb-api</artifactId>
-<version>2.1</version>
<optional>true</optional>
</dependency>
<dependency>
<groupId>com.sun.xml.bind</groupId>
<artifactId>jaxb-impl</artifactId>
-<version>2.2</version>
<optional>true</optional>
</dependency>
-<!-- DirGenerator -->
-<dependency>
-<groupId>jakarta-regexp</groupId>
-<artifactId>jakarta-regexp</artifactId>
-<version>1.4</version>
-</dependency>
-<!-- NekoGenerator -->
-<dependency>
-<groupId>net.sourceforge.nekohtml</groupId>
-<artifactId>nekohtml</artifactId>
-<version>1.9.15</version>
-</dependency>
Both components DirGenerator/NekoGenerator have deps that are not present in
the parent. Removing them will provoke a ClassNotFound exception in case you
use this components in your project.
Can you please re-add this deps?
The idea behind cocoon-optional is that you have to add optional dependencies
in your project, if you use a feature from cocoon-optional that actually needs
an optional dependency.
Look for example to FOP.
Moreover, nekohtml is already declared in cocoon-optional POM, already
correctly marked as optional.
ok regarding the neko, but still the jarkata is missing, isn't it?
Correct.
Since Jakarta RegExp is retired (see [1]), do you think it would be hard
to rework the DirectoryGenerator in order to make use of
java.util.regexp.* instead?
Otherwise you can just add this dependency - with version - in
parent/pom.xml and with optional modifier in cocoon-optional/pom.xml.
One less dependency - even though optional - is better :-)
Regards.
[1] https://jakarta.apache.org/regexp/
--
Francesco Chicchiriccò
Apache Cocoon Committer and PMC Member
http://people.apache.org/~ilgrosso/
