Github user stain closed the pull request at:
https://github.com/apache/commons-lang/pull/62
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user stain opened a pull request:
https://github.com/apache/commons-lang/pull/62
README.md - avoid 404 links
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stain/commons-lang patch-1
Alternatively you can review and
Github user stain commented on the issue:
https://github.com/apache/commons-rdf/pull/43
Agree with @afs that only the builder-factory bit should be serialized -
obviously the actual parser which may be in progress of parsing is tricky to
serialize. So we would need to perhaps clean
Github user stain commented on a diff in the pull request:
https://github.com/apache/commons-rdf/pull/49#discussion_r167732171
--- Diff:
commons-rdf-simple/src/main/java/org/apache/commons/rdf/simple/experimental/AbstractRDFParser.java
---
@@ -58,8 +60,12 @@
*/
public
Github user stain commented on the issue:
https://github.com/apache/commons-rdf/pull/43
Picking up this - @ajs6f do you still think we should proceed along those
lines? I am also reluctant to making the abstract factory (builder)
serializable, but I can see the reasoning
Github user stain commented on a diff in the pull request:
https://github.com/apache/commons-rdf/pull/49#discussion_r168274256
--- Diff:
commons-rdf-simple/src/main/java/org/apache/commons/rdf/simple/experimental/AbstractRDFParser.java
---
@@ -58,8 +60,12 @@
*/
public
Github user stain commented on the issue:
https://github.com/apache/commons-rdf/pull/43
Thanks, @ajs6f !
I found some old code where I had tried to make a fluent interface.. I
managed to update it to the current master and sorted some issues.
I pushed it to the
Github user stain commented on the issue:
https://github.com/apache/commons-rdf/pull/43
You may have better ideas on how to do something like
[ParserConfigImpl](https://github.com/apache/commons-rdf/blob/fluent-parser/commons-rdf-api/src/main/java/org/apache/commons/rdf/api/io
Github user stain commented on the issue:
https://github.com/apache/commons-rdf/pull/28
Thanks! Merged. I also added you as a `` to be shown on
https://commons.apache.org/proper/commons-rdf/team-list.html - hope that's OK.
Any other OSGi issues? How do you do the equiv
GitHub user stain opened a pull request:
https://github.com/apache/commons-rdf/pull/30
COMMONSRDF-51 language tags compared lower case
This fixes
[COMMONSRDF-51](https://issues.apache.org/jira/browse/COMMONSRDF-51) - at least
from `Literal.equals()` and `Literal.hashCode
Github user stain commented on a diff in the pull request:
https://github.com/apache/commons-rdf/pull/27#discussion_r95840179
--- Diff: api/src/main/java/org/apache/commons/rdf/api/RDFSyntax.java ---
@@ -22,6 +22,124 @@
import java.util.Optional;
/**
+ * An RDF
Github user stain commented on a diff in the pull request:
https://github.com/apache/commons-rdf/pull/27#discussion_r95840249
--- Diff: api/src/main/java/org/apache/commons/rdf/api/RDFSyntax.java ---
@@ -22,6 +22,124 @@
import java.util.Optional;
/**
+ * An RDF
Github user stain commented on a diff in the pull request:
https://github.com/apache/commons-rdf/pull/27#discussion_r95840484
--- Diff: api/src/main/java/org/apache/commons/rdf/api/RDFSyntax.java ---
@@ -22,6 +22,124 @@
import java.util.Optional;
/**
+ * An RDF
Github user stain commented on a diff in the pull request:
https://github.com/apache/commons-rdf/pull/27#discussion_r95840655
--- Diff: api/src/main/java/org/apache/commons/rdf/api/RDFSyntax.java ---
@@ -22,6 +22,124 @@
import java.util.Optional;
/**
+ * An RDF
Github user stain commented on a diff in the pull request:
https://github.com/apache/commons-rdf/pull/27#discussion_r95841065
--- Diff: api/src/main/java/org/apache/commons/rdf/api/RDFSyntax.java ---
@@ -22,6 +22,124 @@
import java.util.Optional;
/**
+ * An RDF
Github user stain commented on a diff in the pull request:
https://github.com/apache/commons-rdf/pull/27#discussion_r95841290
--- Diff: api/src/main/java/org/apache/commons/rdf/api/RDFSyntax.java ---
@@ -34,7 +152,7 @@
* 1.1 Primer
* @see
Github user stain commented on a diff in the pull request:
https://github.com/apache/commons-rdf/pull/27#discussion_r95843006
--- Diff:
simple/src/main/java/org/apache/commons/rdf/simple/experimental/AbstractRDFParser.java
---
@@ -240,7 +240,7 @@ public T rdfTermFactory(RDF
Github user stain commented on a diff in the pull request:
https://github.com/apache/commons-rdf/pull/27#discussion_r95843235
--- Diff:
simple/src/main/java/org/apache/commons/rdf/simple/experimental/AbstractRDFParser.java
---
@@ -240,7 +240,7 @@ public T rdfTermFactory(RDF
Github user stain commented on the issue:
https://github.com/apache/commons-rdf/pull/30
This pull request returns `getLanguageTag()` in whatever case the
underlying platform does (e.g. I think RDF4J and JSONLD-Java preserves casing,
while Jena and Simple converts to lowercase
Github user stain commented on the issue:
https://github.com/apache/commons-rdf/pull/30
There seems to be consensus on
http://lists.w3.org/Archives/Public/public-rdf-comments/2017Jan/thread.html and
http://lists.w3.org/Archives/Public/semantic-web/2017Jan/thread.html in the
_Are
Github user stain commented on the issue:
https://github.com/apache/commons-rdf/pull/30
Right, BCP47 normalisation would make sense, but sadly that is not directly
permitted by RDF 1.1, only normalisation to lower case :-( - probably to
avoid dependency on the registry
Github user stain commented on the issue:
https://github.com/apache/commons-rdf/pull/30
OK, so then it makes sense for the Commons RDF tests to only care about the
value being preserved (whatever the case going in or out is upper or
lower), and that our .equals and .hashCode is
Github user stain commented on the issue:
https://github.com/apache/commons-rdf/pull/30
I added equivalent tests for `Graph` add/contains/remove, and this fails
for Jena:
```
java.lang.AssertionError
at org.junit.Assert.fail(Assert.java:86)
at
Github user stain commented on the issue:
https://github.com/apache/commons-rdf/pull/31
Thanks, this looks sensible to me!
Should we add unit test for each of the new `asRDFTerm` methods? They are
in a way already tested through `createLiteral` etc.., but just so we don&#
Github user stain commented on the issue:
https://github.com/apache/commons-rdf/pull/30
Thanks @afs , that makes sense, `JenaGraphImpl` was indeed using
`graph.delete()`.
I have fixed in both `JenaGraphImpl` and `JenaDatasetImpl`. See comment -
do you think there is much
Github user stain commented on the issue:
https://github.com/apache/commons-rdf/pull/30
I propose now to merge this branch following COMMONSRDF-55 fixing. Thanks
everyone!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user stain opened a pull request:
https://github.com/apache/commons-rdf/pull/32
COMMONSRDF-55: Handle Jena's urn:x-arq:DefaultGraph and friends
This fixes
[COMMONSRDF-55](https://issues.apache.org/jira/browse/COMMONSRDF-55) by adding
special testing of Jena
Github user stain commented on the issue:
https://github.com/apache/commons-rdf/pull/32
Any comments from perhaps @afs or @ajs6f? I'm not sure exactly at what
boundary we should replace `` and friends with
`Optional.empty()` -- in the solution of this PR it happens for any
Github user stain commented on the issue:
https://github.com/apache/commons-rdf/pull/32
The Commons RDF marker for the default graph (as of today) is
`Optional.empty()` and not an `RDFNode` (and thus can only be used in the
`Quad.getGraphName()` position).
There are four
Github user stain commented on the issue:
https://github.com/apache/commons-rdf/pull/32
The thing is a Commons RDF `JenaQuad` has in a way two feet into Jena - the
underlying Jena `Quad` as well as the underlying `Node` instances (which would
be wrapped as `RDFTerm` instances
Github user stain commented on the issue:
https://github.com/apache/commons-rdf/pull/32
I guess it's a question of where we put the "inconsistency" barrier. We can
probably assume that in the odd case that `urn:x-arq:DefaultGraph` appear
literally in a non-Jena `IRI
Github user stain commented on the issue:
https://github.com/apache/commons-rdf/pull/32
Note that option (2) would also add potential inconsistency between Commons
RDF `.getGraphName().isPresent()` and `asJenaQuad().isDefaultGraph()`, which is
unfortunate, but only in that from
Github user stain commented on the issue:
https://github.com/apache/commons-rdf/pull/32
I've added javadoc to this effect (commit 7bbff25) and will merge this now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user stain commented on a diff in the pull request:
https://github.com/apache/commons-rdf/pull/27#discussion_r100208441
--- Diff: api/src/main/java/org/apache/commons/rdf/api/RDFSyntax.java ---
@@ -178,17 +206,62 @@ private RDFSyntax(final String name, final String
Github user stain commented on a diff in the pull request:
https://github.com/apache/commons-rdf/pull/27#discussion_r100209281
--- Diff: api/src/main/java/org/apache/commons/rdf/api/RDFSyntax.java ---
@@ -91,7 +148,30 @@
* Datasets.
*/
public boolean
Github user stain commented on a diff in the pull request:
https://github.com/apache/commons-rdf/pull/27#discussion_r100211712
--- Diff: api/src/main/java/org/apache/commons/rdf/api/RDFSyntax.java ---
@@ -22,6 +22,124 @@
import java.util.Optional;
/**
+ * An RDF
Github user stain commented on the issue:
https://github.com/apache/commons-rdf/pull/27
Let's discuss the mutability etc. of the `RDFParser` factory separate on
dev@commons - that's a general thing which anyway should not affect this pull
request on `RDFSyntax`.
Github user stain commented on the issue:
https://github.com/apache/commons-rdf/pull/27
OK, so I added them as `Set` - it might be an ordered set (e.g.
`LinkedHashSet`).
I merged `RDFA_XHTML` and `RDFA_HTML` and made them return such a set to
include both `text/html` and
Github user stain commented on the issue:
https://github.com/apache/commons-rdf/pull/27
I've merged this. Thanks for the help, @ansell!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
39 matches
Mail list logo
