Github user stain commented on a diff in the pull request:
https://github.com/apache/commons-rdf/pull/49#discussion_r167732171
--- Diff:
commons-rdf-simple/src/main/java/org/apache/commons/rdf/simple/experimental/AbstractRDFParser.java
---
@@ -58,8 +60,12 @@
*/
public abstract class AbstractRDFParser<T extends AbstractRDFParser<T>>
implements RDFParser, Cloneable {
- public static final ThreadGroup threadGroup = new ThreadGroup("Commons
RDF parsers");
- private static final ExecutorService threadpool =
Executors.newCachedThreadPool(r -> new Thread(threadGroup, r));
+ public static final AtomicInteger threadCount = new AtomicInteger();
+ private static Thread newThread(Runnable r) {
--- End diff --
I disagree on this style change, the previous code was much cleaner. Why is
a method-reference on 4 lines that is only used once better than a very small
lambda?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
