[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #197: Fix non-thread safe code related to text date times

2019-03-15 Thread GitBox
stevedlawrence commented on a change in pull request #197: Fix non-thread safe code related to text date times URL: https://github.com/apache/incubator-daffodil/pull/197#discussion_r266057369 ## File path:

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #196: Use setScale() not round() when rounding BigDecimals

2019-03-15 Thread GitBox
mbeckerle commented on a change in pull request #196: Use setScale() not round() when rounding BigDecimals URL: https://github.com/apache/incubator-daffodil/pull/196#discussion_r266064793 ## File path:

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #196: Use setScale() not round() when rounding BigDecimals

2019-03-15 Thread GitBox
mbeckerle commented on a change in pull request #196: Use setScale() not round() when rounding BigDecimals URL: https://github.com/apache/incubator-daffodil/pull/196#discussion_r266065151 ## File path:

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #197: Fix non-thread safe code related to text date times

2019-03-15 Thread GitBox
mbeckerle commented on a change in pull request #197: Fix non-thread safe code related to text date times URL: https://github.com/apache/incubator-daffodil/pull/197#discussion_r266055142 ## File path:

[GitHub] [incubator-daffodil] jadams-tresys commented on issue #196: Use setScale() not round() when rounding BigDecimals

2019-03-15 Thread GitBox
jadams-tresys commented on issue #196: Use setScale() not round() when rounding BigDecimals URL: https://github.com/apache/incubator-daffodil/pull/196#issuecomment-473361431 Just added a test to confirm that BigDecimal.setScale does in fact return a copy of the original BigDecimal with

[GitHub] [incubator-daffodil] jadams-tresys opened a new pull request #196: Use setScale() not round() when rounding BigDecimals

2019-03-15 Thread GitBox
jadams-tresys opened a new pull request #196: Use setScale() not round() when rounding BigDecimals URL: https://github.com/apache/incubator-daffodil/pull/196 In order to perform a round/floor/ceiling on a BigDecimal and not retain any decimal points we need to use BD.setScale with a

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #196: Use setScale() not round() when rounding BigDecimals

2019-03-15 Thread GitBox
mbeckerle commented on a change in pull request #196: Use setScale() not round() when rounding BigDecimals URL: https://github.com/apache/incubator-daffodil/pull/196#discussion_r266057931 ## File path:

[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #196: Use setScale() not round() when rounding BigDecimals

2019-03-15 Thread GitBox
mbeckerle commented on a change in pull request #196: Use setScale() not round() when rounding BigDecimals URL: https://github.com/apache/incubator-daffodil/pull/196#discussion_r266057276 ## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/dpath/FNFunctions.scala

[GitHub] [incubator-daffodil] jadams-tresys commented on a change in pull request #196: Use setScale() not round() when rounding BigDecimals

2019-03-15 Thread GitBox
jadams-tresys commented on a change in pull request #196: Use setScale() not round() when rounding BigDecimals URL: https://github.com/apache/incubator-daffodil/pull/196#discussion_r266067762 ## File path:

[GitHub] [incubator-daffodil] stevedlawrence opened a new pull request #197: Fix non-thread safe code related to text date times

2019-03-15 Thread GitBox
stevedlawrence opened a new pull request #197: Fix non-thread safe code related to text date times URL: https://github.com/apache/incubator-daffodil/pull/197 We create an ICU Calendar object to handle parsing/unparsing text date times. Unfortunately, this Calendar object isn't thread

[jira] [Resolved] (DAFFODIL-2093) Cannot build and test daffodil in IntelliJ

2019-03-15 Thread Steve Lawrence (JIRA)
[ https://issues.apache.org/jira/browse/DAFFODIL-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Lawrence resolved DAFFODIL-2093. -- Resolution: Fixed Fixed in commit 9db5146504d8195f7503cf4fca066b9a7083d6d1

[GitHub] [incubator-daffodil] stevedlawrence merged pull request #195: Changes to support building in IntelliJ

2019-03-15 Thread GitBox
stevedlawrence merged pull request #195: Changes to support building in IntelliJ URL: https://github.com/apache/incubator-daffodil/pull/195 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-daffodil] jadams-tresys commented on a change in pull request #196: Use setScale() not round() when rounding BigDecimals

2019-03-15 Thread GitBox
jadams-tresys commented on a change in pull request #196: Use setScale() not round() when rounding BigDecimals URL: https://github.com/apache/incubator-daffodil/pull/196#discussion_r266061115 ## File path:

Re: Daffodil IntelliJ Support

2019-03-15 Thread Steve Lawrence
For those interested in using IntelliJ, the below changes have been merged into Daffodil to allow building with IntelliJ. Documentation on how to set it up to build and run tests is available on the wiki: https://cwiki.apache.org/confluence/display/DAFFODIL/IntelliJ+IDEA+Setup - Steve On

[GitHub] [incubator-daffodil] stevedlawrence commented on issue #196: Use setScale() not round() when rounding BigDecimals

2019-03-15 Thread GitBox
stevedlawrence commented on issue #196: Use setScale() not round() when rounding BigDecimals URL: https://github.com/apache/incubator-daffodil/pull/196#issuecomment-473392810 +1 This is an automated message from the Apache

[jira] [Assigned] (DAFFODIL-2075) dfdl:hexBinary does not correcty reduce xs:integer

2019-03-15 Thread Josh Adams (JIRA)
[ https://issues.apache.org/jira/browse/DAFFODIL-2075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Adams reassigned DAFFODIL-2075: Assignee: Josh Adams > dfdl:hexBinary does not correcty reduce xs:integer >

[GitHub] [incubator-daffodil] jadams-tresys merged pull request #196: Use setScale() not round() when rounding BigDecimals

2019-03-15 Thread GitBox
jadams-tresys merged pull request #196: Use setScale() not round() when rounding BigDecimals URL: https://github.com/apache/incubator-daffodil/pull/196 This is an automated message from the Apache Git Service. To respond to

[jira] [Resolved] (DAFFODIL-2076) fn:ceiling does not work on xs:decimal

2019-03-15 Thread Josh Adams (JIRA)
[ https://issues.apache.org/jira/browse/DAFFODIL-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Adams resolved DAFFODIL-2076. -- Resolution: Fixed Assignee: Dave Thompson (was: Josh Adams) This has been resolved

[GitHub] [incubator-daffodil] stevedlawrence merged pull request #197: Fix non-thread safe code related to text date times

2019-03-15 Thread GitBox
stevedlawrence merged pull request #197: Fix non-thread safe code related to text date times URL: https://github.com/apache/incubator-daffodil/pull/197 This is an automated message from the Apache Git Service. To respond to

[jira] [Resolved] (DAFFODIL-2097) Non-thread safe code related to EvCalendar

2019-03-15 Thread Steve Lawrence (JIRA)
[ https://issues.apache.org/jira/browse/DAFFODIL-2097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Lawrence resolved DAFFODIL-2097. -- Resolution: Fixed Fixed in commit a01cc32375a50761a9688c6243c245df59ba85a0 >

[jira] [Created] (DAFFODIL-2097) Non-thread safe code related to EvCalendar

2019-03-15 Thread Steve Lawrence (JIRA)
Steve Lawrence created DAFFODIL-2097: Summary: Non-thread safe code related to EvCalendar Key: DAFFODIL-2097 URL: https://issues.apache.org/jira/browse/DAFFODIL-2097 Project: Daffodil

[jira] [Commented] (DAFFODIL-2097) Non-thread safe code related to EvCalendar

2019-03-15 Thread Steve Lawrence (JIRA)
[ https://issues.apache.org/jira/browse/DAFFODIL-2097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793664#comment-16793664 ] Steve Lawrence commented on DAFFODIL-2097: -- I was thinking we could just clone the calendar

[jira] [Commented] (DAFFODIL-2097) Non-thread safe code related to EvCalendar

2019-03-15 Thread Michael Beckerle (JIRA)
[ https://issues.apache.org/jira/browse/DAFFODIL-2097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793657#comment-16793657 ] Michael Beckerle commented on DAFFODIL-2097: So this happens because the CalendarEv gets

[jira] [Assigned] (DAFFODIL-2076) fn:ceiling does not work on xs:decimal

2019-03-15 Thread Josh Adams (JIRA)
[ https://issues.apache.org/jira/browse/DAFFODIL-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Adams reassigned DAFFODIL-2076: Assignee: Josh Adams > fn:ceiling does not work on xs:decimal >