[dpdk-dev] [PATCH v2 1/4] bus/vmbus: add hyper-v virtual bus support

2018-04-16 Thread Stephen Hemminger
From: Stephen Hemminger This patch adds support for an additional bus type Virtual Machine BUS (VMBUS) on Microsoft Hyper-V in Windows 10, Windows Server 2016 and Azure. Most of this code was extracted from FreeBSD and some of this is from earlier code donated by Brocade. Only Linux is supported

[dpdk-dev] [PATCH v2 2/4] net/netvsc: add hyper-v netvsc network device

2018-04-16 Thread Stephen Hemminger
From: Stephen Hemminger The driver supports Hyper-V networking directly like virtio for KVM or vmxnet3 for VMware. This code is based off of the FreeBSD driver. The file and variable names are kept the same to help with understanding (with most of the BSD style warts removed). Signed-off-by: St

[dpdk-dev] [PATCH v2 4/4] bus/vmbus and net/netvsc: add meson build support

2018-04-16 Thread Stephen Hemminger
Update meson build files for new netvsc and vmbus drivers. Signed-off-by: Stephen Hemminger --- config/meson.build | 7 +++ drivers/bus/meson.build| 2 +- drivers/bus/vmbus/meson.build | 17 + drivers/net/meson.build| 2 +- drivers/net/netvsc/m

[dpdk-dev] [PATCH v2 3/4] net/netvsc: add documentation

2018-04-16 Thread Stephen Hemminger
Matching documentation for new netvsc device. Signed-off-by: Stephen Hemminger --- doc/guides/nics/index.rst | 1 + doc/guides/nics/netvsc.rst | 73 ++ doc/guides/rel_notes/release_18_05.rst | 6 +++ 3 files changed, 80 insertions(+) create mod

Re: [dpdk-dev] [PATCH] eal/ipc: fix missing ignore message name

2018-04-16 Thread Thomas Monjalon
13/04/2018 18:16, Tan, Jianfeng: > > On 4/13/2018 11:55 PM, Anatoly Burakov wrote: > > We are trying to notify sender that response from current process > > should be ignored, but we didn't specify which request this response > > was for. Fix by copying request name from the original message. > >

[dpdk-dev] [PATCH 00/14] bnxt patchset

2018-04-16 Thread Ajit Khaparde
patchset against dpdk-next-net. Please apply. Thanks Ajit Khaparde (13): net/bnxt: set default log level to informational net/bnxt: set padding flags in Rx descriptor net/bnxt: fix bnxt_hwrm_vnic_alloc net/bnxt: fix incorrect ntuple flag setting net/bnxt: fix Rx checksum flags for tunne

[dpdk-dev] [PATCH 03/14] net/bnxt: fix bnxt_hwrm_vnic_alloc

2018-04-16 Thread Ajit Khaparde
In bnxt_hwrm_vnic_alloc, use rte_cpu_to_le_32 while setting the flags. Fixes: 2691827e82c0 ("net/bnxt: add HWRM VNIC alloc") Cc: sta...@dpdk.org Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bn

[dpdk-dev] [PATCH 04/14] net/bnxt: fix incorrect ntuple flag setting

2018-04-16 Thread Ajit Khaparde
We are wrongly setting the Rx path flag while creating the ntuple filter. It needs to be set for L2 or Exact Match filters only. Fixes: 5ef3b79fdfe6 ("net/bnxt: support flow filter ops") Cc: sta...@dpdk.org Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_filter.c | 3 ++- 1 file changed,

[dpdk-dev] [PATCH 01/14] net/bnxt: set default log level to informational

2018-04-16 Thread Ajit Khaparde
Set the default log level to RTE_LOG_INFO from RTE_LOG_NOTICE. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 1d4ff54b7..b7aab65ab 100644 ---

[dpdk-dev] [PATCH 05/14] net/bnxt: fix Rx checksum flags for tunnel frames

2018-04-16 Thread Ajit Khaparde
Fix Rx checksum status for tunnel frames as seen by hardware. Current code does not handle cases for tunnel frames correctly. Fixes: 7ec39d8c524b ("net/bnxt: update status of Rx IP/L4 CKSUM") Cc: sta...@dpdk.org Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_rxr.h | 16

[dpdk-dev] [PATCH 02/14] net/bnxt: set padding flags in Rx descriptor

2018-04-16 Thread Ajit Khaparde
Set the RX_PROD_PKT_BD_FLAGS_EOP_PAD in Rx buffer descriptors. Fixes: 2eb53b134aae ("net/bnxt: add initial Rx code") Cc: sta...@dpdk.org Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_rxr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_rxr.c b/

[dpdk-dev] [PATCH 10/14] net/bnxt: reset l2_filter_id once filter is freed

2018-04-16 Thread Ajit Khaparde
The fw_l2_filter_id for a ntuple filter is needed only for the lifetime of the ntuple filter. Once the filter is free, reset the field. The associated l2_filter will be freed as a part of its own cleanup. Fixes: 5ef3b79fdfe6 ("net/bnxt: support flow filter ops") Cc: sta...@dpdk.org Signed-off-by:

[dpdk-dev] [PATCH 06/14] net/bnxt: fix L2 filter cleanup

2018-04-16 Thread Ajit Khaparde
We are wrongly freeing up a filter in the driver while it is still configured in the HW. This can cause incorrect L2 filter id to be used for filters created subsequently. This filter will be cleared on cleanup anyway. Fixes: 5ef3b79fdfe6 ("net/bnxt: support flow filter ops") Cc: sta...@dpdk.org

[dpdk-dev] [PATCH 11/14] net/bnxt: free memory allocated for VF filters

2018-04-16 Thread Ajit Khaparde
Memory allocated to hold VF filter info is not being freed currently. This can cause potential memory leak. Fixes: 7a5b0874440e ("net/bnxt: support to add a VF MAC address") Cc: sta...@dpdk.org Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_filter.c | 8 1 file changed, 8 insert

[dpdk-dev] [PATCH 12/14] net/bnxt: use UINT64_MAX to initialize filter ids

2018-04-16 Thread Ajit Khaparde
Use UINT64_MAX to initialize l2, ntuple, em filter_id fields instead of hardcoded -1; Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_filter.c | 8 drivers/net/bnxt/bnxt_hwrm.c | 8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/bnxt/bnxt_fi

[dpdk-dev] [PATCH 09/14] net/bnxt: maintain rx_mbuf_alloc_fail per RxQ

2018-04-16 Thread Ajit Khaparde
Currently we have a single counter for mbuf alloc failure. Make it per RxQ instead. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h| 1 - drivers/net/bnxt/bnxt_ethdev.c | 1 - drivers/net/bnxt/bnxt_rxq.c| 1 + drivers/net/bnxt/bnxt_rxq.h| 1 + drivers/net/bnxt/bnxt_r

[dpdk-dev] [PATCH 07/14] net/bnxt: fix bnxt_flow_destroy

2018-04-16 Thread Ajit Khaparde
bnxt_hwrm_clear_l2_filter needs to be called only if the filter type is L2 and not otherwise. Also check for the return value of bnxt_hwrm_clear_l2_filter(). Fixes: 5ef3b79fdfe6 ("net/bnxt: support flow filter ops") Cc: sta...@dpdk.org Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_filt

[dpdk-dev] [PATCH 08/14] net/bnxt: add code to determine the Tx COS queue

2018-04-16 Thread Ajit Khaparde
The hwrm_queue_qportcfg command has been extended to determine the COS queue that a Tx ring needs to use. This patch adds code to determine the information from the FW and use it while creating the Tx rings. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h| 2 + drivers

[dpdk-dev] [PATCH 14/14] bnxt: add device ID for Stratus VF

2018-04-16 Thread Ajit Khaparde
From: Somnath Kotur Fixes: 1cd45aeb3270 ("net/bnxt: support Stratus VF device") Cc: ajit.khapa...@broadcom.com Signed-off-by: Somnath Kotur --- drivers/net/bnxt/bnxt_ethdev.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/

[dpdk-dev] [PATCH 13/14] net/bnxt: avoid freeing mem_zone multiple times

2018-04-16 Thread Ajit Khaparde
Since we are storing the mem_zone address for each ring created, we are freeing the same address multiple times. For example the memory zone created for Rx is being freed during Rx ring cleanup, AGG ring cleanup and CQ cleanup. Avoid this by storing the memory zone address in RXQ instead and free i

Re: [dpdk-dev] [PATCH v6 51/70] mem: add support for mapping hugepages at runtime

2018-04-16 Thread Yongseok Koh
> On Apr 11, 2018, at 5:30 AM, Anatoly Burakov > wrote: > > Nothing uses this code yet. The bulk of it is copied from old > memory allocation code (linuxapp eal_memory.c). We provide an > EAL-internal API to allocate either one page or multiple pages, > guaranteeing that we'll get contiguous VA

Re: [dpdk-dev] [PATCH v2 0/5] allow procinfo and pdump on eth vdev

2018-04-16 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jianfeng Tan > Sent: Friday, April 6, 2018 1:45 AM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Tan, Jianfeng > Subject: [dpdk-dev] [PATCH v2 0/5] allow procinfo and pdump on eth vdev > > v2: > - Add spinlock

Re: [dpdk-dev] [PATCH v6 44/70] net/mlx5: use virt2memseg instead of iteration

2018-04-16 Thread Yongseok Koh
> On Apr 11, 2018, at 5:30 AM, Anatoly Burakov > wrote: > > Reduce dependency on internal details of EAL memory subsystem, and > simplify code. > > Signed-off-by: Anatoly Burakov > Tested-by: Santosh Shukla > Tested-by: Hemant Agrawal > Tested-by: Gowrishankar Muthukrishnan > --- > drivers

[dpdk-dev] [PATCH v3] drivers/net/i40e: fix missing promiscuous disable at device disable

2018-04-16 Thread Rosen Xu
v3 updates: === - Move modification from device close to device disable - i40evf_reset_vf() will cause kernel driver enable all vlan promiscuous, so unicast/multicast promiscuous disable should set before reset. v2 updates: === - Add more comments In scenario of Kernel Drive

Re: [dpdk-dev] [PATCH v2] drivers/net/i40e/i40e_ethdev_vf.c: fix missing promiscuous disable at device stop

2018-04-16 Thread Xu, Rosen
Hi Helin, > -Original Message- > From: Zhang, Helin > Sent: Thursday, March 29, 2018 13:11 > To: Zhang, Qi Z ; Xu, Rosen ; > Xing, Beilei > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2] drivers/net/i40e/i40e_ethdev_vf.c: fix > missing promiscuous disable at device stop > > > >

[dpdk-dev] [PATCH v3] kni: fix possible rx_q mbuf leaks and speed up alloc_q release

2018-04-16 Thread Yangchao Zhou
rx_q fifo can only be released by kernel thread. There may be mbuf leaks in rx_q because kernel threads are randomly stopped. When the kni is released and netdev is unregisterd, convert the physical address mbufs in rx_q to the virtual address in free_q. By the way, alloc_q can be processed toget

Re: [dpdk-dev] [PATCH v3 04/14] net/mlx5: support Rx tunnel type identification

2018-04-16 Thread Xueming(Steven) Li
> -Original Message- > From: Adrien Mazarguil > Sent: Tuesday, April 17, 2018 12:03 AM > To: Xueming(Steven) Li > Cc: Nélio Laranjeiro ; Shahaf Shuler > ; dev@dpdk.org; > Olivier Matz > Subject: Re: [PATCH v3 04/14] net/mlx5: support Rx tunnel type identification > > On Mon, Apr 16,

Re: [dpdk-dev] [PATCH] drivers/net: update link status

2018-04-16 Thread Tiwei Bie
On Mon, Apr 16, 2018 at 05:10:24PM +0100, Ferruh Yigit wrote: > On 4/14/2018 11:55 AM, Tiwei Bie wrote: > > On Fri, Apr 13, 2018 at 10:53:55PM +0100, Ferruh Yigit wrote: > >> On 4/10/2018 4:41 PM, Tiwei Bie wrote: > >>> On Tue, Mar 13, 2018 at 06:05:34PM +, Ferruh Yigit wrote: > Update lin

[dpdk-dev] whether DPDK support FreeBSD Guest OS VM on Xen hypervisor.

2018-04-16 Thread Zhongliang Shu
Hi, Guys: I have found the DPDK Xen Guideline and there have example and steps About how DPDK supporting Linux Guest OS VM on Xen Hypervisor. But I cannot find similar document  about FreeBSD Guest OS VM on Xen Hypervisor. For example, 1): there has xen_dom0.ko under librte_eal/linuxapp, but n

Re: [dpdk-dev] [PATCH v2] net/enic: add primary mac address handler

2018-04-16 Thread Hyong Youb Kim
On Mon, Apr 16, 2018 at 11:40:17AM +0200, David Marchand wrote: > Modified enic_del_mac_address() to get a return value from the vnic layer. > Reused the .mac_addr_add and .mac_addr_del callbacks code to implement > primary mac address handler. > > Signed-off-by: David Marchand > --- Thanks. Th

Re: [dpdk-dev] [PATCH v4 3/4] app/testpmd: add more GRE extension to csum engine

2018-04-16 Thread Xueming(Steven) Li
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, April 17, 2018 6:45 AM > To: Xueming(Steven) Li > Cc: dev@dpdk.org; Wenzhuo Lu ; Jingjing Wu > ; Yongseok Koh > ; Olivier MATZ ; Shahaf Shuler > ; > Ferruh Yigit > Subject: Re: [dpdk-dev] [PATCH v4 3/4] app/testpmd: add mo

Re: [dpdk-dev] [PATCH v8 0/5] add ifcvf vdpa driver

2018-04-16 Thread Wang, Xiao W
Thanks for the reminder. Will fix it. BRs, Xiao > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, April 17, 2018 2:07 AM > To: Wang, Xiao W > Cc: Yigit, Ferruh ; Burakov, Anatoly > ; dev@dpdk.org; maxime.coque...@redhat.com; > Wang, Zhihong ; Bie,

[dpdk-dev] [PATCH] net/nfp: fix possible resource leak

2018-04-16 Thread Yangchao Zhou
Signed-off-by: Yangchao Zhou --- drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c index ad6ce72..f2fcc4a 100644 --- a/drivers/net/nfp/nfpcore

Re: [dpdk-dev] [PATCH v5 01/19] crypto/ccp: add AMD ccp skeleton PMD

2018-04-16 Thread Kumar, Ravi1
>Hi Ravi, > >> -Original Message- >> From: Kumar, Ravi1 [mailto:ravi1.ku...@amd.com] >> Sent: Monday, April 2, 2018 6:50 AM >> To: De Lara Guarch, Pablo ; >> dev@dpdk.org >> Cc: hemant.agra...@nxp.com >> Subject: RE: [PATCH v5 01/19] crypto/ccp: add AMD ccp skeleton PMD >> >> > >> > >> >>

[dpdk-dev] [disscussion] A problem about dpdk backup-mode bond switching with mlx4 VF devices

2018-04-16 Thread chenchanghu
Hi, When I used the mlx4 pmd, I meet a problem about mlx4 VF bond switching which bond mod is backup-mode . The detail test is descripted below. 1.Test environmemt infomation: a. Linux distribution: CentOS b. dpdk version: dpdk-16.04 c. Ethernet device : mlx4 VF d. pmd info: mlx4

Re: [dpdk-dev] [PATCH v2 07/15] net/mlx5: support tunnel RSS level

2018-04-16 Thread Nélio Laranjeiro
On Sat, Apr 14, 2018 at 12:25:12PM +, Xueming(Steven) Li wrote: >[...] > > > @@ -1211,23 +1322,23 @@ mlx5_flow_convert(struct rte_eth_dev *dev, > > > if (ret) > > > goto exit_free; > > > } > > > - if (parser->mark) > > > - mlx5_flow_create_flag_mark(parser,

Re: [dpdk-dev] [PATCH v5 2/5] vhost: support selective datapath

2018-04-16 Thread Maxime Coquelin
On 04/15/2018 07:39 PM, Thomas Monjalon wrote: 03/04/2018 10:02, Maxime Coquelin: On 04/02/2018 01:46 PM, Zhihong Wang wrote: lib/librte_vhost/Makefile | 4 +- lib/librte_vhost/rte_vdpa.h| 87 + lib/librte_vhost/rte_vhost_version.map

Re: [dpdk-dev] [PATCH v3 04/14] net/mlx5: support Rx tunnel type identification

2018-04-16 Thread Nélio Laranjeiro
On Sat, Apr 14, 2018 at 12:57:58PM +, Xueming(Steven) Li wrote: > +Adrien > > > -Original Message- > > From: Nélio Laranjeiro > > Sent: Friday, April 13, 2018 9:03 PM > > To: Xueming(Steven) Li > > Cc: Shahaf Shuler ; dev@dpdk.org; Olivier Matz > > > > Subject: Re: [PATCH v3 04/14]

Re: [dpdk-dev] [PATCH v7 7/8] examples/vhost_crypto: add vhost crypto sample application

2018-04-16 Thread Maxime Coquelin
On 04/15/2018 07:35 PM, Thomas Monjalon wrote: 15/04/2018 16:34, Thomas Monjalon: Hi, 05/04/2018 18:01, Fan Zhang: This patch adds vhost_crypto sample application to DPDK. Signed-off-by: Fan Zhang --- examples/vhost_crypto/Makefile| 32 +++ examples/vhost_crypto/main.c | 541 +

Re: [dpdk-dev] [PATCH] ethdev: remove new to old offloads API helpers

2018-04-16 Thread Thomas Monjalon
16/04/2018 08:02, Shahaf Shuler: > According to > > commit 315ee8374e0e ("doc: reduce initial offload API rework scope >to drivers") > > All PMDs should have moved to the new offloads API. Therefore it is safe > to remove the new->old convert helps. > > The old->new helpers w

Re: [dpdk-dev] [PATCH v2 07/15] net/mlx5: support tunnel RSS level

2018-04-16 Thread Xueming(Steven) Li
> -Original Message- > From: Nélio Laranjeiro > Sent: Monday, April 16, 2018 3:14 PM > To: Xueming(Steven) Li > Cc: Shahaf Shuler ; dev@dpdk.org > Subject: Re: [PATCH v2 07/15] net/mlx5: support tunnel RSS level > > On Sat, Apr 14, 2018 at 12:25:12PM +, Xueming(Steven) Li wrote: >

Re: [dpdk-dev] [PATCH v3 04/14] net/mlx5: support Rx tunnel type identification

2018-04-16 Thread Xueming(Steven) Li
> -Original Message- > From: Nélio Laranjeiro > Sent: Monday, April 16, 2018 3:29 PM > To: Xueming(Steven) Li > Cc: Shahaf Shuler ; dev@dpdk.org; Olivier Matz > ; Adrien Mazarguil > Subject: Re: [PATCH v3 04/14] net/mlx5: support Rx tunnel type > identification > > On Sat, Apr 14, 201

Re: [dpdk-dev] [PATCH] net/bonding: fix link properties with autoneg

2018-04-16 Thread Matan Azrad
Hi Chas From: Chas Williams, Wednesday, February 14, 2018 12:55 AM > If a link is carrier down and using autonegotiation, then the PMD may not > have detected a speed yet. In this case the best we can do is ignore the link > speed and duplex since they aren't valid. Ok for this. > To be comple

Re: [dpdk-dev] [PATCH v2 07/15] net/mlx5: support tunnel RSS level

2018-04-16 Thread Nélio Laranjeiro
On Mon, Apr 16, 2018 at 07:46:08AM +, Xueming(Steven) Li wrote: >[...] > > > > > @@ -1386,6 +1386,8 @@ mlx5_ind_table_ibv_verify(struct rte_eth_dev > > *dev) > > > > > * Number of queues. > > > > > * @param tunnel > > > > > * Tunnel type. > > > > > + * @param rss_level > > > > > + *

Re: [dpdk-dev] [PATCH v3 3/4] ethdev: add TTL change actions in flow API

2018-04-16 Thread Adrien Mazarguil
Hi Shahaf, On Mon, Apr 16, 2018 at 05:48:19AM +, Shahaf Shuler wrote: > Hi Qi, > > Am wondering if we can make the below more generic and not tailored for > specific use cases. Regarding this, please see my previous answer [1] where I asked Qi to make his changes more focused on the use ca

Re: [dpdk-dev] [PATCH v3 11/14] net/mlx5: support MPLS-in-GRE and MPLS-in-UDP

2018-04-16 Thread Nélio Laranjeiro
On Fri, Apr 13, 2018 at 03:22:50PM +, Xueming(Steven) Li wrote: >[...] > > @@ > > > > static > > > > > const struct mlx5_flow_items mlx5_flow_items[] = { > > > > > .convert = mlx5_flow_create_vxlan_gpe, > > > > > .dst_sz = sizeof(struct ibv_flow_spec_tunnel), > > >

Re: [dpdk-dev] DEV_RX_OFFLOAD_SCATTER for ixgbe and igb devices

2018-04-16 Thread Stokes, Ian
> On 4/13/2018 3:52 PM, Stokes, Ian wrote: > > Hi all, > > > > Currently it's the case that for some NICs (e.g. igb driver or ixgbe > driver based), scatter_rx needs to be enabled explicitly in the case where > it was not configured before. > > > > A patch submitted for ovs-dpdk proposes to check t

Re: [dpdk-dev] kernel binding of devices + hotplug

2018-04-16 Thread Bruce Richardson
On Sat, Apr 14, 2018 at 08:10:28PM +, Matan Azrad wrote: > Hi all > > From: Burakov, Anatoly, Friday, April 13, 2018 8:41 PM > > To: Bruce Richardson ; Thomas Monjalon > > > > Cc: dev@dpdk.org; pmati...@redhat.com; david.march...@6wind.com; > > jia@intel.com; Matan Azrad ; > > konstantin.

[dpdk-dev] [PATCH] net/ixgbe: fix segfault in configuring VF VLAN strip

2018-04-16 Thread Wei Dai
This patch fixes a segment fault in ixgbevf_vlan_offload_set( ) when a Rx queue with index < max_rx_queues is not setup. For such queue, rxq = dev->data->rx_queues[i] is null pointer. Fixes: 860a94d3c692 ("net/ixgbe: support VLAN strip per queue offloading in VF") Cc: sta...@dpdk.org Signed-off-b

Re: [dpdk-dev] [PATCH] net/ixgbe: fix segfault in configuring VF VLAN strip

2018-04-16 Thread Lin, Xueqin
Tested-by: Xueqin Lin 1. Branch: master 2. NIC: Niantic Steps: 1. Pull branch code to newest and apply the patch 2. Create one VF port using kernel PF echo 1 > /sys/bus/pci/devices/\:81\:00.0/sriov_numvfs 3. Bind VF to igb_uio 4. Start testpmd, find VF testpmd could startup successfully.

Re: [dpdk-dev] [PATCH v3 3/4] ethdev: add TTL change actions in flow API

2018-04-16 Thread Shahaf Shuler
Monday, April 16, 2018 11:12 AM, Adrien Mazarguil: > Subject: Re: [dpdk-dev] [PATCH v3 3/4] ethdev: add TTL change actions in > flow API > > Hi Shahaf, > > On Mon, Apr 16, 2018 at 05:48:19AM +, Shahaf Shuler wrote: > > Hi Qi, > > > > Am wondering if we can make the below more generic and not

Re: [dpdk-dev] [PATCH] net/ixgbe: fix segfault in configuring VF VLAN strip

2018-04-16 Thread Lin, Xueqin
> -Original Message- > From: Dai, Wei > Sent: Monday, April 16, 2018 4:14 PM > To: Lu, Wenzhuo ; Ananyev, Konstantin > ; Zhang, Qi Z ; Lin, > Xueqin > Cc: dev@dpdk.org; Dai, Wei ; sta...@dpdk.org > Subject: [PATCH] net/ixgbe: fix segfault in configuring VF VLAN strip > > This patch fixes

Re: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix the default aead assignments

2018-04-16 Thread Akhil Goyal
On 4/11/2018 2:45 PM, Hemant Agrawal wrote: The code is incorrectly updating the authxform instead of aead xforms. Fixes: b79e4c00af0e ("cryptodev: use AES-GCM/CCM as AEAD algorithms") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- examples/l2fwd-crypto/main.c | 4 ++-- 1 file changed,

Re: [dpdk-dev] [PATCH 1/2] crypto/dpaa_sec: improve the error checking

2018-04-16 Thread Akhil Goyal
On 4/5/2018 2:05 PM, Hemant Agrawal wrote: From: Sunil Kumar Kori Reported by NXP's internal coverity Signed-off-by: Sunil Kumar Kori --- drivers/crypto/dpaa_sec/dpaa_sec.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) Acked-by: Akhil Goyal

Re: [dpdk-dev] [PATCH 2/2] crypto/dpaa2_sec: improve error handling

2018-04-16 Thread Akhil Goyal
On 4/5/2018 2:05 PM, Hemant Agrawal wrote: From: Sunil Kumar Kori Fixed as reported by NXP's internal coverity. Also part of dpdk coverity. Coverity issue: 268331 Coverity issue: 268333 Signed-off-by: Sunil Kumar Kori --- Acked-by: Akhil Goyal

Re: [dpdk-dev] [v3,3/3] doc: add private data info in crypto guide

2018-04-16 Thread Akhil Goyal
Hi Abhinandan, On 4/16/2018 12:24 PM, Abhinandan Gujjar wrote: Signed-off-by: Abhinandan Gujjar Acked-by: Akhil Goyal I think I acked this complete series. And this patch is v2 not v3. You should also mention the changelog. Thanks, Akhil --- doc/guides/prog_guide/cryptodev_lib.rst | 27 +

Re: [dpdk-dev] kernel binding of devices + hotplug

2018-04-16 Thread Guo, Jia
hi, all On 4/15/2018 4:10 AM, Matan Azrad wrote: Hi all From: Burakov, Anatoly, Friday, April 13, 2018 8:41 PM To: Bruce Richardson ; Thomas Monjalon Cc: dev@dpdk.org; pmati...@redhat.com; david.march...@6wind.com; jia@intel.com; Matan Azrad ; konstantin.anan...@intel.com; step...@networ

Re: [dpdk-dev] [PATCH v3 04/14] net/mlx5: support Rx tunnel type identification

2018-04-16 Thread Adrien Mazarguil
On Mon, Apr 16, 2018 at 08:05:13AM +, Xueming(Steven) Li wrote: > > > > -Original Message- > > From: Nélio Laranjeiro > > Sent: Monday, April 16, 2018 3:29 PM > > To: Xueming(Steven) Li > > Cc: Shahaf Shuler ; dev@dpdk.org; Olivier Matz > > ; Adrien Mazarguil > > Subject: Re: [PATC

Re: [dpdk-dev] [v3,3/3] doc: add private data info in crypto guide

2018-04-16 Thread Gujjar, Abhinandan S
Hi Akhil, Missed out the *series* and thought the ack was only on the doc patch. Regarding change log, Just before posting I looked at recent patches. Most of them, didn't have change log! So, I didn't add it. Yes, there is a typo in the subject of this patch. Does this require newer version of p

[dpdk-dev] [PATCH v2] net/enic: add primary mac address handler

2018-04-16 Thread David Marchand
Modified enic_del_mac_address() to get a return value from the vnic layer. Reused the .mac_addr_add and .mac_addr_del callbacks code to implement primary mac address handler. Signed-off-by: David Marchand --- Changes since v1: - rebased on dpdk-next-net following mac_addr_set rework, - since eni

Re: [dpdk-dev] [PATCH v3 3/4] ethdev: add TTL change actions in flow API

2018-04-16 Thread Adrien Mazarguil
On Mon, Apr 16, 2018 at 08:56:37AM +, Shahaf Shuler wrote: > Monday, April 16, 2018 11:12 AM, Adrien Mazarguil: > > Subject: Re: [dpdk-dev] [PATCH v3 3/4] ethdev: add TTL change actions in > > flow API > > > > Hi Shahaf, > > > > On Mon, Apr 16, 2018 at 05:48:19AM +, Shahaf Shuler wrote: >

Re: [dpdk-dev] [pull-request] next-eventdev 18.05 RC1

2018-04-16 Thread Thomas Monjalon
14/04/2018 09:25, Jerin Jacob: > http://dpdk.org/git/next/dpdk-next-eventdev Pulled, thanks

Re: [dpdk-dev] [PATCH v7 1/5] vfio: extend data structure for multi container

2018-04-16 Thread Burakov, Anatoly
On 15-Apr-18 4:33 PM, Xiao Wang wrote: Currently eal vfio framework binds vfio group fd to the default container fd during rte_vfio_setup_device, while in some cases, e.g. vDPA (vhost data path acceleration), we want to put vfio group to a separate container and program IOMMU via this container.

Re: [dpdk-dev] [PATCH v7 2/5] vfio: add multi container support

2018-04-16 Thread Burakov, Anatoly
On 15-Apr-18 4:33 PM, Xiao Wang wrote: This patch adds APIs to support container create/destroy and device bind/unbind with a container. It also provides API for IOMMU programing on a specified container. A driver could use "rte_vfio_create_container" helper to create a ^^ wrong API name in co

[dpdk-dev] [PATCH] app/eventdev: fix typos in timer adapter options

2018-04-16 Thread Thomas Monjalon
The options names in code and doc are not the same. Fixes: 98c6292105d4 ("app/eventdev: add options for event timer adapter") Cc: pbhagavat...@caviumnetworks.com Signed-off-by: Thomas Monjalon --- app/test-eventdev/evt_options.c | 2 +- doc/guides/tools/testeventdev.rst | 12 ++-- 2

Re: [dpdk-dev] [PATCH v2 07/15] net/mlx5: support tunnel RSS level

2018-04-16 Thread Xueming(Steven) Li
> -Original Message- > From: Nélio Laranjeiro > Sent: Monday, April 16, 2018 4:09 PM > To: Xueming(Steven) Li > Cc: Shahaf Shuler ; dev@dpdk.org > Subject: Re: [PATCH v2 07/15] net/mlx5: support tunnel RSS level > > On Mon, Apr 16, 2018 at 07:46:08AM +, Xueming(Steven) Li wrote: >

Re: [dpdk-dev] [PATCH] app/eventdev: fix typos in timer adapter options

2018-04-16 Thread Pavan Nikhilesh
On Mon, Apr 16, 2018 at 12:03:53PM +0200, Thomas Monjalon wrote: > The options names in code and doc are not the same. > > Fixes: 98c6292105d4 ("app/eventdev: add options for event timer adapter") > Cc: pbhagavat...@caviumnetworks.com > > Signed-off-by: Thomas Monjalon > --- > app/test-eventdev/e

Re: [dpdk-dev] [PATCH] eal: fix compilation without VFIO

2018-04-16 Thread Burakov, Anatoly
On 16-Apr-18 6:50 AM, Shahaf Shuler wrote: Friday, April 13, 2018 4:59 PM, Thomas Monjalon: OK. Shahaf, will you submit a v2 with this, or should i do it? I think it should be just a matter of #ifndef VFIO_PRESENT //define vfio_device_info struct #endif - this should take care of the problem of

Re: [dpdk-dev] [PATCH] app/eventdev: fix typos in timer adapter options

2018-04-16 Thread Pavan Nikhilesh
On Mon, Apr 16, 2018 at 12:03:53PM +0200, Thomas Monjalon wrote: > The options names in code and doc are not the same. > > Fixes: 98c6292105d4 ("app/eventdev: add options for event timer adapter") > Cc: pbhagavat...@caviumnetworks.com > > Signed-off-by: Thomas Monjalon > --- > app/test-eventdev/e

[dpdk-dev] [PATCH] drivers/net: remove duplicated includes

2018-04-16 Thread Thomas Monjalon
Duplicated includes are found with devtools/check-dup-includes.sh Signed-off-by: Thomas Monjalon --- drivers/net/axgbe/axgbe_common.h | 1 - drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/net/axgbe/axgbe_common.h b/drivers/net/ax

[dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null terminated.

2018-04-16 Thread Fan Zhang
Coverity issue: 272563 Fixes: 8245472c58c8 ("examples/ip_pipeline: add sw queue object") Signed-off-by: Fan Zhang --- examples/ip_pipeline/swq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/ip_pipeline/swq.c b/examples/ip_pipeline/swq.c index c11bbf27e..be78704c1

[dpdk-dev] [PATCH] net/thunderx: fix MTU configuration for jumbo pkts

2018-04-16 Thread Nitin Saxena
thunderx pmd driver passes dev_info.max_rx_pktlen as 9200 (via rte_eth_dev_info_get()) to application. But, when application tries to set MTU as (9200 - sizeof(ethernet_header_t)) the operation fails because of missing CRC and VLAN additions. This patch fixes the following for thunderx pmd driver:

[dpdk-dev] [PATCH] app/eventdev: fix typos in timer adapter options

2018-04-16 Thread Pavan Nikhilesh
The options names in code and doc are not the same. Fixes: 98c6292105d4 ("app/eventdev: add options for event timer adapter") Suggested-by: Thomas Monjalon Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/evt_options.c | 2 +- app/test-eventdev/evt_options.h | 8 2 files changed,

[dpdk-dev] [PATCH] examples/ip_pipeline: fix uninitialized scalar variable

2018-04-16 Thread Fan Zhang
Coverity issue: 272575 Fixes: 133c2c6565d6 ("examples/ip_pipeline: add link object") Signed-off-by: Fan Zhang --- examples/ip_pipeline/cli.c | 2 +- examples/ip_pipeline/link.c | 8 +--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/examples/ip_pipeline/cli.c b/examples/ip_

[dpdk-dev] [PATCH] eal/vfio: export all VFIO functions when not compiling VFIO

2018-04-16 Thread Anatoly Burakov
Previously, VFIO functions were not compiled in and exported if VFIO compilation was disabled. Fix this by actually compiling all of the functions unconditionally, , and provide missing prototypes on Linux. Fixes: 279b581c897d ("vfio: expose functions") Fixes: 73a639085938 ("vfio: allow to map oth

[dpdk-dev] [PATCH] examples/ip_pipeline: fix logically dead node

2018-04-16 Thread Fan Zhang
Coverity issue: 272567 Fixes: d75c371e9b46 ("examples/ip_pipeline: add pipeline object") Signed-off-by: Fan Zhang --- examples/ip_pipeline/cli.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c index 199a31ff8..6c07ca223 100644 ---

[dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null terminated

2018-04-16 Thread Fan Zhang
Coverity issue: 272572 Fixes: 719374345cee ("examples/ip_pipeline: add action profile objects") Signed-off-by: Fan Zhang --- examples/ip_pipeline/action.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/ip_pipeline/action.c b/examples/ip_pipeline/action.c index 77a04

Re: [dpdk-dev] [PATCH v3 00/13] eal: replace calls to rte_panic and refrain from new instances

2018-04-16 Thread Burakov, Anatoly
On 13-Apr-18 7:30 PM, Arnon Warshavsky wrote: The purpose of this patch series is to cleanup the library code from paths that end up aborting the process, and move to checking error values, in order to allow the running process perform an orderly teardown or other mitigation of the event. This p

Re: [dpdk-dev] [PATCH] compat: add virtio crypto header file

2018-04-16 Thread Zhang, Roy Fan
> -Original Message- > From: Jay Zhou [mailto:jianjay.z...@huawei.com] > Sent: Saturday, April 14, 2018 10:27 AM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; De Lara Guarch, Pablo > ; Yigit, Ferruh ; > Tan, Jianfeng ; Zhang, Roy Fan > ; arei.gong...@huawei.com; > weidong.hu...@hua

Re: [dpdk-dev] [PATCH v3 08/13] eal: replace rte_panic instances in hugepage_info

2018-04-16 Thread Burakov, Anatoly
On 13-Apr-18 7:30 PM, Arnon Warshavsky wrote: replace panic calls with log and retrun value. Signed-off-by: Arnon Warshavsky --- lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/lib/librte_eal/linuxapp/

Re: [dpdk-dev] [PATCH 1/8] bus/fslmc: support MC DPDMAI object

2018-04-16 Thread Shreyansh Jain
On Saturday 07 April 2018 08:46 PM, Nipun Gupta wrote: This patch adds the DPDMAI (Data Path DMA Interface) object support in MC driver. Signed-off-by: Cristian Sovaiala Signed-off-by: Nipun Gupta --- drivers/bus/fslmc/Makefile | 3 +- drivers/bus/fslmc/mc/dpdmai.c

Re: [dpdk-dev] [PATCH v5 02/21] eal: list acceptable init priorities

2018-04-16 Thread Neil Horman
On Sun, Apr 15, 2018 at 05:13:13PM +0200, Gaëtan Rivet wrote: > Hello Neil, > > On Sat, Apr 14, 2018 at 02:45:45PM -0400, Neil Horman wrote: > > On Fri, Apr 13, 2018 at 02:55:11PM +0200, Gaëtan Rivet wrote: > > > Hi Shreyansh, > > > > > > On Fri, Apr 13, 2018 at 06:22:43PM +0530, Shreyansh Jain w

Re: [dpdk-dev] [PATCH 0/4] support for write combining

2018-04-16 Thread Rafał Kozik
Hello Bruce, thank you for your advices. > 1. Why not always have igb_uio support write-combining since it can be > controlled thereafter via userspace mapping one file or another? I added parameter to the igb_uio because currently it perform ioremap and fails if it return NULL. But performing i

Re: [dpdk-dev] [PATCH 2/8] bus/fslmc: support scanning and probing of QDMA devices

2018-04-16 Thread Shreyansh Jain
On Saturday 07 April 2018 08:46 PM, Nipun Gupta wrote: Signed-off-by: Nipun Gupta --- drivers/bus/fslmc/fslmc_bus.c | 2 ++ drivers/bus/fslmc/fslmc_vfio.c | 1 + drivers/bus/fslmc/rte_fslmc.h | 2 ++ 3 files changed, 5 insertions(+) [...] Can you please explain, in the commit message,

Re: [dpdk-dev] [PATCH v3 01/13] crypto: replace rte_panic instances in crypto driver

2018-04-16 Thread Neil Horman
On Fri, Apr 13, 2018 at 09:30:32PM +0300, Arnon Warshavsky wrote: > replace panic calls with log and return value. > > -- > v2: > - reformat error message to include literal string in a single line > > Signed-off-by: Arnon Warshavsky > --- > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 8 +

Re: [dpdk-dev] [PATCH] eal/vfio: export all VFIO functions when not compiling VFIO

2018-04-16 Thread Thomas Monjalon
16/04/2018 12:59, Anatoly Burakov: > --- a/lib/librte_eal/common/include/rte_vfio.h > +++ b/lib/librte_eal/common/include/rte_vfio.h > @@ -33,10 +33,6 @@ > #define VFIO_NOIOMMU_MODE \ > "/sys/module/vfio/parameters/enable_unsafe_noiommu_mode" > > -#ifdef __cplusplus > -extern "C" { >

Re: [dpdk-dev] [PATCH] eal/vfio: export all VFIO functions when not compiling VFIO

2018-04-16 Thread Burakov, Anatoly
On 16-Apr-18 12:55 PM, Thomas Monjalon wrote: 16/04/2018 12:59, Anatoly Burakov: --- a/lib/librte_eal/common/include/rte_vfio.h +++ b/lib/librte_eal/common/include/rte_vfio.h @@ -33,10 +33,6 @@ #define VFIO_NOIOMMU_MODE \ "/sys/module/vfio/parameters/enable_unsafe_noiommu_mode"

Re: [dpdk-dev] [PATCH 3/8] bus/fslmc: add macros required by QDMA for FLE and FD

2018-04-16 Thread Shreyansh Jain
On Saturday 07 April 2018 08:46 PM, Nipun Gupta wrote: Signed-off-by: Nipun Gupta --- drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h b/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h index 1ef9502..b7b98d1 100644

[dpdk-dev] [PATCH v2] eal/vfio: export all VFIO functions when not compiling VFIO

2018-04-16 Thread Anatoly Burakov
Previously, VFIO functions were not compiled in and exported if VFIO compilation was disabled. Fix this by actually compiling all of the functions unconditionally, , and provide missing prototypes on Linux. Fixes: 279b581c897d ("vfio: expose functions") Fixes: 73a639085938 ("vfio: allow to map oth

Re: [dpdk-dev] [PATCH v7 1/5] vfio: extend data structure for multi container

2018-04-16 Thread Wang, Xiao W
Hi Anatoly, > -Original Message- > From: Burakov, Anatoly > Sent: Monday, April 16, 2018 6:03 PM > To: Wang, Xiao W ; Yigit, Ferruh > > Cc: dev@dpdk.org; maxime.coque...@redhat.com; Wang, Zhihong > ; Bie, Tiwei ; Tan, Jianfeng > ; Liang, Cunming ; Daly, > Dan ; tho...@monjalon.net; Chen,

[dpdk-dev] [PATCH] examples/ipsec-secgw: fix usage print

2018-04-16 Thread Anoob Joseph
The usage print was not updated when jumbo frames & crypto_dev mask support was added. Fixing that. Also, the optional arguments were not properly highlighted in the usage header. This is also fixed. General cleanup of the usage print was also done to make it look more cleaner and similar to what

[dpdk-dev] dpdk and dpdk-next-net build is broken on RHEL 7.4

2018-04-16 Thread Andrew Rybchenko
Hi, dpdk and dpdk-next-net build is broken on RHEL 7.4. It looks like after pull from next-eventdev. == Build app/test-eventdev   CC test_perf_common.o /home/arybchik/src/dpdk-next-net/app/test-eventdev/test_perf_common.c: In function ‘perf_event_timer_produ cer’: /home/arybchik/src/dpdk-next-

Re: [dpdk-dev] [PATCH v3 07/14] net/mlx5: support tunnel RSS level

2018-04-16 Thread Nélio Laranjeiro
On Sat, Apr 14, 2018 at 10:12:58AM +, Xueming(Steven) Li wrote: > Hi Nelio, >[...] > > > + if (!found) > > > + DRV_LOG(WARNING, > > > + "port %u rss hash function doesn't match " > > > + "pattern", dev->data->port_id); > > > > The hash function is toepli

Re: [dpdk-dev] [PATCH v2 07/15] net/mlx5: support tunnel RSS level

2018-04-16 Thread Nélio Laranjeiro
On Mon, Apr 16, 2018 at 10:06:06AM +, Xueming(Steven) Li wrote: > > > > -Original Message- > > From: Nélio Laranjeiro > > Sent: Monday, April 16, 2018 4:09 PM > > To: Xueming(Steven) Li > > Cc: Shahaf Shuler ; dev@dpdk.org > > Subject: Re: [PATCH v2 07/15] net/mlx5: support tunnel R

Re: [dpdk-dev] [PATCH v2 8/9] doc: add DPAA2 CMDIF rawdev guide

2018-04-16 Thread Hemant Agrawal
On 4/7/2018 8:04 PM, Nipun Gupta wrote: Signed-off-by: Nipun Gupta --- MAINTAINERS| 1 + doc/guides/rawdevs/dpaa2_cmdif.rst | 132 + you also need to add entry in guides/index for these. Also create a rawdevs/index.rst file wit

Re: [dpdk-dev] [PATCH v7 2/5] vfio: add multi container support

2018-04-16 Thread Wang, Xiao W
Hi Anatoly, > -Original Message- > From: Burakov, Anatoly > Sent: Monday, April 16, 2018 6:03 PM > To: Wang, Xiao W ; Yigit, Ferruh > > Cc: dev@dpdk.org; maxime.coque...@redhat.com; Wang, Zhihong > ; Bie, Tiwei ; Tan, Jianfeng > ; Liang, Cunming ; Daly, > Dan ; tho...@monjalon.net; Chen,

Re: [dpdk-dev] dpdk and dpdk-next-net build is broken on RHEL 7.4

2018-04-16 Thread Pavan Nikhilesh
Hi Andrew, Thanks for reporting the issue, will fix it and send out a patch soon. Pavan On Mon, Apr 16, 2018 at 03:24:21PM +0300, Andrew Rybchenko wrote: > Hi, > > dpdk and dpdk-next-net build is broken on RHEL 7.4. > It looks like after pull from next-eventdev. > > == Build app/test-eventdev >

[dpdk-dev] [PATCH] app/eventdev: fix gcc 4.8 compilation errors

2018-04-16 Thread Pavan Nikhilesh
test_perf_common.c: In function ‘perf_event_timer_producer’: test_perf_common.c:99:3: error: missing initializer for field ‘priority’ of ‘struct ’ [-Werror=missing-field-initializers] .ev.sched_type = t->opt->sched_type_list[0], Fixes: d008f20bce23 ("app/eventdev: add event timer adapter as a

[dpdk-dev] [PATCH v7 0/9] switching devices representation

2018-04-16 Thread Declan Doherty
This patchset follows on from the port rerpesentor patchsets and the community discussion that resulted. It outlines the model for representing and controlling switching capable devices in a new programmer's guide entry based upon the excellent summary by Adrien Mazarguil in (http://dpdk.org/ml/a

[dpdk-dev] [PATCH v7 1/9] doc: add switch representation documentation

2018-04-16 Thread Declan Doherty
Add document to describe the model for representing switching capable devices in DPDK, using a general ethdev port model and through port representors. This document also details the port model and the rte_flow semantics required for flow programming, as well as listing some example use cases. Si

  1   2   3   >