[dpdk-dev] Fwd: |WARNING| [PATCH] nfp: report link speed using hardware info
2016-11-18 15:31, Alejandro Lucero: > On Fri, Nov 18, 2016 at 3:24 PM, Ferruh Yigit > wrote: > > > On 11/18/2016 3:10 PM, Alejandro Lucero wrote: > > > Hi Thomas, > > > > > > I got this email when sending a patch some minutes ago. > > > > > > The point is I trusted script/checkpatches.sh which did not report those > > > warnings. > > > Am I doing anything wrong when using checkpatches.sh? > > > > I am also getting same warnings as below, this can be related to the > > checkpatch.pl version. > > > > I have: Version: 0.32 > > (./scripts/checkpatch.pl --version) > > > Uhmm, I got same one. The last update of this version number is from 2011... I guess we have to live without checkpatch versioning.
[dpdk-dev] Fwd: |WARNING| [PATCH] nfp: report link speed using hardware info
2016-11-18 15:24, Ferruh Yigit: > On 11/18/2016 3:10 PM, Alejandro Lucero wrote: > > Hi Thomas, > > > > I got this email when sending a patch some minutes ago. > > > > The point is I trusted script/checkpatches.sh which did not report those > > warnings. > > Am I doing anything wrong when using checkpatches.sh? > > I am also getting same warnings as below, this can be related to the > checkpatch.pl version. > > I have: Version: 0.32 > (./scripts/checkpatch.pl --version) Yes checkpatch at dpdk.org uses the version 0.32. I could try to add it in the mail report.
[dpdk-dev] Fwd: |WARNING| [PATCH] nfp: report link speed using hardware info
On Fri, Nov 18, 2016 at 3:31 PM, Alejandro Lucero < alejandro.lucero at netronome.com> wrote: > > > On Fri, Nov 18, 2016 at 3:24 PM, Ferruh Yigit > wrote: > >> On 11/18/2016 3:10 PM, Alejandro Lucero wrote: >> > Hi Thomas, >> > >> > I got this email when sending a patch some minutes ago. >> > >> > The point is I trusted script/checkpatches.sh which did not report those >> > warnings. >> > Am I doing anything wrong when using checkpatches.sh? >> >> I am also getting same warnings as below, this can be related to the >> checkpatch.pl version. >> >> I have: Version: 0.32 >> (./scripts/checkpatch.pl --version) >> >> > Uhmm, I got same one. > > Ok. It seems I suffered a temporal blindness. I though the automatic report was about warnings but it is about checks. But I got just one of the checks messages. This is the output with -v and adding OPTIONS used: ### [PATCH] nfp: report link speed using hardware info OPTIONS: --no-tree --max-line-length=80 --show-types --ignore=LINUX_VERSION_CODE,FILE_PATH_CHANGES,VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,PREFER_KERNEL_TYPES,BIT_MACRO,CONST_STRUCT,SPLIT_STRING,LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,NEW_TYPEDEFS,COMPARISON_TO_NULL CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #60: FILE: drivers/net/nfp/nfp_net.c:856: + else { + total: 0 errors, 0 warnings, 1 checks, 68 lines checked 0/1 valid patch > > >> > >> > -- Forwarded message -- >> > From: >> > Date: Fri, Nov 18, 2016 at 3:04 PM >> > Subject: |WARNING| [PATCH] nfp: report link speed using hardware info >> > To: test-report at dpdk.org >> > Cc: Alejandro Lucero >> > >> > >> > Test-Label: checkpatch >> > Test-Status: WARNING >> > http://dpdk.org/patch/17091 >> > >> > _coding style issues_ >> > >> > >> > CHECK:MACRO_ARG_REUSE: Macro argument reuse 'arr' - possible >> side-effects? >> > #53: FILE: drivers/net/nfp/nfp_net.c:806: >> > +#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0])) >> > >> > CHECK:BRACES: Blank lines aren't necessary after an open brace '{' >> > #91: FILE: drivers/net/nfp/nfp_net.c:856: >> > + else { >> > + >> > >> > total: 0 errors, 0 warnings, 2 checks, 68 lines checked >> > >> >> >
[dpdk-dev] Fwd: |WARNING| [PATCH] nfp: report link speed using hardware info
On Fri, Nov 18, 2016 at 3:26 PM, Ferruh Yigit wrote: > On 11/18/2016 3:10 PM, Alejandro Lucero wrote: > > Hi Thomas, > > > > I got this email when sending a patch some minutes ago. > > > > The point is I trusted script/checkpatches.sh which did not report those > > warnings. > > Am I doing anything wrong when using checkpatches.sh? > > > > > > -- Forwarded message -- > > From: > > Date: Fri, Nov 18, 2016 at 3:04 PM > > Subject: |WARNING| [PATCH] nfp: report link speed using hardware info > > To: test-report at dpdk.org > > Cc: Alejandro Lucero > > > > > > Test-Label: checkpatch > > Test-Status: WARNING > > http://dpdk.org/patch/17091 > > > > _coding style issues_ > > > > > > CHECK:MACRO_ARG_REUSE: Macro argument reuse 'arr' - possible > side-effects? > > #53: FILE: drivers/net/nfp/nfp_net.c:806: > > +#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0])) > > btw, you can benefit from RTE_DIM: > > lib/librte_eal/common/include/rte_common.h:352: > #define RTE_DIM(a) (sizeof (a) / sizeof ((a)[0])) > > Thanks! I will use it in the next patch version. > > > > CHECK:BRACES: Blank lines aren't necessary after an open brace '{' > > #91: FILE: drivers/net/nfp/nfp_net.c:856: > > + else { > > + > > > > total: 0 errors, 0 warnings, 2 checks, 68 lines checked > > > >
[dpdk-dev] Fwd: |WARNING| [PATCH] nfp: report link speed using hardware info
On Fri, Nov 18, 2016 at 3:24 PM, Ferruh Yigit wrote: > On 11/18/2016 3:10 PM, Alejandro Lucero wrote: > > Hi Thomas, > > > > I got this email when sending a patch some minutes ago. > > > > The point is I trusted script/checkpatches.sh which did not report those > > warnings. > > Am I doing anything wrong when using checkpatches.sh? > > I am also getting same warnings as below, this can be related to the > checkpatch.pl version. > > I have: Version: 0.32 > (./scripts/checkpatch.pl --version) > > Uhmm, I got same one. > > > > > > -- Forwarded message -- > > From: > > Date: Fri, Nov 18, 2016 at 3:04 PM > > Subject: |WARNING| [PATCH] nfp: report link speed using hardware info > > To: test-report at dpdk.org > > Cc: Alejandro Lucero > > > > > > Test-Label: checkpatch > > Test-Status: WARNING > > http://dpdk.org/patch/17091 > > > > _coding style issues_ > > > > > > CHECK:MACRO_ARG_REUSE: Macro argument reuse 'arr' - possible > side-effects? > > #53: FILE: drivers/net/nfp/nfp_net.c:806: > > +#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0])) > > > > CHECK:BRACES: Blank lines aren't necessary after an open brace '{' > > #91: FILE: drivers/net/nfp/nfp_net.c:856: > > + else { > > + > > > > total: 0 errors, 0 warnings, 2 checks, 68 lines checked > > > >
[dpdk-dev] Fwd: |WARNING| [PATCH] nfp: report link speed using hardware info
On 11/18/2016 3:10 PM, Alejandro Lucero wrote: > Hi Thomas, > > I got this email when sending a patch some minutes ago. > > The point is I trusted script/checkpatches.sh which did not report those > warnings. > Am I doing anything wrong when using checkpatches.sh? > > > -- Forwarded message -- > From: > Date: Fri, Nov 18, 2016 at 3:04 PM > Subject: |WARNING| [PATCH] nfp: report link speed using hardware info > To: test-report at dpdk.org > Cc: Alejandro Lucero > > > Test-Label: checkpatch > Test-Status: WARNING > http://dpdk.org/patch/17091 > > _coding style issues_ > > > CHECK:MACRO_ARG_REUSE: Macro argument reuse 'arr' - possible side-effects? > #53: FILE: drivers/net/nfp/nfp_net.c:806: > +#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0])) btw, you can benefit from RTE_DIM: lib/librte_eal/common/include/rte_common.h:352: #define RTE_DIM(a) (sizeof (a) / sizeof ((a)[0])) > > CHECK:BRACES: Blank lines aren't necessary after an open brace '{' > #91: FILE: drivers/net/nfp/nfp_net.c:856: > + else { > + > > total: 0 errors, 0 warnings, 2 checks, 68 lines checked >
[dpdk-dev] Fwd: |WARNING| [PATCH] nfp: report link speed using hardware info
On 11/18/2016 3:10 PM, Alejandro Lucero wrote: > Hi Thomas, > > I got this email when sending a patch some minutes ago. > > The point is I trusted script/checkpatches.sh which did not report those > warnings. > Am I doing anything wrong when using checkpatches.sh? I am also getting same warnings as below, this can be related to the checkpatch.pl version. I have: Version: 0.32 (./scripts/checkpatch.pl --version) > > > -- Forwarded message -- > From: > Date: Fri, Nov 18, 2016 at 3:04 PM > Subject: |WARNING| [PATCH] nfp: report link speed using hardware info > To: test-report at dpdk.org > Cc: Alejandro Lucero > > > Test-Label: checkpatch > Test-Status: WARNING > http://dpdk.org/patch/17091 > > _coding style issues_ > > > CHECK:MACRO_ARG_REUSE: Macro argument reuse 'arr' - possible side-effects? > #53: FILE: drivers/net/nfp/nfp_net.c:806: > +#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0])) > > CHECK:BRACES: Blank lines aren't necessary after an open brace '{' > #91: FILE: drivers/net/nfp/nfp_net.c:856: > + else { > + > > total: 0 errors, 0 warnings, 2 checks, 68 lines checked >
[dpdk-dev] Fwd: |WARNING| [PATCH] nfp: report link speed using hardware info
Hi Thomas, I got this email when sending a patch some minutes ago. The point is I trusted script/checkpatches.sh which did not report those warnings. Am I doing anything wrong when using checkpatches.sh? -- Forwarded message -- From:Date: Fri, Nov 18, 2016 at 3:04 PM Subject: |WARNING| [PATCH] nfp: report link speed using hardware info To: test-report at dpdk.org Cc: Alejandro Lucero Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/17091 _coding style issues_ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'arr' - possible side-effects? #53: FILE: drivers/net/nfp/nfp_net.c:806: +#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0])) CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #91: FILE: drivers/net/nfp/nfp_net.c:856: + else { + total: 0 errors, 0 warnings, 2 checks, 68 lines checked