[GitHub] drill pull request #1106: DRILL-6129: Fixed query failure due to nested colu...

Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/1106 ---

[GitHub] drill pull request #1115: DRILL-6138: Move RecordBatchSizer to org.apache.dr...

Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/1115 ---

[GitHub] drill pull request #1118: DRILL-6144: Make directMemory amount configurable ...

Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/1118 ---

Build failed in Jenkins: drill-scm #934

See Changes: [parthc] DRILL-6129: Fixed query failure due to nested column data type change [parthc] DRILL-6138: Move RecordBatchSizer to org.apache.drill.exec.record [parthc] DRILL-6144: Make direct memory amount confi

Re: Batch Sizing for Parquet Flat Reader

Is there a JIRA for this? Would be useful to capture the comments in the JIRA. Note that the document itself is not comment-able as it is shared with view-only permissions. Some thoughts in no particular order- 1) The Page based statistical approach is likely to run into trouble with the encoding

[GitHub] drill pull request #1107: DRILL-6123: Limit batch size for Merge Join based ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1107#discussion_r167283942 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractRecordBatchMemoryManager.java --- @@ -0,0 +1,63 @@ +/* + * Licensed

[GitHub] drill pull request #1107: DRILL-6123: Limit batch size for Merge Join based ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1107#discussion_r167284434 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractRecordBatchMemoryManager.java --- @@ -0,0 +1,63 @@ +/* + * Licensed

[GitHub] drill pull request #1107: DRILL-6123: Limit batch size for Merge Join based ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1107#discussion_r167281940 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractRecordBatchMemoryManager.java --- @@ -0,0 +1,63 @@ +/* + * Licensed

[GitHub] drill pull request #1107: DRILL-6123: Limit batch size for Merge Join based ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1107#discussion_r167146010 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/RecordBatchSizer.java --- @@ -137,10 +137,10 @@ public ColumnSize(Value

[GitHub] drill pull request #1107: DRILL-6123: Limit batch size for Merge Join based ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1107#discussion_r167284278 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractRecordBatchMemoryManager.java --- @@ -0,0 +1,63 @@ +/* + * Licensed

[GitHub] drill pull request #1107: DRILL-6123: Limit batch size for Merge Join based ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1107#discussion_r167282219 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractRecordBatchMemoryManager.java --- @@ -0,0 +1,63 @@ +/* + * Licensed

[GitHub] drill pull request #1107: DRILL-6123: Limit batch size for Merge Join based ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1107#discussion_r167146312 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/RecordBatchSizer.java --- @@ -311,8 +311,8 @@ public static ColumnSize

[GitHub] drill pull request #1116: DRILL-6140: Correctly list Operators in a Query Pr...

Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/1116#discussion_r167269862 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileWrapper.java --- @@ -322,4 +330,16 @@ public String getOperator

[GitHub] drill pull request #1116: DRILL-6140: Correctly list Operators in a Query Pr...

Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/1116#discussion_r167286191 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/OperatorWrapper.java --- @@ -45,12 +45,25 @@ private final Stri

[GitHub] drill pull request #1116: DRILL-6140: Correctly list Operators in a Query Pr...

Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/1116#discussion_r167288758 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/OperatorWrapper.java --- @@ -45,12 +45,25 @@ private final Stri

[jira] [Created] (DRILL-6147) Limit batch size for Flat Parquet Reader

salim achouche created DRILL-6147: - Summary: Limit batch size for Flat Parquet Reader Key: DRILL-6147 URL: https://issues.apache.org/jira/browse/DRILL-6147 Project: Apache Drill Issue Type: I

[GitHub] drill issue #1119: DRILL-6143: Made FragmentsRunner's rpc timeout a SystemOp...

Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1119 @arina-ielchiieva is on vacation. @vrozov, @Ben-Zvi can you take a look? ---

Re: Batch Sizing for Parquet Flat Reader

Thank you Parth for providing feedback; please find my answers below: I have created Apache JIRA DRILL-6147 for tracking this improvement. > 2) Not sure where you were going with the predicate pushdown section and how it pertains to yo

[GitHub] drill pull request #1119: DRILL-6143: Made FragmentsRunner's rpc timeout a S...

Github user vrozov commented on a diff in the pull request: https://github.com/apache/drill/pull/1119#discussion_r167312527 --- Diff: exec/java-exec/src/main/resources/drill-module.conf --- @@ -413,6 +413,7 @@ drill.exec.options: { # to start at least 2 partitions then Hash

[GitHub] drill pull request #1119: DRILL-6143: Made FragmentsRunner's rpc timeout a S...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1119#discussion_r167338469 --- Diff: exec/java-exec/src/main/resources/drill-module.conf --- @@ -413,6 +413,7 @@ drill.exec.options: { # to start at least 2 partitions then Has

[GitHub] drill pull request #1119: DRILL-6143: Made FragmentsRunner's rpc timeout a S...

Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/1119#discussion_r167343642 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java --- @@ -212,7 +212,8 @@ new OptionDefinition

[GitHub] drill pull request #1119: DRILL-6143: Made FragmentsRunner's rpc timeout a S...

Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1119#discussion_r167346417 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java --- @@ -212,7 +212,8 @@ new OptionDefinition

[jira] [Created] (DRILL-6148) TestSortSpillWithException is sometimes failing.

Hanumath Rao Maduri created DRILL-6148: -- Summary: TestSortSpillWithException is sometimes failing. Key: DRILL-6148 URL: https://issues.apache.org/jira/browse/DRILL-6148 Project: Apache Drill

[GitHub] drill pull request #1120: DILL-6148: TestSortSpillWithException is sometimes...

GitHub user HanumathRao opened a pull request: https://github.com/apache/drill/pull/1120 DILL-6148: TestSortSpillWithException is sometimes failing. I have changed the test case to use the EXTERNAL_SORT_MAX_MEMORY to configure the sort operator to use less memory instead of relying

[jira] [Created] (DRILL-6149) Support Query Level Options

Timothy Farkas created DRILL-6149: - Summary: Support Query Level Options Key: DRILL-6149 URL: https://issues.apache.org/jira/browse/DRILL-6149 Project: Apache Drill Issue Type: Bug

[GitHub] drill pull request #1107: DRILL-6123: Limit batch size for Merge Join based ...

Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/1107#discussion_r167380394 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/RecordBatchSizer.java --- @@ -137,10 +137,10 @@ public ColumnSize(ValueVecto

[GitHub] drill pull request #1107: DRILL-6123: Limit batch size for Merge Join based ...

Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/1107#discussion_r167380761 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/RecordBatchSizer.java --- @@ -311,8 +311,8 @@ public static ColumnSize getCo

[GitHub] drill pull request #1107: DRILL-6123: Limit batch size for Merge Join based ...

Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/1107#discussion_r167380917 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractRecordBatchMemoryManager.java --- @@ -0,0 +1,63 @@ +/* + * Licensed to th

[GitHub] drill issue #1107: DRILL-6123: Limit batch size for Merge Join based on memo...

Github user ppadma commented on the issue: https://github.com/apache/drill/pull/1107 @paul-rogers Thank you very much for the review. Updated the PR with review comments taken care of. Please take a look. ---

[GitHub] drill issue #1105: DRILL-6125: Fix possible memory leak when query is cancel...

Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1105 @sachouche I traced through the code. The updateAggregateStats method is called, which then calls the getOutgoingBatches method of the code generated Partitioners. That method is just a simple getter

[GitHub] drill issue #1119: DRILL-6143: Made FragmentsRunner's rpc timeout a SystemOp...

Github user vrozov commented on the issue: https://github.com/apache/drill/pull/1119 LGTM ---