[GitHub] paul-rogers commented on issue #1367: DRILL-6585: PartitionSender clones vectors, but shares field metdata

2018-07-13 Thread GitBox
paul-rogers commented on issue #1367: DRILL-6585: PartitionSender clones vectors, but shares field metdata URL: https://github.com/apache/drill/pull/1367#issuecomment-404987283 @sohami, thanks for your comments and questions. Unfortunately, I cannot debug the use case and so you may have

Re: [DISCUSS] 1.14.0 release

2018-07-13 Thread Timothy Farkas
Hi Boaz, I looked at DRILL-6606 and have updated the ticket, I should have a fix monday. It looks like a minor logical error. I'm not clear on why you suspect DRILL-6453 is cause by batch sniffing, perhaps we can discuss offline. Thanks, Tim On Fri, Jul 13, 2018 at 2:01 PM, Arina Yelchiyeva <

[GitHub] paul-rogers closed pull request #1367: DRILL-6585: PartitionSender clones vectors, but shares field metdata

2018-07-13 Thread GitBox
paul-rogers closed pull request #1367: DRILL-6585: PartitionSender clones vectors, but shares field metdata URL: https://github.com/apache/drill/pull/1367 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] paul-rogers commented on issue #1367: DRILL-6585: PartitionSender clones vectors, but shares field metdata

2018-07-13 Thread GitBox
paul-rogers commented on issue #1367: DRILL-6585: PartitionSender clones vectors, but shares field metdata URL: https://github.com/apache/drill/pull/1367#issuecomment-404987313 Closing this PR. Will try a different approach since we're not converging on a solution.

[GitHub] paul-rogers commented on issue #1244: DRILL-6373: Refactor Result Set Loader for Union, List support

2018-07-13 Thread GitBox
paul-rogers commented on issue #1244: DRILL-6373: Refactor Result Set Loader for Union, List support URL: https://github.com/apache/drill/pull/1244#issuecomment-404987892 @sohami, the cost of my proposed fix has exceeded its benefit -- we're just not converging. I've closed that PR and

Re: [DISCUSS] 1.14.0 release

2018-07-13 Thread Arina Yelchiyeva
Two more regressions: https://issues.apache.org/jira/browse/DRILL-6603 https://issues.apache.org/jira/browse/DRILL-6605 Kind regards, Arina On Fri, Jul 13, 2018 at 11:25 PM Sorabh Hamirwasia wrote: > Hi Boaz, > Couple of updates. > > *Merged In:* > DRILL-6542: (May be Ready2Commit soon)

[GitHub] ilooner commented on issue #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable.

2018-07-13 Thread GitBox
ilooner commented on issue #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable. URL: https://github.com/apache/drill/pull/1296#issuecomment-404977655 @vdiravka addressed your comments, and I pushed a few more changes after your last pass. I

[jira] [Resolved] (DRILL-6471) Different result for CAST String and Decimal literals as Decimal

2018-07-13 Thread Arina Ielchiieva (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-6471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arina Ielchiieva resolved DRILL-6471. - Resolution: Fixed Merged into master with commit id

[GitHub] vvysotskyi opened a new pull request #1380: DRILL-6472: Prevent using zero precision in CAST function

2018-07-13 Thread GitBox
vvysotskyi opened a new pull request #1380: DRILL-6472: Prevent using zero precision in CAST function URL: https://github.com/apache/drill/pull/1380 - Add check for the correctness of scale value; - Add check for fitting the value to the value with the concrete scale and precision;

[GitHub] arina-ielchiieva closed pull request #1380: DRILL-6472: Prevent using zero precision in CAST function

2018-07-13 Thread GitBox
arina-ielchiieva closed pull request #1380: DRILL-6472: Prevent using zero precision in CAST function URL: https://github.com/apache/drill/pull/1380 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] arina-ielchiieva commented on issue #1380: DRILL-6472: Prevent using zero precision in CAST function

2018-07-13 Thread GitBox
arina-ielchiieva commented on issue #1380: DRILL-6472: Prevent using zero precision in CAST function URL: https://github.com/apache/drill/pull/1380#issuecomment-404825163 +1, LGTM. This is an automated message from the

[GitHub] jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-07-13 Thread GitBox
jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r202296895 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetIsPredicate.java

[GitHub] jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-07-13 Thread GitBox
jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r202296895 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetIsPredicate.java

[jira] [Created] (DRILL-6606) Hash Join returns incorrect data types when joining subqueries with limit 0

2018-07-13 Thread Bohdan Kazydub (JIRA)
Bohdan Kazydub created DRILL-6606: - Summary: Hash Join returns incorrect data types when joining subqueries with limit 0 Key: DRILL-6606 URL: https://issues.apache.org/jira/browse/DRILL-6606 Project:

[GitHub] arina-ielchiieva edited a comment on issue #1371: DRILL-6588: Make Sys tables of nullable datatypes

2018-07-13 Thread GitBox
arina-ielchiieva edited a comment on issue #1371: DRILL-6588: Make Sys tables of nullable datatypes URL: https://github.com/apache/drill/pull/1371#issuecomment-404765907 @kkhatua could you please add unit tests, similar to the queries you showed in description. You can add with

Re: [DISCUSS] 1.14.0 release

2018-07-13 Thread Arina Yelchiyeva
During implementing late limit 0 optimization, Bohdan has found one more regression after Hash Join spill to disk. https://issues.apache.org/jira/browse/DRILL-6606 Boaz please take a look. Kind regards, Arina On Fri, Jul 13, 2018 at 4:34 AM Boaz Ben-Zvi wrote: >We are getting close to a

[GitHub] arina-ielchiieva commented on a change in pull request #1379: DRILL-6591: Show Exception for failed queries submitted in WebUI

2018-07-13 Thread GitBox
arina-ielchiieva commented on a change in pull request #1379: DRILL-6591: Show Exception for failed queries submitted in WebUI URL: https://github.com/apache/drill/pull/1379#discussion_r202313820 ## File path:

[GitHub] arina-ielchiieva commented on a change in pull request #1379: DRILL-6591: Show Exception for failed queries submitted in WebUI

2018-07-13 Thread GitBox
arina-ielchiieva commented on a change in pull request #1379: DRILL-6591: Show Exception for failed queries submitted in WebUI URL: https://github.com/apache/drill/pull/1379#discussion_r202314075 ## File path:

[GitHub] arina-ielchiieva commented on a change in pull request #1379: DRILL-6591: Show Exception for failed queries submitted in WebUI

2018-07-13 Thread GitBox
arina-ielchiieva commented on a change in pull request #1379: DRILL-6591: Show Exception for failed queries submitted in WebUI URL: https://github.com/apache/drill/pull/1379#discussion_r202313562 ## File path:

[GitHub] arina-ielchiieva commented on a change in pull request #1379: DRILL-6591: Show Exception for failed queries submitted in WebUI

2018-07-13 Thread GitBox
arina-ielchiieva commented on a change in pull request #1379: DRILL-6591: Show Exception for failed queries submitted in WebUI URL: https://github.com/apache/drill/pull/1379#discussion_r202314199 ## File path:

[GitHub] arina-ielchiieva commented on a change in pull request #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths)

2018-07-13 Thread GitBox
arina-ielchiieva commented on a change in pull request #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths) URL: https://github.com/apache/drill/pull/1336#discussion_r202316800 ## File path:

[GitHub] arina-ielchiieva commented on a change in pull request #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths)

2018-07-13 Thread GitBox
arina-ielchiieva commented on a change in pull request #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths) URL: https://github.com/apache/drill/pull/1336#discussion_r202317536 ## File path:

[GitHub] arina-ielchiieva commented on a change in pull request #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths)

2018-07-13 Thread GitBox
arina-ielchiieva commented on a change in pull request #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths) URL: https://github.com/apache/drill/pull/1336#discussion_r202317510 ## File path:

[GitHub] arina-ielchiieva commented on a change in pull request #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths)

2018-07-13 Thread GitBox
arina-ielchiieva commented on a change in pull request #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths) URL: https://github.com/apache/drill/pull/1336#discussion_r202316399 ## File path:

[GitHub] arina-ielchiieva commented on a change in pull request #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths)

2018-07-13 Thread GitBox
arina-ielchiieva commented on a change in pull request #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths) URL: https://github.com/apache/drill/pull/1336#discussion_r202315854 ## File path:

[GitHub] arina-ielchiieva commented on a change in pull request #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths)

2018-07-13 Thread GitBox
arina-ielchiieva commented on a change in pull request #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths) URL: https://github.com/apache/drill/pull/1336#discussion_r202316212 ## File path:

[GitHub] arina-ielchiieva commented on a change in pull request #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths)

2018-07-13 Thread GitBox
arina-ielchiieva commented on a change in pull request #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths) URL: https://github.com/apache/drill/pull/1336#discussion_r202317605 ## File path:

[GitHub] arina-ielchiieva commented on a change in pull request #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths)

2018-07-13 Thread GitBox
arina-ielchiieva commented on a change in pull request #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths) URL: https://github.com/apache/drill/pull/1336#discussion_r202319288 ## File path:

[GitHub] kkhatua commented on a change in pull request #1379: DRILL-6591: Show Exception for failed queries submitted in WebUI

2018-07-13 Thread GitBox
kkhatua commented on a change in pull request #1379: DRILL-6591: Show Exception for failed queries submitted in WebUI URL: https://github.com/apache/drill/pull/1379#discussion_r202251468 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/QueryWrapper.java

[GitHub] kkhatua commented on a change in pull request #1379: DRILL-6591: Show Exception for failed queries submitted in WebUI

2018-07-13 Thread GitBox
kkhatua commented on a change in pull request #1379: DRILL-6591: Show Exception for failed queries submitted in WebUI URL: https://github.com/apache/drill/pull/1379#discussion_r202257580 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/QueryWrapper.java

Re: Metadata management improvement

2018-07-13 Thread Padma Penumarthy
Hi Joel, This is my understanding: We have list of all directories (i.e. all subdirectories and their subdirectories etc.) in the metadata cache file of each directory. We go through that list of directories and check directory modification time against modification time of metadata cache file in

[GitHub] arina-ielchiieva commented on issue #1307: DRILL-6473: Upgrade Drill 1.14 with Hive 2.3 for mapr profile

2018-07-13 Thread GitBox
arina-ielchiieva commented on issue #1307: DRILL-6473: Upgrade Drill 1.14 with Hive 2.3 for mapr profile URL: https://github.com/apache/drill/pull/1307#issuecomment-404756224 @sohami, yes, please DO NOT merge it in since Hive Mapr version is not published yet.

[GitHub] arina-ielchiieva commented on issue #1371: DRILL-6588: Make Sys tables of nullable datatypes

2018-07-13 Thread GitBox
arina-ielchiieva commented on issue #1371: DRILL-6588: Make Sys tables of nullable datatypes URL: https://github.com/apache/drill/pull/1371#issuecomment-404765907 @kkhatua could you please add unit tests, similar to the queries you showed in description.

[GitHub] Ben-Zvi commented on a change in pull request #1373: DRILL-6517: Hash-Join: If not OK, exit early from prefetchFirstBatchFromBothSides

2018-07-13 Thread GitBox
Ben-Zvi commented on a change in pull request #1373: DRILL-6517: Hash-Join: If not OK, exit early from prefetchFirstBatchFromBothSides URL: https://github.com/apache/drill/pull/1373#discussion_r202364770 ## File path:

[GitHub] Ben-Zvi commented on a change in pull request #1373: DRILL-6517: Hash-Join: If not OK, exit early from prefetchFirstBatchFromBothSides

2018-07-13 Thread GitBox
Ben-Zvi commented on a change in pull request #1373: DRILL-6517: Hash-Join: If not OK, exit early from prefetchFirstBatchFromBothSides URL: https://github.com/apache/drill/pull/1373#discussion_r202366385 ## File path:

[GitHub] ppadma commented on a change in pull request #1373: DRILL-6517: Hash-Join: If not OK, exit early from prefetchFirstBatchFromBothSides

2018-07-13 Thread GitBox
ppadma commented on a change in pull request #1373: DRILL-6517: Hash-Join: If not OK, exit early from prefetchFirstBatchFromBothSides URL: https://github.com/apache/drill/pull/1373#discussion_r202367354 ## File path:

Re: [DISCUSS] 1.14.0 release

2018-07-13 Thread Arina Yelchiyeva
We cannot release with existing regressions, especially taking into account the there are not minor issues. As far as I understand reverting is not an option since hash join spill feature are extended into several commits + subsequent fixes. I guess we need to consider postponing the release until

[GitHub] ppadma commented on a change in pull request #1373: DRILL-6517: Hash-Join: If not OK, exit early from prefetchFirstBatchFromBothSides

2018-07-13 Thread GitBox
ppadma commented on a change in pull request #1373: DRILL-6517: Hash-Join: If not OK, exit early from prefetchFirstBatchFromBothSides URL: https://github.com/apache/drill/pull/1373#discussion_r202359215 ## File path:

[GitHub] ppadma commented on a change in pull request #1373: DRILL-6517: Hash-Join: If not OK, exit early from prefetchFirstBatchFromBothSides

2018-07-13 Thread GitBox
ppadma commented on a change in pull request #1373: DRILL-6517: Hash-Join: If not OK, exit early from prefetchFirstBatchFromBothSides URL: https://github.com/apache/drill/pull/1373#discussion_r202357583 ## File path:

[GitHub] ppadma commented on a change in pull request #1373: DRILL-6517: Hash-Join: If not OK, exit early from prefetchFirstBatchFromBothSides

2018-07-13 Thread GitBox
ppadma commented on a change in pull request #1373: DRILL-6517: Hash-Join: If not OK, exit early from prefetchFirstBatchFromBothSides URL: https://github.com/apache/drill/pull/1373#discussion_r202356476 ## File path:

Re: [DISCUSS] 1.14.0 release

2018-07-13 Thread Boaz Ben-Zvi
(Guessing ...) It is possible that the root cause for DRILL-6606 is similar to that in DRILL-6453 -- that is the new "early sniffing" in the Hash-Join, which repeatedly invokes next() on the two "children" of the join *during schema discovery* until non-empty data is returned (or NONE, STOP,

[jira] [Resolved] (DRILL-4454) NPE on select with options when file does not exist

2018-07-13 Thread Arina Ielchiieva (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-4454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arina Ielchiieva resolved DRILL-4454. - Resolution: Fixed > NPE on select with options when file does not exist >

[jira] [Resolved] (DRILL-3468) CTAS IOB

2018-07-13 Thread Arina Ielchiieva (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-3468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arina Ielchiieva resolved DRILL-3468. - Resolution: Fixed > CTAS IOB > > > Key: DRILL-3468 >

[GitHub] HanumathRao opened a new pull request #1381: DRILL-6475: Unnest: Null fieldId Pointer.

2018-07-13 Thread GitBox
HanumathRao opened a new pull request #1381: DRILL-6475: Unnest: Null fieldId Pointer. URL: https://github.com/apache/drill/pull/1381 @amansinha100 Can you please review this PR. This PR includes changes related to updating the row type and also correlated column for the unnest

Re: [DISCUSS] 1.14.0 release

2018-07-13 Thread Aman Sinha
I would say we have to take a measured approach to this and decide on a case-by-case which issue is a show stopper. While of course we have to make every effort to avoid regression, we cannot claim that a particular release will not cause any regression. I believe there are 1+ passing tests,

[GitHub] vdiravka opened a new pull request #1382: DRILL-5495: convert_from function on top of int96 data results in Arr…

2018-07-13 Thread GitBox
vdiravka opened a new pull request #1382: DRILL-5495: convert_from function on top of int96 data results in Arr… URL: https://github.com/apache/drill/pull/1382 …ayIndexOutOfBoundsException The only issue is the wrong parameter is used for iteration in the process of reading values

[GitHub] arina-ielchiieva commented on issue #1382: DRILL-5495: convert_from function on top of int96 data results in Arr…

2018-07-13 Thread GitBox
arina-ielchiieva commented on issue #1382: DRILL-5495: convert_from function on top of int96 data results in Arr… URL: https://github.com/apache/drill/pull/1382#issuecomment-404876965 Looks like is was mechanical error. @vdiravka nice catch! Though I am not sure to validate this we need

[GitHub] vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-07-13 Thread GitBox
vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r202422357 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetIsPredicate.java

[GitHub] kkhatua commented on a change in pull request #1379: DRILL-6591: Show Exception for failed queries submitted in WebUI

2018-07-13 Thread GitBox
kkhatua commented on a change in pull request #1379: DRILL-6591: Show Exception for failed queries submitted in WebUI URL: https://github.com/apache/drill/pull/1379#discussion_r202417667 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/QueryWrapper.java

[GitHub] kkhatua commented on a change in pull request #1379: DRILL-6591: Show Exception for failed queries submitted in WebUI

2018-07-13 Thread GitBox
kkhatua commented on a change in pull request #1379: DRILL-6591: Show Exception for failed queries submitted in WebUI URL: https://github.com/apache/drill/pull/1379#discussion_r202417597 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/QueryWrapper.java

[GitHub] ilooner commented on a change in pull request #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths)

2018-07-13 Thread GitBox
ilooner commented on a change in pull request #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths) URL: https://github.com/apache/drill/pull/1336#discussion_r202443140 ## File path:

[GitHub] ilooner commented on issue #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths)

2018-07-13 Thread GitBox
ilooner commented on issue #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths) URL: https://github.com/apache/drill/pull/1336#issuecomment-404932368 @arina-ielchiieva Thanks for catching mistakes, I have

[GitHub] ilooner commented on a change in pull request #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths)

2018-07-13 Thread GitBox
ilooner commented on a change in pull request #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths) URL: https://github.com/apache/drill/pull/1336#discussion_r202452062 ## File path:

[GitHub] kkhatua commented on a change in pull request #1379: DRILL-6591: Show Exception for failed queries submitted in WebUI

2018-07-13 Thread GitBox
kkhatua commented on a change in pull request #1379: DRILL-6591: Show Exception for failed queries submitted in WebUI URL: https://github.com/apache/drill/pull/1379#discussion_r202420484 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/QueryWrapper.java

[GitHub] ilooner commented on a change in pull request #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths)

2018-07-13 Thread GitBox
ilooner commented on a change in pull request #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths) URL: https://github.com/apache/drill/pull/1336#discussion_r202443712 ## File path:

[GitHub] ilooner commented on a change in pull request #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths)

2018-07-13 Thread GitBox
ilooner commented on a change in pull request #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths) URL: https://github.com/apache/drill/pull/1336#discussion_r202443689 ## File path:

[GitHub] vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-07-13 Thread GitBox
vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r202402885 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetIsPredicate.java

[GitHub] vdiravka commented on issue #1382: DRILL-5495: convert_from function on top of int96 data results in Arr…

2018-07-13 Thread GitBox
vdiravka commented on issue #1382: DRILL-5495: convert_from function on top of int96 data results in Arr… URL: https://github.com/apache/drill/pull/1382#issuecomment-404892801 @arina-ielchiieva Yes, it is mechanical issue. `recordsToReadInThisPass` is `numNonNullValues` (see

[GitHub] arina-ielchiieva commented on issue #1382: DRILL-5495: convert_from function on top of int96 data results in Arr…

2018-07-13 Thread GitBox
arina-ielchiieva commented on issue #1382: DRILL-5495: convert_from function on top of int96 data results in Arr… URL: https://github.com/apache/drill/pull/1382#issuecomment-404895013 @vdiravka, thanks for the explanation. LGTM, +1.

[GitHub] ilooner commented on a change in pull request #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths)

2018-07-13 Thread GitBox
ilooner commented on a change in pull request #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths) URL: https://github.com/apache/drill/pull/1336#discussion_r202444031 ## File path:

[GitHub] kkhatua commented on issue #1371: DRILL-6588: Make Sys tables of nullable datatypes

2018-07-13 Thread GitBox
kkhatua commented on issue #1371: DRILL-6588: Make Sys tables of nullable datatypes URL: https://github.com/apache/drill/pull/1371#issuecomment-404909514 Added a unit test that groups and counts the number of IS_NULLABLE values. Originally, the query would have returned only 1 group

[GitHub] arina-ielchiieva closed pull request #1382: DRILL-5495: convert_from function on top of int96 data results in Arr…

2018-07-13 Thread GitBox
arina-ielchiieva closed pull request #1382: DRILL-5495: convert_from function on top of int96 data results in Arr… URL: https://github.com/apache/drill/pull/1382 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] kkhatua commented on issue #1379: DRILL-6591: Show Exception for failed queries submitted in WebUI

2018-07-13 Thread GitBox
kkhatua commented on issue #1379: DRILL-6591: Show Exception for failed queries submitted in WebUI URL: https://github.com/apache/drill/pull/1379#issuecomment-404905251 Done with the change This is an automated message from

[GitHub] ilooner commented on a change in pull request #1373: DRILL-6517: Hash-Join: If not OK, exit early from prefetchFirstBatchFromBothSides

2018-07-13 Thread GitBox
ilooner commented on a change in pull request #1373: DRILL-6517: Hash-Join: If not OK, exit early from prefetchFirstBatchFromBothSides URL: https://github.com/apache/drill/pull/1373#discussion_r202425486 ## File path:

[GitHub] ilooner commented on a change in pull request #1373: DRILL-6517: Hash-Join: If not OK, exit early from prefetchFirstBatchFromBothSides

2018-07-13 Thread GitBox
ilooner commented on a change in pull request #1373: DRILL-6517: Hash-Join: If not OK, exit early from prefetchFirstBatchFromBothSides URL: https://github.com/apache/drill/pull/1373#discussion_r202423357 ## File path:

[GitHub] arina-ielchiieva commented on a change in pull request #1379: DRILL-6591: Show Exception for failed queries submitted in WebUI

2018-07-13 Thread GitBox
arina-ielchiieva commented on a change in pull request #1379: DRILL-6591: Show Exception for failed queries submitted in WebUI URL: https://github.com/apache/drill/pull/1379#discussion_r202427605 ## File path:

[GitHub] kkhatua commented on a change in pull request #1379: DRILL-6591: Show Exception for failed queries submitted in WebUI

2018-07-13 Thread GitBox
kkhatua commented on a change in pull request #1379: DRILL-6591: Show Exception for failed queries submitted in WebUI URL: https://github.com/apache/drill/pull/1379#discussion_r202432457 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/QueryWrapper.java

[GitHub] ilooner commented on a change in pull request #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths)

2018-07-13 Thread GitBox
ilooner commented on a change in pull request #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths) URL: https://github.com/apache/drill/pull/1336#discussion_r202437046 ## File path:

[GitHub] ilooner commented on a change in pull request #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths)

2018-07-13 Thread GitBox
ilooner commented on a change in pull request #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths) URL: https://github.com/apache/drill/pull/1336#discussion_r202437164 ## File path:

[GitHub] jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-07-13 Thread GitBox
jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r202408237 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetIsPredicate.java

[GitHub] vdiravka commented on a change in pull request #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable.

2018-07-13 Thread GitBox
vdiravka commented on a change in pull request #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable. URL: https://github.com/apache/drill/pull/1296#discussion_r202418392 ## File path:

[GitHub] vdiravka commented on a change in pull request #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable.

2018-07-13 Thread GitBox
vdiravka commented on a change in pull request #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable. URL: https://github.com/apache/drill/pull/1296#discussion_r202386993 ## File path:

[GitHub] vdiravka commented on a change in pull request #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable.

2018-07-13 Thread GitBox
vdiravka commented on a change in pull request #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable. URL: https://github.com/apache/drill/pull/1296#discussion_r202386359 ## File path:

[GitHub] vdiravka commented on a change in pull request #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable.

2018-07-13 Thread GitBox
vdiravka commented on a change in pull request #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable. URL: https://github.com/apache/drill/pull/1296#discussion_r202385699 ## File path:

[GitHub] vdiravka commented on a change in pull request #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable.

2018-07-13 Thread GitBox
vdiravka commented on a change in pull request #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable. URL: https://github.com/apache/drill/pull/1296#discussion_r202418755 ## File path:

[GitHub] vdiravka commented on a change in pull request #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable.

2018-07-13 Thread GitBox
vdiravka commented on a change in pull request #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable. URL: https://github.com/apache/drill/pull/1296#discussion_r202386141 ## File path:

[GitHub] ilooner commented on a change in pull request #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths)

2018-07-13 Thread GitBox
ilooner commented on a change in pull request #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths) URL: https://github.com/apache/drill/pull/1336#discussion_r202443154 ## File path:

Re: [DISCUSS] 1.14.0 release

2018-07-13 Thread Vlad Rozov
My 2 cents: From Apache point of view it is OK to do a release even if unit tests do not pass at all or there is a large number of regression introduced. Apache release is a source release and as long as it compiles and does not have license issues, it is up to community (PMC) to decide on

[GitHub] sohami commented on issue #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths)

2018-07-13 Thread GitBox
sohami commented on issue #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths) URL: https://github.com/apache/drill/pull/1336#issuecomment-404967213 @arina-ielchiieva / @ilooner Removing ready-to-commit

[GitHub] sohami commented on issue #1244: DRILL-6373: Refactor Result Set Loader for Union, List support

2018-07-13 Thread GitBox
sohami commented on issue #1244: DRILL-6373: Refactor Result Set Loader for Union, List support URL: https://github.com/apache/drill/pull/1244#issuecomment-404968576 @paul-rogers - I have posted couple of questions for this change on other PR (https://github.com/apache/drill/pull/1367)

[GitHub] sohami closed pull request #1379: DRILL-6591: Show Exception for failed queries submitted in WebUI

2018-07-13 Thread GitBox
sohami closed pull request #1379: DRILL-6591: Show Exception for failed queries submitted in WebUI URL: https://github.com/apache/drill/pull/1379 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[jira] [Created] (DRILL-6608) Properly Handle Creation and Closure of DrillFileSystems

2018-07-13 Thread Timothy Farkas (JIRA)
Timothy Farkas created DRILL-6608: - Summary: Properly Handle Creation and Closure of DrillFileSystems Key: DRILL-6608 URL: https://issues.apache.org/jira/browse/DRILL-6608 Project: Apache Drill

Re: [DISCUSS] 1.14.0 release

2018-07-13 Thread Parth Chandra
Our (unwritten) rule has been that a commit cannot even go in unless unit _and_ regression tests pass. Releases are stricter, all tests, longevity tests, UI, are required to pass. In addition, any performance regression needs to be discussed. So far we have not made any exceptions, but that is

[GitHub] arina-ielchiieva commented on issue #1379: DRILL-6591: Show Exception for failed queries submitted in WebUI

2018-07-13 Thread GitBox
arina-ielchiieva commented on issue #1379: DRILL-6591: Show Exception for failed queries submitted in WebUI URL: https://github.com/apache/drill/pull/1379#issuecomment-404944699 +1, LGTM. This is an automated message from

[GitHub] ilooner commented on a change in pull request #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable.

2018-07-13 Thread GitBox
ilooner commented on a change in pull request #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable. URL: https://github.com/apache/drill/pull/1296#discussion_r202491880 ## File path:

[GitHub] arina-ielchiieva commented on issue #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths)

2018-07-13 Thread GitBox
arina-ielchiieva commented on issue #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths) URL: https://github.com/apache/drill/pull/1336#issuecomment-404946291 Looks like there are some compilation errors:

[GitHub] ilooner commented on issue #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable.

2018-07-13 Thread GitBox
ilooner commented on issue #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable. URL: https://github.com/apache/drill/pull/1296#issuecomment-404975183 For some reason github won't let me respond next to one of your comments, so putting response

[GitHub] ilooner commented on a change in pull request #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable.

2018-07-13 Thread GitBox
ilooner commented on a change in pull request #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable. URL: https://github.com/apache/drill/pull/1296#discussion_r202491914 ## File path:

[jira] [Created] (DRILL-6610) Add support for Minimum TLS support

2018-07-13 Thread Rob Wu (JIRA)
Rob Wu created DRILL-6610: - Summary: Add support for Minimum TLS support Key: DRILL-6610 URL: https://issues.apache.org/jira/browse/DRILL-6610 Project: Apache Drill Issue Type: Improvement

Re: [DISCUSS] 1.14.0 release

2018-07-13 Thread Sorabh Hamirwasia
Hi Boaz, Couple of updates. *Merged In:* DRILL-6542: (May be Ready2Commit soon) IndexOutOfBounds exception for multilevel lateral ((Sorabh / Parth)) *In Review:* *DRILL-6475: Query with UNNEST causes a Null Pointer . (( Hanumath ))* Thanks, Sorabh On Fri, Jul 13, 2018 at 1:17 PM, Parth

[GitHub] ilooner commented on a change in pull request #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable.

2018-07-13 Thread GitBox
ilooner commented on a change in pull request #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable. URL: https://github.com/apache/drill/pull/1296#discussion_r202485302 ## File path:

[GitHub] ilooner commented on a change in pull request #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable.

2018-07-13 Thread GitBox
ilooner commented on a change in pull request #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable. URL: https://github.com/apache/drill/pull/1296#discussion_r202485289 ## File path:

[GitHub] ilooner commented on a change in pull request #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable.

2018-07-13 Thread GitBox
ilooner commented on a change in pull request #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable. URL: https://github.com/apache/drill/pull/1296#discussion_r202485318 ## File path:

[GitHub] arina-ielchiieva commented on issue #1371: DRILL-6588: Make Sys tables of nullable datatypes

2018-07-13 Thread GitBox
arina-ielchiieva commented on issue #1371: DRILL-6588: Make Sys tables of nullable datatypes URL: https://github.com/apache/drill/pull/1371#issuecomment-404945249 Once minor comment to remove space, also please squash the commits. +1, LGTM.

[GitHub] arina-ielchiieva commented on a change in pull request #1371: DRILL-6588: Make Sys tables of nullable datatypes

2018-07-13 Thread GitBox
arina-ielchiieva commented on a change in pull request #1371: DRILL-6588: Make Sys tables of nullable datatypes URL: https://github.com/apache/drill/pull/1371#discussion_r202464481 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/store/sys/TestSystemTable.java

[jira] [Created] (DRILL-6607) Index Out of Bounds Error in string_binary function

2018-07-13 Thread John Omernik (JIRA)
John Omernik created DRILL-6607: --- Summary: Index Out of Bounds Error in string_binary function Key: DRILL-6607 URL: https://issues.apache.org/jira/browse/DRILL-6607 Project: Apache Drill Issue

[jira] [Created] (DRILL-6609) Investigate Creation of FileSystem Configuration for Hive Parquet Files

2018-07-13 Thread Timothy Farkas (JIRA)
Timothy Farkas created DRILL-6609: - Summary: Investigate Creation of FileSystem Configuration for Hive Parquet Files Key: DRILL-6609 URL: https://issues.apache.org/jira/browse/DRILL-6609 Project:

[GitHub] ilooner commented on issue #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable.

2018-07-13 Thread GitBox
ilooner commented on issue #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable. URL: https://github.com/apache/drill/pull/1296#issuecomment-404976675 Created a jira for the HiveDrillNativeParquetRowGroupScan issue here