Re: Regression? Drill Truncating Varchars

2019-01-24 Thread Karthikeyan Manivannan
Hi Charles, Can you please provide the stack trace. Thanks Karthik On Tue, Jan 22, 2019 at 9:18 PM Charles Givre wrote: > Hello all, > I’m working on a format plugin to read syslog data, and have encountered > what seems to be a bit of a regression (maybe). The code below is a > helper

Q:why Hive storage plug-in optimization rule NOT working?

2019-01-24 Thread Nai Yan
Greetings, We are trying to learn about drill storage plug-in and try to optimize it for our use scenario, however we have found Hive's opt rule "HivePushPartitionFilterIntoScan" NOT really get involved in planning phase. Accorrding to our understanding, Storage plug-in's opt rule will be

Re: Regression? Drill Truncating Varchars

2019-01-24 Thread Charles Givre
Here you go… Thanks for your help! SELECT

[GitHub] amansinha100 commented on a change in pull request #1620: DRILL-6997: Semijoin is changing the join ordering for some tpcds que…

2019-01-24 Thread GitBox
amansinha100 commented on a change in pull request #1620: DRILL-6997: Semijoin is changing the join ordering for some tpcds que… URL: https://github.com/apache/drill/pull/1620#discussion_r250847043 ## File path:

[GitHub] amansinha100 commented on a change in pull request #1620: DRILL-6997: Semijoin is changing the join ordering for some tpcds que…

2019-01-24 Thread GitBox
amansinha100 commented on a change in pull request #1620: DRILL-6997: Semijoin is changing the join ordering for some tpcds que… URL: https://github.com/apache/drill/pull/1620#discussion_r250847685 ## File path:

[GitHub] amansinha100 commented on a change in pull request #1620: DRILL-6997: Semijoin is changing the join ordering for some tpcds que…

2019-01-24 Thread GitBox
amansinha100 commented on a change in pull request #1620: DRILL-6997: Semijoin is changing the join ordering for some tpcds que… URL: https://github.com/apache/drill/pull/1620#discussion_r250847230 ## File path:

[GitHub] amansinha100 commented on a change in pull request #1620: DRILL-6997: Semijoin is changing the join ordering for some tpcds que…

2019-01-24 Thread GitBox
amansinha100 commented on a change in pull request #1620: DRILL-6997: Semijoin is changing the join ordering for some tpcds que… URL: https://github.com/apache/drill/pull/1620#discussion_r250847400 ## File path:

[GitHub] weijietong commented on issue #1621: DRILL-7000: Queries failing with 'Failed to aggregate or route the RF…

2019-01-24 Thread GitBox
weijietong commented on issue #1621: DRILL-7000: Queries failing with 'Failed to aggregate or route the RF… URL: https://github.com/apache/drill/pull/1621#issuecomment-457130068 +1 LGTM This is an automated message from the

[jira] [Created] (DRILL-7001) Documentation - renaming columns name in csv header

2019-01-24 Thread benj (JIRA)
benj created DRILL-7001: --- Summary: Documentation - renaming columns name in csv header Key: DRILL-7001 URL: https://issues.apache.org/jira/browse/DRILL-7001 Project: Apache Drill Issue Type: Wish

[GitHub] arina-ielchiieva commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework

2019-01-24 Thread GitBox
arina-ielchiieva commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework URL: https://github.com/apache/drill/pull/1618#discussion_r250595479 ## File path:

[GitHub] arina-ielchiieva commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework

2019-01-24 Thread GitBox
arina-ielchiieva commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework URL: https://github.com/apache/drill/pull/1618#discussion_r250613878 ## File path:

[GitHub] arina-ielchiieva commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework

2019-01-24 Thread GitBox
arina-ielchiieva commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework URL: https://github.com/apache/drill/pull/1618#discussion_r250585447 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/ReaderState.java

[GitHub] arina-ielchiieva commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework

2019-01-24 Thread GitBox
arina-ielchiieva commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework URL: https://github.com/apache/drill/pull/1618#discussion_r250586846 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/ReaderState.java

[GitHub] arina-ielchiieva commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework

2019-01-24 Thread GitBox
arina-ielchiieva commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework URL: https://github.com/apache/drill/pull/1618#discussion_r250591376 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/ScanOperatorExec.java

[GitHub] arina-ielchiieva commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework

2019-01-24 Thread GitBox
arina-ielchiieva commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework URL: https://github.com/apache/drill/pull/1618#discussion_r250608494 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/file/FileMetadata.java

[GitHub] arina-ielchiieva commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework

2019-01-24 Thread GitBox
arina-ielchiieva commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework URL: https://github.com/apache/drill/pull/1618#discussion_r250591780 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/ScanOperatorExec.java

[GitHub] arina-ielchiieva commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework

2019-01-24 Thread GitBox
arina-ielchiieva commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework URL: https://github.com/apache/drill/pull/1618#discussion_r250591467 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/ScanOperatorExec.java

[GitHub] arina-ielchiieva commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework

2019-01-24 Thread GitBox
arina-ielchiieva commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework URL: https://github.com/apache/drill/pull/1618#discussion_r250618703 ## File path:

[GitHub] arina-ielchiieva commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework

2019-01-24 Thread GitBox
arina-ielchiieva commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework URL: https://github.com/apache/drill/pull/1618#discussion_r250594821 ## File path:

[GitHub] arina-ielchiieva commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework

2019-01-24 Thread GitBox
arina-ielchiieva commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework URL: https://github.com/apache/drill/pull/1618#discussion_r250597030 ## File path:

[GitHub] arina-ielchiieva commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework

2019-01-24 Thread GitBox
arina-ielchiieva commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework URL: https://github.com/apache/drill/pull/1618#discussion_r250615178 ## File path:

[GitHub] arina-ielchiieva commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework

2019-01-24 Thread GitBox
arina-ielchiieva commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework URL: https://github.com/apache/drill/pull/1618#discussion_r250612100 ## File path:

[GitHub] arina-ielchiieva commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework

2019-01-24 Thread GitBox
arina-ielchiieva commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework URL: https://github.com/apache/drill/pull/1618#discussion_r250616495 ## File path:

[GitHub] arina-ielchiieva commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework

2019-01-24 Thread GitBox
arina-ielchiieva commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework URL: https://github.com/apache/drill/pull/1618#discussion_r250575132 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/ReaderState.java

[GitHub] arina-ielchiieva commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework

2019-01-24 Thread GitBox
arina-ielchiieva commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework URL: https://github.com/apache/drill/pull/1618#discussion_r250608930 ## File path:

[GitHub] arina-ielchiieva commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework

2019-01-24 Thread GitBox
arina-ielchiieva commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework URL: https://github.com/apache/drill/pull/1618#discussion_r250626306 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/scan/TestScanBatchWriters.java

[GitHub] arina-ielchiieva commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework

2019-01-24 Thread GitBox
arina-ielchiieva commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework URL: https://github.com/apache/drill/pull/1618#discussion_r250598167 ## File path:

[GitHub] arina-ielchiieva commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework

2019-01-24 Thread GitBox
arina-ielchiieva commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework URL: https://github.com/apache/drill/pull/1618#discussion_r250597646 ## File path:

[GitHub] arina-ielchiieva commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework

2019-01-24 Thread GitBox
arina-ielchiieva commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework URL: https://github.com/apache/drill/pull/1618#discussion_r250586889 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/ReaderState.java

[GitHub] arina-ielchiieva commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework

2019-01-24 Thread GitBox
arina-ielchiieva commented on a change in pull request #1618: DRILL-6950: Row set-based scan framework URL: https://github.com/apache/drill/pull/1618#discussion_r250608895 ## File path:

[GitHub] sohami commented on issue #1600: DRILL-6947: fix RuntimeFilter memory leak

2019-01-24 Thread GitBox
sohami commented on issue #1600: DRILL-6947: fix RuntimeFilter memory leak URL: https://github.com/apache/drill/pull/1600#issuecomment-457270884 +1 LTGM Please squash all commits into 2 commits such that changes related to DRILL-6947 are in 1 commit and DRILL-6999 are in other commit.

[GitHub] amansinha100 commented on a change in pull request #729: Drill 1328: Support table statistics for Parquet

2019-01-24 Thread GitBox
amansinha100 commented on a change in pull request #729: Drill 1328: Support table statistics for Parquet URL: https://github.com/apache/drill/pull/729#discussion_r250445032 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillStatsTable.java

[GitHub] amansinha100 commented on a change in pull request #729: Drill 1328: Support table statistics for Parquet

2019-01-24 Thread GitBox
amansinha100 commented on a change in pull request #729: Drill 1328: Support table statistics for Parquet URL: https://github.com/apache/drill/pull/729#discussion_r250695535 ## File path:

[GitHub] amansinha100 commented on a change in pull request #729: Drill 1328: Support table statistics for Parquet

2019-01-24 Thread GitBox
amansinha100 commented on a change in pull request #729: Drill 1328: Support table statistics for Parquet URL: https://github.com/apache/drill/pull/729#discussion_r250703423 ## File path: protocol/src/main/protobuf/UserBitShared.proto ## @@ -350,6 +350,9 @@ enum

[GitHub] amansinha100 commented on a change in pull request #729: Drill 1328: Support table statistics for Parquet

2019-01-24 Thread GitBox
amansinha100 commented on a change in pull request #729: Drill 1328: Support table statistics for Parquet URL: https://github.com/apache/drill/pull/729#discussion_r250700249 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/util/Utilities.java ## @@ -60,9

[GitHub] amansinha100 commented on a change in pull request #729: Drill 1328: Support table statistics for Parquet

2019-01-24 Thread GitBox
amansinha100 commented on a change in pull request #729: Drill 1328: Support table statistics for Parquet URL: https://github.com/apache/drill/pull/729#discussion_r250443381 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillStatsTable.java

[GitHub] amansinha100 commented on a change in pull request #729: Drill 1328: Support table statistics for Parquet

2019-01-24 Thread GitBox
amansinha100 commented on a change in pull request #729: Drill 1328: Support table statistics for Parquet URL: https://github.com/apache/drill/pull/729#discussion_r250692027 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillStatsTable.java

[GitHub] amansinha100 commented on a change in pull request #729: Drill 1328: Support table statistics for Parquet

2019-01-24 Thread GitBox
amansinha100 commented on a change in pull request #729: Drill 1328: Support table statistics for Parquet URL: https://github.com/apache/drill/pull/729#discussion_r250697144 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/DirectScanPrel.java

[GitHub] amansinha100 commented on a change in pull request #729: Drill 1328: Support table statistics for Parquet

2019-01-24 Thread GitBox
amansinha100 commented on a change in pull request #729: Drill 1328: Support table statistics for Parquet URL: https://github.com/apache/drill/pull/729#discussion_r250701068 ## File path: exec/java-exec/src/main/resources/drill-module.conf ## @@ -584,6 +584,8 @@

[GitHub] amansinha100 commented on a change in pull request #729: Drill 1328: Support table statistics for Parquet

2019-01-24 Thread GitBox
amansinha100 commented on a change in pull request #729: Drill 1328: Support table statistics for Parquet URL: https://github.com/apache/drill/pull/729#discussion_r250441772 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillScanRelBase.java

[GitHub] amansinha100 commented on a change in pull request #729: Drill 1328: Support table statistics for Parquet

2019-01-24 Thread GitBox
amansinha100 commented on a change in pull request #729: Drill 1328: Support table statistics for Parquet URL: https://github.com/apache/drill/pull/729#discussion_r250698815 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/NestedLoopJoinPrule.java

[GitHub] amansinha100 commented on a change in pull request #729: Drill 1328: Support table statistics for Parquet

2019-01-24 Thread GitBox
amansinha100 commented on a change in pull request #729: Drill 1328: Support table statistics for Parquet URL: https://github.com/apache/drill/pull/729#discussion_r250691493 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillStatsTable.java

[GitHub] amansinha100 commented on a change in pull request #729: Drill 1328: Support table statistics for Parquet

2019-01-24 Thread GitBox
amansinha100 commented on a change in pull request #729: Drill 1328: Support table statistics for Parquet URL: https://github.com/apache/drill/pull/729#discussion_r250709589 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StatisticsAggrFunctions.java