GitHub user chunhui-shi opened a pull request:
https://github.com/apache/drill/pull/408
DRILL-4237 DRILL-4478 fully implement hash to use murmur3 and correspondent
unit tests
1, Implement Murmur3 to work on DrillBuf and long(double), both avoid
object or extra buffer creation
Github user chunhui-shi commented on the pull request:
https://github.com/apache/drill/pull/408#issuecomment-193430786
As to the test code that use original cpp implementation to generate the
test vectors in murmur3_buf.json and murmur3_double.json. Please refer to here
Github user chunhui-shi closed the pull request at:
https://github.com/apache/drill/pull/408
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user chunhui-shi opened a pull request:
https://github.com/apache/drill/pull/430
DRILL-4237 DRILL-4478 fully implement hash to use murmur3 and correspâ¦
Since we have to have our own implementations of hash functions, UNIT tests
should guarantee the correctness of
GitHub user chunhui-shi opened a pull request:
https://github.com/apache/drill/pull/702
DRILL-5088: set default codec for toJson
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chunhui-shi/drill DRILL-5088
Alternatively you can
GitHub user chunhui-shi opened a pull request:
https://github.com/apache/drill/pull/715
DRILL-5105: remove buffer size checking in getBuffers since it is onlâ¦
â¦y for debug and the redundancy increases exponentially.
You can merge this pull request into a Git repository by
Congratulations to IndexR team! What is your plan to add indexR storage
plugin to Drill? Cannot wait to try it out with Drill.
On Tue, Jan 3, 2017 at 9:02 AM, Jinfeng Ni wrote:
> Forward to drill dev list. People on dev list might be interested in
> this as well.
>
>
> On Tue, Jan 3, 2017 at 8
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/715#discussion_r94471881
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/vector/complex/MapVector.java
---
@@ -134,10 +134,6 @@ public int getBufferSizeFor(final int
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/706#discussion_r94492239
--- Diff: exec/java-exec/src/main/codegen/templates/NewValueFunctions.java
---
@@ -17,6 +17,12 @@
*/
<@pp.dropOutputFile />
+&
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/609#discussion_r94686987
--- Diff:
contrib/storage-mongo/src/main/resources/bootstrap-storage-plugins.json ---
@@ -3,7 +3,8 @@
mongo : {
type:"
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/609#discussion_r94687060
--- Diff:
contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoStoragePlugin.java
---
@@ -136,17 +138,40 @@ public synchronized
Or you want to delete tpch-sample-data from your local mvn cache
(~/.m2/repository/org/apache/drill/contrib/data/tpch-sample-data) and try
it again. The previous download could be corrupted or did not succeed.
On Thu, Jan 5, 2017 at 11:02 AM, Chun Chang wrote:
> The FW might be the cause, but yo
Github user chunhui-shi commented on the issue:
https://github.com/apache/drill/pull/715
Keep original code as commented out per offline discussion with Paul.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user chunhui-shi commented on the issue:
https://github.com/apache/drill/pull/702
MongoGroupScan tries to read first record to guess record width. So this
toJson is called for only first record.
Notice that MongoClient.getDefaultCodecRegistry() contains
GitHub user chunhui-shi opened a pull request:
https://github.com/apache/drill/pull/722
DRILL-5196: init MongoDB cluster when run a single test case directlyâ¦
⦠through command line or IDE.
Other fixes include:
Sync mongo-java-driver versions to newer 3.2.0
I guess you are using Hive 2.0 as meta server while Drill has only 1.2
libraries.
In Hive 2.0 above, This delta format could have more than one '_' as separator
while 1.2 has only one '_'.
I think Drill should eventually update to use Hive's 2.0/2.1 libraries.
___
Github user chunhui-shi closed the pull request at:
https://github.com/apache/drill/pull/722
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user chunhui-shi opened a pull request:
https://github.com/apache/drill/pull/741
DRILL-5196: init MongoDB cluster when run a single test case directlyâ¦
⦠through command line or IDE.
Other fixes include:
Sync mongo-java-driver versions to newer 3.2.0
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/702#discussion_r99448154
--- Diff:
contrib/storage-mongo/src/test/java/org/apache/drill/exec/store/mongo/TestTableGenerator.java
---
@@ -58,7 +59,16 @@ public static void
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/741#discussion_r99452939
--- Diff:
contrib/storage-mongo/src/test/java/org/apache/drill/exec/store/mongo/MongoTestSuit.java
---
@@ -234,15 +243,25 @@ private static void
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/741#discussion_r99453293
--- Diff:
contrib/storage-mongo/src/test/java/org/apache/drill/exec/store/mongo/MongoTestSuit.java
---
@@ -234,15 +243,25 @@ private static void
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/741#discussion_r99455997
--- Diff:
contrib/storage-mongo/src/test/java/org/apache/drill/exec/store/mongo/MongoTestSuit.java
---
@@ -204,16 +209,20 @@ private static void cleanup
Github user chunhui-shi commented on the issue:
https://github.com/apache/drill/pull/594
+1. LGTM. Need to address conflict before ready to commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/750#discussion_r102377194
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/CompliantTextRecordReader.java
---
@@ -118,12 +118,21 @@ public
GitHub user chunhui-shi opened a pull request:
https://github.com/apache/drill/pull/776
DRILL-5165: limitRel to return correct rows for limit all case
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chunhui-shi/drill DRILL-5165
Github user chunhui-shi commented on the issue:
https://github.com/apache/drill/pull/776
It failed without the fix.
From: Jinfeng Ni
Sent: Wednesday, March 8, 2017 10:56:06 AM
To: apache/drill
Cc: Chunhui Shi; Author
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/776#discussion_r105102270
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/limit/TestLimitWithExchanges.java
---
@@ -125,6 +125,15 @@ public void
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/784#discussion_r106044402
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/PrelVisualizerVisitor.java
---
@@ -0,0 +1,217
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/784#discussion_r106044432
--- Diff:
logical/src/main/java/org/apache/drill/common/expression/FieldReference.java ---
@@ -1,4 +1,4 @@
-/**
--- End diff --
I have
I think they are using the same timezone data from IANA,
For Java the timezone data can be found under jre/lib/zi, and Oracle has a
timezone update tool too.
For enterprise software vendors, timezone update actually is a big thing.
From: Boaz Ben-Zvi
Sent: Thursd
Hi community, I just tried to connect to Hangout. Do you have any topic for
today?
From: Arina Yelchiyeva
Sent: Tuesday, March 21, 2017 10:11 AM
To: dev@drill.apache.org
Subject: Hangouts: 03/21/2017
Will hangouts be held today?
Kind regards
Arina
Hi,
I don't have topic for now. If you have anything want to raise for discussion
please reply to the email or join the hangout at
https://hangouts.google.com/hangouts/_/event/ci4rdiju8bv04a64efj5fedd0lc
Thanks,
Chunhui
GitHub user chunhui-shi opened a pull request:
https://github.com/apache/drill/pull/795
DRILL-5089: Get only partial schemas of relevant storage plugins instâ¦
â¦ead of all storages ahead.
1. For each query, rootSchema is empty, add schemas of a storage plugin
only when
GitHub user chunhui-shi opened a pull request:
https://github.com/apache/drill/pull/796
DRILL-5365: DrillFileSystem setConf in constructor. DrillFileSystem câ¦
â¦ould be created based on provided URI.
You can merge this pull request into a Git repository by running:
$ git
GitHub user chunhui-shi opened a pull request:
https://github.com/apache/drill/pull/797
DRILL-5286: No need to convert when the relNode and target candidate â¦
â¦set are the same
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user chunhui-shi opened a pull request:
https://github.com/apache/drill/pull/798
DRILL-5297: when the generated plan mismatches, PlanTest print the geâ¦
â¦nerated plan along with expected pattern
You can merge this pull request into a Git repository by running:
$ git
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/797#discussion_r108052498
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/SubsetTransformer.java
---
@@ -45,15 +48,20 @@ public RelTraitSet
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/797#discussion_r109025164
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/SubsetTransformer.java
---
@@ -45,15 +48,20 @@ public RelTraitSet
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/796#discussion_r115107663
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/DrillFileSystem.java
---
@@ -89,22 +89,36 @@ public DrillFileSystem(Configuration
Congrats Paul! Thank you for your contributions!
From: rahul challapalli
Sent: Friday, May 19, 2017 9:20:52 AM
To: dev
Subject: Re: [ANNOUNCE] New Committer: Paul Rogers
Congratulations Paul. Well Deserved.
On Fri, May 19, 2017 at 8:46 AM, Gautam Parai wrote:
We are going to have a hangout today at 10:00am Pacific Time. Please feel free
to raise topics of interests.
Chunhui
hangouts is at
https://docs.google.com/spreadsheets/d/1bEQKk16Kktb1XeZwKD8xCuhaO8FtNfF1Cr2rcTv1a6M/edit#gid=0
From: Chunhui Shi
Sent: Tuesday, June 27, 2017 9:53:37 AM
To: dev@drill.apache.org; u...@drill.apache.org
Subject: Drill hangout today
We are going to have a
Hangout minutes:
Attendees: Jyothsna, Jinfeng, Pritesh, Boaz, Paul, Arina, John, Rob, etc
Arina as the release manager for 1.11.0 asked some questions about logistics of
a new release for Drill.
Jinfeng provided some description about the workflow, like get PGP key, prepare
candidates.
Arina
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/875#discussion_r128875470
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZKACLProviderFactory.java
---
@@ -0,0 +1,44 @@
+/**
+ * Licensed to the
A while ago my experiments ( https://issues.apache.org/jira/browse/DRILL-4778 )
show that JDK is more favorable in the aspect of the efficiency of generated
code, as to the time of the compilation at that time it was Janino showing
better performance. If in JDK 8 this is no more the case, I don'
Correct my previous response:
In DRILL-4778, JDK was faster in compilation but generated slower code. Janino
was slower in compilation and generate faster code. Your JIRA did not mention
how was the performance when running generated code. You may want to test this
aspect as well.
From: weij
Github user chunhui-shi closed the pull request at:
https://github.com/apache/drill/pull/776
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
What is your github account?
From: Timothy Farkas
Sent: Tuesday, August 8, 2017 3:31:13 PM
To: dev@drill.apache.org
Subject: First Drill Ticket
Hello All,
I'm getting started on my first newbie drill ticket
https://issues.apache.org/jira/browse/DRILL-4211 . If I
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/430#discussion_r56924863
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/HashHelper.java
---
@@ -17,47 +17,77 @@
*/
package
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/430#discussion_r57202442
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/HashHelper.java
---
@@ -17,47 +17,77 @@
*/
package
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/430#discussion_r57203072
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MurmurHash3.java
---
@@ -0,0 +1,264 @@
+/**
+ * Licensed to the Apache
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/430#discussion_r57206301
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MurmurHash3.java
---
@@ -0,0 +1,264 @@
+/**
+ * Licensed to the Apache
Hi Xueping,
The drill-module.conf should be put into the your jar file. The logic about
what jar to scan(thus to extract the class) during startup is based on if
there is a drill-module.conf in that jar file. Hope this helps.
Thanks,
Chunhui
On Tue, Mar 29, 2016 at 2:29 AM, xuepingy...@cienet.c
Thanks for pointing to openHFT. I went through multiple Java
implementations including this one. The reason I decided to use smhasher as
the source of truth was, the smhasher implementation includes comprehensive
tests to cover the attributes for measuring goodness of a non-cryptographic
hash funct
Github user chunhui-shi commented on the pull request:
https://github.com/apache/drill/pull/430#issuecomment-206578634
@jacques-n
The email response is not pushed here. So copy the sent email as below:
Thanks for pointing to openHFT. Yes, I went through multiple Java
GitHub user chunhui-shi opened a pull request:
https://github.com/apache/drill/pull/470
DRILL-4143: Fix inconsistency in writing metadata with different user's
permission.
When accessing readBlockMeta, use an impersonated special Filesystem
object which is of drillbituser.
Github user chunhui-shi commented on the pull request:
https://github.com/apache/drill/pull/470#issuecomment-207939397
This function is one entrance to access metadata. Write (Automatic metadata
update) will happen during this 'read' process if there is any directory/file
Github user chunhui-shi commented on the pull request:
https://github.com/apache/drill/pull/470#issuecomment-208558947
This createMeta is only called in RefreshMetadataHandler using a
DrillFileSystem created locally without impersonation, so the filesystem used
in createMeta needs no
The rand([seed optional]) is loaded from hive's UDF, the 'random()'
function is drill's implementation.
Since drill has the logic to use the previous function container thus the
previous result is reused. I would say this is a bug for random generator.
The fix should be allowing some functions not
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/430#discussion_r59290217
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/DrillHash.java
---
@@ -0,0 +1,50 @@
+/**
+ * Licensed to the Apache
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/430#discussion_r59290818
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MurmurHash3.java
---
@@ -0,0 +1,280 @@
+/**
+ * Licensed to the Apache
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/430#discussion_r59290968
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestHashBase.java ---
@@ -0,0 +1,72 @@
+/**
+ * Licensed to the Apache
Github user chunhui-shi closed the pull request at:
https://github.com/apache/drill/pull/430
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user chunhui-shi opened a pull request:
https://github.com/apache/drill/pull/485
DRILL-4237: Implement murmur3 for HashHelper
Unit Test was removed from this commit. Test codes and the the test vector
generator program will be included in functional tests in a separate
Github user chunhui-shi commented on the pull request:
https://github.com/apache/drill/pull/485#issuecomment-212017670
Previous pull request and comments: https://github.com/apache/drill/pull/408
---
If your project is set up for it, you can reply to this email and have your
reply
Github user chunhui-shi commented on the pull request:
https://github.com/apache/drill/pull/485#issuecomment-212021177
https://github.com/apache/drill/pull/430
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user chunhui-shi closed the pull request at:
https://github.com/apache/drill/pull/470
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Big congratulations to Parth!
Thanks Jacques for founding Drill project and way to go drillers!
Chunhui
On Wed, May 25, 2016 at 11:45 AM, John Omernik wrote:
> Congratz Parth, and thank you Jacques!
>
> On Wed, May 25, 2016 at 1:25 PM, Xiao Meng wrote:
>
> > Big congratulations, Parth!
> >
> >
GitHub user chunhui-shi opened a pull request:
https://github.com/apache/drill/pull/509
DRILL-4618: Fix hive function loader not correctly take random flag; â¦
â¦and function visitor should not use previous function holder if this
function is nondeterministic
You can merge this
There are two issues, one is we use hive's deterministic flag in an
opposite way, another one is when drill visit an expression, we take a
previous found holder, but that is not right if this function is
nondeterministic. A JIRA was created and a pull request of fix was posted:
https://issues.apac
I think to avoid that size increase is to revert back to the previous
change which implemented the CORS manually and did not introduce this extra
jar file. If our goal is to eat only one egg we don't need to buy a hen.
On Mon, Jun 6, 2016 at 2:36 PM, sudheeshkatkam wrote:
> Github user sudheeshk
Usually I create one branch under my own repo for one fix, then submit a
new pull request from that branch.
On Thu, Jun 9, 2016 at 12:46 PM, Dave Oshinsky
wrote:
> My user on github already has one Apache Drill fork, and one pull request (
> https://github.com/apache/drill/pull/372). This has
GitHub user chunhui-shi opened a pull request:
https://github.com/apache/drill/pull/535
DRILL-4695: Log error thrown from drillbit.run
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chunhui-shi/drill errexit
Alternatively you
Github user chunhui-shi closed the pull request at:
https://github.com/apache/drill/pull/535
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user chunhui-shi opened a pull request:
https://github.com/apache/drill/pull/537
DRILL-4695: Log error thrown out of drillbit.run before close
Seems reverting previous change closes the pull request, have to send a new
one. Thanks Sudheesh for prompt code review at
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/518#discussion_r70863798
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java
---
@@ -110,21 +118,29 @@ public void
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/518#discussion_r70872218
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/json/TestJsonRecordReader.java
---
@@ -56,11 +57,19 @@ public void
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/518#discussion_r70879473
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/json/TestJsonRecordReader.java
---
@@ -159,64 +164,91 @@ public void drill_3353
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/518#discussion_r70879554
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/json/TestJsonRecordReader.java
---
@@ -159,64 +164,91 @@ public void drill_3353
Github user chunhui-shi commented on the issue:
https://github.com/apache/drill/pull/518
Thanks for providing a way to skip bad json records and addressing my
comments.
Besides the minor improvements I suggested above: comment format changes
that may be due to line width in your
GitHub user chunhui-shi opened a pull request:
https://github.com/apache/drill/pull/546
DRILL-4783: flatten operator should not throw exception if there is empty
resultset
returned for underlying operator which is convert_from or other complex
functions.
You can merge this pull
Github user chunhui-shi commented on the issue:
https://github.com/apache/drill/pull/509
@StevenMPhillips Hi Steven, is this fix addressing your concern now? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user chunhui-shi commented on the issue:
https://github.com/apache/drill/pull/546
@jaltekruse Hi Jason, could you help to review this change? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/546#discussion_r71471032
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java
---
@@ -129,8 +129,14 @@ private void
Cool. And we know that there are already many 'light weight' APIs soon
become the main stream APIs.
On Tue, Jul 19, 2016 at 10:56 PM, Paul Rogers wrote:
> Hi All,
>
> As I’ve been playing with and learning about Drill, it struck me that
> Drill is a wonderful “industrial strength” query engine,
Github user chunhui-shi commented on the issue:
https://github.com/apache/drill/pull/546
Thanks @jaltekruse for the review. I updated exception text and added test
case following your suggestion.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/546#discussion_r71634838
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java
---
@@ -129,11 +129,21 @@ private void
Github user chunhui-shi commented on the issue:
https://github.com/apache/drill/pull/546
Update based on Jinfeng's comment. Jinfeng, could you check if I addressed
your concern? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appe
+1
Built from source zip file with unit test all passed on Linux
Randomly verified DRILL-4825
On Fri, Aug 12, 2016 at 3:52 AM, Arina Yelchiyeva <
arina.yelchiy...@gmail.com> wrote:
> +1 (non-binding)
> On Windows built from source, ran in embedded mode.
> Installed on cluster.
> Checked some ne
The topics I think we should cover are:
1, Updates on 1.8.0 release.
2, Recently there are some thoughts on how to improve and shorten unit
tests. Would like to get some more inputs on this topic.
If there is any topic you feel that we should discuss, please feel free to
bring them up here or at
The link of hangout is:
https://plus.google.com/hangouts/_/event/ci4rdiju8bv04a64efj5fedd0lc
uild improvement, e.g. split java-exec into smaller
pieces, remove stdout output of unit tests, maven run in parallel, timing
unit tests, drill bit restart, etc.
unit tests fails often. windows, Mac, linux,
Chunhui
On Tue, Aug 23, 2016 at 10:04 AM, Chunhui Shi wrote:
> The link of han
+1(non binding)
Built from source under apache profile with Unit tests passed.
Ran some queries all got expected results.
On Mon, Aug 29, 2016 at 2:13 PM, Paul Rogers wrote:
> +1 (non binding)
>
> The Drill-on-YARN project is coming soon. That project has an exhaustive
> unit test for the Drill
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/578#discussion_r78790827
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/plain/PlainServer.java
---
@@ -0,0 +1,174 @@
+/**
+ * Licensed to the
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/578#discussion_r78791283
--- Diff:
protocol/src/main/java/org/apache/drill/exec/proto/UserProtos.java ---
@@ -47,157 +47,165 @@ public static void registerAllExtensions
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/578#discussion_r78791984
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/plain/PlainServer.java
---
@@ -0,0 +1,174 @@
+/**
+ * Licensed to the
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/578#discussion_r78798093
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java ---
@@ -246,28 +154,80 @@ protected void handle
Github user chunhui-shi commented on the issue:
https://github.com/apache/drill/pull/587
+1, unit test passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/594#discussion_r81617585
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java
---
@@ -131,14 +139,33 @@ public void
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/594#discussion_r81619047
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java
---
@@ -337,6 +364,7 @@ private void writeData(MapWriter
1 - 100 of 232 matches
Mail list logo
