[GitHub] drill pull request #940: DRILL-5752 Speed Up Unit Tests add Test Categories

2017-09-13 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/940#discussion_r138683227 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestCorruptParquetDateCorrection.java --- @@ -59,6 +61,7 @@ * Use

[GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...

2017-09-11 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/923#discussion_r138205470 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/server/TestOptions.java --- @@ -56,7 +56,7 @@ public void checkChangedColumn() throws Exception

[GitHub] drill issue #923: DRILL-5723: Added System Internal Options That can be Modi...

2017-09-11 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/923 @paul-rogers Finished apply review comments. PR is ready for review again. ---

[GitHub] drill issue #940: DRILL-5752 Speed Up Unit Tests add Test Categories

2017-09-13 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/940 Thanks @paul-rogers squashed and ready to commit ---

[GitHub] drill issue #945: DRILL-5798 Fixed Unstable Tests

2017-09-18 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/945 @paul-rogers Yeah it fixes jdbc-all. Sorry for the mix up this mistake mainly stemmed from me being ignorant of the jenkins build and being unaware of jenkins failures until the batch commit

[GitHub] drill issue #945: DRILL-5798 Fixed Unstable Tests

2017-09-18 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/945 @paul-rogers I had added a dependency that was being pulled into the jdbc-all jar. I excluded that dependency, but the size of the jar had still grown to be 100 kb over 29 Mb, so I bumped the allowed

[GitHub] drill pull request #957: DRILL-5809 Fixed Option Storage Backward Compatibil...

2017-09-23 Thread ilooner
GitHub user ilooner opened a pull request: https://github.com/apache/drill/pull/957 DRILL-5809 Fixed Option Storage Backward Compatibility Issue Introduced With Option System Change This PR resolves the backward compatibility issue introduced with https://github.com/apache/drill

[GitHub] drill issue #957: DRILL-5809 Fixed Option Storage Backward Compatibility Iss...

2017-09-23 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/957 @paul-rogers ---

[GitHub] drill issue #940: DRILL-5752 Speed Up Unit Tests add Test Categories

2017-09-13 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/940 Please merge my other PR https://github.com/apache/drill/pull/923 before this one. Thanks! ---

[GitHub] drill issue #923: DRILL-5723: Added System Internal Options That can be Modi...

2017-09-13 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/923 Thanks @paul-rogers squashed and ready to commit. Please merge this change before my other PR https://github.com/apache/drill/pull/940 ---

[GitHub] drill pull request #945: DRILL-5798 Fixed Unstable Tests

2017-09-18 Thread ilooner
GitHub user ilooner opened a pull request: https://github.com/apache/drill/pull/945 DRILL-5798 Fixed Unstable Tests - Fixed unstable StatusResourcesTest - Fixed buggy port hunting for the WebService - Fixed bug in ClientFixture which does not assign the correct user port

[GitHub] drill issue #945: DRILL-5798 Fixed Unstable Tests

2017-09-18 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/945 @paul-rogers PR https://github.com/apache/drill/pull/923 accidentally got merged before I finished fixing jenkins test issues. This PR fixes the tests that were failing on jenkins as a result

[GitHub] drill issue #970: DRILL-5832: Migrate OperatorFixture to use SystemOptionMan...

2017-10-04 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/970 @paul-rogers Some tests are failing on my machine ``` Failed tests: TestMetadataProvider.tables:154 expected: but was: TestMetadataProvider.tablesWithTableNameFilter:219

[GitHub] drill issue #970: DRILL-5832: Migrate OperatorFixture to use SystemOptionMan...

2017-10-04 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/970 @paul-rogers It looks like the unit test failures were caused by an unrelated issue. My Mac sometimes create a wifi*.log file in /tmp . And the presence of the file in /tmp causes some unit tests

[GitHub] drill issue #984: DRILL-5783 Made a unit test for generated Priority Queue. ...

2017-10-12 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/984 @paul-rogers Applied / responding to comments. Also removed RecordBatchBuilder and used RowSetBuilder. ---

[GitHub] drill issue #923: DRILL-5723: Added System Internal Options That can be Modi...

2017-09-08 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/923 @paul-rogers Finished applying comments, and cleanup. It's ready for review again now. ---

[GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...

2017-09-11 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/923#discussion_r138168189 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/OptionMetaData.java --- @@ -0,0 +1,68 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...

2017-09-11 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/923#discussion_r138171404 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/DrillConfigIterator.java --- @@ -58,17 +58,17 @@ public OptionValue next

[GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...

2017-09-11 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/923#discussion_r138173050 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/BaseOptionManager.java --- @@ -17,44 +17,84 @@ */ package

[GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...

2017-09-11 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/923#discussion_r138167788 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/OptionValue.java --- @@ -63,32 +88,32 @@ public final Double float_val

[GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...

2017-09-11 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/923#discussion_r138168825 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/OptionManager.java --- @@ -17,49 +17,97 @@ */ package

[GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...

2017-09-11 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/923#discussion_r138133105 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/testing/TestExceptionInjection.java --- @@ -216,79 +216,77 @@ public void

[GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...

2017-09-11 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/923#discussion_r138132972 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/RestClientFixture.java --- @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software

[GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...

2017-09-11 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/923#discussion_r138133008 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/testing/TestPauseInjection.java --- @@ -150,66 +150,61 @@ public void pauseOnSpecificBit

[GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...

2017-09-11 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/923#discussion_r138132892 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/server/TestOptions.java --- @@ -56,7 +56,7 @@ public void checkChangedColumn() throws Exception

[GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...

2017-09-11 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/923#discussion_r138133824 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/limit/TestLimitWithExchanges.java --- @@ -71,7 +72,8 @@ public void

[GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...

2017-09-11 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/923#discussion_r138152185 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java --- @@ -346,17 +347,63 @@ public void deleteAllOptions

[GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...

2017-09-11 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/923#discussion_r138148176 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestMergeJoinAdvanced.java --- @@ -102,10 +103,11 @@ public void testFix2967

[GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...

2017-09-11 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/923#discussion_r138152163 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestMergeJoinAdvanced.java --- @@ -102,10 +103,11 @@ public void testFix2967

[GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...

2017-09-05 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/923#discussion_r137122952 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java --- @@ -83,18 +86,20 @@ @VisibleForTesting public Drillbit

[GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...

2017-09-05 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/923#discussion_r137136257 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/RestClientFixture.java --- @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software

[GitHub] drill issue #923: DRILL-5723: Added System Internal Options That can be Modi...

2017-09-07 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/923 So it looks like Drill's treatment of OptionType and OptionScope is inconsistent at present. To correct this I am doing the following: - OptionType seems to be I'll defined. I think

[GitHub] drill pull request #940: DRILL-5752 Speed Up Unit Tests add Test Categories

2017-09-12 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/940#discussion_r138506701 --- Diff: common/src/test/java/org/apache/drill/categories/package-info.java --- @@ -0,0 +1,23 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] drill pull request #940: DRILL-5752 Speed Up Unit Tests add Test Categories

2017-09-12 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/940#discussion_r138506769 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java --- @@ -54,11 +56,13 @@ import

[GitHub] drill pull request #940: DRILL-5752 Speed Up Unit Tests add Test Categories

2017-09-12 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/940#discussion_r138497894 --- Diff: exec/jdbc/src/test/java/org/apache/drill/jdbc/ConnectionTest.java --- @@ -57,7 +61,9 @@ public static void setUpConnection() throws SQLException

[GitHub] drill pull request #940: DRILL-5752 Speed Up Unit Tests add Test Categories

2017-09-12 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/940#discussion_r138497914 --- Diff: exec/jdbc/src/test/java/org/apache/drill/jdbc/ConnectionTest.java --- @@ -57,7 +61,9 @@ public static void setUpConnection() throws SQLException

[GitHub] drill pull request #940: DRILL-5752 Speed Up Unit Tests add Test Categories

2017-09-12 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/940#discussion_r138499857 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java --- @@ -54,11 +56,13 @@ import

[GitHub] drill pull request #940: DRILL-5752 Speed Up Unit Tests add Test Categories

2017-09-12 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/940#discussion_r138505403 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/xsort/TestSimpleExternalSort.java --- @@ -148,10 +149,10 @@ public void

[GitHub] drill pull request #940: DRILL-5752 Speed Up Unit Tests add Test Categories

2017-09-12 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/940#discussion_r138489633 --- Diff: common/src/test/java/org/apache/drill/categories/package-info.java --- @@ -0,0 +1,23 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] drill pull request #940: DRILL-5752 Speed Up Unit Tests add Test Categories

2017-09-12 Thread ilooner
GitHub user ilooner opened a pull request: https://github.com/apache/drill/pull/940 DRILL-5752 Speed Up Unit Tests add Test Categories This PR does the following. **Increased Concurrency:** Previously tests only executed in 2 simultaneous processes, now one process per

[GitHub] drill issue #940: DRILL-5752 Speed Up Unit Tests add Test Categories

2017-09-12 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/940 @paul-rogers This is an implementation of the Test Categories suggestion you made on the dev list. It's ready for review. ---

[GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...

2017-09-11 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/923#discussion_r138182296 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/BaseOptionManager.java --- @@ -17,44 +17,84 @@ */ package

[GitHub] drill pull request #964: DRILL-5755 Reduced default number of batches kept i...

2017-09-26 Thread ilooner
GitHub user ilooner opened a pull request: https://github.com/apache/drill/pull/964 DRILL-5755 Reduced default number of batches kept in memory by TopN You can merge this pull request into a Git repository by running: $ git pull https://github.com/ilooner/drill DRILL-5755

[GitHub] drill issue #957: DRILL-5809 Fixed Option Storage Backward Compatibility Iss...

2017-09-25 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/957 @paul-rogers Applied comments and did a few other changes. Unit tests cover backward compatability. I manually tested forward compatability locally by saving some options with the new version using

[GitHub] drill issue #957: DRILL-5809 Fixed Option Storage Backward Compatibility Iss...

2017-09-25 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/957 @paul-rogers Applied comments and squashed commits ---

[GitHub] drill issue #940: DRILL-5752 Speed Up Unit Tests add Test Categories

2017-09-27 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/940 @paul-rogers I have made a few other changes, could you review once more? ---

[GitHub] drill pull request #965: DRILL-5811 reduced repeated log messages further.

2017-09-28 Thread ilooner
GitHub user ilooner opened a pull request: https://github.com/apache/drill/pull/965 DRILL-5811 reduced repeated log messages further. This reduces the number of messages printed for blocks that are on nodes on which there is no drillbit running. Now the number of messages printed

[GitHub] drill issue #965: DRILL-5811 reduced repeated log messages further.

2017-09-28 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/965 @paul-rogers ---

[GitHub] drill issue #940: DRILL-5752 Speed Up Unit Tests add Test Categories

2017-09-30 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/940 Yeah this is ready for final review and commit. To do a quick build and smoke test you can do ``` mvn -T 1C clean install -DexcludedGroups="org.apache.drill.categories.Slo

[GitHub] drill pull request #957: DRILL-5809 Fixed Option Storage Backward Compatibil...

2017-09-25 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/957#discussion_r140946604 --- Diff: common/src/test/java/org/apache/drill/testutils/DirTestWatcher.java --- @@ -0,0 +1,61 @@ +/** + * Licensed to the Apache Software

[GitHub] drill issue #868: DRILL-5547:Linking config options with system option manag...

2017-08-25 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/868 @dvjyothsna @paul-rogers Tim here. When do you guys think this PR will go in? Seems like it didn't make it into this last batch of commits :(. I will be opening another PR soon that is dependent

[GitHub] drill pull request #923: Drill 5723

2017-08-25 Thread ilooner
GitHub user ilooner opened a pull request: https://github.com/apache/drill/pull/923 Drill 5723 You can merge this pull request into a Git repository by running: $ git pull https://github.com/ilooner/drill DRILL-5723 Alternatively you can review and apply these changes

[GitHub] drill issue #913: - DRILL-5729 Fix Travis Build

2017-08-28 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/913 @parthchandra I think the PR still needs a +1 from a committer. If Vlad's review is sufficient, could you give this a +1? Thanks, Tim --- If your project is set up for it, you can reply

[GitHub] drill issue #923: DRILL-5723: Added System Internal Options That can be Modi...

2017-08-28 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/923 @paul-rogers Applied your comments and cleaned up the PR, it should be ready for review now. If additional work needs to be done to make this easier to review please let me know. Thanks

[GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...

2017-09-01 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/923#discussion_r136672454 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/OperatorFixture.java --- @@ -90,13 +93,13 @@ public static class OperatorFixtureBuilder

[GitHub] drill issue #923: DRILL-5723: Added System Internal Options That can be Modi...

2017-09-01 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/923 Thanks @paul-rogers I'll work on addressing the comments and talk to you next week about some questions I have. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...

2017-09-01 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/923#discussion_r136669723 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java --- @@ -70,11 +69,13

[GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...

2017-09-01 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/923#discussion_r136671911 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/RestClientFixture.java --- @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software

[GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...

2017-09-01 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/923#discussion_r136669290 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java --- @@ -70,11 +69,13

[GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...

2017-09-01 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/923#discussion_r136669314 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java --- @@ -70,11 +69,13

[GitHub] drill pull request #923: DRILL-5723: Added System Internal Options That can ...

2017-09-01 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/923#discussion_r136670944 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/server/rest/StatusResourcesTest.java --- @@ -0,0 +1,80 @@ +/* + * Licensed

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

2017-10-11 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r144194241 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/CodeGenerator.java --- @@ -90,12 +89,11 @@ private String generatedCode

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

2017-10-11 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r144194940 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/CodeCompiler.java --- @@ -110,6 +109,11 @@ public CodeGenCompiler(final DrillConfig

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

2017-10-11 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r144193392 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/compile/CodeCompiler.java --- @@ -110,6 +109,11 @@ public CodeGenCompiler(final DrillConfig

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

2017-10-11 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r144194617 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/TopN/PriorityQueue.java --- @@ -20,22 +20,58 @@ import

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

2017-10-11 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r144195098 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/TopN/TopNBatch.java --- @@ -95,7 +91,9 @@ public TopNBatch(TopN popConfig

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

2017-10-12 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r144205146 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/TopN/TopNBatch.java --- @@ -335,20 +333,32 @@ private void purge() throws

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

2017-10-10 Thread ilooner
GitHub user ilooner opened a pull request: https://github.com/apache/drill/pull/984 DRILL-5783 Made a unit test for generated Priority Queue. DRILL-5841 Fix tmp folder errors. ## DRILL-5783 - A unit test is created for the priority queue in the TopN operator - The code

[GitHub] drill issue #984: DRILL-5783 Made a unit test for generated Priority Queue. ...

2017-10-10 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/984 @paul-rogers ---

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

2017-10-18 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145575588 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/selection/SelectionVector4.java --- @@ -116,6 +116,14 @@ public void clear

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

2017-10-18 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145575310 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/TopN/TopNBatch.java --- @@ -335,20 +336,42 @@ private void purge() throws

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

2017-10-18 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145574915 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/TopN/TopNBatch.java --- @@ -335,20 +336,42 @@ private void purge() throws

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

2017-10-18 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145574026 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/TopN/PriorityQueue.java --- @@ -20,22 +20,58 @@ import

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

2017-10-18 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145575781 --- Diff: exec/java-exec/src/main/resources/drill-module.conf --- @@ -247,7 +248,7 @@ drill.exec: { } }, sort

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

2017-10-18 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145575975 --- Diff: exec/java-exec/src/test/java/org/apache/drill/TestAggNullable.java --- @@ -21,29 +21,25 @@ import

[GitHub] drill issue #970: DRILL-5832: Migrate OperatorFixture to use SystemOptionMan...

2017-10-17 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/970 @paul-rogers Some of the changes I am making on top of https://github.com/apache/drill/pull/978/ as part of DRILL-5730 will likely conflict with this change. When do you think this could make

[GitHub] drill pull request #1003: DRILL-5893: Reverted the number of forked test pro...

2017-10-19 Thread ilooner
GitHub user ilooner opened a pull request: https://github.com/apache/drill/pull/1003 DRILL-5893: Reverted the number of forked test processes back to 2 You can merge this pull request into a Git repository by running: $ git pull https://github.com/ilooner/drill DRILL-5893

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

2017-10-19 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145790506 --- Diff: exec/vector/src/main/codegen/templates/FixedValueVectors.java --- @@ -908,6 +908,15 @@ public void generateTestData(int count

[GitHub] drill issue #1003: DRILL-5893: Reverted the number of forked test processes ...

2017-10-19 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1003 @arina-ielchiieva ---

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

2017-10-19 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145827440 --- Diff: exec/java-exec/src/test/java/org/apache/drill/TestAltSortQueries.java --- @@ -64,9 +73,9 @@ public void testJoinWithLimit() throws Exception

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

2017-10-19 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145815670 --- Diff: exec/java-exec/src/test/resources/topN/one_key_sort.json --- @@ -12,11 +12,11 @@ pop:"mock-scan",

[GitHub] drill issue #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 Stabali...

2017-11-15 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1023 @arina-ielchiieva Spoke with @paul-rogers . This will likely introduce some conflicts for https://github.com/apache/drill/pull/921 . In an effort to lighten the workload for that contributor we'll

[GitHub] drill issue #984: DRILL-5783 Made a unit test for generated Priority Queue. ...

2017-11-14 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/984 Resolved conflicts. ---

[GitHub] drill pull request #1048: DRILL-5987: Use one version of javassist

2017-11-22 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1048#discussion_r152703332 --- Diff: common/pom.xml --- @@ -63,12 +63,29 @@ org.msgpack msgpack 0.6.6 + --- End diff -- Removed

[GitHub] drill issue #1057: DRILL-5993 Append Row Method For VectorContainer (WIP)

2017-11-29 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1057 @paul-rogers since HashJoin does not need to support Selection Vectors maybe we can postpone adding the corresponding appendRow methods if and when they are needed. I suspect by the time anyone

[GitHub] drill issue #1057: DRILL-5993 Append Row Method For VectorContainer (WIP)

2017-11-29 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1057 Please let me know if I should make any more changes. ---

[GitHub] drill pull request #1048: DRILL-5987: Use one version of javassist

2017-11-22 Thread ilooner
GitHub user ilooner opened a pull request: https://github.com/apache/drill/pull/1048 DRILL-5987: Use one version of javassist There were two different versions of javassist being pulled in by **msgpack** and **reflections**. This makes sure only one version is included. You can

[GitHub] drill issue #1048: DRILL-5987: Use one version of javassist

2017-11-22 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1048 @arina-ielchiieva ---

[GitHub] drill pull request #1057: DRILL-5993 Append Row Method For VectorContainer (...

2017-11-29 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1057#discussion_r153958856 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/record/TestVectorContainer.java --- @@ -124,4 +132,52 @@ public void testContainerMerge

[GitHub] drill issue #1053: DRILL-5989 Travis Finally Runs Smoke Tests!!!

2017-11-28 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1053 @arina-ielchiieva ---

[GitHub] drill pull request #1053: DRILL-5989 Travis Finally Runs Smoke Tests!!!

2017-11-28 Thread ilooner
GitHub user ilooner opened a pull request: https://github.com/apache/drill/pull/1053 DRILL-5989 Travis Finally Runs Smoke Tests!!! ## DRILL-5989 Previously Travis would only do a build for each pull request. Now Travis will also run all the smoke tests every time a PR

[GitHub] drill pull request #1056: DRILL-6000: Categorized graceful shutdown unit tes...

2017-11-29 Thread ilooner
GitHub user ilooner opened a pull request: https://github.com/apache/drill/pull/1056 DRILL-6000: Categorized graceful shutdown unit tests as SlowTests Graceful shutdown unit tests were failing on Travis, and should not be run as part of the SmokeTests You can merge this pull

[GitHub] drill issue #1056: DRILL-6000: Categorized graceful shutdown unit tests as S...

2017-11-29 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1056 @arina-ielchiieva ---

[GitHub] drill issue #1057: DRILL-5993 Append Row Method For VectorContainer (WIP)

2017-11-29 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1057 @Ben-Zvi @paul-rogers ---

[GitHub] drill pull request #1057: DRILL-5993 Append Row Method For VectorContainer (...

2017-11-29 Thread ilooner
GitHub user ilooner opened a pull request: https://github.com/apache/drill/pull/1057 DRILL-5993 Append Row Method For VectorContainer (WIP) ## Motivation HashJoin requires a method that can take a row from a VectorContainer and append it to a destination VectorContainer

[GitHub] drill issue #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 Stabali...

2017-12-04 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/1023 @paul-rogers Can you take another pass at reviewing this? I have resolved conflicts with the graceful shutdown work. The graceful shutdown tests were also timing out on my laptop so I fixed them. ---

[GitHub] drill pull request #1045: DRILL-5730 Test Mocking Improvements

2017-12-12 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1045#discussion_r156490496 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java --- @@ -17,483 +17,216 @@ */ package

[GitHub] drill pull request #1045: DRILL-5730 Test Mocking Improvements

2017-12-12 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1045#discussion_r156494301 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java --- @@ -17,483 +17,216 @@ */ package

[GitHub] drill pull request #1045: DRILL-5730 Test Mocking Improvements

2017-12-12 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1045#discussion_r156494989 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java --- @@ -17,483 +17,216 @@ */ package

[GitHub] drill pull request #1045: DRILL-5730 Test Mocking Improvements

2017-12-12 Thread ilooner
Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/1045#discussion_r156534237 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java --- @@ -17,483 +17,216 @@ */ package

  1   2   3   4   5   >