Re: Dynamic UDFs support

2016-06-21 Thread Paul Rogers
have a common path that is independent of the fact >>> that it is Drill on YARN or not, as maintaining two separate ways of >>> dealing with loading/unloading UDFs will be painful and error prone. >>> One more note (I left a comment in the doc) - not sure about >>> authori

Question re "obscure" Drill scripts

2016-06-21 Thread Paul Rogers
Hi All, The Drill-on-YARN (DoY) stuff will include some much-needed clean-up of the Drill scripts in $DRILL_HOME/bin, so I need to retest all the scripts. Three scripts seem pretty obscure. But, let’s start with the known ones. The “primary” scripts seem to be: drillbit.sh — User command to

Re: Question re "obscure" Drill scripts

2016-06-21 Thread Paul Rogers
need the heavy heap & direct memory when the Drill code acts only as a client? Thanks, - Paul > On Jun 21, 2016, at 11:48 AM, Paul Rogers <prog...@maprtech.com> wrote: > > Hi All, > > The Drill-on-YARN (DoY) stuff will include some much-needed clean-up of the > Dril

Re: Dynamic UDFs support

2016-06-20 Thread Paul Rogers
ch.com> wrote: > > This will need to work with YARN (Once Drill is YARN enabled, I would > expect a lot of users using it in conjunction with YARN). > Paul, I am not clear why this wouldn't work with YARN. Can you elaborate. > > -Neeraja > > On Mon, Jun 20, 2016 at 7:01 PM,

Re: Dynamic UDFs support

2016-06-20 Thread Paul Rogers
t; I think Jacques' point about ownership conflicts is not addressed clearly. > Also, the unloading is not clear. The delete command should probably remove > the UDF and unload it. > > > On Fri, Jun 17, 2016 at 11:19 AM, Paul Rogers <prog...@maprtech.com> wrot

Re: Dynamic UDFs support

2016-06-27 Thread Paul Rogers
ey will be added later as enhancement. >> >> More detains in the document: >> >> https://docs.google.com/document/d/1MluM17EKajvNP_x8U4aymcOihhUm8BMm8t_hM0jEFWk/edit >> >> Kind regards >> Arina >> >> On Fri, Jun 17, 2016 at 1:25 AM Paul Rogers <prog...@maprtech.com&

Proposal to add site & node config

2016-04-12 Thread Paul Rogers
Hi All, As part of the Drill-on-YARN project we would like to split out user (“site”) configuration from that for Drill itself. We also want to split distribution-provided settings (such as those set by MapR) from user configuration. Finally, we want to separate per-node configuration from

Re: Proposal: Create v2 branch to work on breaking changes

2016-04-12 Thread Paul Rogers
;>>>> >>>>>> Thoughts? >>>>>> >>>>>> Re: Branches/Dangers >>>>>> >>>>>> Good points on this Julian. >>>>>> >>>>>> How about this: >>>>>> >

[GitHub] drill pull request: DRILL-4596: Drill should do version check amon...

2016-04-12 Thread paul-rogers
Github user paul-rogers commented on the pull request: https://github.com/apache/drill/pull/474#issuecomment-208943460 Hi All. Version compatibility is a complex issue. Do we have a design document that explains our goals and policy? Is the goal to allow rolling updates of clients

[GitHub] drill pull request: DRILL-4596: Drill should do version check amon...

2016-04-12 Thread paul-rogers
Github user paul-rogers commented on the pull request: https://github.com/apache/drill/pull/474#issuecomment-208959253 Some other design issues. The idea of a rollling upgrade presupposes that we can shut down a Drillbit, bring up a new one, and the cluster keeps running. But, today

Drill on YARN

2016-03-22 Thread Paul Rogers
Hi All, I’m a new member of the Drill Team here at MapR. We’d like to take a look at running Drill on YARN for production customers. JIRA suggests some early work may have been done (DRILL-142 , DRILL-1170

Re: Proposal: Create v2 branch to work on breaking changes

2016-03-26 Thread Paul Rogers
Hi All, 2.0 is a good opportunity to enhance our ZK information. See DRILL-4543: Advertise Drill-bit ports, status, capabilities in ZooKeeper. This change will simplify YARN integration. This enhancement will change the “public API” in ZK. To Parth’s point, we can do so in a way that old

Re: Drill on YARN

2016-03-27 Thread Paul Rogers
derstanding of the memory allocation > mechanisms within Drill. (High level, neophyte here). I do feel as a > cluster admin, as I have said, that the Llama approach (now that I > understand it better) would worry me, especially in a multi-tenant > cluster. And as you said Paul, it &qu

Re: Drill on YARN

2016-03-26 Thread Paul Rogers
your > discussion on resizing Yarn containers more than anything. > > So i just tossed out a bunch of ideas here to keep discussion running. > Drill Devs, I would love a better understanding of the memory allocation > mechanisms within Drill. (High level, neophyte here). I do feel as a &

[GitHub] drill pull request: DRILL-4313: Improve method of picking a random...

2016-03-07 Thread paul-rogers
Github user paul-rogers commented on the pull request: https://github.com/apache/drill/pull/396#issuecomment-193489132 Thanks for addressing the review comments! +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] drill pull request: Drill 4581

2016-04-13 Thread paul-rogers
Github user paul-rogers commented on the pull request: https://github.com/apache/drill/pull/477#issuecomment-209731896 Thanks; I'll do that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

Re: Drill on YARN

2016-04-13 Thread Paul Rogers
ntegration, and that is >> the feeling I got in talking to folks on and off list about memory >> management. >> >> This is a hard topic, but one that I am glad you are spearheading Paul, >> because as we see more and more clusters get folded together, having a >> citizen t

[GitHub] drill pull request: Drill 4581

2016-04-13 Thread paul-rogers
Github user paul-rogers commented on the pull request: https://github.com/apache/drill/pull/477#issuecomment-209728811 This fix leaves the external interface unchanged. This is a preparation for the work to add a site configuration level; but none of that work is in this fix. Instead

[GitHub] drill pull request: Drill 4581

2016-04-13 Thread paul-rogers
GitHub user paul-rogers opened a pull request: https://github.com/apache/drill/pull/477 Drill 4581 Provides fixes to the Drill launch scripts for multiple issues in DRILL-4581. You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] drill pull request: Drill 4581

2016-04-14 Thread paul-rogers
Github user paul-rogers closed the pull request at: https://github.com/apache/drill/pull/477 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] drill pull request: Drill 4581

2016-04-14 Thread paul-rogers
Github user paul-rogers commented on the pull request: https://github.com/apache/drill/pull/477#issuecomment-210070503 Closing this request due to some newbie Git errors. Will open a new one in proper format. --- If your project is set up for it, you can reply to this email and have

[GitHub] drill pull request: DRILL-4581: Minor fixes to drill startup scrip...

2016-04-14 Thread paul-rogers
GitHub user paul-rogers opened a pull request: https://github.com/apache/drill/pull/478 DRILL-4581: Minor fixes to drill startup scripts for linux This pull request replaces a previous one. No code differences; this one resolves some git issues. Provides fixes to a number

[GitHub] drill pull request #544: DRILL 4581 Revised

2016-07-12 Thread paul-rogers
GitHub user paul-rogers opened a pull request: https://github.com/apache/drill/pull/544 DRILL 4581 Revised Extensive revisions to the Drill scripts to prepare them for Drill-on-YARN, to provide a full site directory, to move distribution-specific settings out of the user’s

Re: Dynamic UDFs support

2016-07-14 Thread Paul Rogers
. I have re-worked dynamic UDF support > document taking into account Zookeeper usage. > > Link to the document - > https://docs.google.com/document/d/1MluM17EKajvNP_x8U4aymcOihhUm8BMm8t_hM0jEFWk/edit > > Kind regards > Arina > > On Tue, Jun 28, 2016 at 12:55 AM Paul Rog

Re: Dynamic UDFs support

2016-07-21 Thread Paul Rogers
want my query to run on those bits and a >>> not too disruptive way to restart just those bits >>> >>> The above may be obvious to Drill experts. If it is then perhaps the UDF >>> docs could just point out how to easily develop UDFs in an iterative >>>

Re: Dynamic UDFs support

2016-07-21 Thread Paul Rogers
larary is I'd want my query to run on those bits and a >> not too disruptive way to restart just those bits >> >> The above may be obvious to Drill experts. If it is then perhaps the UDF >> docs could just point out how to easily develop UDFs in an iterative >> fashion. >

[GitHub] drill issue #558: DRILL-4822: Add $DRILL_SITE to distrib-env.sh search path

2016-08-02 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/558 $DRILL_SITE means the site directory. At present, I don't believe we have a $DRILL_ENV/env directory. The site directory is meant to be a location, outside of $DRILL_HOME, that contains site

[GitHub] drill pull request #558: DRILL-4822: Add $DRILL_SITE to distrib-env.sh searc...

2016-08-02 Thread paul-rogers
GitHub user paul-rogers opened a pull request: https://github.com/apache/drill/pull/558 DRILL-4822: Add $DRILL_SITE to distrib-env.sh search path DRILL-4581 provided revisions to the Drill launch scripts. As part of that fix, we introduced a new distrib-env.sh file to hold settings

[GitHub] drill pull request #564: DRILL-4836: ZK Issue during Drillbit startup, possi...

2016-08-09 Thread paul-rogers
GitHub user paul-rogers opened a pull request: https://github.com/apache/drill/pull/564 DRILL-4836: ZK Issue during Drillbit startup, possibly due to race condition ZK Issue during Drillbit startup, possibly due to race condition. A change made in February created a race

Re: A light-weight, versioned client API for Drill

2016-07-20 Thread Paul Rogers
uages. > > Julian > > > On Wed, Jul 20, 2016 at 10:35 AM, Chunhui Shi <c...@maprtech.com> wrote: >> Cool. And we know that there are already many 'light weight' APIs soon >> become the main stream APIs. >> >> On Tue, Jul 19, 2016 at 10:

[GitHub] drill pull request #547: Drill-4581: Extensive revisions to the Drill launch...

2016-07-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/547#discussion_r71647434 --- Diff: distribution/src/resources/drill-config.sh --- @@ -50,94 +70,252 @@ home=`cd "$bin/..">/dev/null; pwd` this="

[GitHub] drill pull request #547: Drill-4581: Extensive revisions to the Drill launch...

2016-07-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/547#discussion_r71647038 --- Diff: distribution/src/resources/drill-config.sh --- @@ -50,94 +70,252 @@ home=`cd "$bin/..">/dev/null; pwd` this="

[GitHub] drill pull request #547: Drill-4581: Extensive revisions to the Drill launch...

2016-07-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/547#discussion_r71646935 --- Diff: distribution/src/resources/drill-config.sh --- @@ -193,21 +366,24 @@ if $is_cygwin; then DRILL_LOG_DIR=`cygpath -w "$DRILL_LO

[GitHub] drill pull request #547: Drill-4581: Extensive revisions to the Drill launch...

2016-07-20 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/547#discussion_r71646967 --- Diff: distribution/src/resources/drill-config.sh --- @@ -50,94 +70,252 @@ home=`cd "$bin/..">/dev/null; pwd` this="

Re: Dynamic UDFs support

2016-07-21 Thread Paul Rogers
cution code. > > > On Mon, Jul 18, 2016 at 3:36 PM, Parth Chandra <pchan...@maprtech.com> > wrote: > >> +1 on simplifying the design and postpone the items Paul has suggested. >> >> Arina, Paul, I think we need to work out some of the design related to >

[GitHub] drill issue #547: Drill-4581: Extensive revisions to the Drill launch script...

2016-07-20 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/547 Thanks for the review. Glad the comments were helpful. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] drill issue #547: Drill-4581: Extensive revisions to the Drill launch script...

2016-07-20 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/547 On the backward compabitility question... This is an important point. I checked with our Support folks about this topic. FWIW, they said that they don't know of anyone who has done more than

[GitHub] drill pull request #544: DRILL 4581 Revised

2016-07-18 Thread paul-rogers
Github user paul-rogers closed the pull request at: https://github.com/apache/drill/pull/544 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] drill issue #544: DRILL 4581 Revised

2016-07-18 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/544 Created new version, closing this one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] drill pull request #547: Drill-4581: Extensive revisions to the Drill launch...

2016-07-18 Thread paul-rogers
GitHub user paul-rogers opened a pull request: https://github.com/apache/drill/pull/547 Drill-4581: Extensive revisions to the Drill launch scripts. See DRILL-4581 and DRILL-4591 for an overview. See DRILL-4581 for a detailed list of bugs fixed. See DRILL-4591

A light-weight, versioned client API for Drill

2016-07-19 Thread Paul Rogers
ent/d/1TpJOEUO-DBDGIidOML2_InpJ-fK4yHmsbV5ncqXT6pM The code is in a GitHub repo: https://github.com/paul-rogers/drill-jig The JIRA for this enhancement: DRILL-4791: https://issues.apache.org/jira/browse/DRILL-4791 This has been a great little learning exercise. Is this something that might we might

[GitHub] drill issue #542: DRILL 4581 Final

2016-07-11 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/542 Commiters asked that DoY not be pushed at this time. Closing this request; will open a new one with only the Drill changes, but no DoY scripts. --- If your project is set up for it, you can

[GitHub] drill pull request #542: DRILL 4581 Final

2016-07-11 Thread paul-rogers
Github user paul-rogers closed the pull request at: https://github.com/apache/drill/pull/542 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] drill pull request #542: DRILL 4581 Final

2016-07-10 Thread paul-rogers
GitHub user paul-rogers opened a pull request: https://github.com/apache/drill/pull/542 DRILL 4581 Final Extensive revisions to the Drill launch scripts to fix a number of bugs, and to prepare the scripts for use in Drill-on-YARN. Unit tests will be merged as part

Drill-on-YARN pull requests

2016-07-10 Thread Paul Rogers
Hi All, The Drill-on-YARN work (DRILL-1170) is drawing to a close and is ready to be merged into master. The project resulted in about 80+ new files, 10K+ lines of code, so this will be a bit of an effort to merge. Drill-on-YARN is actually independent of the rest of Drill. Except for changes

[GitHub] drill issue #517: DRILL-4704 fix

2016-08-04 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/517 The proximate cause of this particular issue is the mechanism by which the cast function is being generated. As others have noted, the code is passing through lines 316-316. My guess

[GitHub] drill issue #517: DRILL-4704 fix

2016-08-04 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/517 The plot thickens. I tried the fix of setting the precision to a constant of 10. This uncovered a larger issue. The template in question generates cast functions for (INTEGER, BIGINT) x (DECIMAL9

[GitHub] drill issue #517: DRILL-4704 fix

2016-08-05 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/517 Based on above discussion, I played around with the proposed solution. The following takes into consideration the max precision of both the input and output types. It DOES NOT handle truncation

[GitHub] drill issue #517: DRILL-4704 fix

2016-08-05 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/517 Hi Dave, I agree that Drill Decimal support clearly needs attention. I'm expermenting with adjusting the template code to at least generate a meaningful conversion for all int x decimal

[GitHub] drill issue #517: DRILL-4704 fix

2016-08-05 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/517 As a next step, using Dave's solution would better handle truncation: based on the precision of the input value, adjust the scale to truncate low-order digits. --- If your project is set up

[GitHub] drill issue #517: DRILL-4704 fix

2016-08-08 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/517 "Dynamic" meant "for each data value." "Static" meant "at compile time." We make our type decisions at compile time. That is too early to adjust scale ba

[GitHub] drill issue #517: DRILL-4704 fix

2016-08-08 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/517 What is the resolution here? Dave, do you want to review & adopt the suggested code several posts back? That code passed the unit tests that you provided, plus those aready in Drill (u

[GitHub] drill issue #517: DRILL-4704 fix

2016-08-06 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/517 Good point. So, we'd want to issue an overflow error in the cast method, but it seems Drill has no way to do that. So, for now, maybe just leave it at the version that works when numbers

[GitHub] drill issue #517: DRILL-4704 fix

2016-08-06 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/517 To clarify the previous comment... In the case where the maximum required precision for the int type is greater than the maximum precision of the target decimal type, we use Dave's code to figure

[GitHub] drill issue #517: DRILL-4704 fix

2016-08-07 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/517 As a follow-up, the case we're focusing on is an implicit cast: one created by the system to convert an integer to a decimal type in order to do an equality check. To avoid the scale issue

[GitHub] drill issue #558: DRILL-4822: Add $DRILL_SITE to distrib-env.sh search path

2016-08-03 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/558 Turns out the question was about: what does $DRILL_SITE mean. This is the name I use in documentation to refer to the new "site directory." For purposes of this fix, just replace &q

[GitHub] drill issue #557: DRILL-4816: Fix sqlline command line parsing (sqlline -f f...

2016-08-02 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/557 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] drill issue #557: DRILL-4816: Fix sqlline command line parsing (sqlline -f f...

2016-08-02 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/557 Because you are fixing an issue with the scripts changes, please add the following as well to drill-config.sh: # Source distrib-env.sh for any distribution-specific settings

[GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort

2017-02-02 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/717#discussion_r99065293 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/CopierHolder.java --- @@ -0,0 +1,294 @@ +/* + * Licensed

[GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort

2017-02-02 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/717#discussion_r99235897 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java --- @@ -0,0 +1,1321

[GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort

2017-02-02 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/717#discussion_r99065219 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/CopierHolder.java --- @@ -0,0 +1,294 @@ +/* + * Licensed

[GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort

2017-02-02 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/717#discussion_r99066331 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/CopierHolder.java --- @@ -0,0 +1,294 @@ +/* + * Licensed

[GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort

2017-02-02 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/717#discussion_r99193890 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java --- @@ -0,0 +1,1321

[GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort

2017-02-02 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/717#discussion_r99181890 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java --- @@ -0,0 +1,1321

[GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort

2017-02-02 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/717#discussion_r99037775 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/BatchGroup.java --- @@ -0,0 +1,334 @@ +/* + * Licensed

[GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort

2017-02-02 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/717#discussion_r99040069 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/BatchGroup.java --- @@ -0,0 +1,334 @@ +/* + * Licensed

[GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort

2017-02-02 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/717#discussion_r99037413 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -63,13 +63,29 @@ String SPOOLING_BUFFER_DELETE

[GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort

2017-02-02 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/717#discussion_r99189185 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java --- @@ -0,0 +1,1321

[GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort

2017-02-02 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/717#discussion_r99065195 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/CopierHolder.java --- @@ -0,0 +1,294 @@ +/* + * Licensed

[GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort

2017-02-02 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/717#discussion_r99236749 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java --- @@ -0,0 +1,1321

[GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort

2017-02-02 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/717#discussion_r99184602 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java --- @@ -0,0 +1,1321

[GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort

2017-02-02 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/717#discussion_r99195103 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java --- @@ -0,0 +1,1321

[GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort

2017-02-02 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/717#discussion_r99194009 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java --- @@ -0,0 +1,1321

[GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort

2017-02-02 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/717#discussion_r99194543 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java --- @@ -0,0 +1,1321

[GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort

2017-02-02 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/717#discussion_r99234976 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java --- @@ -0,0 +1,1321

[GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort

2017-02-02 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/717#discussion_r99182115 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java --- @@ -0,0 +1,1321

[GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort

2017-02-02 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/717#discussion_r99194920 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java --- @@ -0,0 +1,1321

[GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort

2017-02-02 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/717#discussion_r99067830 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java --- @@ -0,0 +1,1321

[GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort

2017-02-02 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/717#discussion_r99067231 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java --- @@ -0,0 +1,1321

[GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort

2017-02-02 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/717#discussion_r99197052 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java --- @@ -0,0 +1,1321

[GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort

2017-02-02 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/717#discussion_r99067046 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java --- @@ -0,0 +1,1321

[GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort

2017-02-02 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/717#discussion_r99066052 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/CopierHolder.java --- @@ -0,0 +1,294 @@ +/* + * Licensed

[GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort

2017-02-02 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/717#discussion_r99236335 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java --- @@ -0,0 +1,1321

[GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort

2017-02-02 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/717#discussion_r99065931 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/CopierHolder.java --- @@ -0,0 +1,294 @@ +/* + * Licensed

[GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort

2017-02-02 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/717#discussion_r99193167 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java --- @@ -0,0 +1,1321

[GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort

2017-02-02 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/717#discussion_r99239035 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java --- @@ -0,0 +1,1321

[GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort

2017-02-02 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/717#discussion_r99066218 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/CopierHolder.java --- @@ -0,0 +1,294 @@ +/* + * Licensed

[GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort

2017-02-02 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/717#discussion_r99039840 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/BatchGroup.java --- @@ -0,0 +1,334 @@ +/* + * Licensed

[GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort

2017-02-02 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/717#discussion_r99238315 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java --- @@ -0,0 +1,1321

[GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort

2017-02-02 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/717#discussion_r99065262 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/CopierHolder.java --- @@ -0,0 +1,294 @@ +/* + * Licensed

[GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort

2017-02-02 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/717#discussion_r99237065 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java --- @@ -0,0 +1,1321

[GitHub] drill issue #724: JDBC proxy driver: Do not put null value in map

2017-02-03 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/724 Hi David, Thanks much for the fix! Is there a JIRA entry for this fix? If not, please go ahead and create one. Then, rename the PR to: ``` DRILL-: DBC proxy driver: Do not put

[GitHub] drill issue #729: Drill 1328 r4

2017-02-03 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/729 Please rename PR to standard format: ``` DRILL-1328: Some textual description ``` For us novices, "r4" is a bit of a terse description of the purpose of this PR... -

[GitHub] drill pull request #729: Drill 1328 r4

2017-02-03 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/729#discussion_r99391697 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/ContextInformation.java --- @@ -28,12 +28,14 @@ private final String

[GitHub] drill pull request #729: Drill 1328 r4

2017-02-03 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/729#discussion_r99390401 --- Diff: exec/java-exec/src/main/codegen/data/Parser.tdd --- @@ -39,7 +39,13 @@ "METADATA", "DATABASE",

[GitHub] drill pull request #729: Drill 1328 r4

2017-02-03 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/729#discussion_r99391822 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/ContextInformation.java --- @@ -63,4 +65,11 @@ public long getQueryStartTime

[GitHub] drill pull request #729: Drill 1328 r4

2017-02-03 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/729#discussion_r99392948 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/dotdrill/DotDrillUtil.java --- @@ -30,6 +32,9 @@ static final org.slf4j.Logger logger

[GitHub] drill pull request #729: Drill 1328 r4

2017-02-03 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/729#discussion_r99392086 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java --- @@ -245,6 +245,16 @@ public SchemaPlus getRootSchema

[GitHub] drill pull request #729: Drill 1328 r4

2017-02-03 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/729#discussion_r99390012 --- Diff: exec/java-exec/pom.xml --- @@ -410,6 +410,11 @@ joda-time 2.9 + + com.clearspring.analytics

[GitHub] drill pull request #729: Drill 1328 r4

2017-02-03 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/729#discussion_r99392582 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java --- @@ -392,6 +402,11 @@ public String getQueryUserName

  1   2   3   4   5   6   7   8   9   10   >