Github user paul-rogers commented on the pull request:
https://github.com/apache/drill/pull/396#issuecomment-193489132
Thanks for addressing the review comments!
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/660#discussion_r93133935
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/ClassBuilder.java ---
@@ -0,0 +1,189 @@
+/**
+ * Licensed to the Apache
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/660#discussion_r93134098
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/DrillJavaFileObject.java
---
@@ -67,6 +72,22 @@ public boolean isCompiled
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/660#discussion_r93134050
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/ClassBuilder.java ---
@@ -0,0 +1,189 @@
+/**
+ * Licensed to the Apache
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/660#discussion_r93133574
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/AbstractClassCompiler.java
---
@@ -74,9 +76,10 @@ protected String prefixLineNumbers
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/660#discussion_r93134337
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/JaninoClassCompiler.java
---
@@ -58,5 +56,27 @@ public JaninoClassCompiler
GitHub user paul-rogers opened a pull request:
https://github.com/apache/drill/pull/703
DRILL-5104: Foreman should not set sort memory for a physical plan
Physical plans include a plan for memory allocations. However, the code
path in Foreman replans external sort memory, even
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/703#discussion_r93558749
--- Diff:
logical/src/main/java/org/apache/drill/common/logical/PlanProperties.java ---
@@ -112,8 +121,13 @@ public PlanPropertiesBuilder generator
GitHub user paul-rogers opened a pull request:
https://github.com/apache/drill/pull/704
DRILL-5125: Provide option to use generic code for sv remover
Performance tests showed that, for queries with a large number of
columns, it is faster to use a âgenericâ implementation of
GitHub user paul-rogers opened a pull request:
https://github.com/apache/drill/pull/707
DRILL-5157: Multiple Snappy versions on class path
Multiple Snappy versions on class path; causes unit test failures.
Drill's pom.xml files bring in multiple Snappy versions.
GitHub user paul-rogers opened a pull request:
https://github.com/apache/drill/pull/708
DRILL-5152: Enhance the mock data source: better data, SQL access
Provides an enhanced version of the mock data source. See the JIRA entry
for motivation, package-info.java for details of
GitHub user paul-rogers opened a pull request:
https://github.com/apache/drill/pull/709
DRILL-5156: BootStrapContext should close threads
The Bit-Client thread (that's the thread name) finds a closed allocator in
TestDrillbitResilience unit test. This fix (along with DRILL
GitHub user paul-rogers opened a pull request:
https://github.com/apache/drill/pull/710
DRILL-5126: Provide simplified, unified "cluster fixture" for test
Drill provides a robust selection of test frameworks that have evolved to
satisfy the needs of a variety of test case
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/708
There is a older version, usable only via a physical plan. This PR is for a
new version accessible from SQL. With luck, the new version will be available
in 1.10 (and in 1.9 developer builds
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/715#discussion_r94288743
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/vector/complex/MapVector.java
---
@@ -134,10 +134,6 @@ public int getBufferSizeFor(final int
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/715#discussion_r94288748
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/vector/complex/RepeatedMapVector.java
---
@@ -413,14 +413,9 @@ public RepeatedMapAccessor
GitHub user paul-rogers opened a pull request:
https://github.com/apache/drill/pull/716
DRILL-5116: Enable generated code debugging in each Drill operator
DRILL-5052 added the ability to debug generated code. The reviewer
suggested permitting the technique to be used for all Drill
ensive inner loops in
generated code.
- Paul
[1]
https://github.com/paul-rogers/drill/wiki/Optimization-of-External-Sort-Performance
GitHub user paul-rogers opened a pull request:
https://github.com/apache/drill/pull/717
DRILL-5080: Memory-managed version of external sort
Please see the DRILL-5080 JIRA, and subtasks, for reasons for revision,
design spec and list of changes. Basically the idea is to beef up the
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r94704385
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java
---
@@ -49,6 +50,24 @@ public ViewHandler
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r94705117
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java
---
@@ -74,36 +93,49 @@ public PhysicalPlan getPlan
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r94691616
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DropTableHandler.java
---
@@ -55,35 +58,79 @@ public DropTableHandler
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r94703966
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DropTableHandler.java
---
@@ -55,35 +58,79 @@ public DropTableHandler
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r94690087
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/CreateTableHandler.java
---
@@ -242,4 +267,53 @@ private RexNode
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r94643331
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlConverter.java
---
@@ -447,4 +458,50 @@ public RexNode ensureType
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r94642429
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlConverter.java
---
@@ -447,4 +458,50 @@ public RexNode ensureType
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r94704176
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java
---
@@ -49,6 +50,24 @@ public ViewHandler
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r94705285
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/CompoundIdentifierConverter.java
---
@@ -161,7 +161,7 @@ public SqlNode
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r94638152
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/WriterRecordBatch.java
---
@@ -174,13 +174,23 @@ protected void setupNewSchema
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r94643225
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/CreateTableHandler.java
---
@@ -67,43 +71,64 @@ public
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r94691573
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DropTableHandler.java
---
@@ -55,35 +58,79 @@ public DropTableHandler
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r94701739
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DropTableHandler.java
---
@@ -55,35 +58,79 @@ public DropTableHandler
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r94641063
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlConverter.java
---
@@ -447,4 +458,50 @@ public RexNode ensureType
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r94639378
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/FileSystemCreateTableEntry.java
---
@@ -89,11 +94,16 @@ public Writer
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r94704095
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DropTableHandler.java
---
@@ -55,35 +58,79 @@ public DropTableHandler
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r94692337
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DropTableHandler.java
---
@@ -55,35 +58,79 @@ public DropTableHandler
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r94704798
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java
---
@@ -74,36 +74,51 @@ public PhysicalPlan getPlan
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r94689164
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/CreateTableHandler.java
---
@@ -67,43 +71,64 @@ public
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r94638547
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/WriterRecordBatch.java
---
@@ -174,13 +174,23 @@ protected void setupNewSchema
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/713#discussion_r94814315
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java
---
@@ -305,12 +306,23 @@ protected boolean
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r94857201
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java ---
@@ -207,18 +245,85 @@ public SchemaPlus getDefaultSchema
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r94858477
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JsonRecordWriter.java
---
@@ -82,6 +84,9 @@ public void init(Map
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r94856856
--- Diff: distribution/src/resources/drill-override-example.conf ---
@@ -184,7 +184,12 @@ drill.exec: {
# Set this property if custom absolute
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r94858741
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetRecordWriter.java
---
@@ -382,4 +391,20 @@ public void cleanup() throws
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r94858983
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/rpc/user/TemporaryTablesAutomaticDropTest.java
---
@@ -0,0 +1,99 @@
+/**
--- End
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r94859288
--- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/RpcBus.java ---
@@ -164,6 +164,8 @@ public void operationComplete(ChannelFuture future)
throws
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r94826816
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java ---
@@ -54,18 +66,41 @@
private Map properties
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r94857634
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java ---
@@ -207,18 +245,85 @@ public SchemaPlus getDefaultSchema
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/719#discussion_r94860865
--- Diff: exec/java-exec/src/main/resources/rest/profile/profile.ftl ---
@@ -106,7 +106,13 @@
STATE: ${model.getProfile().getState().name
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/719#discussion_r94860581
--- Diff: exec/java-exec/src/main/resources/rest/profile/list.ftl ---
@@ -64,6 +65,8 @@
${query.getState
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/719#discussion_r94860776
--- Diff: exec/java-exec/src/main/resources/rest/profile/profile.ftl ---
@@ -106,7 +106,13 @@
STATE: ${model.getProfile().getState().name
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/701
General comment. Wasn't the design supposed to be that the lazy lookup
would check for the function both in planning ("Calcite") and execution times?
The whole point of the lazy in
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/716#discussion_r94874974
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/ClassBuilder.java ---
@@ -64,14 +67,12 @@
* local variables. Have fun
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/716#discussion_r94875162
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/ClassBuilder.java ---
@@ -82,18 +83,18 @@
private final DrillConfig
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/716#discussion_r94875353
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/CodeCompiler.java ---
@@ -117,18 +200,24 @@ public CodeCompiler(final DrillConfig
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/716#discussion_r94876735
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/CodeCompiler.java ---
@@ -153,4 +242,17 @@ public GeneratedClassEntry(final Class
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/716#discussion_r94877069
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/QueryClassLoader.java
---
@@ -58,6 +58,19 @@ public void injectByteCode(String
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/716#discussion_r94877010
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/ClassCompilerSelector.java
---
@@ -119,13 +119,18 @@ public ClassCompilerSelector
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/716#discussion_r94879149
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/ClassGenerator.java ---
@@ -374,6 +388,124 @@ public HoldingContainer declare(MajorType
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/716#discussion_r94879598
--- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
@@ -167,24 +167,61 @@ drill.exec: {
debug: true,
janino_maxsize: 262144
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/710#discussion_r95052737
--- Diff: exec/java-exec/pom.xml ---
@@ -458,6 +458,12 @@
httpdlog-parser
2.4
+
--- End diff --
Fixed
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/710#discussion_r95052757
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/xsort/TestSimpleExternalSort.java
---
@@ -22,220 +22,167 @@
import
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/710#discussion_r95053180
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/FixtureBuilder.java ---
@@ -0,0 +1,251 @@
+/*
+ * Licensed to the Apache Software
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/710#discussion_r95052810
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java ---
@@ -0,0 +1,405 @@
+/*
+ * Licensed to the Apache Software
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/710#discussion_r95053287
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ProfileParser.java ---
@@ -0,0 +1,217 @@
+/*
+ * Licensed to the Apache Software
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/710#discussion_r95052905
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java ---
@@ -0,0 +1,405 @@
+/*
+ * Licensed to the Apache Software
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/710#discussion_r95053137
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/FixtureBuilder.java ---
@@ -0,0 +1,251 @@
+/*
+ * Licensed to the Apache Software
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/710#discussion_r95053125
--- Diff: exec/java-exec/src/test/java/org/apache/drill/test/FieldDef.java
---
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/710#discussion_r95053415
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/QueryBuilder.java ---
@@ -0,0 +1,314 @@
+/*
+ * Licensed to the Apache Software
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/710#discussion_r95052969
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java ---
@@ -0,0 +1,405 @@
+/*
+ * Licensed to the Apache Software
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/710#discussion_r95053052
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java ---
@@ -0,0 +1,405 @@
+/*
+ * Licensed to the Apache Software
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/716#discussion_r95053577
--- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
@@ -167,10 +167,12 @@ drill.exec: {
debug: true,
janino_maxsize: 262144
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/716#discussion_r95053621
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/ClassBuilder.java ---
@@ -64,36 +67,33 @@
* local variables. Have fun
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/716#discussion_r95053626
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/ClassBuilder.java ---
@@ -64,36 +67,33 @@
* local variables. Have fun
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/716#discussion_r95053687
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/ClassBuilder.java ---
@@ -64,36 +67,33 @@
* local variables. Have fun
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/716#discussion_r95053721
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/ClassBuilder.java ---
@@ -141,7 +142,9 @@ public ClassBuilder(DrillConfig config
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/708#discussion_r95064163
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/MockSubScanPOP.java
---
@@ -40,12 +39,12 @@
private final String url
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/708#discussion_r95064584
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/MockGroupScanPOP.java
---
@@ -104,44 +102,46 @@ public String toString
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/708#discussion_r95064123
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/IntGen.java ---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/708#discussion_r95063860
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/ExtendedMockRecordReader.java
---
@@ -0,0 +1,149 @@
+/*
+ * Licensed to
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/708#discussion_r95063773
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/ColumnDef.java ---
@@ -0,0 +1,178 @@
+/*
+ * Licensed to the Apache
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/708#discussion_r95063923
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/ExtendedMockRecordReader.java
---
@@ -0,0 +1,149 @@
+/*
+ * Licensed to
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/708#discussion_r95064583
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/MockSubScanPOP.java
---
@@ -40,12 +39,12 @@
private final String url
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/719#discussion_r95411447
--- Diff:
protocol/src/main/java/org/apache/drill/exec/proto/UserBitShared.java ---
@@ -13595,6 +13597,17 @@ public long getEnd() {
return end_
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/716#discussion_r95469122
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/ClassBuilder.java ---
@@ -141,7 +142,9 @@ public ClassBuilder(DrillConfig config
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/716#discussion_r95479214
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/ClassBuilder.java ---
@@ -64,14 +67,12 @@
* local variables. Have fun
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/716#discussion_r95472493
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/compile/TestClassTransformation.java
---
@@ -44,6 +44,9 @@
@BeforeClass
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/716#discussion_r95471607
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/CodeCompiler.java ---
@@ -41,12 +39,87 @@
*/
public class
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/716#discussion_r95468443
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/compile/ClassBuilder.java ---
@@ -64,36 +67,33 @@
* local variables. Have fun
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/716#discussion_r95472935
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestConvertFunctions.java
---
@@ -76,6 +75,22 @@
String
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/581#discussion_r95887636
--- Diff:
logical/src/main/java/org/apache/drill/common/expression/fn/JodaDateValidator.java
---
@@ -0,0 +1,216 @@
+/*
+* Licensed to the Apache
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/581#discussion_r95865424
--- Diff:
exec/java-exec/src/main/codegen/templates/DateIntervalFunctionTemplates/SqlToDateTypeFunctions.java
---
@@ -0,0 +1,77
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/581#discussion_r95871016
--- Diff:
exec/java-exec/src/main/codegen/templates/DateIntervalFunctionTemplates/SqlToDateTypeFunctions.java
---
@@ -0,0 +1,77
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/581#discussion_r95883122
--- Diff:
logical/src/main/java/org/apache/drill/common/expression/fn/JodaDateValidator.java
---
@@ -0,0 +1,216 @@
+/*
+* Licensed to the Apache
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/581#discussion_r95887588
--- Diff:
logical/src/main/java/org/apache/drill/common/expression/fn/JodaDateValidator.java
---
@@ -0,0 +1,216 @@
+/*
+* Licensed to the Apache
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/581#discussion_r95887850
--- Diff:
logical/src/main/java/org/apache/drill/common/expression/fn/JodaDateValidator.java
---
@@ -0,0 +1,216 @@
+/*
+* Licensed to the Apache
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/581#discussion_r95883938
--- Diff:
logical/src/test/java/org/apache/drill/common/expression/fn/JodaDateValidatorTest.java
---
@@ -0,0 +1,176 @@
+/*
+* Licensed to the
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/581#discussion_r95865841
--- Diff:
exec/java-exec/src/main/codegen/templates/DateIntervalFunctionTemplates/SqlToDateTypeFunctions.java
---
@@ -0,0 +1,77
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/581#discussion_r95887742
--- Diff:
logical/src/main/java/org/apache/drill/common/expression/fn/JodaDateValidator.java
---
@@ -0,0 +1,216 @@
+/*
+* Licensed to the Apache
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/581#discussion_r95880960
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/testing/TestDateConversions.java
---
@@ -0,0 +1,200 @@
+/*
+* Licensed to
1 - 100 of 3541 matches
Mail list logo
