[GitHub] geode pull request #684: GEODE-3266: Refactoring PDXCommands

GitHub user YehEmily opened a pull request: https://github.com/apache/geode/pull/684 GEODE-3266: Refactoring PDXCommands [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3266) - [x] JIRA ticket referenced - [x] PR rebased -

Re: behavior of "connect" command when --use-ssl

+1 to excluding the home dir at the very least. I think that behavior is surprising, and it also makes it harder to maintain multiple separate, isolated versions of Geode on the same machine. (One can easily introduce an unintended properties file into their configuration simply by copying it

Build failed in Jenkins: Geode-nightly #915

See Changes: [jiliao] GEODE-3339: Refactoring ClusterConfigurationServiceEndToEndDUnitTest [jiliao] GEODE-1359: Refactor IndexCommandsDUnitTest to use test rules and allow [ukohlmeyer] GEODE-3284: New flow:

[GitHub] geode pull request #688: GEODE-3397: Fixed issue with Tomcat locators in cac...

GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/688 GEODE-3397: Fixed issue with Tomcat locators in cache-client.xml file Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we

[GitHub] geode issue #688: GEODE-3397: Fixed issue with Tomcat locators in cache-clie...

Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/688 @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] geode pull request #685: GEODE-3261: Refactoring GfshHelpCommands

Github user pdxrunner commented on a diff in the pull request: https://github.com/apache/geode/pull/685#discussion_r131479491 --- Diff: geode-core/src/test/java/org/apache/geode/management/internal/cli/help/HelperIntegrationTest.java --- @@ -34,7 +36,7 @@ public static

[GitHub] geode issue #687: GEODE-3258: Refactoring DiskStoreCommands

Github user pdxrunner commented on the issue: https://github.com/apache/geode/pull/687 With regards to your comments on the test classes and possible duplication: I would consider splitting the existing test classes so that each of the new *Command classes has it's own

[GitHub] geode issue #686: GEODE-3396 Provide pub-tools support for product name & ve...

Github user davebarnes97 commented on the issue: https://github.com/apache/geode/pull/686 License added to helpers file, as requested. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] geode pull request #687: GEODE-3258: Refactoring DiskStoreCommands

Github user YehEmily closed the pull request at: https://github.com/apache/geode/pull/687 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Review Request 61409: GEODE-3328: simplify GfshParserRule

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61409/#review182225 --- Ship it! I think this is a good improvement to the rule's API.

[GitHub] geode issue #668: GEODE-3306: Remove whitespace StringBuffers/nodes created ...

Github user jaredjstewart commented on the issue: https://github.com/apache/geode/pull/668 Hi Darren, It looks like `xercesImpl` may need to be declared as a `testCompile` dependency rather than `testRuntime` in case people are building with a JDK which does not include

Re: Review Request 61426: GEODE-3277: Fix error path constructors of inner State classes of the Launchers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61426/#review182229 --- Ship it! Ship It! - Jared Stewart On Aug. 4, 2017, 2:55

Re: Review Request 61417: GEODE-3328: adding ssl-truststore-type to the config

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61417/#review182230 --- Ship it! Ship It! - Jared Stewart On Aug. 3, 2017, 9:15

[GitHub] geode pull request #676: GEODE-3321: Adding ErrorCode values to protobuf pro...

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/676 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #687: GEODE-3258: Refactoring DiskStoreCommands

GitHub user YehEmily opened a pull request: https://github.com/apache/geode/pull/687 GEODE-3258: Refactoring DiskStoreCommands [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3258) `DiskStoreCommands` was a huge class that contained a large number

Volunteer Request: Write Draft Board Report For August 2017

Hi Everyone, We are scheduled to report to the Apache board for this months board meeting on August 16 and need to submit a report by Wednesday, August 9th. Goal would be to have a initial draft for the community by Tuesday. Template:

[GitHub] geode pull request #681: Lucene refactoring and clean up

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/681 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #686: GEODE-3396 Provide pub-tools support for product na...

GitHub user davebarnes97 opened a pull request: https://github.com/apache/geode/pull/686 GEODE-3396 Provide pub-tools support for product name & version varia… Adds three variables for use in docs: - geode_product_name - geode_product_name_long -

Re: Review Request 61409: GEODE-3328: simplify GfshParserRule

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61409/#review182227 --- Ship it! Ship It! - Ken Howe On Aug. 3, 2017, 5:12 p.m.,

Re: Review Request 61417: GEODE-3328: adding ssl-truststore-type to the config

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61417/#review182233 ---

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #637 was SUCCESSFUL (with 2024 tests)

--- Spring Data GemFire > Nightly-ApacheGeode > #637 was successful. --- Scheduled 2026 tests in total. https://build.spring.io/browse/SGF-NAG-637/ -- This

[GitHub] geode pull request #686: GEODE-3396 Provide pub-tools support for product na...

Github user davebarnes97 closed the pull request at: https://github.com/apache/geode/pull/686 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] geode issue #668: GEODE-3306: Remove whitespace StringBuffers/nodes created ...

Github user darrenfoong commented on the issue: https://github.com/apache/geode/pull/668 Hi Jared, thank you for your feedback. The initial use case that I was thinking of involved a user wanting to: - use Geode with another JDK (which doesn't have the

[GitHub] geode pull request #664: Fix for GEODE-3292

Github user jujoramos commented on a diff in the pull request: https://github.com/apache/geode/pull/664#discussion_r131367740 --- Diff: geode-pulse/src/test/java/org/apache/geode/tools/pulse/internal/PulseAppListenerTest.java --- @@ -0,0 +1,91 @@ +/* + * Licensed to the

[GitHub] geode pull request #664: Fix for GEODE-3292

Github user jujoramos commented on a diff in the pull request: https://github.com/apache/geode/pull/664#discussion_r131378087 --- Diff: geode-assembly/src/test/java/org/apache/geode/tools/pulse/AbstractPulseConnectivityTest.java --- @@ -15,26 +15,31 @@ package

Re: Review Request 61420: GEODE-3307 CI failure: Uncaught exception in thread Thread[Geode Membership View Creator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61420/#review182214 --- Ship it! Ship It! - Bruce Schuchardt On Aug. 3, 2017, 3:07

Review Request 61426: GEODE-3277: Fix error path constructors of inner State classes of the Launchers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61426/ --- Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Kirk Lund, and

[GitHub] geode pull request #609: GEODE-2886 : sent IllegalStateException instead of ...

Github user upthewaterspout commented on a diff in the pull request: https://github.com/apache/geode/pull/609#discussion_r131433628 --- Diff: geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/WaitUntilFlushedFunction.java --- @@ -85,8 +72,10 @@ public

Re: Review Request 61411: GEODE-3286 Failing to cleanup connections from ConnectionTable receiver table (corrected "stopped" check in previous fix)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61411/#review182211 --- Ship it! Ship It! - Alexander Murmann On Aug. 3, 2017,

Re: Review Request 61411: GEODE-3286 Failing to cleanup connections from ConnectionTable receiver table (corrected "stopped" check in previous fix)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61411/#review182216 --- Ship it! Ship It! - Bruce Schuchardt On Aug. 3, 2017, 4:01