Re: [PROPOSAL] use default value for validate-serializable-objects in dunit

I filed GEODE-6202: DUnit should not enable VALIDATE_SERIALIZABLE_OBJECTS by default https://issues.apache.org/jira/browse/GEODE-6202 And submitted PR #3023 https://github.com/apache/geode/pull/3023 Please review and/or discuss further if needed. Thanks, Kirk On Thu, Mar 15, 2018 at 12:00 PM

Re: Re: [PROPOSAL] use default value for validate-serializable-objects in dunit

Thanks for the input Bruce. I'm going to close the PR for now and do some more thinking about how we test it. On Fri, Dec 21, 2018 at 3:26 PM Bruce Schuchardt wrote: > I agree with running tests with the default settings but I do not agree > with this change. > > I think we need to enable this

Re: Geode 1.8.0 maven repository is missing sources and javadoc jars

Owen, changing what's in a particular version of a library after it has been shipped to me breaks the contract established by the version number, regardless of how minor the changes are. On Fri, Dec 21, 2018 at 12:04 PM Owen Nichols wrote: > My feeling is that a 1.8.1 is not the right response.

Re: Geode 1.8.0 maven repository is missing sources and javadoc jars

The 1.7.0 version of publish.gradle had stuff like: extraArchive { sources = true javadoc = true tests = false } and afterEvaluate { // uses the tasks created by nexus for sources and javadoc if (!getTasksByName('sourcesJar', false).isEmpty()) {

Re: [PROPOSAL] use default value for validate-serializable-objects in dunit

-1 I'm fearful that removing full testing of serialization validation leaves the project exposed to java-serialization bombs.  We need to ensure that our servers and clients are protected from malicious deserialization attacks. On 2018/12/21 22:42:23, Kirk Lund wrote: > > > > I filed

Re: Geode 1.8.0 maven repository is missing sources and javadoc jars

If the only thing that is missing is that we didn’t publish jars then we just need to publish the jars. We don’t need to change the build to do it and rebuild. Manually post the artifacts and correct the gradle for 1.9. > On Dec 21, 2018, at 1:07 PM, Owen Nichols wrote: > > Maybe I

Re: Geode 1.8.0 maven repository is missing sources and javadoc jars

Yep. Sure does look like all the things you mentioned are true. The 'artifacts' configuration is a hold-over from the Legacy (a.k.a. Gradle 1.0) publishing, which I believe the Nexus plugin mimicked / used in its configuration. It looks like both the geode-pulse WAR not publishing and the

Re: Geode 1.8.0 maven repository is missing sources and javadoc jars

Maybe I misunderstand what happened. It sounded like the problem was essentially just “forgot to upload some docs”. If it’s more than that, then in addition to 1.8.1 do we need to take any steps to retract 1.8.0 as DOA? > On Dec 21, 2018, at 12:59 PM, Alexander Murmann wrote: > > Owen,

Re: Geode 1.8.0 maven repository is missing sources and javadoc jars

See also https://issues.apache.org/jira/browse/GEODE-6208 about publishing the pulse war. Anthony > On Dec 21, 2018, at 2:06 PM, Anthony Baker wrote: > > The 1.7.0 version of publish.gradle had stuff like: > > extraArchive { > sources

Fwd: Re: [PROPOSAL] use default value for validate-serializable-objects in dunit

I agree with running tests with the default settings but I do not agree with this change. I think we need to enable this serialization validation by default.  Otherwise servers and clients are exposed to serialization exploits.  We did not enable validation by default when the serialization

Re: Geode 1.8.0 maven repository is missing sources and javadoc jars

I have a preliminary "clean up how we configure publication" PR open which *does not* address these issues. However, if anyone picks up a ticket for these issues while I'm away, I would appreciate it stemming from that work (a) to be clean and modular, and (b) to not heap merge conflicts on

Re: Javadoc errors in org/apache/geode/cache/configuration/RegionAttributesType.java

I merged that for you this earlier this morning > On Dec 20, 2018, at 4:10 PM, Aditya Anchuri wrote: > > Okay. Please go ahead and merge, I can’t since I’m not a committer. > > On Thu, Dec 20, 2018 at 3:00 PM Kirk Lund wrote: > >> Looks good. Thanks! I added my approval. >> >> On Thu, Dec

Re: [DISCUSS] Disable merge for failing pull requests

I was responding to Udo's comment: "Could one not configure the button that the owner of the PR cannot merge the PR?" I'm +1 for disallowing merge until precheck passes. I'm -1 for disallowing the owner of the PR to merge it. On Fri, Dec 21, 2018 at 9:28 AM Helena Bales wrote: > Kirk, this

Reminder: do NOT @Ignore tests that flicker

Just a reminder: please do not @Ignore tests that flicker. I was pairing on some statistics changes this week and ran across a disabled test in DiskSpaceLimitIntegrationTest: @Test @Ignore("Fails frequently in docker container.") public void aboveZeroDeletesPreviousFiles() throws Exception

Re: Geode 1.8.0 maven repository is missing sources and javadoc jars

I confirmed what we upload to the Nexus staging site again with both 1.7 and 1.8. I think we must have stopped uploading these files when we switched to the maven-publish plugin as part of GEODE-5597. Can someone who worked on the recent build changes please take a look? I created GEODE-6235 to

Re: [DISCUSS] Disable merge for failing pull requests

Kirk, this change would not require you to get someone to merge it. It would just require that your PR pass CI before it can be merged. On Thu, Dec 20, 2018 at 2:38 PM Kirk Lund wrote: > I have enough trouble just getting other developers to review my PR. I > don't want to have to struggle to

no call stacks in hung CI runs

I'm trying to figure out why my stress-tests are hanging in CI but not when I run the tests locally.  The artifacts have a "callstacks" directory but there aren't any thread dumps that I've been able to locate. callstacks> ls callstacks-2018-12-20-02-16-27.txt

Re: Geode 1.8.0 maven repository is missing sources and javadoc jars

My feeling is that a 1.8.1 is not the right response. If we can put the missing jars in place manually for 1.8.0 that should be sufficient. -Owen > On Dec 21, 2018, at 9:16 AM, Alexander Murmann wrote: > > I confirmed what we upload to the Nexus staging site again with both 1.7 > and 1.8. I