Re: Review Request 52571: GEODE-1570: upgrade spring libraries

> On Oct. 5, 2016, 9:47 p.m., Jared Stewart wrote: > > I also get compilation errors in PulseAppListener and > > ExceptionHandlingAdvice when I apply this patch, even after refreshing > > gradle. > > Jinmei Liao wrote: > Hnnn, do a clean and refresh. I am not getting the errors. No luck.

Re: Review Request 52571: GEODE-1570: upgrade spring libraries

You must be looking at some wrong patch, or the patch did not apply correctly. The tests are passing: http://test-results-jinmei-1570-2.s3-website-us-west-2.amazonaws.com/test http://test-results-jinmei-1570-2.s3-website-us-west-2. amazonaws.com/flakyTest/ On Wed, Oct 5, 2016 at 3:33 PM, Jared

Re: Hibernate module and Geode 1.0 ?

Bumping to see if we have come to a decision on whether we want to move this to a feature branch and get rid of it for 1.0 or post 1.0, especially now that the 1.0 release branch has been cut On Fri, Sep 23, 2016 at 5:22 PM Anthony Baker wrote: Likewise! Geode provides an L2

Re: Review Request 52571: GEODE-1570: upgrade spring libraries

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52571/#review151584 --- I also have a few unit tests failing from this patch: ```

Assert usage in geode-core

Is there a initiative to get spring-core dependency out of geode-core? The only places we are using spring-core classes in geode-core are those Assert statements like: Assert.isNull, Assert.notNull etc. Should we try to get rid of those? -- Cheers Jinmei

Re: Limiting scope for Geode 1.0

Some of tests labeled flaky in 8929e93bd129b303aae8f9e1b13daf3c3991d1a4 have since been fixed by Nabarun. I think we should reconcile this revision with Nabarun's. On Tue, Oct 4, 2016 at 12:16 PM, Anthony Baker wrote: > I’d like merge 8929e93bd129b303aae8f9e1b13daf3c3991d1a4

Re: Review Request 52524: GEODE-1927 backward compatibility support

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52524/#review151587 --- Ship it! Ship It! - Udo Kohlmeyer On Oct. 4, 2016, 7:36

backward compatibility testing against GemFire 8.x WAN/clients

We now have a backward-compatibility module but it's not well tested. I'd like to add tests to this module that run against GemFire jars downloaded from the Pivotal maven repository. I've already implemented the framework and some smoke tests but want to know how people feel about the tests

Re: Review Request 52571: GEODE-1570: upgrade spring libraries

> On Oct. 5, 2016, 9:18 p.m., Jared Stewart wrote: > > Aren't the (OutputStream) casts in JSONUtils.java redundant since > > outputStream here is already an instance of HeapDataOutputStream which > > extends OutputStream? > > > > Also, I believe our schemaLocations in *-servlet.xml ought to

Re: Assert usage in geode-core

Dan did some work on this: commit 71eb6bfbc429e7cc226671c99f682ec4fb31115d Author: Dan Smith Date: Fri Sep 23 16:40:15 2016 -0700 GEODE-1934: Removing spring-core dependencies from geode-core Remving the spring-core usage in geode-core classes that are not

Re: backward compatibility testing against GemFire 8.x WAN/clients

Given that the official Pivotal maven repo [1] is locked behind a login and a EULA I think this might not work so well. The license compatibility issues would need to be explored as well. How would you feel about testing backwards compatibility against 1.0.0-incubating.M3? Anthony [1]

Re: Review Request 52571: GEODE-1570: upgrade spring libraries

> On Oct. 5, 2016, 9:47 p.m., Jared Stewart wrote: > > I also get compilation errors in PulseAppListener and > > ExceptionHandlingAdvice when I apply this patch, even after refreshing > > gradle. Hnnn, do a clean and refresh. I am not getting the errors. - Jinmei

Re: Limiting scope for Geode 1.0

If fixing flaky tests are not in the release plan, its a good idea to move this from release job...As you said it helps to keep the run clean and makes it easy to track unexpected failures. -Anil. On Wed, Oct 5, 2016 at 2:58 PM, Swapnil Bawaskar wrote: > Some of tests

Re: Assert usage in geode-core

We need to get *all* of the optional dependencies out of the core. That means anything marked optional in geode-core/build.gradle: spring-shell, spring-webmvc, jansi, mx4j, etc. Mostly that is a matter of moving gfsh, the admin REST API, etc. into separate subprojects (GEODE-818). Until we do

Re: Limiting scope for Geode 1.0

*geode-site, rather On Wed, Oct 5, 2016 at 2:37 PM Joey McAllister wrote: > The docs build process creates HTML output that we can drop into > geode-website. +William Markito and I were able to > make this work locally. I'm drafting an updated

Re: Review Request 52571: GEODE-1570: upgrade spring libraries

> On Oct. 5, 2016, 9:24 p.m., Anthony Baker wrote: > > gradle/dependency-resolution.gradle, line 18 > > > > > > What's different that allows us to remove this code? by upgrading the libraries, we don't need these

Re: Review Request 52571: GEODE-1570: upgrade spring libraries

> On Oct. 5, 2016, 9:24 p.m., Anthony Baker wrote: > > geode-assembly/src/test/resources/expected_jars.txt, line 20 > > > > > > Does this jar need to be on the geode/gfsh-dependencies.jar classpath? > > If so, add

Build failed in Jenkins: Geode-release #29

See Changes: [jiliao] GEODE-1570 - developer REST API should be secured [jiliao] GEODE-1570: make GemFireVersion.properties available in the geode-core -- [...truncated 632 lines...]

Re: Review Request 52571: GEODE-1570: upgrade spring libraries

> On Oct. 5, 2016, 9:24 p.m., Anthony Baker wrote: > > geode-core/build.gradle, line 90 > > > > > > We just eliminated spring-core from the classpath of geode-core...what > > code needs this jar? spring-core is

Re: Review Request 52571: GEODE-1570: upgrade spring libraries

> On Oct. 5, 2016, 9:18 p.m., Jared Stewart wrote: > > Aren't the (OutputStream) casts in JSONUtils.java redundant since > > outputStream here is already an instance of HeapDataOutputStream which > > extends OutputStream? > > > > Also, I believe our schemaLocations in *-servlet.xml ought to

[GitHub] incubator-geode issue #254: Feature/geode 999

Github user jaredjstewart commented on the issue: https://github.com/apache/incubator-geode/pull/254 Precheckin passed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

Re: Assert usage in geode-core

If this is the case, I would encourage the use of a fluent API, e.g. *AssertJ's* assertions, to replace *Spring* core's capable Assert [1] class. Resorting back to the ugly and often brittle conditional

Re: buildSrc prevents geode-core:test

Does running in debug mode help any (-d option)? On Tue, Oct 4, 2016 at 11:27 AM, Kirk Lund wrote: > Unfortunately, the --tests syntax works for UnitTests but not > IntegrationTests (which are run via the integrationTest task). For some > reason it hangs. I'd really like our

Re: Podling Report Reminder - October 2016

Looks good! I think the next step is uploading the report onto the wiki and getting mentor signoff. Anthony > On Oct 3, 2016, at 4:08 PM, Dan Smith wrote: > > Thanks Anthony and Swap! Updated draft: > > > Geode > > Geode is a data management platform

Build failed in Jenkins: Geode-nightly #613

See Changes: [abaker] Add FlakyTest category to tests with open bugs [klund] GEODE-1902 - Add GEMFIRE_VERBOSE LogMarker as alias of GEODE_VERBOSE for [klund] GEODE-1902: reformat code [klund] GEODE-1902: add ACCEPT and DENY tests for

Re: Podling Report Reminder - October 2016

I added our report to https://wiki.apache.org/incubator/October2016, it's ready for Mentor review and signoff. Thanks! -Dan On Wed, Oct 5, 2016 at 9:29 AM, Anthony Baker wrote: > Looks good! I think the next step is uploading the report onto the wiki and > getting mentor

Re: CI bugs

Flaky tags were removed from the following tests after fixes were checked in: GEODE-1731 GEODE-1148 GEODE-1364 GEODE-1804 GEODE-1147 GEODE-1384 For now GEODE-1448 remains flaky, even if the receiver port in use issue was resolved because a pause(1) still remains in the test. The flaky tag

Re: Log related test failures in GEODE

CustomConfigWithCacheIntegrationTest is now fixed. Looks like a formatter was run on log4j2-custom.xml which introduced a line feed to the longest line in #247. The currently committed formatters won't introduce line feeds. Also, I thought the formatters only affected java files, but apparently

[GitHub] incubator-geode pull request #254: Feature/geode 999

GitHub user jaredjstewart opened a pull request: https://github.com/apache/incubator-geode/pull/254 Feature/geode 999 Converted from Firefox webdriver to PhantomJS. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] incubator-geode pull request #254: Feature/geode 999

Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/254#discussion_r82066319 --- Diff: geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAbstractTest.java --- @@ -166,18 +197,28 @@ public static void

[GitHub] incubator-geode pull request #254: Feature/geode 999

Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/254#discussion_r82065904 --- Diff: .gitignore --- @@ -13,6 +13,8 @@ build/ build-eclipse/ --- End diff -- do we need to checkin this file? --- If your

[GitHub] incubator-geode pull request #254: Feature/geode 999

Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/254#discussion_r82066044 --- Diff: geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAbstractTest.java --- @@ -136,6 +146,29 @@ private

[GitHub] incubator-geode pull request #254: Feature/geode 999

Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/254#discussion_r82068710 --- Diff: geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAbstractTest.java --- @@ -136,6 +146,29 @@ private

[GitHub] incubator-geode pull request #254: Feature/geode 999

Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/254#discussion_r82067720 --- Diff: .gitignore --- @@ -13,6 +13,8 @@ build/ build-eclipse/ --- End diff -- I added the `screenshots/` directory so that

[GitHub] incubator-geode issue #251: Feature/geode 1570

Github user jinmeiliao commented on the issue: https://github.com/apache/incubator-geode/pull/251 This is pulled into realase/1.0.0.incubating branch, but somehow github is not watching the checkin on that branch to close this PR. --- If your project is set up for it, you can reply

Re: Limiting scope for Geode 1.0

+1 to including docs On Wed, Oct 5, 2016 at 12:48 PM Anthony Baker wrote: > +1 for including docs in the release > > Anthony > > > On Oct 4, 2016, at 11:52 AM, Swapnil Bawaskar > wrote: > > > > This sounds like feature creep, but based on this thread: >

Re: Limiting scope for Geode 1.0

+1 for including docs in the release Anthony > On Oct 4, 2016, at 11:52 AM, Swapnil Bawaskar wrote: > > This sounds like feature creep, but based on this thread: > http://markmail.org/message/fwfslt2s7yl7mqm4 do we want to target GEODE-1952 >

Re: Review Request 52271: GEODE-1938: Big Snapshot File Read Exception via SnapshotReader API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52271/#review151541 --- Ship it! Ship It! - Bruce Schuchardt On Oct. 5, 2016, 12:36

Re: Review Request 52271: GEODE-1938: Big Snapshot File Read Exception via SnapshotReader API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52271/#review151544 ---

Review Request 52571: GEODE-1570: upgrade spring libraries

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52571/ --- Review request for geode, Anthony Baker, Jared Stewart, Kevin Duling, Kirk

Re: Review Request 52571: GEODE-1570: upgrade spring libraries

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52571/#review151558 --- Ship it! Ship It! - Kevin Duling On Oct. 5, 2016, 2:06

[GitHub] incubator-geode pull request #251: Feature/geode 1570

Github user kjduling closed the pull request at: https://github.com/apache/incubator-geode/pull/251 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: Review Request 52571: GEODE-1570: upgrade spring libraries

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52571/#review151560 --- Aren't the (OutputStream) casts in JSONUtils.java redundant since

Review Request 52575: GEODE-1962: increment notQueuedConflated stat is peeked object is unresolvable from off heap

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52575/ --- Review request for geode, nabarun nag and Dan Smith. Repository: geode

Re: Review Request 52571: GEODE-1570: upgrade spring libraries

> On Oct. 5, 2016, 2:18 p.m., Jared Stewart wrote: > > Aren't the (OutputStream) casts in JSONUtils.java redundant since > > outputStream here is already an instance of HeapDataOutputStream which > > extends OutputStream? > > > > Also, I believe our schemaLocations in *-servlet.xml ought to

Re: Limiting scope for Geode 1.0

+1 for skipping flakyTest on release branch and merging 8929e93bd129b303aae8f9e1b13daf3c3991d1a4 On Tue, Oct 4, 2016 at 12:16 PM, Anthony Baker wrote: > I’d like merge 8929e93bd129b303aae8f9e1b13daf3c3991d1a4 to the release > branch. It contains only test changes. Sound

Re: Limiting scope for Geode 1.0

The docs build process creates HTML output that we can drop into geode-website. +William Markito and I were able to make this work locally. I'm drafting an updated README that includes how to add docs to the existing website infrastructure. On Wed, Oct 5, 2016 at 2:25 PM Dan