Re: [GitHub] incubator-geode pull request #240: GEODE-1899: Renamed the custom 'clean' ta...

> https://github.com/apache/incubator-geode/pull/240.patch >> >> To close this pull request, make a commit to your master/trunk branch >> with (at least) the following in the commit message: >> >> This closes #240 >> >>

Speed up your Gradle tasks!

I wanted to share a tip with everyone that may speed up your build and test execution times if you don’t already use it. Before we can speed up these tasks, it would be helpful to measure their baseline. This can be done by adding the --profile flag, e.g. executing “gradle test --profile”. Th

Re: Review Request 52269: GEODE-1659: put security properties in the cluster config and applied to all the members in the cluster.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52269/#review150437 --- Ship it! Ship It! - Jared Stewart On Sept. 26, 2016, 6:51

Re: Review Request 52269: GEODE-1659: put security properties in the cluster config and applied to all the members in the cluster.

exception throwing we had written previously. - Jared Stewart On Sept. 26, 2016, 8:32 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 52306: GEODE-1769: add the ignored exception

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52306/#review150588 --- Ship it! Ship It! - Jared Stewart On Sept. 27, 2016, 6:01

IntelliJ Code Style XML

From where can I obtain the intellijIdeaCodeStyle.xml file referenced in the wiki page about code style? Thanks, Jared

Re: [ANNOUNCE] Donation of Geode documentation

Thanks for the good news! On Sep 29, 2016 8:52 PM, "Kirk Lund" wrote: > Great news! > > On Thursday, September 29, 2016, Anthony Baker wrote: > > > I am pleased to announce the donation of Geode documentation to the > > Geode community. > > > > The documentation provides a complete user guide f

Re: buildSrc prevents geode-core:test

I don’t know why that happens, but I believe -Dtest.single has been deprecated in favor of --tests which lets you specify a test class pattern to match against. The following works for me: ./gradlew geode-core:test --tests *QueryDataFunctionApplyLimitClauseTest (Note that the * is necessary

Re: Review Request 52488: GEODE-420: fix Pulse test when not using any SSLConfig

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52488/#review151196 --- Ship it! Ship It! - Jared Stewart On Oct. 3, 2016, 5:52 p.m

Re: Review Request 52488: GEODE-420: fix Pulse test when not using any SSLConfig

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52488/#review151256 --- Ship it! Ship It! - Jared Stewart On Oct. 3, 2016, 11:20

Re: Review Request 52571: GEODE-1570: upgrade spring libraries

> > (Updated Oct. 5, 2016, 9:06 p.m.) > > > Review request for geode, Anthony Baker, Jared Stewart, Kevin Duling, Kirk > Lund, and Dan Smith. > > > Repository: geode > > > Description > --- > > GEODE-1570: upgrade spring libraries

Re: Review Request 52571: GEODE-1570: upgrade spring libraries

ExceptionHandlingAdvice when I apply this patch, even after refreshing gradle. - Jared Stewart On Oct. 5, 2016, 9:06 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 52571: GEODE-1570: upgrade spring libraries

> On Oct. 5, 2016, 9:47 p.m., Jared Stewart wrote: > > I also get compilation errors in PulseAppListener and > > ExceptionHandlingAdvice when I apply this patch, even after refreshing > > gradle. > > Jinmei Liao wrote: > Hnnn, do a clean and refresh. I am no

Re: Review Request 52571: GEODE-1570: upgrade spring libraries

> On Oct. 5, 2016, 9:18 p.m., Jared Stewart wrote: > > Aren't the (OutputStream) casts in JSONUtils.java redundant since > > outputStream here is already an instance of HeapDataOutputStream which > > extends OutputStream? > > > > Also, I believe our sch

Re: Review Request 52571: GEODE-1570: upgrade spring libraries

as:<3> at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:834) at org.junit.Assert.assertEquals(Assert.java:645) at org.apache.geode.management.internal.cli.shell.GfshInitFileJUnitTest.testInitFile_BadAndGoodCommands(GfshInitFileJUni

Re: Review Request 52571: GEODE-1570: upgrade spring libraries

rather than release/1.0.0-incubating. - Jared Stewart On Oct. 5, 2016, 9:06 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 52571: GEODE-1570: upgrade spring libraries

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52571/#review151724 --- Ship it! Ship It! - Jared Stewart On Oct. 6, 2016, 6:34 p.m

Re: Review Request 52621: GEM-1032: GMSAuthenticator needs to get security properties from system properties

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52621/#review151742 --- Ship it! Ship It! - Jared Stewart On Oct. 6, 2016, 11:03

Re: Review Request 52724: GEODE-1570: improve rest security framework

cleaned up a bit by removing unnecessary if statements checking the log level: ``` if (logger.isDebugEnabled()) { ... } ``` (See https://logging.apache.org/log4j/2.x/performance.html#asyncLoggingWithParams) - Jared Stewart On Oct. 11, 2016, 3:56 a.m., Jinmei Liao wrote

Coding practices/standards

I would like to advocate for adding a Checkstyle or Spotless gradle task to our build process to ensure that all code checked in meets the formatting standards described on the wiki

Re: Coding practices/standards

’s too hard to review. >> >> Anthony >> >>> On Oct 12, 2016, at 10:06 AM, Dan Smith wrote: >>> >>> +1 >>> >>> This might be a good time to reformat the code since I don't think there >>> are too many long lived feat

Re: Coding practices/standards

r precheckin target is also needed. In addition to that I also > wanted PRs to be checked. > > > On Wed, Oct 12, 2016 at 11:12 AM, Jared Stewart > wrote: > > > It would certainly be necessary to make sure that the code style to be > > enforced is sensible, e.g. doe not

Re: Coding practices/standards

>>> outstanding >>> issues in the code and very hard to tell what issues were introduced. >>> >>> >>> --Mark >>> >>> On Wed, Oct 12, 2016 at 11:34 AM, Dan Smith wrote: >>> >>> Seems like it should run as part of

Re: Coding practices/standards

outstanding >>> issues in the code and very hard to tell what issues were introduced. >>> >>> >>> --Mark >>> >>> On Wed, Oct 12, 2016 at 11:34 AM, Dan Smith wrote: >>> >>> Seems like it should run as part of the build targ

Re: Coding practices/standards

e? > > Ken > >> On Oct 12, 2016, at 3:39 PM, Jared Stewart wrote: >> >> If you want to try it out, I pushed a branch to my Geode repo that contains >> this change: >> https://github.com/jaredjstewart/incubator-geode/tree/spotlessPlugin >>

Re: Build failed in Jenkins: Geode-nightly #621

This file was accidentally committed in GEODE-999. Jinmei removed it from develop this morning after we saw the RAT failed last night. I haven’t figured out yet what generated the file in the first place. > On Oct 13, 2016, at 9:04 AM, Anthony Baker wrote: > > Anyone know why this file was ge

Re: Coding practices/standards

uild time locally by 50%. But I still want the ability to > suppress the check similar to -x javadoc. > > On Wed, Oct 12, 2016 at 9:58 PM, William Markito > wrote: > >> This sounds really good to me as well. +1 >> >> On Wed, Oct 12, 2016 at 4:13 PM, Jared Stewar

Re: Coding practices/standards

ROM > /portfolio1 pf1 where ID > 10 and ID < 20 order by ID asc, pkid desc limit > 5 ", "SELECT ID, description, createTime, pkid FROM /portfolio1 pf1 where > ID > 10 and ID < 20 order by ID desc, pkid asc limit 5", "SELECT ID, > description, createTime, pkid FRO

Re: Build failed in Jenkins: Geode-nightly #621

his > will only do the push if the build succeeds: > > echo "./gradlew build" > .git/hooks/pre-push > chmod u+x .git/hooks/pre-push > > You can do git push --no-verify to skip the check if you want to. > > -Dan > > On Thu, Oct 13, 2016 at 9:07 AM, Jar

Re: Review Request 52889: GEODE-1993: refactor tests to use rules rather than abstract classes

m looking at the other changes that they are used by @PreAuthorized annotations in the CrudControllers, but it might be nice to add comments to these methods explaining where they're used so that people in the future don't think they can be deleted. - Jared Stewart On Oct

Re: Review Request 52889: GEODE-1993: refactor tests to use rules rather than abstract classes

-- On Oct. 14, 2016, 5:25 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52889/ > ------- > > (Updated Oc

Re: Review Request 52889: GEODE-1993: refactor tests to use rules rather than abstract classes

t; > Review board requests can be updated and you can see the changes between > diffs. > > Anthony > >> On Oct 14, 2016, at 10:42 AM, Jared Stewart > <mailto:jstew...@pivotal.io>> wrote: >> >> If we used github PRs instead of review board, your se

Re: Review Request 52889: GEODE-1993: refactor tests to use rules rather than abstract classes

> On Oct. 14, 2016, 5:21 p.m., Jared Stewart wrote: > > Many usages of ServerStarter have to specify > > "org/apache/geode/management/internal/security/clientServer.json". I think > > it would be convenient to have some static factory methods like > > S

Re: Review Request 52889: GEODE-1993: refactor tests to use rules rather than abstract classes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52889/#review152719 --- Ship it! Ship It! - Jared Stewart On Oct. 14, 2016, 6:41

Re: Hosting the docs (was Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2)

In the past I have used wkhtmltopdf to build programmatically PDFs from HTML documents. We could try using this to generate a PDF version of the docs in the interim until we can generate a PDF directly from book binder. > On Oct 18, 2016, at 1:09 PM, Michael Stolz wrote: > > Its really import

Re: Hosting the docs (was Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2)

Sadly just looked at the license for wkhtmltopdf and it uses GPL 3.0. I believe that would be an issue as discussed here <https://www.apache.org/licenses/GPL-compatibility.html>. > On Oct 18, 2016, at 1:38 PM, Jared Stewart wrote: > > In the past I have used wkhtm

Re: Coding practices/standards

can open a pull request to enable spotless. > On Oct 14, 2016, at 4:57 PM, Dan Smith wrote: > > +1 - The formatting looks better now. > > -Dan > > On Thu, Oct 13, 2016 at 11:06 AM, Jared Stewart wrote: > >> I agree that the formatter needs fixing up. Our wiki

Re: IntelliJ and Eclipse formatters

I will submit a pr later this week to enable spotless and switch to these templates. The intellij one needs to be updated however. It's give years old and doesnt work with recent versions of intellij. Multiple PRs have been made to update to fix this, but Google has not yet accepted one. I'd like t

Re: Coding practices/standards

ith the summary "EOFException during > deserialize on client update with copy-on-read=true" > > -Kirk > > > On Tue, Oct 18, 2016 at 4:27 PM, Jared Stewart wrote: > >> To give everyone an update, using the Google Java Style eclipse template >> there is an issue

Re: Coding practices/standards

7; and succeeded >>>>> >>>>> Great addition! As long as others are good with the formatter, then I >> am >>>>> good. >>>>> >>>>> --Mark >>>>> >>>>> On Thu, Oct 20, 2016 at 3:40 PM, Kirk L

Re: Coding practices/standards

> geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRTransactionDUnitTest.java > > --Mark > > On Fri, Oct 21, 2016 at 12:08 PM, Jared Stewart wrote: > >> I just pulled and rebased onto develop, and force pushed into the existing >> pull request.

Re: Coding practices/standards

pull. > > --Mark > > > > On Fri, Oct 21, 2016 at 1:21 PM, Jared Stewart wrote: > >> Done! :) >> >> - Jared >>> On Oct 21, 2016, at 12:27 PM, Mark Bretl wrote: >>> >>> One more time! :) >>> >>> Conflictin

Re: Coding practices/standards

>> Thanks Jared for the suggestion of Spotless and follow-up work. >> >> This is now completed and checked into develop. As this does touch many >> files, be prepared the next time you pull. >> >> --Mark >> >> >> >> On Fri, Oct 21, 2

Re: Coding practices/standards

ouch many >> files, be prepared the next time you pull. >> >> --Mark >> >> >> >> On Fri, Oct 21, 2016 at 1:21 PM, Jared Stewart >> wrote: >> >>> Done! :) >>> >>> - Jared >>>> On Oct 21, 2016, at 12:

Re: Coding practices/standards

ormat a branch and then rebase on develop to minimize > conflicts? > > -Kirk > > > On Fri, Oct 21, 2016 at 1:36 PM, Jared Stewart wrote: > >> Fantastic, thanks for merging this in Mark. For anyone with outstanding >> work on branches made before this c

Re: Coding practices/standards

rebase -Xtheirs c2319bb7a6201d5ae82ecb0fe23a1e3b8072c2e1 > > #Rebase onto the rest of develop. Resolve conflicts if any. > git rebase origin/develop > > #Apply formatting > ./gradlew geode-core:spotlessApply > > -Dan > > On Fri, Oct 21, 2016 at 4:34 PM, Jared Stewart wrote:

Re: [DISCUSS] Graduation

+1 On Oct 25, 2016 5:58 PM, "Dan Smith" wrote: > +1 > > -Dan > > On Tue, Oct 25, 2016 at 5:43 PM, Joey McAllister > wrote: > > > +1 > > > > On Tue, Oct 25, 2016 at 5:42 PM Anthony Baker wrote: > > > > > +1 > > > > > > > On Oct 25, 2016, at 5:25 PM, Roman Shaposhnik > wrote: > > > > > > > > Un

Re: Tweaking the IntelliJ and Eclipse formatters

1) +0 2) +1 3) +1 4) +1 - Jared > On Oct 27, 2016, at 3:11 PM, Kirk Lund wrote: > > I'd like to propose making a few changes to our IntelliJ and Eclipse > formatters as well as the Eclipse importorder (all in etc/): > > 1) increase max line length (100 is way too short) > 2) make (hopefully

Re: jmh benchmarks

+1 Jmh is great On Nov 2, 2016 11:18 AM, "Dan Smith" wrote: > Hi all, > > I'd like to add some support for running benchmarks with jmh to geode. Is > this something we're interested in having? JMH is a framework for easily > writing microbenchmarks. It's probably not that useful for large scale

Re: more spotless problems on Windows

The only Windows machine I have is running Windows 8, and I am unable to reproduce this on that machine. I don’t think .gitattributes would affect this, since we have already configured spotless to always use Unix line endings. Naba - Can you run ‘./gradlew spotlessApply’ and push the result

Re: more spotless problems on Windows

: ./gradlew clean build -Dskip.tests=true* >> BUILD SUCCESSFUL >> >> Total time: 5 mins 28.64 secs >> >> NOTE: This happens only the first time. I did run the above steps,couple >> of times on fresh checkouts and I was able to reproduce it every time. >>

Re: Gfsh Parsing

Huge +1 to the idea of simplifying Gfsh parsing. I find the green help text from Spring Shell too be less readable then the black text from JoptSimple, but I assume we can configure that to our choosing. > On Nov 4, 2016, at 10:05 AM, Jinmei Liao wrote: > > This is a good idea. I'll reach out

Re: more spotless problems on Windows

fixed. > On Nov 4, 2016, at 10:48 AM, Nabarun Nag wrote: > > Thank you Jared. I wanted to confirm that this was not an isolated incident > specific to my machine. > > Regards > Naba > > On Fri, Nov 4, 2016 at 10:45 AM Jared Stewart wrote: > >> @Naba, >

Re: more spotless problems on Windows

at & it didn't work. Maybe you'll have better luck. > > Le 11/4/2016 à 11:59 AM, Jared Stewart a écrit : >> From the spotless devs: >> >> Git is not a pure content store, it mucks with line endings. Regardless of >> what you check-in, it will store your

Re: more spotless problems on Windows

Correction: “ * text eol=lf” > On Nov 4, 2016, at 12:09 PM, Jared Stewart wrote: > > “ *test eol=lf”

Re: more spotless problems on Windows

12:07 PM, Bruce Schuchardt wrote: > > Udo and I tried that & it didn't work. Maybe you'll have better luck. > > Le 11/4/2016 à 11:59 AM, Jared Stewart a écrit : >> From the spotless devs: >> >> Git is not a pure content store, it mucks with line